2014-09-11 15:47 GMT+09:00 Fabien COELHO :
>
> Hello Robert,
>
> I am not objecting to the functionality; I'm objecting to bolting on
>> ad-hoc operators one at a time. I think an expression syntax would
>> let us do this in a much more scalable way. If I had time, I'd go do
>> that, but I don'
Show us the evidence. Postgres members showed the test result and them
consideration.
It's very objective comparing.
Best Regards,
--
Mitsumasa KONDO
Hi,
I find typo in your patch. Please confirm.
@line 239
- agg->sum2_lag = 0;
+ agg->sum_lag = 0;
And back patch is welcome for me.
Best Regards,
--
Mitsumasa KONDO
The attached is seemed no problem. But I'd like to say about order of
explanation in five formulas.
Fix version is here. Please confirm, and I mark it for ready for commiter.
Best regards,
--
Mitsumasa KONDO
pgbench-modulo-4-1.patch
Description: Binary data
--
Sent via pgsql-h
Hi,
Here is the review result.
#1. Patch compatibility
Little bit hunk, but it can patch to latest master.
#2. Functionality
No problem.
#3. Documentation
I think modulo operator explanation should put at last at the doc line.
Because the others are more frequently used.
#4. Algorithm
You prop
rch cost
is
relatively high than we expect. We need clever algorithm for efficient and
distributed buffer search using multi process or threads.
Regards,
--
Mitsumasa KONDO
option. We would need to measure how useful exposing
> that is, though.
By the way, does pg_receivexlog process have fsync() in every WAL commit?
If yes, I think that we need no or less fsync() option for the better
performance. It is general in NOSQL storages.
If no, we need fsync() option for more getting reliability and data
integrarity.
Best regards,
--
Mitsumasa KONDO
ble with C & SQL is really useless to me.
>
I like version 3, it is simple and practical. And it's enough in pgbench.
If someone wants to use other implementation of modulo algorithm, he just
changes his source code.
Best regards,
--
Mitsumasa KONDO
senne twister algorithm. erand48 algorithm is slow and not
accurate very much.
By the way, I don't know relativeness of this topic and command line
option... Well whatever...
Regards,
--
Mitsumasa KONDO
e discussion is needed to continue...
Would providing these as additional contrib files be more acceptable?
> Something like "tpc-b-gauss.sql"... Otherwise there is no example available
> to show the feature.
>
I agree the test script and including command line options. It's not harm,
and it's useful.
Best regards,
--
Mitsumasa KONDO
Thanks for your modify the patch! I confirmed that It seems to be fine.
I think that our latest patch fill all community comment.
So it is really ready for committer now.
Best regards,
--
Mitsumasa KONDO
aussian distribution
+ standard deviation threshold: 5.0
+ decile percents: 0.0% 0.1% 2.1% 13.6% 34.1% 34.1% 13.6% 2.1% 0.1% 0.0%
+ probability of max/min percent of the range: 4.0% 0.0%
And I add the explanation about this in the document.
I'm very appreciate for your works!!!
Bes
.
90,001 to 10, => 0 times
#number of access in range of aid (from highest/lowest percent of the
range):
1 to 1,000=> 950 times
...
99,001 to 10, => 0 times
that's all.
Their information is easy to understand distribution of access probability,
isn't it?
Maybe I and Fabien-san have a knowledge of mathematics, so we think decile
percentage is common sense.
But if it isn't common sense, I agree with adding about these explanation
in the documents.
Best regards,
--
Mitsumasa KONDO
ly agree that we likely want that as an additional
> feature. Even if just because it makes the results easier to compare.
>
If we can do positive and logical discussion, I will agree with the
proposal about separate patches.
However, I think that most opposite hacker decided by his feelings...
Actuary, he didn't answer to our proposal about understanding the
parametrized distribution...
So I also think it is blocker. Command line feature is also needed.
Besides, is there a other good method? Please share us.
Best regards,
--
Mitsumasa KONDO
cked the source code, I understood it:( It's not good design...
#Why this parameter use 100?
So I'd like to remove it if you like. It will be more simple.
Attached patch is fixed version, please confirm it.
#Of course, World Cup is being held now. I'm not hurry at all.
n't obviate the need for tools to manage replication, but
> > it would make it possible to get the simplest case right without
> > guessing.
>
> +1, too.
>
> And, what about making pg_copy call posix_fadvise(DONT_NEED) against the
> archived file after the copy? Also It might be good idea to support the
> direct
> copy of the file to avoid wasting the file cache.
Use direct_cp.
http://directcp.sourceforge.net/direct_cp.html
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
eters which are declared double as well,
> and the putVariable uses a "%lf" format...
>
I think it's collect. When we get double argument in scanf(), we can use
%lf format.
> Possibly I'm missing something?
Sorry. I think nothing is missing.
regards,
--
Mitsumasa KONDO
Oh, sorry, I forgot to write URL referring picture.
http://en.wikipedia.org/wiki/Normal_distribution
http://en.wikipedia.org/wiki/Exponential_distribution
regards,
--
Mitsumasa KONDO
2014-03-15 17:50 GMT+09:00 Mitsumasa KONDO :
> Hi
>
> 2014-03-15 15:53 GMT+09:00 Fabien COELHO :
>
file,
it appear distribution we want.
We have no time to fix its very much... But I think almost part of patch
have been completed.
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
gaussian_and_exponential_pgbench_v6.patch
Description: Binary data
<>
gnuplot.sh
Description
2014-01-31 Fujii Masao :
> On Fri, Jan 31, 2014 at 10:18 PM, Mitsumasa KONDO
> wrote:
> > 2014-01-31 Fujii Masao
> >>
> >> On Tue, Jan 28, 2014 at 5:51 PM, Magnus Hagander
> >> wrote:
> >> > On Tue, Jan 28, 2014 at 6:11 AM, Amit Kapila >
&
lumes.
Now, we only see number of transactions and database volumes.
I'd like to see more detail activities from WAL volume in each minutes or
hours.
It might be good for performance improvement by hackers, too
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
es in both
> pg_stat_tmp
> and stats_temp_directory. Even when a user sets stats_temp_directory
> to the directory
> other than pg_stat_tmp, we need to skip the files in pg_stat_tmp. Because,
> per recent change of pg_stat_statements, the external query file is
> always created ther
no time in my office today.
If we hope, I can run 1/N distribution pgbench test next week, I modify my
perl script little bit,
for creating multiple sql files with various sleep time.
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
> without.
I showed first test result which is compared with without
pg_stat_statements and without patch last day. They ran in same server and
same benchmark settings(clients and scale factor) as today's result. When
you merge and see the results, you can confirm not to affect of performance
in my patch.
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
h.. Very sorry...
Last day, I tried to find Kumar mail at 20/11/2013. But I couldn't find
it... Could you tell me e-mail title?
My patch catches up with latest 9.4HEAD.
Regards,
--
Mitsumasa KONDO
d complicated discussions... I think that our
> hope is
> > to commit this patch in this commit-fest or next final commit-fest.
>
> Agreed on no delay for the delay patch, as shown by my commit.
Our forecast was very accurate...
Nice commit, Thanks!
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
r benchmark test before conclusion of
this patch.
What kind of benchmark do you have?
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
2013/12/4 Andres Freund
> On 2013-12-04 22:47:47 +0900, Mitsumasa KONDO wrote:
> > 2013/12/4 Andres Freund
> > When it happened, psql cannot connect standby server at all. I think this
> > behavior is not good.
> > It should only delay recovery position and ca
ou?
>
I'm not sure... You might right or another best way might be existed.
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
think
> that's a bug?
>
When it happened, psql cannot connect standby server at all. I think this
behavior is not good.
It should only delay recovery position and can seen old delay table data.
Cannot connect server is not hoped behavior.
If you think this behavior is the best, I will set ready for commiter. And
commiter will fix it better.
Rregards,
--
Mitsumasa KONDO
NTT Open Source Software Center
than
posix_fallocate().
It will be needed by sorted checkpoint and more faster vacuum command in
near the future.
If you get more detail information, please see linux manual.
I go sight seeing in Dublin with Ishii-san now:-)
Regards,
--
Mitsumasa KONDO
NTT Open Source Software
pg_falloca
carefuly option before starting benchmark.
Please give me comments.
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
pgbench_accurate_option_v0.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
is like Mersenne Twister*.*
Regards,
--
Mitsumasa KONDO
> You had accidentally added to the CF In Progress.
Oh, I had completely mistook this CF schedule :-)
Maybe, Horiguchi-san is same situation...
However, because of your moving, I become first submitter in next CF.
Thank you for moving :-)
--
Mitsumasa KONDO
%m",
>readId, readSeg, readOff)));
> goto next_record_is_invalid;
> }
> if (!ValidXLOGHeader((XLogPageHeader) readBuf, emode, false))
> goto next_record_is_invalid;
I think that horiguchi's discovery point is after this point.
We must fix that CreateRestartPoint() does not create illegal WAL File.
Best regards,
--
Mitsumasa KONDO
35 matches
Mail list logo
