Re: [HACKERS] path toward faster partition pruning

2017-11-09 Thread Kyotaro HORIGUCHI
Hello, At Fri, 10 Nov 2017 14:44:55 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20171110.144455.117208639.horiguchi.kyot...@lab.ntt.co.jp> > > Those two conditions are not orthogonal. Maybe something like > > following seems more understantable. > >

Re: [HACKERS] path toward faster partition pruning

2017-11-09 Thread Kyotaro HORIGUCHI
Ooops! The following comment is wrong. Please ignore it. At Fri, 10 Nov 2017 14:38:11 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20171110.143811.97616847.horiguchi.kyot...@lab.ntt.co.jp> > Those two conditions are not orthogonal. Maybe something like > followin

Re: [HACKERS] path toward faster partition pruning

2017-11-09 Thread Kyotaro HORIGUCHI
Hello, this is the second part of the review. At Fri, 10 Nov 2017 12:30:00 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20171110.123000.151902771.horiguchi.kyot...@lab.ntt.co.jp> > In 0002, bms_add_range has a bit naive-looking loop > In 0003, In 000

Re: [HACKERS] path toward faster partition pruning

2017-11-09 Thread Kyotaro HORIGUCHI
if (!op_in_opfamily(expr_op, partopfamily)) +{ + Oidnegator = get_negator(expr_op); + + if (!OidIsValid(negator) || +!op_in_opfamily(negator, partopfamily)) +continue; classify_partition_bounding_keys() checks the same thing by checking whether th

Re: [HACKERS] Restricting maximum keep segments by repslots

2017-11-09 Thread Kyotaro HORIGUCHI
Oops! The previous patch is forgetting the default case and crashes. At Wed, 08 Nov 2017 13:14:31 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20171108.131431.170534842.horiguchi.kyot...@lab.ntt.co.jp> > > I don't think 'distance' is a good metric -

Re: [HACKERS] [PATCH] Improve geometric types

2017-11-09 Thread Kyotaro HORIGUCHI
| isnan(radius_sum)) > PG_RETURN_BOOL(false); > > /* NaN ordering of FPle() doesn't get into mischief here */ > return PG_RETURN_BOOL(FPle(distance, radius_sum)); (End Of the Comment to 0003) regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pg

Re: [HACKERS] Restricting maximum keep segments by repslots

2017-11-07 Thread Kyotaro HORIGUCHI
Hello, At Mon, 6 Nov 2017 05:20:50 -0800, Andres Freund wrote in <20171106132050.6apzynxrqrzgh...@alap3.anarazel.de> > Hi, > > On 2017-10-31 18:43:10 +0900, Kyotaro HORIGUCHI wrote: > > - distance: > > how many bytes LSN can advance b

Re: [HACKERS] [PATCH] Improve geometric types

2017-11-07 Thread Kyotaro HORIGUCHI
- make_bound_box operates directly on the poly->boundbox. I'm afraid that such coding hinders compiers from using registers. This is a bit apart from this patch, it would be better if we could eliminate internal calls using DirectFunctionCall. reagrds, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-11-06 Thread Kyotaro HORIGUCHI
:00 Kyotaro HORIGUCHI < > horiguchi.kyot...@lab.ntt.co.jp>: > > > Hi, thanks for the new patch. > > > > # The patch is missing xpath_parser.h. That of the first patch was usable. > > > > At Thu, 28 Sep 2017 07:59:41 +0200, Pavel Stehule > > wrote i

Re: [HACKERS] More stats about skipped vacuums

2017-10-31 Thread Kyotaro HORIGUCHI
This is just a repost as a (true) new thread. At Mon, 30 Oct 2017 20:57:50 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20171030.205750.246076862.horiguchi.kyot...@lab.ntt.co.jp> > At Fri, 20 Oct 2017 19:15:16 +0900, Masahiko Sawada > wrote in > > >

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-31 Thread Kyotaro HORIGUCHI
At Thu, 26 Oct 2017 12:42:23 +0200, Robert Haas wrote in > On Thu, Oct 26, 2017 at 10:18 AM, Kyotaro HORIGUCHI > wrote: > > Thank you. I forgot that point. Changed them so that the messages > > are detected as msgids. > > Committed, changing "aggressive"

Re: [HACKERS] Protect syscache from bloating with negative cache entries

2017-10-31 Thread Kyotaro HORIGUCHI
This is a rebased version of the patch. At Fri, 17 Mar 2017 14:23:13 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170317.142313.232290068.horiguchi.kyot...@lab.ntt.co.jp> > At Tue, 7 Mar 2017 19:23:14 -0800, David Steele wrote > in <3b7b7f90-db46-8c37

Re: [HACKERS] Restricting maximum keep segments by repslots

2017-10-31 Thread Kyotaro HORIGUCHI
al_keep_segments) is exhasuted, or how many bytes this slot have lost xlog from restart_lsn. There is a case where live = t and distance = 0. The slot is currently having all the necessary segments but will start to lose them at most two checkpoint passes. regards, -- Kyotaro Horiguchi NTT

Re: [HACKERS] More stats about skipped vacuums

2017-10-30 Thread Kyotaro HORIGUCHI
At Thu, 26 Oct 2017 15:06:30 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20171026.150630.115694437.horiguchi.kyot...@lab.ntt.co.jp> > At Fri, 20 Oct 2017 19:15:16 +0900, Masahiko Sawada > wrote in > > > n_mod_since_analyze | 2 &

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-10-26 Thread Kyotaro HORIGUCHI
Hello. Thank you for looking this. At Mon, 16 Oct 2017 17:58:03 +0900, Michael Paquier wrote in > On Thu, Sep 7, 2017 at 12:33 PM, Kyotaro HORIGUCHI > wrote: > > At Wed, 6 Sep 2017 12:23:53 -0700, Andres Freund wrote > > in <20170906192353.ufp2dq7wm5fd6...@alap3.anar

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-26 Thread Kyotaro HORIGUCHI
Thank you for the comment. (Thank you Sawada-san for reviewng, too.) At Thu, 19 Oct 2017 13:03:38 +0200, Alvaro Herrera wrote in <20171019110338.awwzc3y674co7wof@alvherre.pgsql> > Kyotaro HORIGUCHI wrote: > > > How about the followings? > > > > "automat

Re: [HACKERS] More stats about skipped vacuums

2017-10-25 Thread Kyotaro HORIGUCHI
Mmm. I've failed to create a brand-new thread.. Thank you for the comment. At Fri, 20 Oct 2017 19:15:16 +0900, Masahiko Sawada wrote in > On Tue, Oct 10, 2017 at 7:26 PM, Kyotaro HORIGUCHI > wrote: > > Hello. > > Once in a while I am asked about table bloat. In most

Re: [HACKERS] asynchronous execution

2017-10-20 Thread Kyotaro HORIGUCHI
postgres_fdw's command presending on a remote table. D is the gain of sharding on a connection. The number of partitions/shards is 4. E is the gain using dedicate connection per shard. regards, -- Kyotaro Horiguchi NTT Open Source Software Center >From fc424c16e124934581a184fcadaed1e05f

[HACKERS] More stats about skipped vacuums

2017-10-10 Thread Kyotaro HORIGUCHI
uld be applied to analyze but it might be the another issue. There may be a better way to indicate the vacuum soundness. Any opinions and suggestions are welcome. I'm going to make a patch to do the 'formal' one for the time being. regards. -- Kyotaro Horiguchi NTT Open Sour

Re: [HACKERS] Logging idle checkpoints

2017-10-05 Thread Kyotaro HORIGUCHI
At Thu, 5 Oct 2017 13:41:42 +0200, Alvaro Herrera wrote in <20171005114142.dupjeqe2cnplhgkx@alvherre.pgsql> > Kyotaro HORIGUCHI wrote: > > > # This reminded me of a concern. I'd like to count vacuums that > > # are required but skipped by lock-failure, or killed by

Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw

2017-10-05 Thread Kyotaro HORIGUCHI
. So just merging WCO columns to RETURNING in deparsed query is ok. But can't we concatenate returningList and withCheckOptionList at more higher level? Specifically, just passing calculated used_attr to deparse(Insert|Update)Sql instead of returningList and withCheckOptionList separately. Deparsed queries anyway forget the origin of requested columns. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Logging idle checkpoints

2017-10-04 Thread Kyotaro HORIGUCHI
At Tue, 3 Oct 2017 08:22:27 -0400, Stephen Frost wrote in <2017100317.gj4...@tamriel.snowman.net> > Greetings, > > * Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote: > > At Tue, 3 Oct 2017 10:23:08 +0900, Michael Paquier > > wrote in > > >

Re: [HACKERS] [PATCH] Improve geometric types

2017-10-03 Thread Kyotaro HORIGUCHI
At Mon, 2 Oct 2017 08:23:49 -0400, Robert Haas wrote in > On Mon, Oct 2, 2017 at 4:23 AM, Kyotaro HORIGUCHI > wrote: > > For other potential reviewers: > > > > I found the origin of the function here. > > > > https://www.postgresql.org/message-id/4a90bd

Re: [HACKERS] [PATCH] Improve geometric types

2017-10-03 Thread Kyotaro HORIGUCHI
> > taking the mean of the two distances. If you have a firm reason > > for the change, it is better to be written there, or it might be > > better left alone. > > I don't really, so I left that part out. Mmm, sorry. It's my mistake. > [1] https://www.post

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-10-02 Thread Kyotaro HORIGUCHI
might be complex enough so that it's worth switching to > > yacc/lex based transformer that is formally verifiable and won't > > need a bunch of cryptic tests that finally cannot prove the > > completeness. synchronous_standy_names is far simpler than XPath > > but using yacc/lex parser. > > > > I don't think (not yet) - it is simple state machine now, and when the code > will be stable, then will not be modified. Hmm. Ok, agreed. I didn't mean the current shape ought to be changed. > Thank you for comments, I'll look on it regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Logging idle checkpoints

2017-10-02 Thread Kyotaro HORIGUCHI
checkpoint_timeout. Checkpoint might deserve the same treatment on skipping. By the way RestartCheckPoint emits DEBUG2 messages on skipping. Although restartpoint has different characteristics from checkpoint, if we change the message level for CreateCheckPoint (currently DEBUG1), CreateRestartPoint m

Re: [HACKERS][BUG] Cache invalidation for queries that contains const of temporary composite type

2017-10-02 Thread Kyotaro HORIGUCHI
, y int); prepare test as select row(x, y)::pair from t2; drop type pair; execute test; | ERROR: cache lookup failed for type 16410 In this case the causal expression is in the following form. TargetEntry ( expr = ( RowExpr: typeid = 16410, row_format = COERCE_EXPLICI

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-10-02 Thread Kyotaro HORIGUCHI
tps://www.w3.org/TR/REC-xml/#NT-NameStartChar) I think characters with high-bit set is okay. Also IS_NODENAME_CHAR should be changed. - NODENAME_FIRSTCHAR and IS_NODENAME_CHAR is in the same category but have different naming schemes. Can these are named in the same way? - The current tran

Re: [HACKERS] [PATCH] Improve geometric types

2017-10-02 Thread Kyotaro HORIGUCHI
the segment. It seems absorbing error, so it might be better taking the mean of the two distances. If you have a firm reason for the change, it is better to be written there, or it might be better left alone. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Walsender timeouts and large transactions

2017-10-01 Thread Kyotaro HORIGUCHI
ks. If you think, my patch breaks > something, write test for the case my patch did broke. If you think > my test is wrong, write your test that is more correct. > > Without tests it will be just bird's hubbub. regards, -- Kyotaro Horiguchi NTT Open Source Software Cen

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

2017-10-01 Thread Kyotaro HORIGUCHI
a uniform > fashion. Each .c file shouldn't get to make up its own notion of what > is or is not supported. Anyway currently server and pg_basebackup disagrees on the point. If the "just reverting" patch above is not rejected again, I'll resume working on it. Or oth

Re: [HACKERS] Walsender timeouts and large transactions

2017-09-29 Thread Kyotaro HORIGUCHI
Hello, At Wed, 27 Sep 2017 14:28:37 +0300, Sokolov Yura wrote in <90bb67da7131e6186b50897c4b0f0...@postgrespro.ru> > On 2017-09-12 11:28, Kyotaro HORIGUCHI wrote: > > Hello, > > At Wed, 06 Sep 2017 13:46:16 +, Yura Sokolov > > wrote in > &

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

2017-09-28 Thread Kyotaro HORIGUCHI
s is not about the CATVER directory but lower directories. Being more strict, it actually makes excessive calls to verify_dir_is_em..() for more lower directories contrarily to expectations. I think that we can take more more robust way to detect the CATVER directory. Just checking if it is a top

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-25 Thread Kyotaro HORIGUCHI
At Fri, 22 Sep 2017 17:15:08 +0300, Sokolov Yura wrote in > On 2017-09-22 16:22, Sokolov Yura wrote: > > On 2017-09-22 11:21, Masahiko Sawada wrote: > >> On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI > >> wrote: > >>> At Fri, 22 Sep 2017 15:00:20

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-25 Thread Kyotaro HORIGUCHI
RecordPageWithFreeSpace to return the previous value to avoid duplicate fsm search..) regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-09-25 Thread Kyotaro HORIGUCHI
e in the documentaion ? The documentaion says about the XMLNAMESPACES clause as the folows. https://www.postgresql.org/docs/10/static/functions-xml.html > The optional XMLNAMESPACES clause is a comma-separated list of > namespaces. It specifies the XML namespaces used in the document >

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-22 Thread Kyotaro HORIGUCHI
At Fri, 22 Sep 2017 17:21:04 +0900, Masahiko Sawada wrote in > On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI > wrote: > > At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada > > wrote in > > > >> On Tue, Sep 19, 2017 at 3:31 PM, Kyotaro HORIGUCHI >

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-22 Thread Kyotaro HORIGUCHI
ake all those considerations moot. > An xact earlier than RecentGlobalXmin cannot have active transactions > able to follow links to that page AFAIK. > > TBH, I didn't read the whole papers, though I probably will. > > But, in essence, what's the difference of vacuu

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-22 Thread Kyotaro HORIGUCHI
At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada wrote in > On Tue, Sep 19, 2017 at 3:31 PM, Kyotaro HORIGUCHI > wrote: > > I was just looking the thread since it is found left alone for a > > long time in the CF app. > > > > At Mon, 18 Sep 2017 16:35:58 -0

Re: [HACKERS] analyzeCTE is too strict about typmods?

2017-09-21 Thread Kyotaro HORIGUCHI
it won't be a problem. | ERROR: recursive query "foo" column 1 has collation "it_IT" in non-recursive term but collation "ja_JP" overall | LINE 2: select a from bar |^ | HINT: Use the COLLATE clause to set the collation of the non-recursive term

Re: [HACKERS] hash index on unlogged tables doesn't behave as expected

2017-09-21 Thread Kyotaro HORIGUCHI
At Thu, 21 Sep 2017 20:35:01 -0400, Robert Haas wrote in > On Thu, Sep 21, 2017 at 8:16 PM, Kyotaro HORIGUCHI > wrote: > > Though I don't see it's bug and agree that the message is not > > proper, currently we can create hash indexes without no warning > >

Re: [HACKERS] hash index on unlogged tables doesn't behave as expected

2017-09-21 Thread Kyotaro HORIGUCHI
on unlogged tables, it seems to have been a problem and won't mind. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] hash index on unlogged tables doesn't behave as expected

2017-09-21 Thread Kyotaro HORIGUCHI
ctory indexcmds.c@965:503 > if (strcmp(accessMethodName, "hash") == 0 && > RelationNeedsWAL(rel)) > ereport(WARNING, > (errmsg("hash indexes are not WAL-logged and their use is > discouraged"))); Using !RelationUsesLocalBuffers instead fixes tha

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-21 Thread Kyotaro HORIGUCHI
of index t1_a_idx is NOT skipped > LOG: btvacuumscan(t1_a_idx) result: deleted = 2192, notrecyclable = 0, > hafldead = 0, no_cleanup_needed = true > LOG: automatic vacuum of table "postgres.public.t1": index scans: 0 Any suggestions are welcome. regards, -- Kyotaro Hor

Re: [HACKERS] subscription worker signalling wal writer too much

2017-09-19 Thread Kyotaro HORIGUCHI
WB/WA = 117/1700 : 6.9% of all XLogBackgroundFlush() did nothing. (woke by SetLatch 1582 times) TB/TA =110615/118000: 93% of SetLatch is avoided. (7785 times called) The condition for skipping SetLatch of the latest patch (v2) looks reasonable. And the effect is

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-18 Thread Kyotaro HORIGUCHI
y_scan_heap stores the flag in stats and in the next cycle it is looked up to decide the necessity of index cleanup. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Improve geometric types

2017-09-18 Thread Kyotaro HORIGUCHI
At Fri, 15 Sep 2017 11:25:30 -0400, Robert Haas wrote in > On Fri, Sep 15, 2017 at 4:23 AM, Kyotaro HORIGUCHI > wrote: > > /* don't merge the following same functions with different types > >into single macros so that double evaluation won't happen */ >

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2017-09-18 Thread Kyotaro HORIGUCHI
At Fri, 15 Sep 2017 15:36:26 +0900, Amit Langote wrote in > Hi. > > On 2017/08/28 18:28, Kyotaro HORIGUCHI wrote: > > << the following is another topic >> > > > >>>> BTW, in the partitioned table case, the parent is always locked first >

Re: [HACKERS] [PATCH] Improve geometric types

2017-09-15 Thread Kyotaro HORIGUCHI
gt; (FE_OVERFLOW) is raised. > > Range error: result underflow > An underflow floating-point exception (FE_UNDERFLOW) is raised. > > These functions do not set errno for this case. So, the code seems to need some amendments following to this

Re: [HACKERS] [PATCH] Improve geometric types

2017-09-15 Thread Kyotaro HORIGUCHI
At Fri, 15 Sep 2017 17:23:28 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170915.172328.97446299.horiguchi.kyot...@lab.ntt.co.jp> > At Thu, 14 Sep 2017 16:19:13 -0400, Robert Haas wrote > in > > On Thu, Sep 14, 2017 at 3:33 AM, Kyotaro HORIGUCHI > > wro

Re: [HACKERS] [PATCH] Improve geometric types

2017-09-15 Thread Kyotaro HORIGUCHI
At Thu, 14 Sep 2017 16:19:13 -0400, Robert Haas wrote in > On Thu, Sep 14, 2017 at 3:33 AM, Kyotaro HORIGUCHI > wrote: > > I recall a bit about the double-evaluation hazards. I think the > > functions needs a comment describing the reasons so that anyone > > kind won&#x

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2017-09-14 Thread Kyotaro HORIGUCHI
At Wed, 13 Sep 2017 20:20:48 -0400, Robert Haas wrote in > On Mon, Jun 26, 2017 at 4:46 AM, Kyotaro HORIGUCHI > wrote: > > The cause is that NO INHERIT doesn't take an exlusive lock on the > > parent. This allows expand_inherited_rtentry to add the child > >

Re: [HACKERS] [PATCH] Improve geometric types

2017-09-14 Thread Kyotaro HORIGUCHI
TH + 1, "%+.*g", ndig, num); > >> if (len > MINDOUBLEWIDTH + 1) > >>{ > >> ascii = (char *) repalloc(ascii, len); > >>if (snprintf(ascii, len, "%+.*e", ndig, num) > len) > >> error(ERRO

Re: [HACKERS] WAL logging problem in 9.4.3?

2017-09-13 Thread Kyotaro HORIGUCHI
At Wed, 13 Sep 2017 17:42:39 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170913.174239.25978735.horiguchi.kyot...@lab.ntt.co.jp> > filterdiff seems to did something wrong.. # to did... The patch is broken by filterdiff so I send a new patch made directly by git format

Re: [HACKERS] WAL logging problem in 9.4.3?

2017-09-13 Thread Kyotaro HORIGUCHI
iff master --patience | filterdiff --format=context | grep options filterdiff seems to did something wrong.. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-09-13 Thread Kyotaro HORIGUCHI
Hello, At Wed, 13 Sep 2017 17:28:20 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170913.172820.141647434.horiguchi.kyot...@lab.ntt.co.jp> > The context exists there before the patch but anyway using the > context as per-portal context that doesn't need freeing

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-09-13 Thread Kyotaro HORIGUCHI
At Wed, 13 Sep 2017 13:16:52 +0900, Michael Paquier wrote in > On Wed, Sep 13, 2017 at 1:13 PM, Kyotaro HORIGUCHI > wrote: > > This patch creates a new memory context "Vacuum" under > > PortalContext in vacuum.c, but AFAICS the current context there > > is Po

Re: [HACKERS] Restricting maximum keep segments by repslots

2017-09-13 Thread Kyotaro HORIGUCHI
At Wed, 13 Sep 2017 11:43:06 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170913.114306.67844218.horiguchi.kyot...@lab.ntt.co.jp> horiguchi.kyotaro> At Thu, 07 Sep 2017 21:59:56 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170907.215956.110216588.ho

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-09-12 Thread Kyotaro HORIGUCHI
e it is a child of PortalContext, it will go away eventually even > * if we suffer an error; there's no need for special abort cleanup logic. > */ > vac_context = AllocSetContextCreate(PortalContext, >"Vacuum", >ALLOCSET_DEFAULT_SIZES); So this seems to

Re: [HACKERS] Restricting maximum keep segments by repslots

2017-09-12 Thread Kyotaro HORIGUCHI
At Thu, 07 Sep 2017 21:59:56 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170907.215956.110216588.horiguchi.kyot...@lab.ntt.co.jp> > Hello, > > At Thu, 07 Sep 2017 14:12:12 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI > wrote in > <20170907.141212.

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2017-09-12 Thread Kyotaro HORIGUCHI
At Mon, 28 Aug 2017 18:28:07 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170828.182807.98097766.horiguchi.kyot...@lab.ntt.co.jp> > I'll add this to CF2017-09. This patch got deadly atack from the commit 30833ba. I changed the signature of expand_single_inheri

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

2017-09-12 Thread Kyotaro HORIGUCHI
;1364 if (!(options & HEAP_INSERT_SKIP_WAL) && RelationNeedsWAL(relation)) These lines shows that the patch is applied halfway. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to yo

Re: [HACKERS] WAL logging problem in 9.4.3?

2017-09-12 Thread Kyotaro HORIGUCHI
L(relation, buffer)) So I conclude that the CI mechinery failed to applly the patch correctly. At Thu, 13 Apr 2017 15:29:35 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170413.152935.100104316.horiguchi.kyot...@lab.ntt.co.jp> > > > > I'll post new patch in

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

2017-09-12 Thread Kyotaro HORIGUCHI
ch > >> excludes about one whole hemisphere where it's either too early or too > >> late for people to respond. I'd say waiting for >24 hours would be more > >> appropriate. > > > > Agreed. > > Definitely. Any batch updates have to invo

Re: [HACKERS] [PATCH] Improve geometric types

2017-09-12 Thread Kyotaro HORIGUCHI
palloc(ascii, len); >if (snprintf(ascii, len, "%+.*e", ndig, num) > len) > error(ERROR, "something wrong happens..."); > } I don't think the if part can be used so there would be no performance degradation, I believe. I'd like to pa

Re: [HACKERS] Walsender timeouts and large transactions

2017-09-12 Thread Kyotaro HORIGUCHI
nished sleep for 1ms? } What do you think about this? regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] WAL logging problem in 9.4.3?

2017-09-11 Thread Kyotaro HORIGUCHI
Hello, At Fri, 08 Sep 2017 16:30:01 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170908.163001.53230385.horiguchi.kyot...@lab.ntt.co.jp> > > >> 2017-04-13 12:11:27.065 JST [85441] t/102_vacuumdb_stages.pl > > >> STATEMENT: ANALYZE; > > >&g

Re: [HACKERS] WAL logging problem in 9.4.3?

2017-09-08 Thread Kyotaro HORIGUCHI
Thank you for your notification. At Tue, 5 Sep 2017 12:05:01 +0200, Daniel Gustafsson wrote in > > On 13 Apr 2017, at 11:42, Kyotaro HORIGUCHI > > wrote: > > > > At Thu, 13 Apr 2017 13:52:40 +0900, Michael Paquier > > wrote in > > > >> On Tu

Re: [HACKERS] Restricting maximum keep segments by repslots

2017-09-07 Thread Kyotaro HORIGUCHI
Hello, At Thu, 07 Sep 2017 14:12:12 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170907.141212.227032666.horiguchi.kyot...@lab.ntt.co.jp> > > I would like a flag in pg_replication_slots, and possibly also a > > numerical column that indicates how far away from

Re: [HACKERS] Restricting maximum keep segments by repslots

2017-09-06 Thread Kyotaro HORIGUCHI
lopment, 24x7 Support, Remote DBA, Training & Services > Thanks. -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-09-06 Thread Kyotaro HORIGUCHI
Hello, At Wed, 6 Sep 2017 12:23:53 -0700, Andres Freund wrote in <20170906192353.ufp2dq7wm5fd6...@alap3.anarazel.de> > On 2017-09-06 17:36:02 +0900, Kyotaro HORIGUCHI wrote: > > The problem is that the current ReadRecord needs the first one of > > a series of continuation

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-09-06 Thread Kyotaro HORIGUCHI
eeded refactoring, (seems to me) breaking the concept of XLogReader plug-in system to accomplish this behavior. If it is preferable for you, I'll re-try that. Or hints for other solutions are also welcome. Is there any suggestions? regards, -- Kyotaro Horiguchi NTT Open Source Software

Re: [HACKERS] Protect syscache from bloating with negative cache entries

2017-09-05 Thread Kyotaro HORIGUCHI
Thank you for the comment. At Mon, 28 Aug 2017 21:31:58 -0400, Robert Haas wrote in > On Mon, Aug 28, 2017 at 5:24 AM, Kyotaro HORIGUCHI > wrote: > > This patch have had interferences from several commits after the > > last submission. I amended this patch to follow them

Re: [HACKERS] Protect syscache from bloating with negative cache entries

2017-09-05 Thread Kyotaro HORIGUCHI
Thank you for reviewing this. At Sat, 2 Sep 2017 12:12:47 +1200, Thomas Munro wrote in > On Mon, Aug 28, 2017 at 9:24 PM, Kyotaro HORIGUCHI > wrote: > > This patch have had interferences from several commits after the > > last submission. I amended this patch to follow them

Re: [HACKERS] multiple target of VACUUM command

2017-09-05 Thread Kyotaro HORIGUCHI
Ouch! At Thu, 31 Aug 2017 23:09:20 +0900, Michael Paquier wrote in > On Thu, Aug 31, 2017 at 9:53 PM, Kyotaro HORIGUCHI > wrote: > > I sometimes feel annoyed when trying to VACUUM multiple specific > > tables. > > > > postgres=# vacuum a, b; > > ERROR: sy

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-09-05 Thread Kyotaro HORIGUCHI
Hello, At Mon, 28 Aug 2017 20:07:32 -0700, "David G. Johnston" wrote in > On Mon, Aug 28, 2017 at 2:26 AM, Kyotaro HORIGUCHI < > horiguchi.kyot...@lab.ntt.co.jp> wrote: > > > https://www.postgresql.org/docs/devel/static/runtime-config-client.html > > >

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-09-04 Thread Kyotaro HORIGUCHI
Thank you for the opinions. At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada wrote in > On Tue, Aug 29, 2017 at 10:16 AM, Robert Haas wrote: > > On Mon, Aug 28, 2017 at 5:26 AM, Kyotaro HORIGUCHI > > wrote: > >> Currently the message shows the '%d skipped-f

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-09-03 Thread Kyotaro HORIGUCHI
Hello, Thank you for reviewing this. At Mon, 28 Aug 2017 20:14:54 +0900, Michael Paquier wrote in > On Mon, Aug 28, 2017 at 8:02 PM, Kyotaro HORIGUCHI > wrote: > > The first patch (0001-) fixes this problem, preventing the > > problematic state of WAL segments by retardin

Re: [HACKERS] asynchronous execution

2017-09-03 Thread Kyotaro HORIGUCHI
At Thu, 31 Aug 2017 21:52:36 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170831.215236.135328985.horiguchi.kyot...@lab.ntt.co.jp> > At Thu, 03 Aug 2017 09:30:57 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI > wrote in > <20170803.093057.261590

[HACKERS] multiple target of VACUUM command

2017-08-31 Thread Kyotaro HORIGUCHI
Hello, I sometimes feel annoyed when trying to VACUUM multiple specific tables. postgres=# vacuum a, b; ERROR: syntax error at or near "," LINE 1: vacuum a, b; This patch just allows multiple targets for VACUUM command. regards, -- Kyotaro Horiguchi NTT Open Source Software Ce

Re: [HACKERS] asynchronous execution

2017-08-31 Thread Kyotaro HORIGUCHI
At Thu, 03 Aug 2017 09:30:57 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170803.093057.261590619.horiguchi.kyot...@lab.ntt.co.jp> > > Unfortunately, that's probably another gigantic patch (that > > should probably be written by Andres). > > Ye

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-08-28 Thread Kyotaro HORIGUCHI
cal replication slot in a certain condition. regards, -- Kyotaro Horiguchi NTT Open Source Software Center >From 3813599b74299f1da8d0567ed90542c5f35ed48b Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Wed, 1 Feb 2017 16:07:22 +0900 Subject: [PATCH 1/2] Retard restart LSN of a slo

Re: [HACKERS] Restricting maximum keep segments by repslots

2017-08-28 Thread Kyotaro HORIGUCHI
Hello, I'll add this to CF2017-09. At Mon, 06 Mar 2017 18:20:06 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170306.182006.172683338.horiguchi.kyot...@lab.ntt.co.jp> > Thank you for the comment. > > At Fri, 3 Mar 2017 14:47:20 -0500, Peter Eisentraut >

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2017-08-28 Thread Kyotaro HORIGUCHI
Hello, I'll add this to CF2017-09. At Tue, 27 Jun 2017 16:27:18 +0900, Amit Langote wrote in <75fe42df-b1d8-89ff-596d-d9da0749e...@lab.ntt.co.jp> > On 2017/06/26 18:44, Kyotaro HORIGUCHI wrote: > > At Mon, 26 Jun 2017 18:16:42 +0900, Amit Langote wrote: > >> >

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-08-28 Thread Kyotaro HORIGUCHI
e true effect of ALL_FROZEN. I will add this patch to CF2017-09. At Tue, 4 Apr 2017 20:29:38 +0900, Masahiko Sawada wrote in > On Tue, Apr 4, 2017 at 10:09 AM, Kyotaro HORIGUCHI > wrote: > > | =# vacuum freeze verbose it; > > | INFO: vacuuming "public.it" in aggr

Re: [HACKERS] Protect syscache from bloating with negative cache entries

2017-08-28 Thread Kyotaro HORIGUCHI
Thank you for your attention. At Mon, 14 Aug 2017 17:33:48 -0400, Peter Eisentraut wrote in <09fa011f-4536-b05d-0625-11f3625d8...@2ndquadrant.com> > On 1/24/17 02:58, Kyotaro HORIGUCHI wrote: > >> BTW, if you set a slightly larger > >> context size on the patch

Re: [HACKERS] asynchronous execution

2017-08-02 Thread Kyotaro HORIGUCHI
Thank you for the comment. At Tue, 1 Aug 2017 16:27:41 -0400, Robert Haas wrote in > On Mon, Jul 31, 2017 at 5:42 AM, Kyotaro HORIGUCHI > wrote: > > Another is getting rid of recursive call to run an execution > > tree. > > That happens to be exactly what Andres did f

Re: [HACKERS] asynchronous execution

2017-07-31 Thread Kyotaro HORIGUCHI
At Fri, 28 Jul 2017 17:31:05 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170728.173105.238045591.horiguchi.kyot...@lab.ntt.co.jp> > Thank you for the comment. > > At Wed, 26 Jul 2017 17:16:43 -0400, Robert Haas wrote > in > > regression all

Re: [HACKERS] asynchronous execution

2017-07-28 Thread Kyotaro HORIGUCHI
the pointer, Tom. The subject (segfault in HEAD...) haven't made me think that this kind of discussion was held there. Anyway it seems very closer to asynchronous execution so I'll catch up it considering how I can associate with this. Regards. -- Kyotaro Horiguchi NTT

Re: [HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public.

2017-07-25 Thread Kyotaro HORIGUCHI
hink such breakage doesn't matter so much. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] asynchronous execution

2017-07-25 Thread Kyotaro HORIGUCHI
Hello, 8bf58c0d9bd33686 badly conflicts with this patch, so I'll rebase this and added a patch to refactor the function that Anotonin pointed. This would be merged into 0002 patch. At Tue, 18 Jul 2017 16:24:52 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170718.162452.2

Re: [HACKERS] PgFDW connection invalidation by ALTER SERVER/ALTER USER MAPPING

2017-07-25 Thread Kyotaro HORIGUCHI
At Mon, 24 Jul 2017 10:23:07 +0530, Ashutosh Bapat wrote in > On Fri, Jul 21, 2017 at 10:39 PM, Tom Lane wrote: > > Ashutosh Bapat writes: > >> On Fri, Jul 21, 2017 at 10:55 AM, Kyotaro HORIGUCHI > >> wrote: > >>> The attached patch differs only in t

Re: [HACKERS] Mishandling of WCO constraints in direct foreign table modification

2017-07-21 Thread Kyotaro HORIGUCHI
In UPDATE, Might be a silly question, is CHECK OPTION a "constraint"? regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [TRAP: FailedAssertion] causing server to crash

2017-07-21 Thread Kyotaro HORIGUCHI
At Fri, 21 Jul 2017 11:39:38 +0530, Neha Sharma wrote in > Here is the back trace from the core dump attached. > > (gdb) bt > #0 0x7f4a71424495 in raise () from /lib64/libc.so.6 > #1 0x7f4a71425c75 in abort () from /lib64/libc.so.6 > #2 0x009dc18a in ExceptionalCondition (con

Re: [HACKERS] PgFDW connection invalidation by ALTER SERVER/ALTER USER MAPPING

2017-07-20 Thread Kyotaro HORIGUCHI
At Thu, 20 Jul 2017 18:23:05 -0400, Alvaro Herrera wrote in <20170720222305.ij3pk7qw5im3wozr@alvherre.pgsql> > Kyotaro HORIGUCHI wrote: > > > Finally, I added a new TAP test library PsqlSession. It offers > > interactive psql sessions. Then added a simple test to &

Re: [HACKERS] PgFDW connection invalidation by ALTER SERVER/ALTER USER MAPPING

2017-07-20 Thread Kyotaro HORIGUCHI
ID && + entry->mapping_hashvalue == hashvalue))) + entry->invalidated = true; The attached patch differs only in this point. > I think this is actually a bug fix, and should not wait for the next > commitfest. Agreed. regards, -- Kyotaro Horiguchi NTT Op

Re: [HACKERS] PgFDW connection invalidation by ALTER SERVER/ALTER USER MAPPING

2017-07-19 Thread Kyotaro HORIGUCHI
Finally, I added new TAP test library PsqlSession. At Tue, 18 Jul 2017 18:12:13 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20170718.181213.206979369.horiguchi.kyot...@lab.ntt.co.jp> > > * How about some regression test cases? You couldn't really exercise

Re: [HACKERS] PgFDW connection invalidation by ALTER SERVER/ALTER USER MAPPING

2017-07-18 Thread Kyotaro HORIGUCHI
Thank you for the comments. At Mon, 17 Jul 2017 16:09:04 -0400, Tom Lane wrote in <9897.1500322...@sss.pgh.pa.us> > Kyotaro HORIGUCHI writes: > > This is the revased and revised version of the previous patch. > > A few more comments: > > * Per the spec for Cache

Re: [HACKERS] asynchronous execution

2017-07-18 Thread Kyotaro HORIGUCHI
Hello, At Tue, 11 Jul 2017 10:28:51 +0200, Antonin Houska wrote in <6448.1499761731@localhost> > Kyotaro HORIGUCHI wrote: > > Effectively it is a waiting-queue followed by a > > completed-list. The point of the compaction is keeping the order > > of waiting or not-ye

Re: [HACKERS] PgFDW connection invalidation by ALTER SERVER/ALTER USER MAPPING

2017-07-14 Thread Kyotaro HORIGUCHI
Thank you for the comments. At Thu, 13 Jul 2017 16:54:42 +0530, Ashutosh Bapat wrote in > On Thu, Jul 13, 2017 at 2:53 PM, Kyotaro HORIGUCHI > wrote: > > Hello, moved to pgsql-hackers. > > > > This is the revased and revised version of the previous patch. > > &g

  1   2   3   4   5   6   7   8   9   10   >