Re: [HACKERS] snapshot generation broken again...

2010-01-06 Thread John Naylor
Here's a fix. Sorry, I didn't realize it was ever called without a version number. On Wed, Jan 6, 2010 at 11:18 AM, Stefan Kaltenbrunner > heh that's a nice one the snapshot generation script uses " > gmake -s VERSION=snapshot dist" and that leads to getting " > --set-version=snapshot" passed to g

Re: [HACKERS] Does parallel make require guards against duplicate actions?

2010-01-04 Thread John Naylor
FWIW, the old make rule was fmgroids.h fmgrtab.c: (deps) which is now fmgroids.h: fmgrtab.c ; fmgrtab.c: (deps) I was going by this comment in parser/Makefile: # There is no correct way to write a rule that generates two files. # Rules with two targets don't have that meaning, they are merel

Re: [HACKERS] patch - per-tablespace random_page_cost/seq_page_cost

2010-01-04 Thread John Naylor
Tom, It seems I introduced a couple errors in src/tools/msvc/clean.bat in the bki patch. I'm attaching a cumulative fix. I can resend the complete updated patch, if you like... Sorry! :-) John > I'm planning to go look at Naylor's bki refactoring patch now. Assuming > there isn't any showstoppe

Re: [HACKERS] Patch: Remove all declarations from pg_attribute.h, consolidate BKI scripts

2009-12-20 Thread John Naylor
On Sun, Dec 20, 2009 at 7:24 PM, Andres Freund wrote: > On Monday 21 December 2009 04:23:57 Tom Lane wrote: >> Andres Freund writes: >> > On Monday 21 December 2009 02:23:39 Robert Haas wrote: >> >> A more important point is whether we really need to make this >> >> dependent on Perl 5.6 or later

[HACKERS] Small typos in Hot Standby docs

2009-12-19 Thread John Naylor
Here's a patch: diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml index 6750db8..1276c39 100644 *** a/doc/src/sgml/backup.sgml --- b/doc/src/sgml/backup.sgml *** if (!triggered) *** 2018,2024 !Data Definition Language (DML) - INSERT,

Re: [HACKERS] Experimental patch: generating BKI revisited

2009-11-13 Thread John Naylor
On Fri, Nov 13, 2009 at 5:16 AM, Alvaro Herrera wrote: > I had a look at this some time ago and I must admit that I find it > pretty interesting. The technology choices make it > obviously impossible to merge -- not only the particular Perl modules > used, but the mere fact that Perl is used (and

[HACKERS] Experimental patch: generating BKI revisited

2009-11-04 Thread John Naylor
Hello everyone, I was quite intrigued by a discussion that happened this past summer regarding generation of bootstrap files such as postgres.bki, and the associated pain points of maintaining the DATA() statements in catalog headers. It occurred to me that the current system is backwards: Instead

Re: [HACKERS] Review handling of MOVE and FETCH (ToDo)

2009-09-28 Thread John Naylor
(resent to -hackers) I just applied and tested the new patch. Everything works great. The only thing I would change now is some of the comments. 1). On line 289, one of the regression test comments got copied: +   move forward in c;                --should be at '5' change to: +   move forwar