Re: [HACKERS] [PATCHES] ISBN/ISSN/ISMN/EAN13 module

2006-09-10 Thread Jeremy Kronuz
> ... Tom, were you able to apply the patch without problems > ('cause this is one of the first times I post a patch in a mailing list.) Um, no, doesn't work at all unfortunately: $ patch --dry <~/ean.patch patching file isn.c patch: malformed patch at line 6: enum isn_type { INVALID, ANY

Re: [HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-09-10 Thread Jeremy Kronuz
> Tom, I've checked the version in the cvs and I had made significant changes > from that version. Hm, it sounds like I guessed wrong about which version was newer ... is there something flaky about your machine's system clock? The file timestamps in the two tarballs definitely pointed the othe

Re: [HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-09-09 Thread Jeremy Kronuz
I also added other functionality to the module but I forgot to update the README... contrary to what it says in the README.isn, you do can cast from ean13 to other types, as long as the cast is valid (i.e. you can't cast a EAN13 of a UPC or a ISMN code to a ISBN number, for instance.) So, the

[HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-09-09 Thread Jeremy Kronuz
>> I'm reviewing this for addition to contrib/ now. I notice that there is >> no clear license statement. Is it OK to put the following into the >> README file? > Tom, yes. Also, I just put copyright in the files that contain a significant > amount of code written by me. (i.e. isn.h and isn.

Re: [HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-09-08 Thread Jeremy Kronuz
"Jeremy Kronuz" <[EMAIL PROTECTED]> writes: > Hello again,This is an usable version of my EAN13/UPC/ISBN module. I'm reviewing this for addition to contrib/ now. I notice that there is no clear license statement. Is it OK to put the following into the README file? E

Re: [HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-08-24 Thread Jeremy Kronuz
Hello again,This is an usable version of my EAN13/UPC/ISBN module. It handles EAN13, ISBN13, ISBN, ISMN, ISSN, UPC and the non standard ISMN13 and ISSN13. It validates check digits and can be used to auto generate valid numbers with correct check digits too. It seems the the file I attached w

Re: [HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-08-23 Thread Jeremy Kronuz
> > >  > > > Michael wrote:> > > I do hope that your algorithm for generating 13 digits from 10 has been > > > validated with isbn.org, since all the check digits will change.  I > > > believe it is crucial for postgresql to generate isbn codes in both 10 > > > and 13 digits> >> > Indeed now that

Re: [HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-08-23 Thread Jeremy Kronuz
  > Michael wrote:> I do hope that your algorithm for generating 13 digits from 10 has been > validated with isbn.org, since all the check digits will change.  I > believe it is crucial for postgresql to generate isbn codes in both 10 > and 13 digits Indeed now that see the module it's finally cl

Re: [HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-08-21 Thread Jeremy Kronuz
gt; To: [EMAIL PROTECTED]> Date: Mon, 21 Aug 2006 13:52:26 -0400> CC: pgsql-hackers@postgresql.org> > > Do we want to replace our /contrib/isbn with this, or have it pgfoundry?> > -------> > Jeremy Kronuz 

[HACKERS] ISBN/ISSN/ISMN/EAN13 module

2006-04-25 Thread Jeremy Kronuz
I worked on this ISBN/ISSN/ISMN/EAN13 module about more than a year ago, and I was wondering if it could be made official, I honestly think it's better than the ISBN/ISSN currently included in the official release; plus mine would also probably support UPC codes and it already support the new ISB