Re: [HACKERS] fe-secure.c and SSL/TLS

2013-11-30 Thread Jeffrey Walton
bdl.so.2 (0x7f1e06359000) libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x7f1e06142000) /lib64/ld-linux-x86-64.so.2 (0x7f1e06f6d000) Gotta love back patching and broken versioning ;) Jeff On Sat, Nov 30, 2013 at 4:12 AM, Marko Kreen wrote: > On Sat, Nov 30, 2013 at 03:46:06AM -0

Re: [HACKERS] fe-secure.c and SSL/TLS

2013-11-30 Thread Jeffrey Walton
ints are mainly academic). But I think its still needed for interop. I've never rolled a system without it enabled. Jeff On Fri, Nov 29, 2013 at 7:14 PM, Marko Kreen wrote: > On Fri, Nov 29, 2013 at 06:01:01PM -0500, Jeffrey Walton wrote: >> I know of no other ways to check t

Re: [HACKERS] fe-secure.c and SSL/TLS

2013-11-30 Thread Jeffrey Walton
detail. Please accept my apologies. Jeff On Fri, Nov 29, 2013 at 7:14 PM, Marko Kreen wrote: > On Fri, Nov 29, 2013 at 06:01:01PM -0500, Jeffrey Walton wrote: >> I know of no other ways to check the result of OpenSSL's chain >> validation. The open question (for me) is

Re: [HACKERS] fe-secure.c and SSL/TLS

2013-11-29 Thread Jeffrey Walton
Hi Marko, Forgive me for cherry picking two of these... > I think Postgres uses SSL_VERIFY_PEER + SSL_set_verify() callback instead. > At least for me, the psql -d "dbname=foo sslmode=verify-ca" fails > when cert does not match. I can't comment on the use of psql. My apologies for my ignorance. H

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 7:11 PM, Alvaro Herrera wrote: > Kevin Grittner escribió: > >> These both seemed legitimate to me. Patch attached. Any >> objections to applying it? I realize the memory leak is a tiny one >> in the regression testing code, so it could never amount to enough >> to matter

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 5:19 PM, Peter Eisentraut wrote: > On 11/12/13, 8:18 AM, Kevin Grittner wrote: >> Here is the summary of what was reported: >> >> All Bugs: 313 > >> Does anything stand out as something that is particularly worth >> looking into? Does anything here seem worth assuming is

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 6:04 PM, Kevin Grittner wrote: > Peter Eisentraut wrote: > >> I have tracked scan-build for some time, and I'm sure that almost >> all of these bugs are false positives at this point. > > From poking around, I agree. One particular error I noticed that > it makes a lot is

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 3:35 PM, Andres Freund wrote: > On 2013-11-12 15:33:13 -0500, Jeffrey Walton wrote: >> On Tue, Nov 12, 2013 at 3:25 PM, Andres Freund >> wrote: >> > On 2013-11-12 15:17:18 -0500, Jeffrey Walton wrote: >> > ... >> > It might not

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 9:38 AM, Tom Lane wrote: > Kevin Grittner writes: >> Does anything stand out as something that is particularly worth >> looking into? Does anything here seem worth assuming is completely >> bogus because of the Coverity and Valgrind passes? > > I thought most of it was ob

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 3:25 PM, Andres Freund wrote: > On 2013-11-12 15:17:18 -0500, Jeffrey Walton wrote: >> On Tue, Nov 12, 2013 at 9:38 AM, Tom Lane wrote: >> > ... >> > One thought for the Clang people is that most of the reports such as "null >> >

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-12 Thread Jeffrey Walton
On Tue, Nov 12, 2013 at 9:38 AM, Tom Lane wrote: > ... > > One thought for the Clang people is that most of the reports such as "null > pointer dereference" presumably mean "I think I see an execution path > whereby we could get here with a null pointer". If so, it'd be awfully > helpful if the c

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-11 Thread Jeffrey Walton
On Mon, Nov 11, 2013 at 6:01 PM, Kevin Grittner wrote: > Peter Geoghegan wrote: >> Kevin Grittner wrote: >> >>> I'm currently capturing a text version of all the warnings from >>> this. Will gzip and post when it finishes. It's generating a lot >>> of warnings; I have no idea how many are Post

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-11 Thread Jeffrey Walton
On Mon, Nov 11, 2013 at 5:51 PM, Peter Geoghegan wrote: > On Mon, Nov 11, 2013 at 2:45 PM, Jeffrey Walton wrote: >> I think you are right. Coverity is a very nice tool, and Clang has >> some growing to do. > > To be fair to the LLVM/Clang guys, it's not as if static

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-11 Thread Jeffrey Walton
On Mon, Nov 11, 2013 at 5:18 PM, Kevin Grittner wrote: > [moving the discussion to pgsql-hackers] > > Jeffrey Walton wrote: >> ... >> ## >> # Sanitizers >> >> make distclean >> >> export DYLD_FALLBACK_LIBRARY_PATH=/usr/local/lib/clan

Re: [HACKERS] Clang 3.3 Analyzer Results

2013-11-11 Thread Jeffrey Walton
On Mon, Nov 11, 2013 at 5:29 PM, Peter Geoghegan wrote: > On Mon, Nov 11, 2013 at 2:18 PM, Kevin Grittner wrote: >> I'm currently capturing a text version of all the warnings from >> this. Will gzip and post when it finishes. It's generating a lot >> of warnings; I have no idea how many are Pos