Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-10-10 Thread Wood, Dan
I found one glitch with our merge of the original dup row fix. With that corrected AND Alvaro’s Friday fix things are solid. No dup’s. No index corruption. Thanks so much. On 10/10/17, 7:25 PM, "Michael Paquier" wrote: On Tue, Oct 10, 2017 at 11:14 PM, Alvaro Herrera wrote: > I

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-10-08 Thread Wood, Dan
I’m unclear on what is being repro’d in 9.6. Are you getting the duplicate rows problem or just the reindex problem? Are you testing with asserts enabled(I’m not)? If you are getting the dup rows consider the code in the block in heapam.c that starts with the comment “replace multi by update

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-10-05 Thread Wood, Dan
9 AM, Wood, Dan wrote: > Whatever you do make sure to also test 250 clients running lock.sql. Even with the communities fix plus YiWen’s fix I can still get duplicate rows. What works for “in-block” hot chains may not work when spanning blocks. Interesting. Which version did you t

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-10-04 Thread Wood, Dan
Whatever you do make sure to also test 250 clients running lock.sql. Even with the communities fix plus YiWen’s fix I can still get duplicate rows. What works for “in-block” hot chains may not work when spanning blocks. Once nearly all 250 clients have done their updates and everybody is waiti

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-10-03 Thread Wood, Dan
| 49155 | 36963 | 36961 7 | (0,7) | 8032 | 11010 | 32771 | 36961 | 0 (7 rows) On 10/3/17, 6:20 PM, "Peter Geoghegan" wrote: On Tue, Oct 3, 2017 at 6:09 PM, Wood, Dan wrote: > I’ve just started looking at this again after a fe

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-10-03 Thread Wood, Dan
I’ve just started looking at this again after a few weeks break. There is a tangled web of issues here. With the community fix we get a corrupted page(invalid redirect ptr from indexed item). The cause of that is: pruneheap.c: /* * Check the tuple XMIN agai

[HACKERS] PGCon 2017 registration now open

2017-04-17 Thread Dan Langille
gistration is now open at http://www.pgcon.org/2017/registration.php <http://www.pgcon.org/2017/registration.php> -- Dan Langille - BSDCan / PGCon d...@langille.org <mailto:d...@langille.org>

[HACKERS] potential hardware donation

2017-01-27 Thread Dan Langille
If someone wanted to donate a SuperServer 6028TR-D72R (http://www.supermicro.com/products/system/2U/6028/SYS-6028TR-D72R.cfm) to the PostgreSQL project, would it be used? -- Dan Langille - BSDCan / PGCon d...@langille.org

[HACKERS] reminder: PGCon 2017 CFP

2017-01-17 Thread Dan Langille
7/papers.php>> Instructions for submitting a proposal to PGCon 2017 are available from: <http://www.pgcon.org/2017/submissions.php <http://www.pgcon.org/2017/submissions.php>> -- Dan Langille - BSDCan / PGCon d...@langille.org <mailto:d...@langille.org>

[HACKERS] PGCon 2016 CFP - one week left

2016-01-12 Thread Dan Langille
Hello There is one week left in the PGCon CFP. Details below. Please submit. Thanks. PGCon 2016 will be on 17-21 May 2016 at University of Ottawa. * 17-18 (Tue-Wed) tutorials * 19 & 20 (Thu-Fri) talks - the main part of the conference * 17 & 21 (Wed & Sat) The Developer Unconference & the Us

[HACKERS] PGCon 2016 call for papers

2016-01-03 Thread Dan Langille
In case you've overlooked it, you have about two weeks to submit your proposal. PGCon 2016 will be on 17-21 May 2016 at University of Ottawa. * 17-18 (Tue-Wed) tutorials * 19 & 20 (Thu-Fri) talks - the main part of the conference * 17 & 21 (Wed & Sat) The Developer Unconference & the User Unconfe

Re: [HACKERS] could not truncate directory "pg_subtrans": apparent wraparound

2015-06-08 Thread Dan Langille
If there's anything I can try on my servers to help diagnose the issues, please let me know. If desired, I can arrange access for debugging. On Sat, Jun 6, 2015 at 12:51 AM, Thomas Munro wrote: > On Sat, Jun 6, 2015 at 1:25 PM, Alvaro Herrera > wrote: > > Thomas Munro wrote: > > > >> My idea w

[HACKERS] could not truncate directory "pg_subtrans": apparent wraparound

2015-06-05 Thread Dan Langille
pgsql/data/pg_subtrans] # ls -l total 1 -rw--- 1 pgsql pgsql 8192 Jun 5 19:04 0032 This not not a high throughput server. — Dan Langille http://langille.org/ signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [HACKERS] PGCon hacker lounge

2015-05-28 Thread Dan Langille
> On May 27, 2015, at 12:06 PM, Alexander Korotkov > wrote: > > On Wed, May 27, 2015 at 7:00 PM, Dan Langille <mailto:d...@langille.org>> wrote: > Have you been to PGCon before? Do you remember the hacker lounge? Do you > remember going there to work on stuff? D

[HACKERS] PGCon hacker lounge

2015-05-27 Thread Dan Langille
Have you been to PGCon before? Do you remember the hacker lounge? Do you remember going there to work on stuff? Do you recall anything about it? — Dan Langille http://langille.org/ signature.asc Description: Message signed with OpenPGP using GPGMail

[HACKERS] PGCon 2015

2015-05-04 Thread Dan Langille
want to be there. Don't leave it much longer. — Dan Langille http://langille.org/ signature.asc Description: Message signed with OpenPGP using GPGMail

[HACKERS] HEADS UP: PGCon 2015 major schedule changes

2015-02-05 Thread Dan Langille
week, but we felt that our changes were already disruptive and wanted to minimize the effects this late change may have on people who have already booked travel / accommodation. To those affected, we apologize and hope that this new structure will benefit everyone. — Dan Langille ht

[HACKERS] PGCon 2015 - last day

2015-01-19 Thread Dan Langille
Today is your last day to submit your PGCon 2015 proposal. -- Dan Langille http://langille.org/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] PGCon 2015

2015-01-18 Thread Dan Langille
Is your PGCon 2015 submission going in today or tomorrow? -- Dan Langille http://langille.org/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] PGCon 2015 call for papers - reminder

2015-01-12 Thread Dan Langille
015/papers.php> Instructions for submitting a proposal to PGCon 2015 are available from: <http://www.pgcon.org/2015/submissions.php> — Dan Langille http://langille.org/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscr

[HACKERS] PGCon 2015 call for papers

2015-01-05 Thread Dan Langille
<http://www.pgcon.org/2015/submissions.php> — Dan Langille http://langille.org/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Validating CHECK constraints with SPI

2014-10-29 Thread Dan Robinson
On Wed, Oct 29, 2014 at 7:17 AM, Alvaro Herrera wrote: > Dan Robinson wrote: > > Hi all, > > > > If I'm reading correctly in src/backend/commands/tablecmds.c, it looks > like > > PostgreSQL does a full table scan in validateCheckConstraint and in the &

[HACKERS] Validating CHECK constraints with SPI

2014-10-29 Thread Dan Robinson
rue already if you do the same with enable_indexscan off, but that requires knowing that PostgreSQL is going to do the seq scan no matter what.) Would y'all be open to a patch that made this change? Best, -Dan

[HACKERS] HEADS UP: PGCon 2015 is in June

2014-09-27 Thread Dan Langille
HEADS UP. PGCon 2015 will be in June. That’s a few weeks later than in previous years. — Dan Langille signature.asc Description: Message signed with OpenPGP using GPGMail

[HACKERS] PGCon 2014 - last chance

2014-01-19 Thread Dan Langille
<http://www.pgcon.org/2014/submissions.php> -- Dan Langille - http://langille.org signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [HACKERS] Re: How to reproduce serialization failure for a read only transaction.

2014-01-07 Thread Dan Ports
ransactions are (intentionally) not included in those checks. W1 is therefore allowed to commit; the apparent serial order of execution is W1 followed by W2, and the results of the aborted transaction R aren't consistent with that. Dan -- Dan R. K. PortsUW CSE

[HACKERS] PGCon 2014 call for papers

2013-12-12 Thread Dan Langille
will go out very close to the conference. Do not submit lightning talks proposals until then. See also <http://www.pgcon.org/2014/papers.php> Instructions for submitting a proposal to PGCon 2014 are available from: <http://www.pgcon.org/2014/submissions.php> -- Dan Lan

Re: [HACKERS] SSI freezing bug

2013-10-07 Thread Dan Ports
gt; page-level lock, which would also create unnecessary conflicts. Dan -- Dan R. K. PortsUW CSEhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SSI freezing bug

2013-10-03 Thread Dan Ports
ful thought is needed here... > It seems to me that a change such as you are now suggesting is > likely to be too invasive to back-patch.  Do you agree that it > would make sense to apply the patch I have proposed, back to 9.1, > and then consider any alternative as 9.4 material? I agr

Re: [HACKERS] lwlock contention with SSI

2013-04-10 Thread Dan Ports
ALIZABLEXACTs and RWConflicts, the SerializableXidHash table, the latest SxactCommitSeqno and SxactGlobalXmin, etc. I'm trying to swap back in my notes about how to address this. It is bound to be a substantial project, however. Dan -- Dan R. K. PortsUW CSE

Re: [HACKERS] leaking lots of unreferenced inodes (pg_xlog files?), maybe after moving tables and indexes to tablespace on different volume

2013-03-13 Thread Dan Thomas
now we've been upgrading things in the hope that the problem will go away, but since we've got one server up to fbsd9.1/pg9.2.3 and still seeing the problem we're a little stumped. Any ideas about how we can go about debugging this would be appreciated. Thanks, Dan On 13 March 2013 07

[HACKERS] PGCon 2013 - CFP & unconference day

2013-01-03 Thread Dan Langille
by developers and users of PostgreSQL. Be sure to submit your proposal soon because time is running out. -- Dan Langille - http://langille.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Strange errors from 9.2.1 and 9.2.2 (I hope I'm missing something obvious)

2012-12-16 Thread Dan Scott
On Dec 11, 2012 9:28 PM, "David Gould" wrote: > > Thank you. I got the example via cut and paste from email and pasted it > into psql on different hosts. od tells me it ends each line with: > > \n followed by 0xC2 0xA0 and then normal spaces. The C2A0 thing is > apparently NO-BREAK SPACE. Invi

[HACKERS] PGCon 2013 - call for papers

2012-12-08 Thread Dan Langille
php> Instructions for submitting a proposal to PGCon 2013 are available from: <http://www.pgcon.org/2013/submissions.php> -- Dan Langille - http://langille.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.po

Re: [HACKERS] Extending range of to_tsvector et al

2012-09-30 Thread Dan Scott
Hi John: On Sun, Sep 30, 2012 at 11:45 PM, john knightley wrote: > Dear Dan, > > thank you for your reply. > > The OS I am using is Ubuntu 12.04, with PostgreSQL 9.1.5 installed on > a utf8 local > > A short 5 line dictionary file is sufficient to test:- >

Re: [HACKERS] Doc patch, normalize search_path in index

2012-09-30 Thread Dan Scott
at indexing "search path"-the-concept is useful for translations, and the Japanese translation includes an index (I couldn't find the index for the French translation). -- Dan Scott Laurentian University -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Extending range of to_tsvector et al

2012-09-30 Thread Dan Scott
think they should behave - and we could start building some test cases as a first step? -- Dan Scott Laurentian University -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] plpgsql gram.y make rule

2012-09-24 Thread Dan Scott
a specific file or directory beyond a renaming event. git blame will show you the commit that renamed the file, by default, but then you can request the revision prior to that using the commit hash || '^', for example. "git blame 2fb6cc90^ -- src/backend/parser/gram.y" to work

Re: [HACKERS] Question about SSI, subxacts, and aborted read-only xacts

2012-09-11 Thread Dan Ports
transactions to execute concurrently!) What I was getting at in my previous mail was that there aren't any situations where COMMIT will return a serialization failure for a read-only transaction. Dan -- Dan R. K. PortsUW CSEhttp://drkp.net/ -- Sent via pg

[HACKERS] Doc typo: lexems -> lexemes

2012-09-11 Thread Dan Scott
I ran across a minor typo while reviewing the full-text search documentation. Attached is a patch to address the one usage of "lexems" in a sea of "lexemes". diff --git a/doc/src/sgml/textsearch.sgml b/doc/src/sgml/textsearch.sgml new file mode 100644 index 978aa54..5305198 *** a/doc/src/sgml/text

Re: [HACKERS] Question about SSI, subxacts, and aborted read-only xacts

2012-09-10 Thread Dan Ports
instead of COMMIT, T2 would be allowed to proceed. Dan -- Dan R. K. PortsUW CSEhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] [PATCH] Never convert n_distinct < 2 values to a ratio when computing stats

2012-03-25 Thread Dan McGee
This is a bit of a corner case in all honesty, but if you have a short table (under 20 rows), the 10% heuristic used that decides whether distinct values scale with the row count will result in rather odd values for stadistinct in pg_statistic, such as '-0.2' or '-0.67', rather than the expecte

Re: [HACKERS] a slightly stale comment

2012-03-07 Thread Dan Ports
;t right either -- they may not be serializable, but that isn't the reason why. I don't particularly object to the warning that "the tests in this routine are correct" (although indeed the fact that they've changed over the years does seem to belie it). So I

[HACKERS] a slightly stale comment

2012-03-06 Thread Dan Ports
turb a comment just before its 19th birthday, the bit about two-phase locking and serializability hasn't been correct since around 1999 (when MVCC was added). :-) Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hack

Re: [HACKERS] possible new option for wal_sync_method

2012-03-02 Thread Dan Scales
block device would do the trick of flushing the disk cache. Dan - Original Message - From: "Andres Freund" To: pgsql-hackers@postgresql.org Cc: "Dan Scales" Sent: Monday, February 27, 2012 12:43:49 PM Subject: Re: [HACKERS] possible new option for wal_sync_method Hi,

Re: [HACKERS] possible new option for wal_sync_method

2012-02-16 Thread Dan Scales
options for ext3. I don't think that I have seen a significant different when the DBT2 workload for ext3 option data=ordered. I will measure all these numbers again tonight, but with barrier=0, so as to try to confirm that the write flush itself isn't costing a lot for this configuratio

[HACKERS] possible new option for wal_sync_method

2012-02-16 Thread Dan Scales
nterest in this change, or comments on its usefulness/correctness? It would be just an extra option for wal_sync_method that users can try out and has benefits for certain configurations. Dan diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 266c0de..a830a01 1

Re: [HACKERS] SSI rw-conflicts and 2PC

2012-02-14 Thread Dan Ports
On Tue, Feb 14, 2012 at 09:27:58AM -0600, Kevin Grittner wrote: > Heikki Linnakangas wrote: > > On 14.02.2012 04:57, Dan Ports wrote: > >> The easiest answer would be to just treat every prepared > >> transaction found during recovery as though it had a conflict in >

Re: [HACKERS] SSI rw-conflicts and 2PC

2012-02-14 Thread Dan Ports
gy if we wanted to go that route. I hadn't really considered it because I'm not that familiar with the xlog code (plus, the commit record already contains a variable length field, making it that much more difficult to add another). Dan -- Dan R. K. Ports MIT CSAIL

[HACKERS] SSI rw-conflicts and 2PC

2012-02-13 Thread Dan Ports
one we could plausibly backpatch to 9.1. But if the extra aborts after recovery seem too expensive, we may want to consider one of the other options for future releases. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] RFC: Making TRUNCATE more "MVCC-safe"

2012-02-11 Thread Dan Ports
hat the combination of that code and this patch would ensure full serializability for TRUNCATE operations. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] double writes using "double-write buffer" approach [WIP]

2012-02-08 Thread Dan Scales
gh. I did write the code so that any process can write a completed batch if the batch is not currently being flushed (so as to deal with crashes by backends). Having the backends flush the batches as they fill them up was just simpler for a first prototype. Dan - Original Message ----- Fro

Re: [HACKERS] double writes using "double-write buffer" approach [WIP]

2012-02-06 Thread Dan Scales
f double writes were in use, they might be automatically switched over to full page writes for the duration of the base backup. And the double write file should not be part of the base backup. Dan - Original Message - From: "Fujii Masao" To: "Dan Scales" Cc: &qu

Re: [HACKERS] double writes using "double-write buffer" approach [WIP]

2012-02-05 Thread Dan Scales
the double-write files can be stored on. Thanks, Dan - Original Message - From: "Robert Haas" To: "Dan Scales" Cc: "PG Hackers" Sent: Friday, February 3, 2012 1:48:54 PM Subject: Re: [HACKERS] double writes using "double-write buffer" app

Re: [HACKERS] double writes using "double-write buffer" approach [WIP]

2012-02-03 Thread Dan Scales
more efficient. Can you let me know what the shared_buffers and RAM sizes were for your pgbench run? I can try running the same workload. If the size of shared_buffers is especially small compared to RAM, then we should increase the size of shared_buffers when using double_writes. Thanks, D

[HACKERS] PGCon 2012 Call for Papers - extension

2012-01-29 Thread Dan Langille
<http://www.pgcon.org/2012/papers.php> Instructions for submitting a proposal to PGCon 2012 are available from: <http://www.pgcon.org/2012/submissions.php> -- Dan Langille - http://langille.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make cha

Re: [HACKERS] 16-bit page checksums for 9.2

2012-01-27 Thread Dan Scales
e checksum calculation (PageSetVerificationInfo) to mdextend() (or preferably smgrextend()) as well? Otherwise, you won't be checksumming a bunch of the new pages. Dan - Original Message - From: "Robert Haas" To: "Dan Scales" Cc: "Noah Misch" , "Heikki

[HACKERS] PGCon 2012 Call for Papers - reminder

2012-01-26 Thread Dan Langille
n 2012 are available from: <http://www.pgcon.org/2012/submissions.php> -- Dan Langille - http://langille.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] 16-bit page checksums for 9.2

2012-01-26 Thread Dan Scales
rue, right? bufmgr.c, line 1914 - bufToWrite no longer exists. You could revert changes from 1912-1920 localbuf.c, line 203 - as mentioned below, this comment is no longer relevant, you are checksumming local buffers now Dan - Original Message - From: "Noah Misch" T

Re: [HACKERS] [WIP] Double-write with Fast Checksums

2012-01-17 Thread Dan Scales
py to hear all comments/suggestions. Thanks, Dan - Original Message ----- From: "Dan Scales" To: "Heikki Linnakangas" Cc: "PG Hackers" , jks...@gmail.com, "David Fetter" Sent: Wednesday, January 11, 2012 1:25:21 PM Subject: Re: [HACKERS] [WIP] Do

[HACKERS] PGCon 2012 Call for Papers

2012-01-11 Thread Dan Langille
sions.php> -- Dan Langille - http://langille.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [WIP] Double-write with Fast Checksums

2012-01-11 Thread Dan Scales
point on time, even with the double writes. And just wanted to reiterate one other benefit of double writes -- it greatly reduces the size of the WAL logs. Thanks, Dan - Original Message - From: "Heikki Linnakangas" To: "David Fetter" Cc: "PG Hackers" , jks

[HACKERS] patch: fix SSI finished list corruption

2012-01-06 Thread Dan Ports
t I also reworked some of the surrounding code to make it obvious that r/o and r/w transactions are handled differently -- the existing code felt a bit too clever. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ >From 39f8462332f998d7363058adabac412c7654befe Mon Sep

Re: [HACKERS] autovacuum and default_transaction_isolation

2011-11-29 Thread Dan Ports
_database). But it wouldn't hurt to keep it from pointlessly registering a serializable transaction. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: ht

[HACKERS] autovacuum and default_transaction_isolation

2011-11-29 Thread Dan Ports
UUM on a large table can take a long time, this could affect many concurrent transactions. My one-liner fix for this was to set DefaultXactIsoLevel = XACT_READ_COMMITTED; in AutoVacWorkerMain. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-

Re: [HACKERS] FlexLocks

2011-11-15 Thread Dan Ports
give it a try and see what it looks like, but if anyone has any thoughts, let me know. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SSI implementation question

2011-10-20 Thread Dan Ports
On Thu, Oct 20, 2011 at 07:33:59AM -0500, Kevin Grittner wrote: > Dan Ports wrote: > > The part that's harder is building the list of potential conflicts > > that's used to identify safe snapshots for r/o transactions. That > > (currently) has to happen

Re: [HACKERS] Update on documentation builds on OSX w/ macports

2011-10-19 Thread Dan Ports
at them in the next couple days (with my MacPorts hat on), unless someone beats me to it. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] SSI implementation question

2011-10-19 Thread Dan Ports
e one of them -- but I really want starting a serializable xact to not take any exclusive locks.) Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SSI implementation question

2011-10-19 Thread Dan Ports
I'm also travelling for most of the next two weeks and probably won't be able to do any serious hacking on it until I'm back to the office. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hacker

Re: [HACKERS] SSI implementation question

2011-10-19 Thread Dan Ports
the synchronized snapshots patch yet, so I can't (yet) offer any suggestions about how to implement it. > Which might > be another good reason for changing predicate.c so that we don't hold > the latter while taking a snapshot ... It'd be great if we could do that, but

Re: [HACKERS] SSI implementation question

2011-10-19 Thread Dan Ports
nk the best we can do here is to acquire a lock in shared mode when registering a serializable transaction and in exclusive mode when committing. (Which is what you'd expect, I guess; it's the same story as ProcArrayLock, and for most of the same reasons.) Obviously, we'll also wa

Re: [HACKERS] Overhead cost of Serializable Snapshot Isolation

2011-10-10 Thread Dan Ports
is with the > latter, which seems like a harder problem. No, not that I recall -- if SerializablePredicateLockListLock was on the list of contended locks, it was pretty far down. SerializableXactHashLock was the main bottleneck, and SerializableXactFinishedListLock was a lesser but still signif

Re: [HACKERS] Overhead cost of Serializable Snapshot Isolation

2011-10-10 Thread Dan Ports
lure checks need to examine a node's neighbors in the dependency graph. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Overhead cost of Serializable Snapshot Isolation

2011-10-10 Thread Dan Ports
ck might become a scalability bottleneck. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Use new oom_score_adj without a new compile-time constant

2011-09-26 Thread Dan McGee
On Fri, Sep 23, 2011 at 2:49 PM, Robert Haas wrote: > On Mon, Sep 19, 2011 at 4:36 PM, Dan McGee wrote: >> [ patch ] > > I suppose it's Tom who really needs to comment on this, but I'm not > too enthusiastic about this approach.  Duplicating the Linux kernel >

[HACKERS] [PATCH] POC: inline int4 comparison in tuplesort

2011-09-21 Thread Dan McGee
This attempts to be as simple as it gets while reducing function call depth, and should be viewed as a proof of concept. It is also untested as of now, but will try to do that and report back. I'm hoping I followed the rabbit hole correctly and are correctly comparing the right pointers to each ot

Re: [HACKERS] [PATCH] Use new oom_score_adj without a new compile-time constant

2011-09-19 Thread Dan McGee
On Mon, Sep 19, 2011 at 3:11 PM, Dan McGee wrote: > This is one way to prevent the kernel warning message without having to > introduce a new constant. Scale the old oom_adj-style value the same way > the kernel internally does it and use that instead if oom_score_adj is > available

[HACKERS] [PATCH] Use new oom_score_adj without a new compile-time constant

2011-09-19 Thread Dan McGee
This is one way to prevent the kernel warning message without having to introduce a new constant. Scale the old oom_adj-style value the same way the kernel internally does it and use that instead if oom_score_adj is available for writing. Signed-off-by: Dan McGee --- This addresses some of the

Re: [HACKERS] sinval synchronization considered harmful

2011-07-21 Thread Dan Ports
;t want to emit barriers in between on architectures where it's not actually necessary. That argues for another operation that's defined to be a barrier (mb) on the Alpha but a no-op elsewhere. Certainly the Linux kernel found it useful to do so (read_barrier_depends) Alternatively, one might q

Re: [HACKERS] SSI atomic commit

2011-07-07 Thread Dan Ports
potential conflict if so. We can also skip adding a doomed transaction to the list of possible conflicts because we know it won't commit. This is not really a related issue, but Kevin and I found it while looking into this issue, and it was included in the patch we sent out. Dan --

Re: [HACKERS] SSI atomic commit

2011-07-07 Thread Dan Ports
a new victim if we think we want to abort a transaction with that flag set). prepareSeqNo is being used as a lower bound on the transaction's commit sequence number. It's currently set at the same time as the PREPARED flag, but it doesn't have to be. Dan -- Dan R. K. Ports MIT

Re: [HACKERS] SSI 2PC coverage

2011-07-05 Thread Dan Ports
by a flag. That only happens if "writer" has previously called ReleasePredicateLocks. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SSI atomic commit

2011-07-05 Thread Dan Ports
e that doesn't. If the two steps are separated, that isn't true: two transactions might get their commitSeqNos in one order and make them visible in the other. We should be able to deal with that, but it will make some of the commit ordering checks more complicated. Dan -- Dan R. K. Ports

Re: [HACKERS] pg_upgrade version check improvements and small fixes

2011-06-24 Thread Dan McGee
ckly! To partially toot my own horn but also show where a user like me encountered this, after some packaging hacking, anyone running Arch Linux should be able to do a pg_upgrade from here on out by installing the postgresql-old-upgrade package (http://www.archlinux.org/packages/extra/x86_64

Re: [HACKERS] Repeated PredicateLockRelation calls during seqscan

2011-06-22 Thread Dan Ports
nt to lock. I am rather uneasy about making changes here unless we can be absolutely certain they're right... Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subsc

[HACKERS] pg_upgrade version check improvements and small fixes

2011-06-21 Thread Dan McGee
version, just as the -B datadir has to be the correct version. I'm not on the mailing list nor do I have a lot of free time to keep up with normal development, but if there are quick things I can do to get these patches in let me know. -Dan From 840bdd22b62c8d45796abf7eb9e7b3da0329dce8 Mon Sep

Re: [HACKERS] pika buildfarm member failure on isolationCheck tests

2011-06-21 Thread Dan Ports
On Wed, Jun 22, 2011 at 01:31:11AM -0400, Dan Ports wrote: > Yes, I suspect it can be done better. The reason it's tricky is a lock > ordering issue; part of releasing a SerializableXact has to be done > while holding SerializableXactHashLock and part has to be done without &g

Re: [HACKERS] pika buildfarm member failure on isolationCheck tests

2011-06-21 Thread Dan Ports
it was intended to fail anyway, just with a different error. I didn't think too hard about which error would take precedence. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Repeated PredicateLockRelation calls during seqscan

2011-06-21 Thread Dan Ports
e checking that flag is cheaper than doing a hash lookup in the local predicate lock table before bailing out. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ diff --git a/src/backend/executor/nodeSeqscan.c b/src/backend/executor/nodeSeqscan.c index f356874..32a8

Re: [HACKERS] Coding style point: "const" in function parameter declarations

2011-06-21 Thread Dan Ports
On Tue, Jun 21, 2011 at 06:51:20PM -0400, Tom Lane wrote: > I find this to be poor style, and would like to see if there's any > support for getting rid of the "const" keywords. I'm in favor of removing them too. Dan -- Dan R. K. Ports MIT CSAIL

Re: [HACKERS] pika buildfarm member failure on isolationCheck tests

2011-06-20 Thread Dan Ports
tests actually hits this bug. I removed the anomaly from the duplicate-gids test so that it fails in the intended way, and added a new test to check serialization failures with a prepared transaction. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ diff --git a/src/bac

Re: [HACKERS] pika buildfarm member failure on isolationCheck tests

2011-06-20 Thread Dan Ports
tation. It seems like we do need that SXACT_FLAG_ROLLED_BACK after all, even though it's only set for this brief interval. We need to be able to distinguish a transaction that's just been marked for death (doomed) from one that's already called ReleasePredicateLocks. Dan -- Dan R. K. Ports

Re: [HACKERS] SSI work for 9.1

2011-06-16 Thread Dan Ports
On Fri, Jun 17, 2011 at 12:32:46AM -0400, Robert Haas wrote: > Perhaps it would be best to remove the general item and replace it > with a list of more specific things that need doing - which might just > mean #5. Done. -- Dan R. K. Ports MIT CSAILhttp:/

Re: [HACKERS] SSI work for 9.1

2011-06-16 Thread Dan Ports
) isn't an issue -- maybe we want to add a comment, someplace but I'm not convinced even that is necessary - (3) is a regression test, and is already on the list separately - (5) is a doc issue only There are no open issues with the code that I'm aware of. Dan -- Dan R.

Re: [HACKERS] patch: update README-SSI

2011-06-16 Thread Dan Ports
. > I don't see how there can be a ww-dependency between T0 and Tin. There > can't be a rw-conflict because Tin is read-only, so surely there can't > be a ww-conflict either? Yes, it can only be a wr-conflict. Good catch. Dan -- Dan R. K. Ports MIT CSAIL

[HACKERS] patch: update README-SSI

2011-06-15 Thread Dan Ports
future tense, probably because they were written long ago), and remove a couple items from the "R&D Issues" list that have since been addressed. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ diff --git a/src/backend/storage/lmgr/README-SSI

Re: [HACKERS] SSI patch renumbered existing 2PC resource managers??

2011-06-13 Thread Dan Ports
On Mon, Jun 13, 2011 at 03:33:24PM -0400, Tom Lane wrote: > We can either change that now, or undo the > unnecessary change in existing RM IDs. I vote for the latter. Sounds good to me. I'd offer a patch, but it'd probably take you longer to apply than to make the change yoursel

Re: [HACKERS] SSI patch renumbered existing 2PC resource managers??

2011-06-13 Thread Dan Ports
On Mon, Jun 13, 2011 at 10:22:19PM +0300, Heikki Linnakangas wrote: > As far as I can tell it was for purely cosmetic reasons, to have lock > and predicate lock lines together. Yes, that is the only reason. Dan -- Dan R. K. Ports MIT CSAILhttp://dr

Re: [HACKERS] Small SSI issues

2011-06-11 Thread Dan Ports
pointing to) is in backend-local memory, so it won't change under us. The volatile qualifier (as written) doesn't help with that anyway, it attaches to the data being pointed to, not the pointer itself. Dan -- Dan R. K. Ports MIT CSAILhttp://drkp.net/ --

  1   2   3   4   >