Re: [HACKERS] missing rename support

2013-02-04 Thread Ali Dar
The tweaks made by you seems fine. I'm good with it. Regards, Ali Dar On Sun, Feb 3, 2013 at 8:04 PM, Dean Rasheed wrote: > On 29 January 2013 15:34, Ali Dar wrote: > > Please find attached the complete patch for alter rename rule. I have > > followed all the suggestions.

Re: [HACKERS] information schema parameter_default implementation

2013-01-31 Thread Ali Dar
Another thing I forget: The patch does not apply because of the changes in "catversion.h" Regards, Ali Dar On Thu, Jan 31, 2013 at 6:59 PM, Ali Dar wrote: > On Wed, Jan 9, 2013 at 4:28 PM, Peter Eisentraut wrote: > >> Here is an

Re: [HACKERS] information schema parameter_default implementation

2013-01-31 Thread Ali Dar
fault expression of the parameter, or null if none was specified. It will also be null if the function is not owned by a currently enabled role." I don't know what do you exactly mean by: "function is not owned by a currently enabled role"? Regards, Ali Dar

Re: [HACKERS] missing rename support

2013-01-29 Thread Ali Dar
. 5) Throw appropriate error if user tries to alter rename rule on irrelavent object(e.g index). 6) Psql tab support added 7) Regression test cases added. 8) Documentation added. Regards, Ali Dar On Mon, Jan 21, 2013 at 12:34 AM, Dean Rasheed wrote: > On 3 January 2013 13:49, Ali Dar wr

Re: [HACKERS] missing rename support

2013-01-03 Thread Ali Dar
On Sat, Dec 3, 2011 at 4:46 PM, Peter Eisentraut wrote: > I noticed the following object types don't have support for an ALTER ... > RENAME command: > > DOMAIN (but ALTER TYPE works) > FOREIGN DATA WRAPPER > OPERATOR > RULE > SERVER > > Are there any restrictions why these couldn't be added? > I

[HACKERS] Review: Dumping an Extension's Script

2012-12-05 Thread Ali Dar
for a huge database. And considering if many many extensions are dumped in a huge database, dump might become very slow. Can you think of any other scheme? Maybe you should follow PG's design, and fetch the extension objects in dumpExtension() and dump them. 10) pg_dumpall is not handled at all. User can't use -X switch if he wants to dump all the databases with extensions. Regards, Ali Dar