Hi all,
In the recent thread related to a bug in pg_stop_backup when waiting
for WAL segments to be archived, it has been mentioned that it would
be nice to get backup history files generated as well on standbys:
https://www.postgresql.org/message-id/CA+Tgmobh3=quCzugFP5yA3-z5uzz=YKZ7arnoApJoPN7=0
Tom Lane writes:
> I wonder if Andreas would be interested in trying the randomly-timed-
> SIGTERM thing with sqlsmith.
Will do. Won't miss this chance to try out discostu's extension
pg_rage_terminator[1] :-)
regards,
Andreas
Footnotes:
[1] https://github.com/disco-stu/pg_rage_terminator
On 9 August 2017 at 23:42, Robert Haas wrote:
> On Tue, Aug 8, 2017 at 4:00 AM, Craig Ringer
> wrote:
> >> - When a standby connects to a master, it can optionally supply a list
> >> of slot names that it cares about.
> >
> > Wouldn't that immediately exclude use for PITR and snapshot recovery?
On Thu, Aug 10, 2017 at 9:28 AM, Thomas Munro
wrote:
> On Thu, Aug 10, 2017 at 1:39 AM, Thomas Munro
> wrote:
>> On my computer it took ~1.5 seconds to plan a 1000 partition join,
>> ~7.1 seconds to plan a 2000 partition join, and ~50 seconds to plan a
>> 4000 partition join. I poked around in a
On Wed, Aug 9, 2017 at 3:39 PM, Tom Lane wrote:
> Michael Paquier writes:
>> On Tue, Aug 8, 2017 at 11:33 PM, Tom Lane wrote:
>>> Michael Paquier writes:
I got the same thought, wondering as well if get_slot_xmins should be
renamed check_slot_xmins with the is() tests moved inside it
On Fri, Aug 4, 2017 at 8:19 AM, Masahiko Sawada wrote:
> On Fri, Jul 28, 2017 at 2:24 PM, Noah Misch wrote:
>> This item appears under "decisions to recheck mid-beta". If anyone is going
>> to push for a change here, now is the time.
>
> It has been 1 week since the previous mail. I though that
On 9 August 2017 at 19:05, Robert Haas wrote:
> On Wed, Jul 5, 2017 at 7:53 AM, Amit Khandekar wrote:
>>> This is not applicable on the latest head i.e. commit --
>>> 08aed6604de2e6a9f4d499818d7c641cbf5eb9f7, looks like need a rebasing.
>>
>> Thanks for notifying. Attached is the rebased version
Andres Freund wrote :
> If you were to send a gigabyte of queries, it'd buffer them all up in
memory... So some
>more intelligence is going to be needed.
Firstly, sorry for the delayed response as I got busy with other
activities.
To buffer up the queries before flushing them to the socket, I thi
On 9 August 2017 at 21:23, Petr Jelinek
wrote:
> On 02/08/17 19:35, Yura Sokolov wrote:
> > The following review has been posted through the commitfest application:
> > make installcheck-world: tested, passed
> > Implements feature: not tested
> > Spec compliant: not tested
> > D
On Mon, Aug 07, 2017 at 06:23:56PM -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > On 8/6/17 20:07, Peter Geoghegan wrote:
> >> I've looked into this. I'll give an example of what keyword variants
> >> there are for Greek, and then discuss what I think each is.
>
> > I'm not sure why we wan
On Tue, Aug 08, 2017 at 02:30:51PM +0530, Amit Kapila wrote:
> On Mon, Aug 7, 2017 at 9:38 PM, Ashutosh Sharma wrote:
> > On Mon, Aug 7, 2017 at 7:19 PM, Amit Kapila wrote:
> >> On Mon, Aug 7, 2017 at 6:07 PM, Ashutosh Sharma
> >> wrote:
> >>> Hi,
> >>>
> >> ..
> ..
> >> Why an extra parenthesi
On Wed, Aug 9, 2017 at 6:38 PM, Robert Haas wrote:
> The patch doesn't really conform to our coding standards, though, so
> you need to clean it up (or, if you're not sure what you need to do,
> you need to have someone who knows how PostgreSQL code needs to look
> review it for you).
The documen
Hi all,
In snapbuild.c file, there is a comment as follows.
* NB: Because of that xmax can be lower than xmin, because we only
* increase xmax when a catalog modifying transaction commits. While odd
* looking, it's correct and actually more efficient this way since we hit
* fast paths
On Thu, Aug 10, 2017 at 1:39 AM, Thomas Munro
wrote:
> On my computer it took ~1.5 seconds to plan a 1000 partition join,
> ~7.1 seconds to plan a 2000 partition join, and ~50 seconds to plan a
> 4000 partition join. I poked around in a profiler a bit and saw that
> for the 2000 partition case I
On Wed, Aug 9, 2017 at 11:23 AM, Masahiko Sawada wrote:
> On Mon, Aug 7, 2017 at 1:44 PM, Masahiko Sawada wrote:
>> On Sat, Aug 5, 2017 at 3:29 AM, Peter Geoghegan wrote:
>>> On Fri, Aug 4, 2017 at 11:12 AM, Alvaro Herrera
>>> wrote:
Interesting. We learned elsewhere that it's better to i
On 2017/08/10 5:59, Tom Lane wrote:
> Alvaro Herrera writes:
>> Dean Rasheed wrote:
>>> There was an earlier suggestion to use "greater than or equal to". I
>>> think that would work quite well:
>
>> Is it possible to detect the equality case specifically and use a
>> different errdetail? Someth
On 2017/08/05 2:25, Robert Haas wrote:
> Concretely, my proposal is:
>
> 1. Before calling RelationGetPartitionDispatchInfo, the calling code
> should use find_all_inheritors to lock all the relevant relations (or
> the planner could use find_all_inheritors to get a list of relation
> OIDs, store
On Mon, Jul 31, 2017 at 5:49 PM, Thomas Munro
wrote:
> Here is a version to put it back.
Rebased after conflicting commit 030273b7. Now using format-patch
with a commit message to keep track of review/discussion history.
--
Thomas Munro
http://www.enterprisedb.com
synchronous-replay-v3.patc
Peter Geoghegan writes:
> On Wed, Aug 9, 2017 at 6:19 PM, Tsunakawa, Takayuki
> wrote:
>> That's sad news, as I expected ICU to bring its various collation features
>> to PostgreSQL. I hope it will be easy to add them.
> The reason it is not easy is that text equality is based on strict
> bina
On Wed, Aug 9, 2017 at 6:19 PM, Tsunakawa, Takayuki
wrote:
> From: pgsql-hackers-ow...@postgresql.org
>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Peter Eisentraut
>> There are no case-insensitive collations in PostgreSQL (yet).
>
> That's sad news, as I expected ICU to bring its va
On Thu, Aug 10, 2017 at 1:16 PM, Ashutosh Bapat
wrote:
> Please add this to the next commitfest.
Done: https://commitfest.postgresql.org/14/1229/
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscri
From: pgsql-hackers-ow...@postgresql.org
> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Peter Eisentraut
> There are no case-insensitive collations in PostgreSQL (yet).
That's sad news, as I expected ICU to bring its various collation features to
PostgreSQL. I hope it will be easy to
On Thu, Aug 10, 2017 at 5:09 AM, Thomas Munro
wrote:
> On Thu, Jul 27, 2017 at 5:20 PM, Thomas Munro
> wrote:
>> Agreed. Here's a version that skips those useless detail messages
>> using a coding pattern I found elsewhere.
>
> Rebased after bf6b9e94.
>
Please add this to the next commitfest.
On Wed, Aug 9, 2017 at 9:25 PM, Alvaro Herrera wrote:
> Tom Lane wrote:
>> I think generating whatever we can from a single authoritative file
>> is indeed a good idea.
>
> Yay.
Indeed.
>> But I had the impression that people also wanted to enforce a rule
>> about "only one use of each wait even
On Wed, Aug 9, 2017 at 2:47 PM, Aleksander Alekseev
wrote:
> I believe this patch is "Ready for Committer".
>
> The new status of this patch is: Ready for Committer
Thanks for the lookup, but I think that this is still hasty as no
discussion has happened about a couple of APIs to get object names
Hi,
There is a type of logical replication message 'Y' for data types, but
it's not documented in section 52.9. Logical Replication Message
Formats. Attached patch fixes this. I think it can be PG10 item.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Soft
On 2017-08-08 19:25:37 -0400, Peter Eisentraut wrote:
> On 8/7/17 21:06, Noah Misch wrote:
> >> That would fit. Until v10 (commit 1e8a850), PQconnectStart() had no
> >> in-tree
> >> callers outside of libpq itself.
> > [Action required within three days. This is a generic notification.]
> >
> >
On Thu, Jul 27, 2017 at 5:20 PM, Thomas Munro
wrote:
> Agreed. Here's a version that skips those useless detail messages
> using a coding pattern I found elsewhere.
Rebased after bf6b9e94.
--
Thomas Munro
http://www.enterprisedb.com
ldap-diagnostic-message-v3.patch
Description: Binary data
There are actually very many customizations to collations that are
possible beyond what the "stock" ICU collations provide (whatever
"stock" means). Some of these are really cool, and I can imagine use
cases where they are very compelling that have nothing to do with
internationalization (such cust
2017-08-01 19:57 GMT+02:00 Robert Haas :
> On Tue, Aug 1, 2017 at 12:35 PM, Remi Colinet
> wrote:
> > I did it in version 2 of the patch.
> > I'am skeptical about the use of JSON, XML, and others in such output.
> >
> > Does anyone use these formats (XML, JSON, YAML) for EXPLAIN output?
> > I sus
Alvaro Herrera writes:
> Dean Rasheed wrote:
>> There was an earlier suggestion to use "greater than or equal to". I
>> think that would work quite well:
> Is it possible to detect the equality case specifically and use a
> different errdetail? Something like "the lower bound %s is equal to the
Dean Rasheed wrote:
> On 9 August 2017 at 13:03, Robert Haas wrote:
> > On Tue, Aug 8, 2017 at 11:34 PM, Tom Lane wrote:
> >> A small suggestion is that it'd be better to write it like "Specified
> >> upper bound \"%s\" precedes lower bound \"%s\"." I think "succeeds" has
> >> more alternate mea
On Tue, Aug 8, 2017 at 12:15 PM, Sandeep Thakkar
wrote:
> I copied and pasted that portion of the build log into file build.log
> (attached) for Windows 32bit and Windows 64bit.
Can you also share the output of 'perl -V' on each system?
Comparing the 32-bit log and the 64-bit log, I see the foll
While poking at the arrays-of-domains TODO item, I found yet another area
in which the existing code fails to handle existing supported cases.
Specifically, although DefineRange will happily take domains or composites
as a range subtype, and we already noticed that domains-over-array-of-
composite
On Mon, Aug 7, 2017 at 1:51 PM, Alvaro Herrera wrote:
> * the whole predicate.c stuff is written using SHM_QUEUE. I suppose
> SHM_QUEUE works just fine, but predicate.c was being written at about
> the same time (or a bit earlier) than the newer ilist.c interface was
> being created, which
On Tue, Aug 8, 2017 at 3:50 AM, Amit Kapila wrote:
> Right.
>
> I see two ways to include the cost of the target list for parallel
> paths before rejecting them (a) Don't reject parallel paths
> (Gather/GatherMerge) during add_path. This has the danger of path
> explosion. (b) In the case of par
Tom Lane wrote:
> I think generating whatever we can from a single authoritative file
> is indeed a good idea.
Yay.
> But I had the impression that people also wanted to enforce a rule
> about "only one use of each wait event name", which'd require a
> checker script, no? (I'm not really convin
On 9 August 2017 at 13:03, Robert Haas wrote:
> On Tue, Aug 8, 2017 at 11:34 PM, Tom Lane wrote:
>> A small suggestion is that it'd be better to write it like "Specified
>> upper bound \"%s\" precedes lower bound \"%s\"." I think "succeeds" has
>> more alternate meanings than "precedes", so the
Alvaro Herrera writes:
> This thread is surprising. If we generate the few lines of code being
> in trouble, we don't need any checker script, so I don't see why we'd go
> the route of the checker script instead.
I think generating whatever we can from a single authoritative file
is indeed a goo
This thread is surprising. If we generate the few lines of code being
in trouble, we don't need any checker script, so I don't see why we'd go
the route of the checker script instead.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA,
On Wed, Aug 9, 2017 at 5:38 AM, MauMau wrote:
> I tried to find a particular collation name in pg_collation, but I
> cannot understand the naming convention after reading the following
> article. Specifically, I want to find out whether there is some
> collation equivalent to Japanese_CI_AS in SQ
Project: Explicitly support predicate locks in index AMs besides b-tree
Hi,
In the last two weeks, I mostly worked on predicate locking in rum index.
Rum is based on gin access method. The main difference between rum and
gin is that rum stores additional information in posting tree to perform
a f
On 8/9/17 08:38, MauMau wrote:
> I tried to find a particular collation name in pg_collation, but I
> cannot understand the naming convention after reading the following
> article. Specifically, I want to find out whether there is some
> collation equivalent to Japanese_CI_AS in SQL Server, which
On Tue, Aug 1, 2017 at 4:00 PM, Ildus K wrote:
> It's a workaround. DatumGetTSVector and
> DatumGetTSVectorCopy will upgrade tsvector on the fly if it
> has old format.
Hmm, that seems like a real fix, not just a workaround. If you can
transparently read the old format, there's no problem. Not
On Tue, Aug 8, 2017 at 4:00 AM, Craig Ringer wrote:
>> - When a standby connects to a master, it can optionally supply a list
>> of slot names that it cares about.
>
> Wouldn't that immediately exclude use for PITR and snapshot recovery? I have
> people right now who want the ability to promote a
Hi,
Please find the updated patch for predicate locking in gin index here.
There was a small issue in the previous patch. I didn't consider the case
where only root page exists in the tree, and there is a predicate lock on
it,
and it gets split.
If we treat the original page as a left page and c
On Wed, 9 Aug 2017 09:01:44 +0200
Torsten Zuehlsdorff wrote:
> On 01.08.2017 22:00, Ildus K wrote:
> > On Tue, 1 Aug 2017 15:33:08 -0400
> > Robert Haas wrote:
> >
> >> On Tue, Aug 1, 2017 at 3:10 PM, Ildus K
> >> wrote:
> So this would break pg_upgrade for tsvector columns?
> >>>
>
Thomas Munro writes:
> On Wed, Aug 9, 2017 at 3:44 PM, Tom Lane wrote:
>> Hmm, looking into Makefile.global.in, that step seems to be conditional on
>> MAKELEVEL:
> Ah, right. That coding is recommended in the GNU make manual to
> distinguish from explicit invocation and recursive invocation.
>
On Wed, Aug 09, 2017 at 10:56:50AM -0400, Tom Lane wrote:
> Robert Haas writes:
> > On Wed, Aug 9, 2017 at 10:14 AM, Tom Lane wrote:
> >> Thomas Munro writes:
> >>> As for whether hypothetical check scripts would ever be run, I
> >>> was thinking we should stick them under some make target that
Robert Haas writes:
> On Wed, Aug 9, 2017 at 10:14 AM, Tom Lane wrote:
>> Thomas Munro writes:
>>> As for whether hypothetical check scripts would ever be run, I was
>>> thinking we should stick them under some make target that developers
>>> run all the time anyway -- perhaps "check". Shouldn'
On Wed, Aug 9, 2017 at 10:14 AM, Tom Lane wrote:
> Thomas Munro writes:
>> As for whether hypothetical check scripts would ever be run, I was
>> thinking we should stick them under some make target that developers
>> run all the time anyway -- perhaps "check". Shouldn't we catch simple
>> mechan
Thomas Munro writes:
> As for whether hypothetical check scripts would ever be run, I was
> thinking we should stick them under some make target that developers
> run all the time anyway -- perhaps "check". Shouldn't we catch simple
> mechanically detectable problems as early in the pipeline as p
On 01.08.2017 22:00, Ildus K wrote:
On Tue, 1 Aug 2017 15:33:08 -0400
Robert Haas wrote:
On Tue, Aug 1, 2017 at 3:10 PM, Ildus K
wrote:
So this would break pg_upgrade for tsvector columns?
I added a function that will convert old tsvectors on the fly. It's
the approach used in hstore bef
On Tue, Aug 8, 2017 at 8:51 PM, Ashutosh Bapat
wrote:
> Updated patches attached.
Hi,
I started reviewing this. It's nicely commented, but it's also very
complicated, and it's going to take me several rounds to understand
what all the parts do, but here's some assorted feedback after reading
so
Michael Paquier writes:
> On Tue, Aug 8, 2017 at 11:33 PM, Tom Lane wrote:
>> Michael Paquier writes:
>>> I got the same thought, wondering as well if get_slot_xmins should be
>>> renamed check_slot_xmins with the is() tests moved inside it as well.
>>> Not sure if that's worth the API ugliness
On Wed, Jul 5, 2017 at 7:53 AM, Amit Khandekar wrote:
>> This is not applicable on the latest head i.e. commit --
>> 08aed6604de2e6a9f4d499818d7c641cbf5eb9f7, looks like need a rebasing.
>
> Thanks for notifying. Attached is the rebased version of the patch.
This again needs a rebase.
(And, hey
On 02/08/17 19:35, Yura Sokolov wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: not tested
> Spec compliant: not tested
> Documentation:not tested
>
> There is no check fo
On Wed, Aug 9, 2017 at 9:26 PM, Amit Kapila wrote:
> On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi
> wrote:
> >
> >
> > For the following query the parallel plan is not chosen. The query
> contains
> > an init plan that refer the outer node.
> >
>
> We don't want to generate the parallel plan
Hello!
I am new to Postgres backend development, and have created a recent project
that has minimal C code. It is a transparent DDL replication solution
built on top of pglogical, but with a concept that could be used also with
other logical replication solutions if they support some mechanism to
On Wed, Aug 9, 2017 at 8:54 PM, Kuntal Ghosh
wrote:
> On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi
> wrote:
> >
> > I tested the latest patch and the parallel plan is getting choose for
> most
> > of
> > the init plans.
> >
> Thanks for testing.
>
> > For the following query the parallel plan
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I believe this patch is "Ready for Committer".
The new statu
On Tue, Aug 8, 2017 at 8:17 PM, Tom Lane wrote:
> Peter Geoghegan writes:
> > On Thu, Jan 19, 2017 at 5:45 PM, Peter Geoghegan wrote:
> >> A customer is on 9.6.1, and complains of a segfault observed at least
> >> 3 times.
> > ...
> > For the sake of the archives: this now looks very much like
Hello,
I tried to find a particular collation name in pg_collation, but I
cannot understand the naming convention after reading the following
article. Specifically, I want to find out whether there is some
collation equivalent to Japanese_CI_AS in SQL Server, which means
Japanese, case-insensitiv
On Wed, Aug 9, 2017 at 8:18 AM, Rajkumar Raghuwanshi
wrote:
> --difference in the description of default partition in case of list vs
> range
>
> create table lp (a int) partition by list(a);
> create table lp_d partition of lp DEFAULT;
> postgres=# \d+ lp_d
>Ta
On Wed, Aug 9, 2017 at 1:54 PM, Beena Emerson
wrote:
> Hello Rajkumar,
>
> On Wed, Aug 9, 2017 at 12:37 PM, Rajkumar Raghuwanshi
> wrote:
> >
> > Hi Beena,
> >
> > I have applied Jeevan's v24 patches and then your v9 patch over commit
> > 5ff3d73813ebcc3ff80be77c30b458d728951036.
> > and while t
On Tue, Aug 8, 2017 at 7:33 PM, Dean Rasheed wrote:
> Well perhaps verbosity-reduction isn't sufficient justification but I
> still think this is correct because logically any values in the bound
> after MINVALUE/MAXVALUE are irrelevant, so it seems overly restrictive
> to force all later values t
On Tue, Aug 8, 2017 at 11:34 PM, Tom Lane wrote:
> A small suggestion is that it'd be better to write it like "Specified
> upper bound \"%s\" precedes lower bound \"%s\"." I think "succeeds" has
> more alternate meanings than "precedes", so the wording you have seems
> more confusing than it need
On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi
wrote:
>
>
> On Mon, Jul 17, 2017 at 10:53 PM, Amit Kapila
> wrote:
>>
>> On Tue, Mar 28, 2017 at 7:25 AM, Amit Kapila
>> wrote:
>> > On Thu, Mar 16, 2017 at 2:34 AM, Kuntal Ghosh
>> > wrote:
>> >> On Tue, Mar 14, 2017 at 3:20 PM, Amit Kapila
>>
On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi
wrote:
>
> I tested the latest patch and the parallel plan is getting choose for most
> of
> the init plans.
>
Thanks for testing.
> For the following query the parallel plan is not chosen. The query contains
> an init plan that refer the outer node
On Wed, Aug 9, 2017 at 6:42 PM, Michael Paquier
wrote:
> On Tue, Aug 8, 2017 at 11:35 PM, Alvaro Herrera
> wrote:
>>> All of the above seem like good candidates for a checker script in
>>> src/tools/check_XXX.pl, a bit like the others I've talked about
>>> recently [1][2].
>>
>> Yeah, that's one
On Mon, Aug 7, 2017 at 5:50 PM, Ashutosh Sharma wrote:
> On Fri, Aug 4, 2017 at 7:14 PM, Amit Kapila wrote:
>> On Sun, Jul 30, 2017 at 2:07 PM, Ashutosh Sharma
>> wrote:
>>> Hi,
>>>
>>> On Wed, May 10, 2017 at 2:28 PM, Ashutosh Sharma
>>> wrote:
While doing the code coverage testing of v
Hello Rajkumar,
On Wed, Aug 9, 2017 at 12:37 PM, Rajkumar Raghuwanshi
wrote:
>
> Hi Beena,
>
> I have applied Jeevan's v24 patches and then your v9 patch over commit
> 5ff3d73813ebcc3ff80be77c30b458d728951036.
> and while testing I got a server crash. below is sql to reproduce it.
>
> postgres=#
On Wed, Aug 9, 2017 at 8:26 AM, Beena Emerson
wrote:
> I have updated the patch to make it similar to the way default/null is
> handled in list partition, removing the PARTITION_RANGE_DATUM_DEFAULT.
> This is to be applied over v24 patches shared by Jeevan [1] which
> applies on commit id 5ff3d73
73 matches
Mail list logo
