On 11 July 2016 at 12:04, Michael Paquier wrote:
> On Sat, Jul 9, 2016 at 2:58 AM, Shoaib Lari wrote:
> > Besides making the error message more informative, we had to modify
> > allocate_recordbuf() to return the actual number of bytes that were being
> > allocated.
>
> - report_invalid_re
Hello Michaël,
Minor pgbench documentation improvements so that the description is more
precise:
- a pgbench script may not contain SQL commands, it only needs not to be
empty.
Halfly true as far as I recall. This works and generates two queries:
SELECT 1; \set two 3
Maybe it used to w
On 10 July 2016 at 18:27, Netanel Katzburg wrote:
> BUT, both options are not good, as they are stopping me from even running i
> *nitdb.*
>
>
>
The easiest path for testing will be to use an unpatched PostgreSQL to
`initdb` and create a new database. Then start up a patched one that simply
skip
On 11 July 2016 at 01:56, Joshua D. Drake wrote:
> Hackers,
>
> This just came across my twitter feed:
>
> https://lists.freedesktop.org/archives/systemd-devel/2014-April/018373.html
>
> tl;dr; Systemd 212 defaults to remove all IPC (including SYSV memory) when
> a user "fully" logs out.
>
>
The
On Mon, Jul 11, 2016 at 2:03 PM, Craig Ringer wrote:
> On 9 July 2016 at 01:57, Joshua Bay wrote:
>> and where are this code is in the codebase?
>
> src/backend/replication/logical/*
> src/backend/replication/walsender.c
> src/backend/access/transam/xlogreader.c
> src/include/access/xlogreader.h
Hello Michaël,
You may want to name your patches with .patch or .diff. Using .sql is
disturbing style :)
Indeed! :-)
Indeed, not reporting the progress back to the client in the case of a
script with only meta commands is non-intuitive.
This looks good to me. I'd just rewrite the comment b
On 9 July 2016 at 01:57, Joshua Bay wrote:
> where are the entry points to logical decoding?
>
Well, it depends on what level you're looking at.
Data is read using the xlogreader and fed into the decoding system by the
walsender (when using a logical slot) and the SQL level
pg_logical_slot_[ge
On 11 July 2016 at 11:49, Michael Paquier wrote:
> On Mon, Jul 11, 2016 at 3:36 AM, Julien Rouhaud
> wrote:
> > I'm not opposed, but in this case we should also provide a proper
> > documentation of all the required actions to mimick normal backends.
>
> I'd rather just add a note like "Have a l
On Sat, Jul 9, 2016 at 4:48 PM, Fabien COELHO wrote:
>
> Minor pgbench documentation improvements so that the description is more
> precise:
>
> - a pgbench script may not contain SQL commands, it only needs not to be
>empty.
Halfly true as far as I recall. This works and generates two queri
On Sat, Jul 9, 2016 at 4:09 PM, Fabien COELHO wrote:
>
> While testing meta-command pgbench only scripts, I noticed that there is an
> infinite loop in threadRun, which means that other tasks such as reporting
> progress do not get a chance.
>
> The attached patch breaks this loop by always return
On Sat, Jul 9, 2016 at 2:58 AM, Shoaib Lari wrote:
> Besides making the error message more informative, we had to modify
> allocate_recordbuf() to return the actual number of bytes that were being
> allocated.
- report_invalid_record(state, "record length %u at %X/%X too long",
-
On Mon, Jul 11, 2016 at 3:36 AM, Julien Rouhaud
wrote:
> I'm not opposed, but in this case we should also provide a proper
> documentation of all the required actions to mimick normal backends.
I'd rather just add a note like "Have a look at PostgresMain if you
want to imitate a backend able to r
On Mon, Jul 11, 2016 at 12:42 AM, Tom Lane wrote:
> If we're keeping the "Source code" column, I'd be inclined to keep
> "Language" adjacent to that. When thinking of a function as a black
> box, both language and source code are implementation details; but
> all the other properties listed here
On Sun, Jul 10, 2016 at 11:52 PM, Tom Lane wrote:
> Michael Paquier writes:
>> Thanks! What you have pushed looks fine to me. Also, the portion for
>> src/tools/msvc needs to go further down, I should have precised that
>> earlier. Do you want a patch for that?
>
> Yes, please --- I thought it'd
On 2016/07/09 1:41, Tom Lane wrote:
Etsuro Fujita writes:
I noticed that the return type of IsForeignScanParallelSafe described in
fdwhandler.sgml isn't correct; that should be bool, not Size. Please
find attached a small patch for that.
Pushed, thanks!
Thank you.
Best regards,
Etsuro Fu
On Sat, Apr 9, 2016 at 6:36 AM, Tom Lane wrote:
>
> More generally, I'm not convinced about the use-case for this patch.
> What problem is it supposed to help in dealing with, exactly? Not syntax
> errors in the hba file, evidently, since it doesn't make any attempt to
> instrument the file parse
I wrote:
> So, agreed, let's commit some temporary debug code and see what the
> buildfarm can teach us. Will go work on that in a bit.
After reviewing the buildfarm results, I'm feeling nervous about this
whole idea again. For the most part, the unaccounted-for daylight between
the maximum stac
On 08/07/2016 01:53, Michael Paquier wrote:
> On Fri, Jul 8, 2016 at 3:06 AM, Andres Freund wrote:
>> On 2016-07-07 14:04:36 -0400, Robert Haas wrote:
>>> On Thu, Jul 7, 2016 at 1:52 PM, Julien Rouhaud
>>> wrote:
Should a bgworker modifing data have to call pgstat_report_stat() to
avoid
On 10/07/2016 19:56, Joshua D. Drake wrote:
> Hackers,
>
> This just came across my twitter feed:
>
> https://lists.freedesktop.org/archives/systemd-devel/2014-April/018373.html
>
> tl;dr; Systemd 212 defaults to remove all IPC (including SYSV memory)
> when a user "fully" logs out.
>
AFAIK it
Hackers,
This just came across my twitter feed:
https://lists.freedesktop.org/archives/systemd-devel/2014-April/018373.html
tl;dr; Systemd 212 defaults to remove all IPC (including SYSV memory)
when a user "fully" logs out.
JD
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq
Hi Michael,
Sorry for the delay,
The answer is yes,
I tried 2 things so far:
1. As I understand:
*XLogRecPtr*
*XLogInsert(RmgrId rmid, uint8 info)*
is the primary insert function in xloginsert.c.
I tried commenting the following line at this function, so I can return a
phony pointer every time
Michael Paquier writes:
>> - Reordering the columns, I'd suggest as follows):
>> -- Schema
>> -- Name
>> -- Result data type
>> -- Argument data types
>> -- Type
>> -- Language
>> -- Volatility
>> -- Parallel
>> -- Owner
>> -- Security
>> -- ACL
>> -- Source code
>> -- Description
If we're keepin
Michael Paquier writes:
> Thanks! What you have pushed looks fine to me. Also, the portion for
> src/tools/msvc needs to go further down, I should have precised that
> earlier. Do you want a patch for that?
Yes, please --- I thought it'd all gotten done.
regards, tom lane
On Sat, Jul 9, 2016 at 8:12 AM, Michael Paquier
wrote:
> So to sum up:
> - Add "Parallel" column
> - Add ACLs
> - Reordering the columns, I'd suggest as follows):
> -- Schema
> -- Name
> -- Result data type
> -- Argument data types
> -- Type
> -- Language
> -- Volatility
> -- Parallel
> -- Owner
>
On Sun, Jul 10, 2016 at 5:50 AM, Tom Lane wrote:
> This seemed like a bug fix to me ...
Yes, it is.
> ... so I went ahead and pushed it. I don't
> have any ability to test the Windows parts, so it's possible I missed
> something in the back-patching; please review.
Thanks! What you have pushed
25 matches
Mail list logo
