Re: [HACKERS] parallel.c is not marked as test covered

2016-06-18 Thread Amit Kapila
On Sun, Jun 19, 2016 at 10:10 AM, Tom Lane wrote: > > Peter Eisentraut writes: > > With that, I think it would be preferable to undo the context-hiding > > dance in the tests, as in the attached patch, no? > > Would this not result in unstable test output depending on whether the > code executes

Re: [HACKERS] parallel.c is not marked as test covered

2016-06-18 Thread Tom Lane
Peter Eisentraut writes: > With that, I think it would be preferable to undo the context-hiding > dance in the tests, as in the attached patch, no? Would this not result in unstable test output depending on whether the code executes in the leader or a worker? regards, to

Re: [HACKERS] parallel.c is not marked as test covered

2016-06-18 Thread Peter Eisentraut
On 6/17/16 9:26 AM, Robert Haas wrote: On Wed, Jun 15, 2016 at 5:10 PM, Robert Haas wrote: I'm comfortable with that. Feel free to make it so, unless you want me to do it for some reason. Time is short, so I did this. With that, I think it would be preferable to undo the context-hiding da

Re: [HACKERS] Whether to back-patch fix for aggregate transtype width estimates

2016-06-18 Thread Greg Stark
On Sat, Jun 18, 2016 at 5:14 PM, Tom Lane wrote: > . In 9.x, that's broken and it falls back to > get_typavgwidth's default guess of 32 bytes. If what you've actually > got is, say, varchar(255) and most of the entries actually approach > that length, this could result in a drastic underestimate

Re: [HACKERS] 10.0

2016-06-18 Thread David Fetter
On Sat, Jun 18, 2016 at 05:48:30PM -0700, Josh Berkus wrote: > On 06/16/2016 11:01 PM, Craig Ringer wrote: > > > > I thought about raising this, but I think in the end it's replacing one > > confusing and weird versioning scheme for another confusing and weird > > versioning scheme. > > > > It do

Re: [HACKERS] 10.0

2016-06-18 Thread Josh Berkus
On 06/16/2016 11:01 PM, Craig Ringer wrote: > > I thought about raising this, but I think in the end it's replacing one > confusing and weird versioning scheme for another confusing and weird > versioning scheme. > > It does have the advantage that that compare a two-part major like > 090401 vs 0

Re: [HACKERS] Upgrades and Error Messages

2016-06-18 Thread Tom Lane
Thangalin writes: > $ tail pg_upgrade_dump_11955.log > pg_restore: setting owner and privileges for ACL plperlu > pg_restore: [archiver (db)] Error while PROCESSING TOC: > pg_restore: [archiver (db)] Error from TOC entry 1955; 0 0 ACL plperlu > postgres > pg_restore: [archiver (db)] could not exe

Re: [HACKERS] Upgrades and Error Messages

2016-06-18 Thread David G. Johnston
On Sat, Jun 18, 2016 at 4:52 PM, Thangalin wrote: ​tl/dr; Observations, thoughts, and questions present inline as well.​ ​Note, I'm drawing a conclusion below but do not have the code knowledge to know for certain that what I describe doesn't have holes in it. I'm also assuming a bit about what

[HACKERS] Upgrades and Error Messages

2016-06-18 Thread Thangalin
Hi, ~$ cat upgrade.sh #!/bin/bash /usr/lib/postgresql/9.3/bin/pg_upgrade \ -b /usr/lib/postgresql/9.1/bin/ \ -B /usr/lib/postgresql/9.3/bin/ \ -d /var/lib/postgresql/9.1/main \ -D /var/lib/postgresql/9.3/main \ -o ' -c config_file=/etc/postgresql/9.1/main/postgresql.conf' \ -O ' -

[HACKERS] Rethinking behavior of force_parallel_mode = regress

2016-06-18 Thread Tom Lane
As of HEAD it is possible to get through all of our regression tests with these settings: alter system set force_parallel_mode = regress; alter system set max_parallel_workers_per_gather = 2; alter system set parallel_tuple_cost = 0; alter system set parallel_setup_cost = 0; alter system set min_p

Re: [HACKERS] New design for FK-based join selectivity estimation

2016-06-18 Thread Tom Lane
I wrote: > Tomas Vondra writes: >> Is this a good idea? I'd probably vote to do what's proposed (and >> rejected) in the second half of the comment, i.e. put back the clauses >> and skip the FK as that pretty much says "improve estimate or keep the >> current one, but don't risk making it worse

Re: [HACKERS] New design for FK-based join selectivity estimation

2016-06-18 Thread Tom Lane
Tomas Vondra writes: > A few more comments, about re-reading the patch more thoroughly. I > wouldn't say any of those qualify as bugs, but rather as discussion > about some of the design choices: > 1) NULL handling > I'd argue that we should do something about this, although I agree it's > no

Re: [HACKERS] Whether to back-patch fix for aggregate transtype width estimates

2016-06-18 Thread Tom Lane
Robert Haas writes: > On Fri, Jun 17, 2016 at 10:41 PM, Tom Lane wrote: >> Ordinarily I'd just summarily back-patch a fix, but that commit shipped >> in 9.0, which means it's been broken a long time. I'm worried that >> back-patching a change might be more likely to destabilize plan choices >> t

Re: [HACKERS] Questionabl description in datatype.sgml

2016-06-18 Thread Tom Lane
Tatsuo Ishii writes: > In "8.13.2. Encoding Handling" > > When using binary mode to pass query parameters to the server > and query results back to the client, no character set conversion > is performed, so the situation is different. In this case, an > encoding declaration in

Re: [HACKERS] forcing a rebuild of the visibility map

2016-06-18 Thread Tom Lane
Michael Paquier writes: > On Sat, Jun 18, 2016 at 6:53 AM, Robert Haas wrote: >> Andres, do you want to explain the nature of your concern further? > I am not in his mind, but my guess is that contrib modules are > sometimes used as template examples by other people, and encouraging > users to u

Re: [HACKERS] [BUGS] BUG #14199: The pg_ctl status check on server start is not compatible with the silent_mode=on

2016-06-18 Thread Tom Lane
sobo...@freebsd.org writes: > There is a problem with pg_ctl when it tries to start server with the > "silent_mode=on" option enabled in postgresql.conf. Specifically, this > option causes postgres to fork once more after start. There are two problems > caused by that: > 1. The pm_pid recorded by t

Re: [HACKERS] forcing a rebuild of the visibility map

2016-06-18 Thread Michael Paquier
On Sat, Jun 18, 2016 at 6:53 AM, Robert Haas wrote: > On Fri, Jun 17, 2016 at 2:59 PM, Robert Haas wrote: >>> Having an XLogInsert() in contrib makes me more than a bit squeamish. I >>> think it'd be fair bit better to have that section of code in >>> visibilitymap.c, and then call that from the

[HACKERS] Questionabl description in datatype.sgml

2016-06-18 Thread Tatsuo Ishii
In "8.13.2. Encoding Handling" When using binary mode to pass query parameters to the server and query results back to the client, no character set conversion is performed, so the situation is different. In this case, an encoding declaration in the XML data will be observed, a