[HACKERS] a word-choice question

2015-12-05 Thread Chapman Flack
In PL/Java's function annotations, 'type' has been used for the volatility category: @Function(type=IMMUTABLE) public static String hello() { return "Hello, world!"; } It seems a bit infelicitous because you would probably sooner guess that 'type' was telling you something about the function's

Re: [HACKERS] Size of Path nodes

2015-12-05 Thread Robert Haas
On Sat, Dec 5, 2015 at 9:11 PM, Robert Haas wrote: > here. For example, in the case of nodeSeqscan.c, almost two-thirds of > the new lines of code are to add three additional methods that aren't > called in parallel aware mode, and about half of the rest are due to a > SeqScanState now having one

Re: [HACKERS] Size of Path nodes

2015-12-05 Thread Robert Haas
On Sat, Dec 5, 2015 at 2:29 PM, Tom Lane wrote: > Meh. Size of first patch is a pretty bad guide to whether a particular > structural decision is going to be a good idea in the long run. Do you > need some examples of patches we've rejected because they were done in a > way that minimized the si

Re: [HACKERS] dynloader.h missing in prebuilt package for Windows?

2015-12-05 Thread Bruce Momjian
On Fri, Dec 4, 2015 at 07:09:03PM -0500, Chapman Flack wrote: > On 12/04/15 12:56, Bruce Momjian wrote: > > > > OK, good logical reason to install dynloader.h on Windows. > > Ah! Thanks. I was starting to wonder whether I had said something wrong > and been sent to the bit bucket within my fir

Re: [HACKERS] Size of Path nodes

2015-12-05 Thread Tom Lane
Robert Haas writes: > On Sat, Dec 5, 2015 at 12:35 PM, Tom Lane wrote: >> Amit Kapila writes: >>> To add to whatever has been said above, intention of adding that flag >>> was also to avoid adding new nodes for parallelism. Basically modify >>> the existing nodes (like SeqScan) to take care of

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-12-05 Thread Tom Lane
Andrew Dunstan writes: > On 11/29/2015 04:28 PM, Noah Misch wrote: >> Never mutate the filesystem in a BEGIN block, because "perl -c" runs BEGIN >> blocks. (Likewise for the BEGIN block this patch adds to TestLib.) > Yeah, those two lines might belong in an INIT block. "perldoc perlmod" > for d

Re: [HACKERS] Size of Path nodes

2015-12-05 Thread Greg Stark
On Sat, Dec 5, 2015 at 5:35 PM, Tom Lane wrote: > The planner does not > normally[1] use the same path type to represent two fundamentally different > execution plans with enormously different cost estimates Eh, this is a typical object modelling dilemma. There are lots of different path types a

Re: [HACKERS] Size of Path nodes

2015-12-05 Thread Robert Haas
On Sat, Dec 5, 2015 at 12:35 PM, Tom Lane wrote: > Amit Kapila writes: >> To add to whatever has been said above, intention of adding that flag >> was also to avoid adding new nodes for parallelism. Basically modify >> the existing nodes (like SeqScan) to take care of whatever is needed >> for p

Re: [HACKERS] Random crud left behind by aborted TAP tests

2015-12-05 Thread Tom Lane
Michael Paquier writes: > On Sat, Dec 5, 2015 at 1:59 AM, Tom Lane wrote: >> Let's just put the cruft in tmp_check/ and call it good. > +1. Having those folders with random names showing up when typing git > statue is annoying, so voilà. Looks good to me, so pushed. re

Re: [HACKERS] Size of Path nodes

2015-12-05 Thread Tom Lane
Amit Kapila writes: > To add to whatever has been said above, intention of adding that flag > was also to avoid adding new nodes for parallelism. Basically modify > the existing nodes (like SeqScan) to take care of whatever is needed > for parallel execution. TBH, I would say that that's a damn-

Re: [HACKERS] Size of Path nodes

2015-12-05 Thread Robert Haas
On Fri, Dec 4, 2015 at 4:00 PM, Robert Haas wrote: > If it's really true that the extra byte I added there has doubled > planner memory use, then that's definitely cause for concern. > However, I am skeptical that's really what has happened here. Not > every path has crossed a power-of-two thresh

Re: [HACKERS] [PATCH] Equivalence Class Filters

2015-12-05 Thread Tom Lane
David Rowley writes: > As of today these Equivalence Classes only incorporate expressions which > use the equality operator, but what if the above query had been written as: > select * from t1 inner join t2 on t1.id = t2.id where t1.id <= 10; > Should we not be able to assume that t2.id is also

Re: [HACKERS] libxml2 2.9.3 breaks xml test output

2015-12-05 Thread Christian Ullrich
* Michael Paquier wrote: On Sat, Dec 5, 2015 at 4:38 PM, Christian Ullrich wrote: I have zero experience with libxml2, so no idea if the previous context level can be turned on again. IMHO, the libxml2 change is a bug in itself; PostgreSQL's error messages are more readable with the XML text i

Re: [HACKERS] psql: add \pset true/false

2015-12-05 Thread Michael Paquier
On Fri, Dec 4, 2015 at 6:06 PM, Pavel Stehule wrote: > long time I am dream about integrating Lua to psql > > It is fast enough for these purpose and can be used for custom macros, .. Things are perhaps digressing too much here... Regarding the patch, I would tend to think that we should just rej

Re: [HACKERS] Random crud left behind by aborted TAP tests

2015-12-05 Thread Michael Paquier
On Sat, Dec 5, 2015 at 1:59 AM, Tom Lane wrote: > Let's just put the cruft in tmp_check/ and call it good. +1. Having those folders with random names showing up when typing git statue is annoying, so voilà. -- Michael 20151205_tap_tempdirs.patch Description: binary/octet-stream -- Sent via p

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-12-05 Thread Michael Paquier
On Sat, Dec 5, 2015 at 1:11 AM, Alvaro Herrera wrote: > Michael Paquier wrote: > >> By the way, if there are no objections, I am going to mark this patch >> as committed in the CF app. Putting in the infrastructure is already a >> good step forward, and I will add an entry in next CF to track the

[HACKERS] [PATCH] Equivalence Class Filters

2015-12-05 Thread David Rowley
Hi, I'd like to gather up what the community interest might be for this patch. Let me explain: As of today Equivalence Classes are used in the query planner to allow the planner to have more flexibility into the join order by collecting information to describe which expressions are equal to each

Re: [HACKERS] [patch] Proposal for \rotate in psql

2015-12-05 Thread Pavel Stehule
2015-11-30 16:34 GMT+01:00 Daniel Verite : > Pavel Stehule wrote: > > > [ \rotate being a wrong name ] > > Here's an updated patch. > Today I have a time to play with it. I am sorry for delay. > > First it renames the command to \crosstabview, which hopefully may > be more consensual, a