Re: [HACKERS] [patch] Proposal for \rotate in psql

2015-09-19 Thread Pavel Stehule
2015-09-19 8:03 GMT+02:00 Marcin Mańk : > > > W dniu piątek, 18 września 2015 Daniel Verite > napisał(a): > >> Pavel Stehule wrote: >> >> > in the help inside your last patch, you are using "crosstab". Cannto be >> > crosstab the name for this feature? >> >> If it wasn't taken already by

Re: [HACKERS] ON CONFLICT issues around whole row vars,

2015-09-19 Thread Peter Geoghegan
On Sat, Sep 19, 2015 at 5:11 PM, Andres Freund wrote: > Peter's patch upthread fixes this by pulling expressions from > onConflictSet/Where into the targetlist. I disliked this - much less > than initially - a bit because that seems a bit crufty given that we're > not actually getting data from a

Re: [HACKERS] Update count mismatch - internal error

2015-09-19 Thread Peter Geoghegan
On Sat, Sep 19, 2015 at 5:15 PM, Andres Freund wrote: > postgres[14993][1]=# CREATE TABLE mismatch(a int, b int); > CREATE TABLE > postgres[14993][1]=# UPDATE mismatch SET a = mismatch.*; > ERROR: XX000: UPDATE target count mismatch --- internal error > LOCATION: transformUpdateTargetList, analy

[HACKERS] Update count mismatch - internal error

2015-09-19 Thread Andres Freund
Hi, While working on polishing remaining upsert issues I found a, afaics unrelated, issue: postgres[14993][1]=# CREATE TABLE mismatch(a int, b int); CREATE TABLE postgres[14993][1]=# UPDATE mismatch SET a = mismatch.*; ERROR: XX000: UPDATE target count mismatch --- internal error LOCATION: tran

Re: [HACKERS] ON CONFLICT issues around whole row vars,

2015-09-19 Thread Andres Freund
Hi, To recap for other readers: There's a problem with ON CONFLICT when the SET or ON CONFLICT ... WHERE clause references excluded.* (i.e. as a whole row var). The problem is that setrefs.c in fix_join_expr_mutator() currently won't find a matching entry in the indexed tlist and thus error out w

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-09-19 Thread Tom Lane
Peter Eisentraut writes: > On 7/23/15 6:39 PM, Tom Lane wrote: >> + 2202HEERRCODE_INVALID_TABLESAMPLE_ARGUMENT >> invalid_tablesample_argument >> + 2202GEERRCODE_INVALID_TABLESAMPLE_REPEAT >> invalid_tablesample_repeat > Wher