Re: [HACKERS] pg_upgrade in 9.5 broken for adminpack

On Thu, Apr 16, 2015 at 11:04 PM, Jeff Janes wrote: > > On Thu, Apr 16, 2015 at 7:37 PM, Bruce Momjian wrote: > >> On Thu, Apr 16, 2015 at 07:33:50PM -0700, Jeff Janes wrote: >> > pg_upgrade was recently broken for use upgrading from a system with >> adminpack >> > installed. >> > >> > ... > Th

Re: [HACKERS] pg_upgrade in 9.5 broken for adminpack

On Thu, Apr 16, 2015 at 7:37 PM, Bruce Momjian wrote: > On Thu, Apr 16, 2015 at 07:33:50PM -0700, Jeff Janes wrote: > > pg_upgrade was recently broken for use upgrading from a system with > adminpack > > installed. > > > > Breaking commit is: > > > > commit 30982be4e5019684e1772dd9170aaa53f5a8e89

Re: [HACKERS] Fix broken Install.bat when target directory contains a space

On Thu, Apr 16, 2015 at 5:40 PM, Asif Naeem wrote: > Along with fixing the space in installation path, it is also changing the > behavior of install script, why not just "if NOT [%1]==[] GOTO RUN_INSTALL", > checking for "/?" seems good for help message but it seem not well handled > in the script,

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On 17-04-2015 PM 12:35, Etsuro Fujita wrote: > On 2015/04/17 10:23, Amit Langote wrote: >> By the way, one suggestion may be to attach a "(pushed down)" to the >> ModifyTable's "Foreign Update". And in that case, there would be no mention >> of >> corresponding scan node in the list below exactly

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On 2015/04/17 10:23, Amit Langote wrote: > By the way, one suggestion may be to attach a "(pushed down)" to the > ModifyTable's "Foreign Update". And in that case, there would be no mention of > corresponding scan node in the list below exactly because there would be none. > > postgres=# explain v

Re: [HACKERS] reparsing query

> It is not difficult to output parsed query in some tool readable > format but it comes with a maintain overhead: once tools rely on it, > we have to conform to some schema continuously, like the xml/xmlns. Do > we want to take this? Depends on how far the tools can go with this > exposed informat

Re: [HACKERS] Supporting src/test/modules in MSVC builds

Andrew Dunstan wrote: > > On 04/16/2015 07:42 PM, Michael Paquier wrote: > > > >>>Then if all goes well we can apply the third patch and I'll fix the > >>>buildfarm client for the forthcoming release to run the tests on MSVC > >>>builds. Nothing will break in the meantime - the tests just won't ge

Re: [HACKERS] pg_upgrade in 9.5 broken for adminpack

On Thu, Apr 16, 2015 at 07:33:50PM -0700, Jeff Janes wrote: > pg_upgrade was recently broken for use upgrading from a system with adminpack > installed. > > Breaking commit is: > > commit 30982be4e5019684e1772dd9170aaa53f5a8e894 > Author: Peter Eisentraut > >     Integrate pg_upgrade_support mo

[HACKERS] pg_upgrade in 9.5 broken for adminpack

pg_upgrade was recently broken for use upgrading from a system with adminpack installed. Breaking commit is: commit 30982be4e5019684e1772dd9170aaa53f5a8e894 Author: Peter Eisentraut Integrate pg_upgrade_support module into backend from pg_upgrade_dump_12870.log pg_restore: creating EXTEN

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

Fujita-san, On 16-04-2015 PM 08:40, Etsuro Fujita wrote: >> From what I see in Tom's commit message[0] for FTI patch, this shouldn't be, >> right? >> >> To be specific, there should be "Foreign Scan" there as per the commit. Am I >> missing something? > > As shown in the below example, this patc

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

Hanada-san, > I merged explain patch into foreign_join patch. > > Now v12 is the latest patch. > It contains many garbage lines... Please ensure the patch is correctly based on the latest master + custom_join patch. Thanks, -- NEC Business Creation Division / PG-Strom Project KaiGai Kohei > -

Re: [HACKERS] FILTER/WITHIN GROUP vs. expressions; is a HINT possible here?

On 04/16/2015 04:36 PM, Tom Lane wrote: > You could imagine teaching yyerror() to have some SQL-specific knowledge > that it could apply by comparing the current lookahead token to the > current parse state stack ... but neither of those things are exposed > to it by Bison. We could probably get t

Re: [HACKERS] Supporting src/test/modules in MSVC builds

On 04/16/2015 07:42 PM, Michael Paquier wrote: Then if all goes well we can apply the third patch and I'll fix the buildfarm client for the forthcoming release to run the tests on MSVC builds. Nothing will break in the meantime - the tests just won't get run until the new client version is dep

Re: [HACKERS] Supporting src/test/modules in MSVC builds

On Fri, Apr 17, 2015 at 4:47 AM, Alvaro Herrera wrote: > Andrew Dunstan wrote: >> It looks good, and if you've tested it I'm satisfied. I suggest that >> we apply patches 1 and 2 immediately. AUIU they don't require any >> changes to the buildfarm, as the MSVC build process will automatically >> b

Re: [HACKERS] FILTER/WITHIN GROUP vs. expressions; is a HINT possible here?

Josh Berkus writes: > ERROR: syntax error at or near "FILTER" > LINE 4: count(*)::INT FILTER (WHERE valid) as valid_count, > The error is right, that's invalid syntax. I can't insert a ::INT > between the aggregate() and FILTER. However, the error message is also > rather confu

Re: [HACKERS] FILTER/WITHIN GROUP vs. expressions; is a HINT possible here?

On 04/16/2015 01:18 PM, David G. Johnston wrote: > On Thu, Apr 16, 2015 at 1:06 PM, Josh Berkus >wrote: > > On 04/16/2015 01:01 PM, David G. Johnston wrote: > > If this is not covered adequately enough in the documentation then that > > should be remedied. D

Re: [HACKERS] inherit support for foreign tables

On Wed, Apr 15, 2015 at 09:35:05AM +0900, Kyotaro HORIGUCHI wrote: > Hi, > > Before suppressing the symptom, I doubt the necessity and/or > validity of giving foreign tables an ability to be a parent. Is > there any reasonable usage for the ability? > > I think we should choose to inhibit foreign

Re: [HACKERS] Turning off HOT/Cleanup sometimes

Andres Freund wrote: > On 2015-04-16 10:20:20 -0300, Alvaro Herrera wrote: > > I think you're failing to consider that in the patch there is a > > distinction between read-only page accesses and page updates. During a > > page update, HOT cleanup is always done even with the patch, so there > > wo

Re: [HACKERS] FILTER/WITHIN GROUP vs. expressions; is a HINT possible here?

On Thu, Apr 16, 2015 at 1:06 PM, Josh Berkus wrote: > On 04/16/2015 01:01 PM, David G. Johnston wrote: > > If this is not covered adequately enough in the documentation then that > > should be remedied. Did you evaluate the documentation in that light > > while preparing your blog post? > > Your

Re: [HACKERS] Turning off HOT/Cleanup sometimes

On 16 April 2015 at 15:21, Andres Freund wrote: > On 2015-04-16 10:20:20 -0300, Alvaro Herrera wrote: > > I think you're failing to consider that in the patch there is a > > distinction between read-only page accesses and page updates. During a > > page update, HOT cleanup is always done even wi

[HACKERS] Performance tuning assisted by a GUI application

Hello, (Please pardon me if this is offtopic and I should send it to another mailing list instead) I had a brief discussion on #postgresql and thought that perhaps there might be a need for a tool that would enable a fine-tuning of PostgreSQL performance settings by conveniently testing them with

Re: [HACKERS] FILTER/WITHIN GROUP vs. expressions; is a HINT possible here?

On 04/16/2015 01:01 PM, David G. Johnston wrote: > If this is not covered adequately enough in the documentation then that > should be remedied. Did you evaluate the documentation in that light > while preparing your blog post? Your response seems very defensive. I'm unclear on why discussing im

Re: [HACKERS] FILTER/WITHIN GROUP vs. expressions; is a HINT possible here?

On Thu, Apr 16, 2015 at 12:22 PM, Josh Berkus wrote: > Folks: > > SELECT > device_id, > count(*)::INT as present, > count(*)::INT FILTER (WHERE valid) as valid_count, > mode()::INT WITHIN GROUP (order by val) as mode, > percentile_disc(0.5)::INT WITHIN

Re: [HACKERS] Supporting src/test/modules in MSVC builds

Andrew Dunstan wrote: > Thanks for doing this. Yes, much appreciated. > It looks good, and if you've tested it I'm satisfied. I suggest that > we apply patches 1 and 2 immediately. AUIU they don't require any > changes to the buildfarm, as the MSVC build process will automatically > build and i

[HACKERS] FILTER/WITHIN GROUP vs. expressions; is a HINT possible here?

Folks: SELECT device_id, count(*)::INT as present, count(*)::INT FILTER (WHERE valid) as valid_count, mode()::INT WITHIN GROUP (order by val) as mode, percentile_disc(0.5)::INT WITHIN GROUP (order by val) as median FROM dataflow_0913 GR

Re: [HACKERS] Assertion failure when streaming logical changes

On 04/07/2015 03:54 PM, Andres Freund wrote: On 2015-04-07 17:22:12 +0800, Craig Ringer wrote: It might be a good idea to apply this if nothing better is forthcoming. Logical decoding in WALsenders is broken at the moment. Yes. Committed. - Heikki -- Sent via pgsql-hackers mailing list (p

Re: [HACKERS] [PERFORM] pushing order by + limit to union subqueries

On Sat, Feb 28, 2015 at 8:24 AM, Tom Lane wrote: > > There would be cases where that would be a win, and there would be cases > where it wouldn't be, so I'd not be in favor of making the transformation > blindly. Unfortunately, given the current state of the planner that's > all we could do reall

Re: [HACKERS] INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0

On Thu, Apr 16, 2015 at 2:18 AM, Andres Freund wrote: > On 2015-04-15 18:53:15 +0300, Heikki Linnakangas wrote: >> Hmm, ok, I've read the "INSERT ... ON CONFLICT UPDATE and logical decoding" >> thread now, and I have to say that IMHO it's a lot more sane to handle this >> in ReorderBufferCommit()

Re: [HACKERS] Supporting src/test/modules in MSVC builds

On 04/16/2015 02:46 AM, Michael Paquier wrote: Hi all, As mentioned previously (cab7npqscphafxs2rzeb-fbccjqiknqxjhloztkggim1mf5x...@mail.gmail.com), attached are patches to add support for src/test/modules in MSVC builds, modules whose tests are not supported since they have been moved from con

Re: [HACKERS] PATCH: default_index_tablespace

> > I'm afraid this idea is a nonstarter, because it will break existing > applications, and in particular existing pg_dump output files, which > expect to be able to determine an index's tablespace by setting > "default_tablespace". (It is *not* adequate that the code falls back > to "defaul

Re: [HACKERS] INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0

On Thu, Apr 16, 2015 at 2:23 AM, Andres Freund wrote: > I'm, completely independent of logical decoding, of the *VERY* strong > opinion that 'speculative insertions' should never be visible when > looking with normal snapshots. For one it allows to simplify > considerations around wraparound (whic

Re: [HACKERS] [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

--On 15. April 2015 15:02:05 -0400 Andrew Dunstan wrote: > We've handled the buildfarm being red for a few days before. People are > usually good about applying fixes fairly quickly. Took me some time to get that due to my mail backlog, but i've done the hotfix for dotterel and forced a run fo

Re: [HACKERS] Turning off HOT/Cleanup sometimes

On 2015-04-16 10:20:20 -0300, Alvaro Herrera wrote: > I think you're failing to consider that in the patch there is a > distinction between read-only page accesses and page updates. During a > page update, HOT cleanup is always done even with the patch, so there > won't be any additional bloat tha

Re: [HACKERS] Turning off HOT/Cleanup sometimes

On Thu, Apr 16, 2015 at 6:50 PM, Alvaro Herrera wrote: > Pavan Deolasee wrote: > > On Thu, Apr 16, 2015 at 2:47 PM, Greg Stark wrote: > > > > From a holistic point of view the question is how many times is a given > > > hit chain going to need to be followed before it's pruned. Or to put it > >

[HACKERS] Disabling trust/ident authentication configure option

We have a customer using a patch to harden their PostgreSQL installation (see attached) they would like to contribute. This patch adds the ability to disable "trust" and "ident" authentication at compile time via configure options, thus making it impossible to use these authentication methods for s

Re: [HACKERS] PATCH: default_index_tablespace

On 4/15/15 11:33 PM, Amit Kapila wrote: > On Thu, Apr 16, 2015 at 8:01 AM, Bruce Momjian > wrote: >> >> On Wed, Apr 15, 2015 at 07:12:11PM -0400, Tom Lane wrote: >> > jltal...@adv-solutions.net writes: >> > > This small patch implements

Re: [HACKERS] INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0

On 04/16/2015 12:18 PM, Andres Freund wrote: On 2015-04-15 18:53:15 +0300, Heikki Linnakangas wrote: Hmm, ok, I've read the "INSERT ... ON CONFLICT UPDATE and logical decoding" thread now, and I have to say that IMHO it's a lot more sane to handle this in ReorderBufferCommit() like Peter first d

Re: [HACKERS] initdb -S and tablespaces

Hi. Here's a variation of the earlier patch that follows all links in PGDATA. Does this look more like what you had in mind? -- Abhijit >From d86888b0d2f5a3a57027d26ce050a3bbb58670d3 Mon Sep 17 00:00:00 2001 From: Abhijit Menon-Sen Date: Thu, 6 Nov 2014 00:45:56 +0530 Subject: Recursively fsync

Re: [HACKERS] Turning off HOT/Cleanup sometimes

Pavan Deolasee wrote: > On Thu, Apr 16, 2015 at 2:47 PM, Greg Stark wrote: > > From a holistic point of view the question is how many times is a given > > hit chain going to need to be followed before it's pruned. Or to put it > > another way, how expensive is creating a hot chain. Does it cause

Re: [HACKERS] Streaming replication and WAL archive interactions

On 03/01/2015 12:36 AM, Venkata Balaji N wrote: Patch did get applied successfully to the latest master. Can you please rebase. Here you go. On 01/31/2015 03:07 PM, Andres Freund wrote: On 2014-12-19 22:56:40 +0200, Heikki Linnakangas wrote: This add two new archive_modes, 'shared' and 'alwa

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On 2015/04/16 19:57, Amit Langote wrote: > On 16-04-2015 PM 07:50, Etsuro Fujita wrote: >>> The EXPLAIN output has also been improved as discussed in [1]. >> >> I noticed that the EXPLAIN for a pushed-down update (delete) on inheritance >> childs doubly displays "Foreign Update" ("Foreign Delete"),

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On 16-04-2015 PM 07:50, Etsuro Fujita wrote: >> The EXPLAIN output has also been improved as discussed in [1]. > > I noticed that the EXPLAIN for a pushed-down update (delete) on inheritance > childs doubly displays "Foreign Update" ("Foreign Delete"), one for > ForeignScan and the other for Modif

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On 2015/03/05 21:08, Etsuro Fujita wrote: Here is an updated version. The EXPLAIN output has also been improved as discussed in [1]. I noticed that the EXPLAIN for a pushed-down update (delete) on inheritance childs doubly displays "Foreign Update" ("Foreign Delete"), one for ForeignScan a

Re: [HACKERS] Turning off HOT/Cleanup sometimes

On Thu, Apr 16, 2015 at 2:47 PM, Greg Stark wrote: > > On 15 Apr 2015 15:43, "Simon Riggs" wrote: > > > > It all depends upon who is being selfish. Why is a user "selfish" for > > not wanting to clean every single block they scan, when the people > > that made the mess do nothing and go faster 1

Re: [HACKERS] INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0

On 2015-04-15 17:58:54 +0300, Heikki Linnakangas wrote: > When the speculative insertion is finished, write a new kind of a WAL record > for that. The record only needs to contain the ctid of the tuple. Replaying > that record will clear the flag on the heap tuple that said that it was a > speculat

Re: [HACKERS] INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0

On 2015-04-15 18:53:15 +0300, Heikki Linnakangas wrote: > Hmm, ok, I've read the "INSERT ... ON CONFLICT UPDATE and logical decoding" > thread now, and I have to say that IMHO it's a lot more sane to handle this > in ReorderBufferCommit() like Peter first did, than to make the main > insertion path

Re: [HACKERS] Turning off HOT/Cleanup sometimes

On 15 Apr 2015 15:43, "Simon Riggs" wrote: > > It all depends upon who is being selfish. Why is a user "selfish" for > not wanting to clean every single block they scan, when the people > that made the mess do nothing and go faster 10 minutes from now? > Randomly and massively penalising large SEL

Re: [HACKERS] PATCH: default_index_tablespace

On 15 Apr 2015 19:12, "Tom Lane" wrote: > > I'm afraid this idea is a nonstarter, because it will break existing > applications, and in particular existing pg_dump output files, which > expect to be able to determine an index's tablespace by setting > "default_tablespace". (It is *not* adequate t

Re: [HACKERS] Fix broken Install.bat when target directory contains a space

Hi Michael, I spend spend time look into the patch. Good catch, I am also surprised to see that current Windows install script don’t support spaces in the path. Please see my findings as following i.e. *Without the patch* 1. > C:\PG\postgresql\src\tools\msvc>install "C:\PG\postgresql\inst with

[HACKERS] Minor improvement to config.sgml

Hi, Attached is a small patch to mark up on with in doc/src/sgml/config.sgml. Best regards, Etsuro Fujita diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index b30c68d..0d8624a 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -6752,7 +6752,7 @@ dynamic_lib

Re: [HACKERS] FPW compression leaks information

On Wed, Apr 15, 2015 at 9:42 PM, Michael Paquier wrote: > On Wed, Apr 15, 2015 at 9:20 PM, Michael Paquier > wrote: >> On Wed, Apr 15, 2015 at 2:22 PM, Fujii Masao wrote: >>> On Wed, Apr 15, 2015 at 11:55 AM, Michael Paquier wrote: 1) Doc patch to mention that it is possible that compression

Re: [HACKERS] inherit support for foreign tables

On 2015/03/23 2:57, Tom Lane wrote: > Etsuro Fujita writes: >> [ fdw-inh-8.patch ] > > I've committed this with some substantial rearrangements, notably: > * As I mentioned earlier, I got rid of a few unnecessary restrictions on > foreign tables so as to avoid introducing warts into inheritance