Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code

2015-02-07 Thread Michael Paquier
On Fri, Feb 6, 2015 at 4:58 PM, Fujii Masao wrote: > timestamp.c:1708: warning: implicit declaration of function > 'HandleStartupProcInterrupts' > > I got the above warning at the compilation. > > +pg_usleep(wait_time); > +HandleStartupProcInterrupts(); > +total_time -= wait

Re: [HACKERS] Parallel Seq Scan

2015-02-07 Thread Amit Kapila
On Sun, Feb 8, 2015 at 3:46 AM, Robert Haas wrote: > > On Sat, Feb 7, 2015 at 4:30 PM, Andres Freund wrote: > > On 2015-02-06 22:57:43 -0500, Robert Haas wrote: > >> On Fri, Feb 6, 2015 at 2:13 PM, Robert Haas wrote: > >> > My first comment here is that I think we should actually teach > >> > he

Re: [HACKERS] Parallel Seq Scan

2015-02-07 Thread Amit Kapila
On Sat, Feb 7, 2015 at 12:43 AM, Robert Haas wrote: > > The complicated part here seems to me to figure out what we need to > pass from the parallel leader to the parallel worker to create enough > state for quals and projection. If we want to be able to call > ExecScan() without modification, wh

[HACKERS] assessing parallel-safety

2015-02-07 Thread Robert Haas
Amit's parallel sequential scan assumes that we can enter parallel mode when the parallel sequential scan is initialized and exit parallel mode when the scan ends and all the code that runs in between will be happy with that. Unfortunately, that's not necessarily the case. There are two ways it c

Re: [HACKERS] parallel mode and parallel contexts

2015-02-07 Thread Andres Freund
Hi, On 2015-02-06 22:43:21 -0500, Robert Haas wrote: > Here's v4, with that fixed and a few more tweaks. If you attached files generated with 'git format-patch' I could directly apply then with the commit message and such. All at once if it's mutliple patches, as individual commits. On nontrivia

[HACKERS] 9.6 Feature help requested: Inclusion Constraints

2015-02-07 Thread Jeff Davis
I believe Inclusion Constraints will be important for postgres. Unfortunately, my time has been scarce lately, so without help it may miss 9.6 as well. If someone is interested in working on this with me to deliver a good submission in a couple months, please let me know. The idea is to make a gen

Re: [HACKERS] perplexing error message

2015-02-07 Thread Robert Haas
On Sat, Feb 7, 2015 at 4:35 PM, Tom Lane wrote: > What's going on here is that we're checking the SELECT that is added > by the rule, and per TFM that executes before the UPDATE, so you get > this error first rather than one complaining about UPDATE (which you > would get later if this one hadn't

Re: [HACKERS] Parallel Seq Scan

2015-02-07 Thread Robert Haas
On Sat, Feb 7, 2015 at 4:30 PM, Andres Freund wrote: > On 2015-02-06 22:57:43 -0500, Robert Haas wrote: >> On Fri, Feb 6, 2015 at 2:13 PM, Robert Haas wrote: >> > My first comment here is that I think we should actually teach >> > heapam.c about parallelism. >> >> I coded this up; see attached.

Re: [HACKERS] perplexing error message

2015-02-07 Thread Tom Lane
Robert Haas writes: > There are a lot of things that are understandably forbidden in a > read-only transaction, but one would not expect SELECT to be among > them. And yet, one can get the system to complain about precisely > that: > ... This seems to be the result of this code in ExecCheckXactRe

Re: [HACKERS] Cube extension kNN support

2015-02-07 Thread Alexander Korotkov
Hi! On Sat, Feb 7, 2015 at 12:45 PM, Stas Kelvich wrote: > I had updated old patch with kNN operators for cube data structures. > Copying description from old message: > > Following distance operators introduced: > > <#> taxicab distance > <-> euclidean distance > <=> chebyshev distance > > For

Re: [HACKERS] Parallel Seq Scan

2015-02-07 Thread Andres Freund
On 2015-02-06 22:57:43 -0500, Robert Haas wrote: > On Fri, Feb 6, 2015 at 2:13 PM, Robert Haas wrote: > > My first comment here is that I think we should actually teach > > heapam.c about parallelism. > > I coded this up; see attached. I'm also attaching an updated version > of the parallel coun

[HACKERS] perplexing error message

2015-02-07 Thread Robert Haas
There are a lot of things that are understandably forbidden in a read-only transaction, but one would not expect SELECT to be among them. And yet, one can get the system to complain about precisely that: rhaas=# create table rules_src(f1 int, f2 int); ERROR: relation "rules_src" already exists r

Re: [HACKERS] Fetch zero result rows when executing a query?

2015-02-07 Thread David G Johnston
On Sat, Feb 7, 2015 at 10:41 AM, Shay Rojansky [via PostgreSQL] < ml-node+s1045698n5837082...@n5.nabble.com> wrote: > Sorry everyone, I was unexpectedly very busy and couldn't respond > earlier... My apologies. > > I'll clarify just a little... I am indeed talking about the PostgreSQL > network pr

Re: [HACKERS] Fetch zero result rows when executing a query?

2015-02-07 Thread Shay Rojansky
Sorry everyone, I was unexpectedly very busy and couldn't respond earlier... My apologies. I'll clarify just a little... I am indeed talking about the PostgreSQL network protocol, and not about query optimization (with LIMIT or omitting RETURNING etc.). I am implementing ADO.NET's ExecuteNonQuery,

Re: [HACKERS] GRANT USAGE on FOREIGN SERVER exposes passwords

2015-02-07 Thread Corey Huinker
It is far from central to this conversation, but I can confirm that RedShift currently only supports user+pass combinations. It's likely that each node has a pg_hba.conf, but the customer is not given credentials to ssh to the individual nodes. On Thu, Feb 5, 2015 at 10:48 AM, Stephen Frost wrot

[HACKERS] more RLS oversights

2015-02-07 Thread Robert Haas
I happened to notice this morning while hacking that the "hasRowSecurity" fields added to PlannerGlobal and PlannedStmt have not been given proper nodefuncs.c support. Both need to be added to outfuncs.c, and the latter to copyfuncs.c. The latter omission may well be a security bug, although I ha

Re: [HACKERS] New CF app deployment

2015-02-07 Thread Magnus Hagander
On Sat, Feb 7, 2015 at 1:53 PM, Tom Lane wrote: > Magnus Hagander writes: > > On Sat, Feb 7, 2015 at 1:02 AM, Jeff Janes wrote: > >> I'd like the ability to add a comment which does not get turned into an > >> email. > > > I really don't ;) > > > The reason I really don't like that is that this

Re: [HACKERS] New CF app deployment

2015-02-07 Thread Tom Lane
Magnus Hagander writes: > On Sat, Feb 7, 2015 at 1:02 AM, Jeff Janes wrote: >> I'd like the ability to add a comment which does not get turned into an >> email. > I really don't ;) > The reason I really don't like that is that this now makes it impossible to > track the review status by just re

Re: [HACKERS] New CF app deployment

2015-02-07 Thread Magnus Hagander
On Sat, Feb 7, 2015 at 1:02 AM, Jeff Janes wrote: > On Fri, Feb 6, 2015 at 5:20 AM, Robert Haas wrote: > >> On Fri, Feb 6, 2015 at 5:51 AM, Magnus Hagander >> wrote: >> > So in an attempt to actually move this forward in a constructive way I'm >> > going to ignore a bunch of what happened afte

Re: [HACKERS] New CF app deployment

2015-02-07 Thread Magnus Hagander
On Mon, Jan 19, 2015 at 10:53 PM, Magnus Hagander wrote: > On Mon, Jan 19, 2015 at 10:05 PM, Robert Haas > wrote: > >> On Mon, Jan 19, 2015 at 3:57 PM, Magnus Hagander >> wrote: >> > The new site has been deployed and should now be usable. >> >> There are, for some reason, three copies of "Clar

Re: [HACKERS] relid of non user created tables

2015-02-07 Thread Tom Lane
Deepak S writes: > I wish to know if it is safe to assume that non user created tables always > have a relid of less than 10,000 (I chose this value after trial and error). Depends what you consider "user created". System catalogs with manually-assigned OIDs will have OIDs below 10K, but initdb

Re: [HACKERS] Cube extension kNN support

2015-02-07 Thread Stas Kelvich
Hi! I had updated old patch with kNN operators for cube data structures. Copying description from old message: Following distance operators introduced: <#> taxicab distance <-> euclidean distance <=> chebyshev distance For example: SELECT * FROM objects ORDER BY objects.coord <-> '(137,42,314

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-02-07 Thread Pavel Stehule
Hi I am sending a review of this patch. 1. We would this patch? yes. It is a good idea - checking internal view is more comfortable and faster than checking some (possibly longer) pg_hba.conf. There was no objections. 2. Scope - does this patch, what we need? yes. There was a discussion about

[HACKERS] relid of non user created tables

2015-02-07 Thread Deepak S
Hi, I find that the relid of tables in all user created databases are having a value greater than 10,000 while the non user created tables produces a relid of value less than 10,000. For eg., the query transformed from the meta command "\dt" or "\l" gave me 'relid' values like 2615, 1259 and 12