ctidscan as an example of custom-scan (Re: [HACKERS] [v9.5] Custom Plan API)

2014-12-14 Thread Kouhei Kaigai
This attached patch adds a code example of custom-scan interface. This custom-scan provider ("ctidscan") performs almost same as built-in SeqScan plan, but can produce same results with less page scan in case when qualifier of relation scan has inequality operators (>, >=, < or <=) on "ctid" syste

[HACKERS] Comment typo in typedef struct BrinTuple

2014-12-14 Thread Amit Langote
Hi, Find attached that does: -* mt_info is laid out in the following fashion: +* bt_info is laid out in the following fashion: uint8 bt_info; } BrinTuple; Thanks, Amit BrinTuple-typo-fix.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-

Re: [HACKERS] On partitioning

2014-12-14 Thread Claudio Freire
On Sun, Dec 14, 2014 at 11:12 PM, Amit Langote wrote: >> On egress you need some direct way to compare the scan quals with the >> partitioning values. I would imagine this to be similar to how scan >> quals are compared to the values stored in a BRIN index: each scan qual >> has a corresponding o

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-14 Thread Michael Paquier
Note: this patch has been moved to CF 2014-12 and I marked myself as an author if that's fine... I've finished by being really involved in that. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailp

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 3:09 PM, Tom Lane wrote: > Michael Paquier writes: >> - Point to polygon distance operator > I looked at that briefly during the last fest, but was unsure whether it > was too entangled with the GiST patches that Heikki was looking at. Recalling my memories of this morning

Re: [HACKERS] [PATCH] Add transforms feature

2014-12-14 Thread Tom Lane
Peter Eisentraut writes: > On 4/4/14 6:21 PM, Andres Freund wrote: > + /* dependency on transform used by return type, if any */ > + if ((trfid = get_transform_oid(returnType, languageObjectId, true))) >> Should be compared to InvalidOid imo, rather than implicitly assuming >> that Inval

Re: [HACKERS] Commit fest 2014-12, let's begin!

2014-12-14 Thread Tom Lane
Michael Paquier writes: > Let's begin the commit fest of December: > https://commitfest.postgresql.org/action/commitfest_view?id=25 > ... > To committers: there are 2 patches marked as ready for committer from > previous commit fest: > - Foreign table inheritance I should probably take this one.

[HACKERS] Logical Replication Helpers WIP for discussion

2014-12-14 Thread Petr Jelinek
Hello, we've made few helper functions for making logical replication easier, I bundled it into contrib module as this is mainly for discussion at this time (I don't expect this to get committed any time soon, but it is good way to iron out protocol, etc). I created sample logical decoding p

Re: [HACKERS] Add generate_series(numeric, numeric)

2014-12-14 Thread Andrew Gierth
> "Ali" == Ali Akbar writes: Ali> I think yes, it will be good. The alternative is restructuring Ali> this paragraph in the SRF docs: >> The memory context that is current when the SRF is called is a >> transient context that will be cleared between calls. This means >> that you do not

[HACKERS] Commit fest 2014-12, let's begin!

2014-12-14 Thread Michael Paquier
Hi all, Let's begin the commit fest of December: https://commitfest.postgresql.org/action/commitfest_view?id=25 Looking at the stats at the top of the above page, there are currently 56 patches to be dealt with: - Needs Review: 48 - Waiting on Author: 5 - Ready for Committer: 3 In short we are in

Re: [HACKERS] Add generate_series(numeric, numeric)

2014-12-14 Thread Ali Akbar
2014-12-15 10:25 GMT+07:00 Andrew Gierth : > > > "Fujii" == Fujii Masao writes: > > Fujii> Pushed. > > Bug found: > > regression=# select count(*) from generate_series(1::numeric,10) v, > generate_series(1,v) w; > count > --- > 0 > (1 row) > > regression=# select count(*) from gener

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2014-12-14 Thread Ali Akbar
2014-12-15 11:06 GMT+07:00 Michael Paquier : > > On Mon, Dec 15, 2014 at 1:02 PM, Ali Akbar wrote: > > 2014-12-15 10:19 GMT+07:00 Michael Paquier : > >> > >> On Mon, Dec 15, 2014 at 9:05 AM, Ali Akbar wrote: > >> > Peter, while reviewing the better performing patch myself, now i think > >> > the

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-14 Thread Amit Kapila
On Sat, Dec 13, 2014 at 9:41 PM, Andrew Dunstan wrote: > On 11/20/2014 02:27 AM, Amit Kapila wrote: >> >> On Wed, Nov 19, 2014 at 11:46 PM, Robert Haas mailto:robertmh...@gmail.com>> wrote: >> > On Tue, Nov 18, 2014 at 9:19 AM, Alvaro Herrera >> > mailto:alvhe...@2ndquadrant.com>> wrote: >> > >> R

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 1:02 PM, Ali Akbar wrote: > 2014-12-15 10:19 GMT+07:00 Michael Paquier : >> >> On Mon, Dec 15, 2014 at 9:05 AM, Ali Akbar wrote: >> > Peter, while reviewing the better performing patch myself, now i think >> > the >> > patch needs more work to be committed. The structuring

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2014-12-14 Thread Ali Akbar
2014-12-15 11:02 GMT+07:00 Ali Akbar : > > 2014-12-15 10:19 GMT+07:00 Michael Paquier : >> >> On Mon, Dec 15, 2014 at 9:05 AM, Ali Akbar wrote: >> > Peter, while reviewing the better performing patch myself, now i think >> the >> > patch needs more work to be committed. The structuring of the meth

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2014-12-14 Thread Ali Akbar
2014-12-15 10:19 GMT+07:00 Michael Paquier : > > On Mon, Dec 15, 2014 at 9:05 AM, Ali Akbar wrote: > > Peter, while reviewing the better performing patch myself, now i think > the > > patch needs more work to be committed. The structuring of the method > will be > > confusing in the long term. I t

Re: [HACKERS] Status of CF 2014-10 and upcoming 2014-12

2014-12-14 Thread Michael Paquier
On Sun, Dec 14, 2014 at 12:00 AM, Michael Paquier wrote: > In any case, I will be able to do that on Monday. > Opinions? So I have been through all the remaining 20~25 patches of CF 2014-10, and roughly moved them to the next CF 2014-12 or returned them with feedback depending on their state and

Re: [HACKERS] RLS with check option - surprised design

2014-12-14 Thread Michael Paquier
On Sat, Nov 22, 2014 at 5:59 AM, Stephen Frost wrote: > * Peter Geoghegan (p...@heroku.com) wrote: >> On Fri, Nov 21, 2014 at 6:57 AM, Stephen Frost wrote: >> > [blah] >> [re-blah] > [re-re-blah] This patch has already been committed, but there are still many concerns shared, so moving it to CF 2

Re: [HACKERS] alter user set local_preload_libraries.

2014-12-14 Thread Michael Paquier
On Tue, Dec 9, 2014 at 11:56 PM, Robert Haas wrote: > On Mon, Dec 8, 2014 at 9:18 PM, Tom Lane wrote: >> Barring someone committing to spend the time to improve that situation >> (time that would be poorly invested IMO), I don't think that we want to >> open up ignore_system_indexes as USERSET, o

Re: [HACKERS] Escaping from blocked send() reprised.

2014-12-14 Thread Michael Paquier
On Thu, Oct 30, 2014 at 10:27 PM, Heikki Linnakangas wrote: > On 10/03/2014 06:29 PM, Heikki Linnakangas wrote: >> [blah] > About patch 3: > Looking closer, this design still looks OK to me. As you said yourself, the > comments need some work (e.g. the step 5. in the top comment in async.c > needs

Re: [HACKERS] Final Patch for GROUPING SETS

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 12:28 PM, Andrew Gierth wrote: >> "Michael" == Michael Paquier writes: > > Michael> Based on those comments, I am marking this patch as > Michael> "Returned with Feedback" on the CF app for 2014-10. Andrew, > Michael> feel free to move this entry to CF 2014-12 if yo

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-14 Thread Tom Lane
Amit Kapila writes: > On Mon, Dec 15, 2014 at 5:39 AM, Tom Lane wrote: >> What makes you think quote isn't allowed in tablespace paths? > Below part of code makes me think that quote is not allowed. > Oid > CreateTableSpace(CreateTableSpaceStmt *stmt) > { > .. > /* disallow quotes, else CREATE

Re: [HACKERS] Final Patch for GROUPING SETS

2014-12-14 Thread Andrew Gierth
> "Michael" == Michael Paquier writes: Michael> Based on those comments, I am marking this patch as Michael> "Returned with Feedback" on the CF app for 2014-10. Andrew, Michael> feel free to move this entry to CF 2014-12 if you are Michael> planning to continue working on it so as it woul

Re: [HACKERS] alter user/role CURRENT_USER

2014-12-14 Thread Michael Paquier
On Fri, Nov 14, 2014 at 5:39 PM, Kyotaro HORIGUCHI wrote: > Hi, this is revised version. > >> Kyotaro HORIGUCHI wrote: >> >> > - Storage for new information >> > >> > The new struct NameId stores an identifier which telling what it >> > logically is using the new enum NameIdTypes. >> >> I think Na

Re: [HACKERS] Add generate_series(numeric, numeric)

2014-12-14 Thread Andrew Gierth
> "Fujii" == Fujii Masao writes: Fujii> Pushed. Bug found: regression=# select count(*) from generate_series(1::numeric,10) v, generate_series(1,v) w; count --- 0 (1 row) regression=# select count(*) from generate_series(1::numeric,10) v, generate_series(1,v+0) w; count ---

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 9:05 AM, Ali Akbar wrote: > Peter, while reviewing the better performing patch myself, now i think the > patch needs more work to be committed. The structuring of the method will be > confusing in the long term. I think I'll restructure the patch in the next > commitfest. >

Re: [HACKERS] WIP: dynahash replacement for buffer table

2014-12-14 Thread Michael Paquier
There hasn't been much activity on this patch these days, and Andres has provided some feedback, hence switching to Returned with feedback. Regards, -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/m

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2014-12-14 Thread Michael Paquier
On Thu, Nov 27, 2014 at 8:51 PM, Alex Shulgin wrote: > > Dag-Erling Smørgrav writes: > >> Alex Shulgin writes: >>> OK, looks like I've come up with something workable: I've added >>> sslprotocol connection string keyword similar to pre-existing >>> sslcompression, etc. Please see attached v2 of

Re: [HACKERS] WIP: multivariate statistics / proof of concept

2014-12-14 Thread Michael Paquier
On Wed, Dec 10, 2014 at 5:15 AM, Tomas Vondra wrote: > I agree with moving the patch to the next CF - I'm working on the patch, > but I will take a bit more time to submit a new version and I can do > that in the next CF. OK cool. I just moved it by myself. I didn't see it yet registered in 2014-1

Re: [HACKERS] moving from contrib to bin

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 11:45 AM, Peter Eisentraut wrote: > On 12/14/14 9:08 PM, Michael Paquier wrote: >>> - no Windows build system support yet >> Do you need some help here? > > Sure. > >> I am getting worried about potential >> breakage with the version information built with MSVC and MinGW..

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-12-14 Thread Michael Paquier
On Fri, Oct 17, 2014 at 7:44 AM, Simon Riggs wrote: > Thanks for the review. > > On 16 October 2014 23:23, MauMau wrote: > >> (3) >> SELECT against a view generated two audit log lines, one for the view >> itself, and the other for the underlying table. Is this intended? I'm not >> saying that'

Re: [HACKERS] moving from contrib to bin

2014-12-14 Thread Peter Eisentraut
On 12/14/14 9:08 PM, Michael Paquier wrote: >> - no Windows build system support yet > Do you need some help here? Sure. > I am getting worried about potential > breakage with the version information built with MSVC and MinGW.. I don't know what that is. -- Sent via pgsql-hackers mailing l

Re: [HACKERS] replicating DROP commands across servers

2014-12-14 Thread Michael Paquier
On Thu, Oct 16, 2014 at 7:01 AM, Alvaro Herrera wrote: > Alvaro Herrera wrote: >> Andres Freund wrote: >> >> > Having reread the patch just now I basically see two things to >> > criticize: >> > a) why isn't this accessible at SQL level? That seems easy to address. >> > b) Arguably some of this co

Re: [HACKERS] [Bug] Inconsistent result for inheritance and FOR UPDATE.

2014-12-14 Thread Etsuro Fujita
(2014/12/13 1:17), Tom Lane wrote: > Etsuro Fujita writes: >>> (2014/12/12 10:37), Tom Lane wrote: Yeah, this is clearly a thinko: really, nothing in the planner should be using get_parse_rowmark(). I looked around for other errors of the same type and found that postgresGetForeign

Re: [HACKERS] 9.5: Better memory accounting, towards memory-bounded HashAgg

2014-12-14 Thread Michael Paquier
On Mon, Dec 8, 2014 at 9:39 AM, Michael Paquier wrote: > On Tue, Dec 2, 2014 at 2:14 PM, Jeff Davis wrote: >> On Sun, 2014-11-30 at 17:49 -0800, Peter Geoghegan wrote: >>> On Mon, Nov 17, 2014 at 11:39 PM, Jeff Davis wrote: >>> > I can also just move isReset there, and keep mem_allocated as a ui

Re: [HACKERS] B-Tree support function number 3 (strxfrm() optimization)

2014-12-14 Thread Michael Paquier
On Wed, Dec 3, 2014 at 10:43 AM, Peter Geoghegan wrote: > On Tue, Dec 2, 2014 at 5:28 PM, Peter Geoghegan wrote: >> Attached, revised patchset makes these updates. > > Whoops. Missed some obsolete comments. Here is a third commit that > makes a further small modification to one comment. Moving th

Re: [HACKERS] On partitioning

2014-12-14 Thread Amit Langote
Alvaro wrote: > Claudio Freire wrote: > > > Fair enough, but that's not the same as not requiring easy proofs. The > > planner might not the one doing the proofs, but you still need proofs. > > > > Even if the proving method is hardcoded into the partitioning method, > > as in the case of list or

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-14 Thread Michael Paquier
On Fri, Dec 12, 2014 at 6:39 AM, Robert Haas wrote: > It's probably something we should add, but there's enough to do > getting the basic feature working first. Moving this patch to CF 2014-12 as work is still going on. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq

Re: [HACKERS] moving from contrib to bin

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 10:59 AM, Peter Eisentraut wrote: > - no Windows build system support yet Do you need some help here? I am getting worried about potential breakage with the version information built with MSVC and MinGW.. > - We have traditionally kept an individual author acknowledgement

Re: [HACKERS] pgcrypto: PGP signatures

2014-12-14 Thread Michael Paquier
On Wed, Nov 12, 2014 at 7:05 AM, Jeff Janes wrote: > On Sat, Nov 1, 2014 at 7:52 AM, Marko Tiikkaja wrote: >> >> Hi, >> >> I discovered a problem with the lack of MDC handling in the signature info >> extraction code, so I've fixed that and added a test message. v9 here. >> >> >> > > Hi Marko, >

Re: [HACKERS] moving from contrib to bin

2014-12-14 Thread Peter Eisentraut
Here is a patch series to move pg_archivecleanup pg_standby pg_test_fsync pg_test_timing pg_upgrade pg_xlogdump pgbench from contrib/ to src/bin/. Move people didn't like moving oid2name and vacuumlo, which I understand. So I'll leave those for now. I have also included a patch to move pg_upgr

Re: [HACKERS] KNN-GiST with recheck

2014-12-14 Thread Michael Paquier
On Tue, Jan 28, 2014 at 10:54 PM, Heikki Linnakangas wrote: > 1. This patch introduces a new "polygon <-> point" operator. That seems > useful on its own, with or without this patch. This patch is tracked with this entry in the commit fest app and is marked as "Ready for committer". Hence I am mov

Re: [HACKERS] GiST kNN search queue (Re: KNN-GiST with recheck)

2014-12-14 Thread Michael Paquier
On Thu, Dec 11, 2014 at 12:50 AM, Heikki Linnakangas wrote: > On 01/28/2014 04:12 PM, Alexander Korotkov wrote: >>> >>> >3. A binary heap would be a better data structure to buffer the >>> > rechecked >>> >values. A Red-Black tree allows random insertions and deletions, but in >>> >this case you n

Re: [HACKERS] inherit support for foreign tables

2014-12-14 Thread Michael Paquier
On Thu, Dec 11, 2014 at 2:54 PM, Ashutosh Bapat wrote: > On Thu, Dec 11, 2014 at 8:39 AM, Etsuro Fujita > wrote: >> >> Hi Ashutosh, >> >> Thanks for the review! >> >> (2014/12/10 14:47), Ashutosh Bapat wrote: >>> >>> We haven't heard anything from Horiguchi-san and Hanada-san for almost a >>> wee

Re: [HACKERS] Final Patch for GROUPING SETS

2014-12-14 Thread Michael Paquier
On Thu, Dec 11, 2014 at 3:36 AM, Tom Lane wrote: > I don't really have any comments on the algorithms yet, having spent too > much time trying to figure out underdocumented data structures to get to > the algorithms. However, noting the addition of list_intersection_int() > made me wonder whether

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-12-14 Thread Michael Paquier
On Tue, Dec 9, 2014 at 2:52 AM, Peter Geoghegan wrote: > On Mon, Dec 8, 2014 at 9:43 AM, Peter Geoghegan wrote: >> I think it's very possible that the wrong alias may be provided by the >> user, and that we should consider that when providing a hint. > > Note that the existing mechanism (the mech

Re: [HACKERS] Status of CF 2014-10 and upcoming 2014-12

2014-12-14 Thread Michael Paquier
On Sun, Dec 14, 2014 at 12:29 AM, Andrew Dunstan wrote: >> Opinions? > I will look at clearing out a few of the Ready For Committer patches today > and tomorrow. Thank you. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: ht

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-14 Thread Amit Kapila
On Mon, Dec 15, 2014 at 5:39 AM, Tom Lane wrote: > > Amit Kapila writes: > >> On Sat, Dec 13, 2014 at 10:48 PM, Tom Lane wrote: > >>> 1. The patch is completely naive about what might be in the symlink > >>> path string; eg embedded spaces in the path would break it. On at > >>> least some plat

Re: [HACKERS] DROP PRIVILEGES OWNED BY

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 9:43 AM, Marko Tiikkaja wrote: > Hi, > > This week I had a problem where I wanted to drop only the privileges a > certain role had in the system, while keeping all the objects. I couldn't > figure out a reasonable way to do that, so I've attached a patch for this to > this

[HACKERS] DROP PRIVILEGES OWNED BY

2014-12-14 Thread Marko Tiikkaja
Hi, This week I had a problem where I wanted to drop only the privileges a certain role had in the system, while keeping all the objects. I couldn't figure out a reasonable way to do that, so I've attached a patch for this to this email. Please consider it for inclusion into 9.5. The synta

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-14 Thread Andrew Dunstan
On 12/14/2014 07:09 PM, Tom Lane wrote: Amit Kapila writes: On Sat, Dec 13, 2014 at 10:48 PM, Tom Lane wrote: 1. The patch is completely naive about what might be in the symlink path string; eg embedded spaces in the path would break it. On at least some platforms, newlines could be in the

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-14 Thread Tom Lane
Amit Kapila writes: >> On Sat, Dec 13, 2014 at 10:48 PM, Tom Lane wrote: >>> 1. The patch is completely naive about what might be in the symlink >>> path string; eg embedded spaces in the path would break it. On at >>> least some platforms, newlines could be in the path as well. I'm not >>> sur

Re: [HACKERS] Custom timestamp format in logs

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 3:16 AM, Tom Lane wrote: > You could argue that pgBadger et al could just document that they don't > support nonstandard timestamp formats ... but then it's really unclear why > we're shifting the complexity burden in this direction rather than asking > why the one propriet

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2014-12-14 Thread Ali Akbar
2014-12-14 22:18 GMT+07:00 Ali Akbar : > > > I ran a test using postgres-US.fo built in the PostgreSQL source tree, >> which is 38 MB, and ran >> >> select unnest(xpath('//fo:bookmark-title', b, array[array['fo', >> 'http://www.w3.org/1999/XSL/Format']])) from data; >> >> (Table contains one row on

Re: [HACKERS] Custom timestamp format in logs

2014-12-14 Thread Michael Paquier
On Mon, Dec 15, 2014 at 1:36 AM, Magnus Hagander wrote: > On Sat, Dec 13, 2014 at 3:50 PM, Michael Paquier > wrote: >> >> Hi all, >> >> This week, we heard about a user willing to use a custom timestamp >> format across a set of services to improve the debugability of the >> whole set, Postgres b

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Mark Cave-Ayland
On 14/12/14 20:07, Craig Ringer wrote: > On 12/15/2014 02:46 AM, Mark Cave-Ayland wrote: >> Interestingly enough, I tend to work in a very similar way to this. When >> submitting patches upstream, I tend to rebase on a new branch and then >> squash/rework as required. > > Same here, and I find it

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Craig Ringer
On 12/15/2014 02:46 AM, Mark Cave-Ayland wrote: > Interestingly enough, I tend to work in a very similar way to this. When > submitting patches upstream, I tend to rebase on a new branch and then > squash/rework as required. Same here, and I find it works really well ... when I do it properly. I

Re: [HACKERS] BRIN range operator class

2014-12-14 Thread Emre Hasegeli
> I thought we can do better than minmax for the inet data type, > and ended up with a generalized opclass supporting both inet and range > types. Patch based on minmax-v20 attached. It works well except > a few small problems. I will improve the patch and add into > a commitfest after BRIN fram

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Mark Cave-Ayland
On 14/12/14 18:24, Peter Geoghegan wrote: > On Sun, Dec 14, 2014 at 9:05 AM, Tom Lane wrote: >> TBH, I'm not really on board with this line of argument. I don't find >> broken-down patches to be particularly useful for review purposes. An >> example I was just fooling with this week is the GROU

Re: [HACKERS] proposal: plpgsql - Assert statement

2014-12-14 Thread Pavel Stehule
2014-12-14 18:57 GMT+01:00 Alvaro Herrera : > > Pavel Stehule wrote: > > Hi > > > > any comments to last proposal and patch? > > WTH is that pstrdup("hint is null") thing? Debugging leftover? > No, only not well error message. I propose a syntax ASSERT boolean_expression [, text expression ] -- t

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Mark Cave-Ayland
On 14/12/14 17:30, Andrew Dunstan wrote: > On 12/14/2014 12:05 PM, Tom Lane wrote: >> Craig Ringer writes: >>> On 12/14/2014 10:35 PM, Mark Cave-Ayland wrote: Compare this to say, for example, huge patches such as RLS. >>> I specifically objected to that being flattened into a single monster

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Peter Geoghegan
On Sun, Dec 14, 2014 at 9:05 AM, Tom Lane wrote: > TBH, I'm not really on board with this line of argument. I don't find > broken-down patches to be particularly useful for review purposes. An > example I was just fooling with this week is the GROUPING SETS patch, > which was broken into three s

Re: [HACKERS] Custom timestamp format in logs

2014-12-14 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> TBH, my answer to the rhetorical question is "no". There is nothing >> weird about the timestamps %t emits now, and no reason why they should >> need to be configurable, except that somebody thinks it's easier to >> lobby us to complicate our software t

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Mark Cave-Ayland
On 14/12/14 17:05, Tom Lane wrote: > Craig Ringer writes: >> On 12/14/2014 10:35 PM, Mark Cave-Ayland wrote: >>> Compare this to say, for example, huge patches such as RLS. > >> I specifically objected to that being flattened into a single monster >> patch when I saw that'd been done. If you loo

Re: [HACKERS] proposal: plpgsql - Assert statement

2014-12-14 Thread Alvaro Herrera
Pavel Stehule wrote: > Hi > > any comments to last proposal and patch? WTH is that pstrdup("hint is null") thing? Debugging leftover? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers

Re: [HACKERS] Custom timestamp format in logs

2014-12-14 Thread Alvaro Herrera
Tom Lane wrote: > Magnus Hagander writes: > > On Sat, Dec 13, 2014 at 3:50 PM, Michael Paquier > > wrote: > >> This week, we heard about a user willing to use a custom timestamp > >> format across a set of services to improve the debugability of the > >> whole set, Postgres being one of them. Unf

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-14 Thread Alvaro Herrera
Amit Kapila wrote: > One way to deal with this could be to append a delimiter(which is not > allowed > in tablespace path like quote (\')) at the end of tablespace path while > writing the same to symlink label file and then use that as end marker while > reading it from file. Some GNU tools such

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Andrew Dunstan
On 12/14/2014 12:05 PM, Tom Lane wrote: Craig Ringer writes: On 12/14/2014 10:35 PM, Mark Cave-Ayland wrote: Compare this to say, for example, huge patches such as RLS. I specifically objected to that being flattened into a single monster patch when I saw that'd been done. If you look at my

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Mark Cave-Ayland
On 14/12/14 15:57, Craig Ringer wrote: > On 12/14/2014 10:35 PM, Mark Cave-Ayland wrote: > >> If I could name just one thing that I think would improve things it >> would be submission of patches to the list in git format-patch format. >> Why? Because it enables two things: 1) by definition patch

Re: [HACKERS] proposal: plpgsql - Assert statement

2014-12-14 Thread Pavel Stehule
Hi any comments to last proposal and patch? Pavel 2014-11-26 19:52 GMT+01:00 Pavel Stehule : > > Hi > > 2014-11-26 16:46 GMT+01:00 Pavel Stehule : > >> >> >> 2014-11-26 13:31 GMT+01:00 Marko Tiikkaja : >> >>> On 11/26/14 8:55 AM, Pavel Stehule wrote: >>> * should be assertions globally enab

Re: [HACKERS] Confusing comment in tidbitmap.c

2014-12-14 Thread Tom Lane
David Rowley writes: > The following comment above #define PAGES_PER_CHUNK in tibbitmap.c appears > to be incorrect: > "But we > * also want PAGES_PER_CHUNK to be a power of 2 to avoid expensive integer > * remainder operations. So, define it like this:" > I don't quite follow this as it does

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Tom Lane
Craig Ringer writes: > On 12/14/2014 10:35 PM, Mark Cave-Ayland wrote: >> Compare this to say, for example, huge patches such as RLS. > I specifically objected to that being flattened into a single monster > patch when I saw that'd been done. If you look at my part in the work on > the row securi

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Mark Cave-Ayland
On 14/12/14 15:51, Craig Ringer wrote: > On 12/14/2014 10:35 PM, Mark Cave-Ayland wrote: >> Compare this to say, for example, huge patches such as RLS. > > I specifically objected to that being flattened into a single monster > patch when I saw that'd been done. If you look at my part in the work

Re: [HACKERS] Custom timestamp format in logs

2014-12-14 Thread Tom Lane
Magnus Hagander writes: > On Sat, Dec 13, 2014 at 3:50 PM, Michael Paquier > wrote: >> This week, we heard about a user willing to use a custom timestamp >> format across a set of services to improve the debugability of the >> whole set, Postgres being one of them. Unfortunately datestyle does >>

Re: [HACKERS] Custom timestamp format in logs

2014-12-14 Thread Magnus Hagander
On Sat, Dec 13, 2014 at 3:50 PM, Michael Paquier wrote: > > Hi all, > > This week, we heard about a user willing to use a custom timestamp > format across a set of services to improve the debugability of the > whole set, Postgres being one of them. Unfortunately datestyle does > not take into acco

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Craig Ringer
On 12/14/2014 10:35 PM, Mark Cave-Ayland wrote: > If I could name just one thing that I think would improve things it > would be submission of patches to the list in git format-patch format. > Why? Because it enables two things: 1) by definition patches are > "small-chunked" into individually revi

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Craig Ringer
On 12/14/2014 10:35 PM, Mark Cave-Ayland wrote: > Compare this to say, for example, huge patches such as RLS. I specifically objected to that being flattened into a single monster patch when I saw that'd been done. If you look at my part in the work on the row security patch, while I was ultimatel

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-14 Thread Amit Kapila
On Sun, Dec 14, 2014 at 11:54 AM, Amit Kapila wrote: > > On Sat, Dec 13, 2014 at 10:48 PM, Tom Lane wrote: > > > > Andrew Dunstan writes: > > > On 11/20/2014 02:27 AM, Amit Kapila wrote: > > >> Now the part where I would like to receive feedback before revising the > > >> patch is on the coding

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2014-12-14 Thread Ali Akbar
> > I ran a test using postgres-US.fo built in the PostgreSQL source tree, > which is 38 MB, and ran > > select unnest(xpath('//fo:bookmark-title', b, array[array['fo', > 'http://www.w3.org/1999/XSL/Format']])) from data; > > (Table contains one row only.) > > The timings were basically indistingui

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 > #2 is solved by my previous comments about giving the CFM/C the > authority. -Core could do that, they are in charge of release. I don't think authority is the solution. Or certainly not one that would work with an open source project like

Re: [HACKERS] Commitfest problems

2014-12-14 Thread Mark Cave-Ayland
On 13/12/14 09:37, Craig Ringer wrote: >> Speaking as the originator of commitfests, they were *always* intended >> to be a temporary measure, a step on the way to something else like >> continuous integration. > > I'd really like to see the project revisit some of the underlying > assumptions th

Re: [HACKERS] speedup tidbitmap patch: cache page

2014-12-14 Thread David Rowley
On 23 October 2014 at 00:52, Teodor Sigaev wrote: > > In specific workload postgres could spend a lot of time in > tbm_add_tuples, up to 50% of query time. hash_search call is expensive and > called twice for each ItemPointer to insert. Suggested patch tries to cache > last PagetableEntry pointer

[HACKERS] Confusing comment in tidbitmap.c

2014-12-14 Thread David Rowley
The following comment above #define PAGES_PER_CHUNK in tibbitmap.c appears to be incorrect: "But we * also want PAGES_PER_CHUNK to be a power of 2 to avoid expensive integer * remainder operations. So, define it like this:" I don't quite follow this as it does nothing of the kind. Check tbm_pa