Re: [HACKERS] copy.c handling for RLS is insecure

2014-11-26 Thread Stephen Frost
Robert, * Stephen Frost (sfr...@snowman.net) wrote: > * Robert Haas (robertmh...@gmail.com) wrote: > > In DoCopy, some RLS-specific code constructs a SelectStmt to handle > > the case where COPY TO is invoked on an RLS-protected relation. But I > > think this step is bogus in two ways: > > > >

Re: [HACKERS] OCLASS_ROWSECURITY oversights, and other kvetching

2014-11-26 Thread Stephen Frost
Robert, all, Apologies for this taking so long, it was a bit bigger than I had anticipated and other things were going on also, as happens. * Stephen Frost (sfr...@snowman.net) wrote: > * Robert Haas (robertmh...@gmail.com) wrote: > > The RLS patch added OCLASS_ROWSECURITY but it seems that not e

Re: [HACKERS] What exactly is our CRC algorithm?

2014-11-26 Thread Abhijit Menon-Sen
At 2014-11-26 18:56:52 -0500, br...@momjian.us wrote: > > I would test it with fsync=off to remove the fsync delay. That will > simulate an SSD or BBU controller. The earlier tests were run with fsync=off. I ran another round of the replay tests on the i7 server, this time replaying 30GB of WAL

Re: [HACKERS] Compiling C++ extensions on MSVC using scripts in src/tools

2014-11-26 Thread Michael Paquier
On Thu, Nov 27, 2014 at 1:40 AM, Tom Lane wrote: > Andrew Dunstan writes: >> This doesn't seem to me to be terribly well expressed (I know it's not your >> fault, quite possibly it's mine.) Perhaps we should replace >> [r]?[cyl](pp)? >> with >> (c|cpp|y|l|rc) > > +1 ... the original codi

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-11-26 Thread Michael Paquier
On Thu, Nov 27, 2014 at 12:55 AM, Sawada Masahiko wrote: > +1 to define new something object type and remove do_user and do_system. > But if we add OBJECT_SYSTEM to ObjectType data type, > system catalogs are OBJECT_SYSTEM as well as OBJECT_TABLE. > It's a bit redundant? Yes, kind of. That's a sup

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-11-26 Thread Michael Paquier
On Wed, Nov 26, 2014 at 8:27 PM, Syed, Rahila wrote: > Don't we need to initialize doPageCompression similar to doPageWrites in > InitXLOGAccess? Yep, you're right. I missed this code path. > Also , in the earlier patches compression was set 'on' even when fpw GUC is > 'off'. This was to facil

Re: [HACKERS] bug in json_to_record with arrays

2014-11-26 Thread Josh Berkus
On 11/26/2014 12:48 PM, Tom Lane wrote: > Wouldn't it be better if it said > > ERROR: invalid input syntax for array: "["potter","chef","programmer"]" > DETAIL: Dimension value is missing. > > which is comparable to what you'd get out of most other input functions > that were feeling i

Re: [HACKERS] The problems of PQhost()

2014-11-26 Thread Noah Misch
On Tue, Nov 25, 2014 at 09:53:10PM +0900, Fujii Masao wrote: > On Tue, Nov 25, 2014 at 12:37 PM, Noah Misch wrote: > > On Wed, Jan 22, 2014 at 11:48:26PM +0900, Fujii Masao wrote: > >> (3) PQhost() cannot return the hostaddr. > > > >> We can fix the problem (3) by changing PQhost() so that it also

Re: [HACKERS] Add shutdown_at_recovery_target option to recovery.conf

2014-11-26 Thread Fujii Masao
On Wed, Nov 26, 2014 at 5:15 AM, Simon Riggs wrote: > On 25 November 2014 at 14:06, Fujii Masao wrote: >> On Thu, Nov 20, 2014 at 5:35 AM, Simon Riggs wrote: >>> On 19 November 2014 16:41, Fujii Masao wrote: On Wed, Nov 19, 2014 at 10:49 PM, Robert Haas wrote: > On Wed, Nov 19,

Re: [HACKERS] dblink_get_connections() result for no connections

2014-11-26 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/25/2014 12:49 PM, Tom Lane wrote: > While fooling around with the array_agg(anyarray) patch, I noted > that dblink_get_connections() returns NULL if there are no active > connections. It seems like an empty array might be a saner > definition

Re: [HACKERS] Add shutdown_at_recovery_target option to recovery.conf

2014-11-26 Thread Michael Paquier
On Wed, Nov 26, 2014 at 7:10 PM, Christoph Berg wrote: > Re: Petr Jelinek 2014-11-25 <5474efea.2040...@2ndquadrant.com> >> >Patch committed. >> >> Thanks! > > I'm a bit late to the party, but wouldn't > > recovery_target_action = ... > > have been a better name for this? It'd be in line with the o

Re: [HACKERS] Add CREATE support to event triggers

2014-11-26 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Bruce Momjian wrote: > > How would replicating DDL handle cases where the master and slave > > servers have different major versions and the DDL is only supported by > > the Postgres version on the master server? > > Normally you would replicate

Re: [HACKERS] Add CREATE support to event triggers

2014-11-26 Thread Alvaro Herrera
Bruce Momjian wrote: > On Sat, Nov 8, 2014 at 05:56:00PM +0100, Andres Freund wrote: > > On 2014-11-08 11:52:43 -0500, Tom Lane wrote: > > > Adding a similar level of burden to support a feature with a > > > narrow use-case seems like a nonstarter from here. > > > > I don't understand this statem

Re: [HACKERS] Add CREATE support to event triggers

2014-11-26 Thread Bruce Momjian
On Sat, Nov 8, 2014 at 05:56:00PM +0100, Andres Freund wrote: > On 2014-11-08 11:52:43 -0500, Tom Lane wrote: > > Adding a similar > > level of burden to support a feature with a narrow use-case seems like > > a nonstarter from here. > > I don't understand this statement. In my experience the lac

Re: [HACKERS] memory explosion on planning complex query

2014-11-26 Thread Andrew Dunstan
On 11/26/2014 05:00 PM, Andrew Dunstan wrote: Attached is some anonymized DDL for a fairly complex schema from a PostgreSQL Experts client. Also attached is an explain query that runs against the schema. The client's problem is that in trying to run the explain, Postgres simply runs out of m

Re: [HACKERS] 9.2 recovery/startup problems

2014-11-26 Thread Jeff Janes
On Tue, Nov 25, 2014 at 9:30 PM, Jeff Janes wrote: > Using both 9.2.9 and 9_2_STABLE 9b468bcec15f1ea7433d4, I get a fairly > reproducible startup failure. > > What I was doing is restore a database from a base backup and roll it > forward with a recovery.conf until it completes and starts up. Th

Re: [HACKERS] What exactly is our CRC algorithm?

2014-11-26 Thread Bruce Momjian
On Fri, Nov 21, 2014 at 07:49:45AM -0600, k...@rice.edu wrote: > Hi, > > This indicates that another part of the system is the resource limit, > not the CRC calculation. My money is on the I/O system. Try it using > an in memory filesystem and see if that matters. Even if it is still > the same re

Re: [HACKERS] 9.2 recovery/startup problems

2014-11-26 Thread Michael Paquier
On Thu, Nov 27, 2014 at 4:29 AM, Jeff Janes wrote: > pg_xlogdump doesn't exist yet in 9.2 (or can I use a newer one against the > older files?). Not sure if pg_xlogdump would work (9.5 not for sure, 9.4 should partially, 9.3 has better chances), but you could try this one as well that is compatib

Re: [HACKERS] Maximum number of WAL files in the pg_xlog directory

2014-11-26 Thread Bruce Momjian
On Mon, Nov 3, 2014 at 12:39:26PM -0800, Jeff Janes wrote: > It looked to me that the formula, when descending from a previously stressed > state, would be: > > greatest(1 + checkpoint_completion_target) * checkpoint_segments, > wal_keep_segments) + 1 +  > 2 * checkpoint_segments + 1  I don't th

Re: [HACKERS] bug in json_to_record with arrays

2014-11-26 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> As far as your request for a better error message is concerned, I'm a >> bit inclined to lay the blame on array_in rather than the JSON code. >> Wouldn't it be better if it said >> >> ERROR: invalid input syntax for array: "["pott

Re: [HACKERS] memory explosion on planning complex query

2014-11-26 Thread Andrew Dunstan
On 11/26/2014 05:26 PM, Peter Geoghegan wrote: On Wed, Nov 26, 2014 at 2:00 PM, Andrew Dunstan wrote: The client's question is whether this is not a bug. It certainly seems like it should be possible to plan a query without chewing up this much memory, or at least to be able to limit the amoun

Re: [HACKERS] memory explosion on planning complex query

2014-11-26 Thread Tomas Vondra
On 26.11.2014 23:26, Peter Geoghegan wrote: > On Wed, Nov 26, 2014 at 2:00 PM, Andrew Dunstan wrote: >> The client's question is whether this is not a bug. It certainly seems like >> it should be possible to plan a query without chewing up this much memory, >> or at least to be able to limit the a

Re: [HACKERS] memory explosion on planning complex query

2014-11-26 Thread Antonin Houska
On 11/26/2014 11:00 PM, Andrew Dunstan wrote: > > Attached is some anonymized DDL for a fairly complex schema from a > PostgreSQL Experts client. Also attached is an explain query that runs > against the schema. The client's problem is that in trying to run the > explain, Postgres simply runs o

Re: [HACKERS] memory explosion on planning complex query

2014-11-26 Thread Peter Geoghegan
On Wed, Nov 26, 2014 at 2:00 PM, Andrew Dunstan wrote: > The client's question is whether this is not a bug. It certainly seems like > it should be possible to plan a query without chewing up this much memory, > or at least to be able to limit the amount of memory that can be grabbed > during plan

Re: [HACKERS] bug in json_to_record with arrays

2014-11-26 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > As far as your request for a better error message is concerned, I'm a > bit inclined to lay the blame on array_in rather than the JSON code. > Wouldn't it be better if it said > > ERROR: invalid input syntax for array: "["potter","chef","programmer"]"

Re: [HACKERS] bug in json_to_record with arrays

2014-11-26 Thread Andrew Dunstan
On 11/26/2014 03:48 PM, Tom Lane wrote: Arguably, populate_record_worker should be smart enough to convert somehow, but it isn't today. Looks to me like it wouldn't succeed for the comparable case of converting a sub-object to a Postgres composite type, either. I'm satisfied with regarding tho

Re: [HACKERS] 9.2 recovery/startup problems

2014-11-26 Thread Andres Freund
Hi, On 2014-11-26 11:29:09 -0800, Jeff Janes wrote: > On Wed, Nov 26, 2014 at 5:06 AM, Alvaro Herrera > wrote: > > > Jeff Janes wrote: > > > > > This is what I get in the log from the attempted restart: > > > > > > PST LOG: database system was interrupted; last known up at 2014-11-25 > > > 15:4

Re: [HACKERS] bug in json_to_record with arrays

2014-11-26 Thread Tom Lane
Josh Berkus writes: > On 11/26/2014 11:54 AM, Josh Berkus wrote: >> Tested on 9.4b3, 9.4rc1, 9.5devel >> >> select * from json_to_record(' >> {"id":1,"val":"josh","valry":["potter","chef","programmer"]}') as r(id >> int, val text, valry text[]); >> >> ERROR: missing dimension value >> >> With

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Peter Eisentraut
On 11/26/14 3:42 PM, Palle Girgensohn wrote: > >> 26 nov 2014 kl. 20:42 skrev Peter Eisentraut : >> >> (A build >> option and a more explicit warning might be nice.) > > In the freebsd ports, it is an option, default is off. :-) That's even better. Sorry, I looked at the port sources and could

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Palle Girgensohn
> 26 nov 2014 kl. 20:42 skrev Peter Eisentraut : > > (A build > option and a more explicit warning might be nice.) In the freebsd ports, it is an option, default is off. :-) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www

Re: [HACKERS] GSSAPI, SSPI - include_realm default

2014-11-26 Thread Stephen Frost
* Magnus Hagander (mag...@hagander.net) wrote: > On Wed, Nov 26, 2014 at 8:01 PM, Stephen Frost wrote: > > This would be done for 9.5 and we would need to note it in the release > > notes, of course. > > I suggest we also backpatch some documentation suggesting that people > manually change t

Re: [HACKERS] GSSAPI, SSPI - include_realm default

2014-11-26 Thread Magnus Hagander
On Wed, Nov 26, 2014 at 8:01 PM, Stephen Frost wrote: > Greetings, > > The include_realm default for GSSAPI and SSPI is currently > 'include_realm=0', meaning that the realm is stripped off of the > Kerberos principal (aka the 'system' username) prior to looking up the > user in pg_authid.

Re: [HACKERS] bug in json_to_record with arrays

2014-11-26 Thread Josh Berkus
On 11/26/2014 11:54 AM, Josh Berkus wrote: > Tested on 9.4b3, 9.4rc1, 9.5devel > > select * from json_to_record(' > {"id":1,"val":"josh","valry":["potter","chef","programmer"]}') as r(id > int, val text, valry text[]); > > ERROR: missing dimension value > > With some experimentation, I can't fi

[HACKERS] bug in json_to_record with arrays

2014-11-26 Thread Josh Berkus
Tested on 9.4b3, 9.4rc1, 9.5devel select * from json_to_record(' {"id":1,"val":"josh","valry":["potter","chef","programmer"]}') as r(id int, val text, valry text[]); ERROR: missing dimension value With some experimentation, I can't find any way to convert a JSON array to an array field using js

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Peter Eisentraut
On 11/26/14 9:27 AM, Alvaro Herrera wrote: > I haven't done anything about documentation. I thought a new chapter > after "Additional Supplied Modules", perhaps entitled "Additional Sample > Modules" would be appropriate. I would remove the SGML files and put simple README files into each directo

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Peter Eisentraut
On 11/26/14 12:46 PM, Peter Geoghegan wrote: > On Wed, Nov 26, 2014 at 2:05 AM, Dave Page wrote: >> You may want to bear in mind that postgres.app is on the main PG >> downloads page on the website. If you're patching Postgres to add a >> feature like this, it would become a fork and would have to

Re: [HACKERS] 9.2 recovery/startup problems

2014-11-26 Thread Jeff Janes
On Wed, Nov 26, 2014 at 5:06 AM, Alvaro Herrera wrote: > Jeff Janes wrote: > > > This is what I get in the log from the attempted restart: > > > > PST LOG: database system was interrupted; last known up at 2014-11-25 > > 15:40:33 PST > > PST LOG: database system was not properly shut down; auto

Re: [HACKERS] GSSAPI, SSPI - include_realm default

2014-11-26 Thread Stephen Frost
* Peter Eisentraut (pete...@gmx.net) wrote: > On 11/26/14 2:01 PM, Stephen Frost wrote: > > As such, I'd like to propose changing the default to be > > 'include_realm=1'. > > Sounds reasonable to me. > > include_realm is supported back to 8.4, so affected users can set > include_realm=0 in thei

Re: [HACKERS] GSSAPI, SSPI - include_realm default

2014-11-26 Thread Peter Eisentraut
On 11/26/14 2:01 PM, Stephen Frost wrote: > As such, I'd like to propose changing the default to be > 'include_realm=1'. Sounds reasonable to me. include_realm is supported back to 8.4, so affected users can set include_realm=0 in their existing installations. -- Sent via pgsql-hackers mail

[HACKERS] Caching negative lookup results in typcache.c

2014-11-26 Thread Tom Lane
In the pgsql-performance thread at http://www.postgresql.org/message-id/flat/CAOR=d=3j1U_q-zf8+jUx1hkx8ps+N8pm=EUTqyFdJ5ov=+f...@mail.gmail.com it emerged that a substantial part of the slowdown Scott saw from 8.4 to 9.2 was an unexpected consequence of the fact that the planner now considers hashi

[HACKERS] GSSAPI, SSPI - include_realm default

2014-11-26 Thread Stephen Frost
Greetings, The include_realm default for GSSAPI and SSPI is currently 'include_realm=0', meaning that the realm is stripped off of the Kerberos principal (aka the 'system' username) prior to looking up the user in pg_authid. This is fine in a single-realm environment but extremely dange

Re: [HACKERS] proposal: plpgsql - Assert statement

2014-11-26 Thread Pavel Stehule
Hi 2014-11-26 16:46 GMT+01:00 Pavel Stehule : > > > 2014-11-26 13:31 GMT+01:00 Marko Tiikkaja : > >> On 11/26/14 8:55 AM, Pavel Stehule wrote: >> >>> * should be assertions globally enabled/disabled? - I have no personal >>> preference in this question. >>> >> >> I think so. The way I would use

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2014-11-26 Thread Alex Shulgin
Alex Shulgin writes: >>> >>> I can do that too, just need a hint where to look at in libpq/psql to >>> add the option. >> >> The place to *enforce* the option is src/interfaces/libpq/fe-secure.c >> (look for SSLv23_method() and SSL_CTX_set_options()). I haven't looked >> into how to set it. > > Y

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Alvaro Herrera
Robert Haas wrote: > On Wed, Nov 26, 2014 at 9:27 AM, Alvaro Herrera > wrote: > > Because many of them had either "test" in their names or some other > > now-useless particle, I renamed them: > > > > worker_spi -> bgworker > > test_decoding -> logical_decoding > > dummy_seclabel

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Peter Geoghegan
On Wed, Nov 26, 2014 at 2:05 AM, Dave Page wrote: > You may want to bear in mind that postgres.app is on the main PG > downloads page on the website. If you're patching Postgres to add a > feature like this, it would become a fork and would have to be moved > out of the "PostgreSQL Core Distributi

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Peter Geoghegan
On Wed, Nov 26, 2014 at 6:21 AM, Greg Stark wrote: > There were a number of problems with using ICU including the large > dependency and the limitations of the iterator model but the main > issue was that it's fundamentally a choice between being consistent > with every other application on your s

Re: [HACKERS] [BUGS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON

2014-11-26 Thread Andrew Dunstan
On 11/26/2014 11:48 AM, Andrew Dunstan wrote: In json.c we now check numbers like this: JsonLexContext dummy_lex; boolnumeric_error; ... dummy_lex.input = *outputstr == '-' ? outputstr + 1 : outputstr; dummy_lex.input_length = strlen(dummy_lex.input); json_lex_numb

Re: [HACKERS] [BUGS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON

2014-11-26 Thread Andrew Dunstan
On 11/26/2014 11:19 AM, Tom Lane wrote: bo...@edookit.com writes: The hstore_to_json_loose(hstore) produces an invalid JSON in the following case: SELECT hstore_to_json_loose(hstore(ARRAY ['name'], ARRAY ['1.'] :: TEXT [])) Output: {"name": 1.} The actual output is indeed incorrect as JSON does

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Geoff Montee
On Wed, Nov 26, 2014 at 10:17 AM, Palle Girgensohn wrote: > > > > 26 nov 2014 kl. 14:06 skrev Palle Girgensohn : > > > > Well, this discussion actually pushes the priority quite a bit for me -- > > someone else actually beeing interested about the patch... I thought it was > > just me... :)= > >

Re: [HACKERS] Compiling C++ extensions on MSVC using scripts in src/tools

2014-11-26 Thread Tom Lane
Andrew Dunstan writes: > This doesn't seem to me to be terribly well expressed (I know it's not your > fault, quite possibly it's mine.) Perhaps we should replace > [r]?[cyl](pp)? > with > (c|cpp|y|l|rc) +1 ... the original coding is illegible already, not to mention wrong since it will

Re: [HACKERS] Compiling C++ extensions on MSVC using scripts in src/tools

2014-11-26 Thread Andrew Dunstan
On 11/25/2014 11:46 PM, Michael Paquier wrote: Hi all, In the stuff I work on in a daily basis there are a couple of extensions written in C++, compiling them with MSVC on Windows using slightly-different scripts available in src/tools after copying them directly in contrib/. However, the build

Re: [HACKERS] [BUGS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON

2014-11-26 Thread Tom Lane
bo...@edookit.com writes: > The hstore_to_json_loose(hstore) produces an invalid JSON in the following > case: > SELECT hstore_to_json_loose(hstore(ARRAY ['name'], ARRAY ['1.'] :: TEXT > [])) > Output: {"name": 1.} > The actual output is indeed incorrect as JSON does not permit `1.` - it must >

Re: [HACKERS] Follow up to irc on CREATE INDEX vs. maintenance_work_mem on 9.3

2014-11-26 Thread Alex Shulgin
Andrew Gierth writes: >> "Alex" == Alex Shulgin writes: > > > Tom Lane writes: > >> Must've been my evil twin. > > Alex> Sorry, I must be under false impression that RhodiumToad is > Alex> *your* nick on #postgresql at freenode. I don't recall who > Alex> told me that, but I was pret

Re: [HACKERS] Proposal : REINDEX SCHEMA

2014-11-26 Thread Sawada Masahiko
On Wed, Nov 26, 2014 at 3:48 PM, Michael Paquier wrote: > On Wed, Nov 19, 2014 at 1:37 AM, Simon Riggs wrote: >> On 23 October 2014 00:21, Alvaro Herrera wrote: >> Attached patch is latest version patch I modified above. Also, I noticed I had forgotten to add the patch regarding docume

Re: [HACKERS] proposal: plpgsql - Assert statement

2014-11-26 Thread Pavel Stehule
2014-11-26 13:31 GMT+01:00 Marko Tiikkaja : > On 11/26/14 8:55 AM, Pavel Stehule wrote: > >> * should be assertions globally enabled/disabled? - I have no personal >> preference in this question. >> > > I think so. The way I would use this function is to put expensive checks > into strategic loca

Re: [HACKERS] Follow up to irc on CREATE INDEX vs. maintenance_work_mem on 9.3

2014-11-26 Thread Andrew Gierth
> "Alex" == Alex Shulgin writes: > Tom Lane writes: >> Must've been my evil twin. Alex> Sorry, I must be under false impression that RhodiumToad is Alex> *your* nick on #postgresql at freenode. I don't recall who Alex> told me that, but I was pretty sure it's you. :-p ... what Peopl

Re: [HACKERS] Follow up to irc on CREATE INDEX vs. maintenance_work_mem on 9.3

2014-11-26 Thread Tom Lane
Alex Shulgin writes: > Tom Lane writes: >> Must've been my evil twin. > Sorry, I must be under false impression that RhodiumToad is *your* nick > on #postgresql at freenode. I don't recall who told me that, but I was > pretty sure it's you. :-p That's Andrew Gierth, I believe. I'm not much fo

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Stephen Frost
* Andres Freund (and...@2ndquadrant.com) wrote: > On 2014-11-26 10:18:20 -0500, Stephen Frost wrote: > > * Andres Freund (and...@2ndquadrant.com) wrote: > > > I don't see how you read the contrary from the guidelines: > > > > The primary message should be short, factual, and avoid reference to > >

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Andres Freund
On 2014-11-26 10:18:20 -0500, Stephen Frost wrote: > * Andres Freund (and...@2ndquadrant.com) wrote: > > I don't see how you read the contrary from the guidelines: > > > The primary message should be short, factual, and avoid reference to > > > implementation details such as specific function names

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > This is pretty bulky, but really the vast majority of the changes here > > are just "git mv". > > For ease of review, is there a way to get git to show just the diffs that > *aren't* git mv? (That is, show changes in a file's content without > respect

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Stephen Frost
* Andres Freund (and...@2ndquadrant.com) wrote: > I don't see how you read the contrary from the guidelines: > > The primary message should be short, factual, and avoid reference to > > implementation details such as specific function names. "Short" means > > "should fit on one line under normal co

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Palle Girgensohn
> 26 nov 2014 kl. 14:06 skrev Palle Girgensohn : > > Well, this discussion actually pushes the priority quite a bit for me -- > someone else actually beeing interested about the patch... I thought it was > just me... :)= By "pushes the priority", I mean it gets more prioritized, in case that w

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Andres Freund
On 2014-11-26 10:08:57 -0500, Tom Lane wrote: > Alvaro Herrera writes: > > This is pretty bulky, but really the vast majority of the changes here > > are just "git mv". > > For ease of review, is there a way to get git to show just the diffs that > *aren't* git mv? (That is, show changes in a fi

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Palle Girgensohn
> 26 nov 2014 kl. 15:56 skrev Neil Tiffin : > > > On Nov 26, 2014, at 8:21 AM, Greg Stark wrote: > >> I find it hard to believe the original premise of this thread. We knew >> there were some problems with OSX and FreeBSD but surely they can't be >> completely broken? > > Ever tried to use Sp

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Andres Freund
On 2014-11-26 11:53:40 -0300, Alvaro Herrera wrote: > Stephen Frost wrote: > > * Andres Freund (and...@2ndquadrant.com) wrote: > > > On 2014-11-26 08:33:10 -0500, Stephen Frost wrote: > > > > Doesn't that argument then apply to the other messages which I pointed > > > > out in my follow-up to Andre

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > In the context at hand, I think most of the messages in question are > currently phrased like "must be superuser to do X". I'd be fine with > changing that to "permission denied to do X", but not to just > "permission denied". Apologies for the terseness o

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Palle Girgensohn
> 26 nov 2014 kl. 15:21 skrev Greg Stark : > > I find it hard to believe the original premise of this thread. We knew > there were some problems with OSX and FreeBSD but surely they can't be > completely broken? What happens if you run "ls" with your locale set > to something like fr_FR.UTF8 ? Do

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Tom Lane
Alvaro Herrera writes: > This is pretty bulky, but really the vast majority of the changes here > are just "git mv". For ease of review, is there a way to get git to show just the diffs that *aren't* git mv? (That is, show changes in a file's content without respect to its having moved?)

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Tom Lane
Alvaro Herrera writes: > Stephen Frost wrote: >> * Andres Freund (and...@2ndquadrant.com) wrote: >>> On 2014-11-26 08:33:10 -0500, Stephen Frost wrote: Doesn't that argument then apply to the other messages which I pointed out in my follow-up to Andres, where the detailed info is in the

Re: [HACKERS] Follow up to irc on CREATE INDEX vs. maintenance_work_mem on 9.3

2014-11-26 Thread Alex Shulgin
Tom Lane writes: > Stephen Frost writes: >> * Alex Shulgin (a...@commandprompt.com) wrote: >>> Tom, >>> >>> First of all, thanks for your help on IRC last time with that CREATE >>> INDEX memory consumption problem. > >> Doubt it was Tom, but if it was, wanna share what channel on IRC it was? >

[HACKERS] [PATCH] explain sortorder

2014-11-26 Thread Timmer, Marius
Hello everyone, For creating indexes on more than one column, it is useful to know the sort order of each sort key. So now, if you run EXPLAIN in VERBOSE mode, you get the sort order information in the order the sort keys are displayed - Lukas - This patch is meant for discussion - It’s against

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Neil Tiffin
On Nov 26, 2014, at 8:21 AM, Greg Stark wrote: > I find it hard to believe the original premise of this thread. We knew > there were some problems with OSX and FreeBSD but surely they can't be > completely broken? Ever tried to use Spotlight for searching (English) on the Mac, not completely b

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Alvaro Herrera
Stephen Frost wrote: > * Andres Freund (and...@2ndquadrant.com) wrote: > > On 2014-11-26 08:33:10 -0500, Stephen Frost wrote: > > > Doesn't that argument then apply to the other messages which I pointed > > > out in my follow-up to Andres, where the detailed info is in the hint > > > and the main e

Re: [HACKERS] Follow up to irc on CREATE INDEX vs. maintenance_work_mem on 9.3

2014-11-26 Thread Tom Lane
Stephen Frost writes: > * Alex Shulgin (a...@commandprompt.com) wrote: >> Tom, >> >> First of all, thanks for your help on IRC last time with that CREATE >> INDEX memory consumption problem. > Doubt it was Tom, but if it was, wanna share what channel on IRC it was? > :D Must've been my evil twi

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Stephen Frost
* Andres Freund (and...@2ndquadrant.com) wrote: > On 2014-11-26 08:33:10 -0500, Stephen Frost wrote: > > Doesn't that argument then apply to the other messages which I pointed > > out in my follow-up to Andres, where the detailed info is in the hint > > and the main error message is essentially 'pe

[HACKERS] Re: [GENERAL] issue in postgresql 9.1.3 in using arrow key in Solaris platform

2014-11-26 Thread Adrian Klaver
On 11/26/2014 02:16 AM, M Tarkeshwar Rao wrote: Hi all, We are facing following issue in postgresql 9.1.3 in using arrow key in Solaris platform. *Can you please help us to resolve it or any new release has fix for this or any workaround for this?* Would seem to me to be an interaction betwee

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Alvaro Herrera
This is pretty bulky, but really the vast majority of the changes here are just "git mv". -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services test_modules.patch.gz Description: application/gzip -- Sent via pgsql-hackers mailin

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Fabrízio de Royes Mello
On Wed, Nov 26, 2014 at 12:27 PM, Alvaro Herrera wrote: > > Here's a patch. This creates a new subdir src/test/modules and places > the five initially proposed modules in there. They continue to have > their makefile with the same ifdef USE_PGXS pattern; they are no longer > installed by default

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Robert Haas
On Wed, Nov 26, 2014 at 9:27 AM, Alvaro Herrera wrote: > Here's a patch. This creates a new subdir src/test/modules and places > the five initially proposed modules in there. They continue to have > their makefile with the same ifdef USE_PGXS pattern; they are no longer > installed by default. >

Re: [HACKERS] no test programs in contrib

2014-11-26 Thread Alvaro Herrera
Here's a patch. This creates a new subdir src/test/modules and places the five initially proposed modules in there. They continue to have their makefile with the same ifdef USE_PGXS pattern; they are no longer installed by default. Because many of them had either "test" in their names or some ot

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Greg Stark
I find it hard to believe the original premise of this thread. We knew there were some problems with OSX and FreeBSD but surely they can't be completely broken? What happens if you run "ls" with your locale set to something like fr_FR.UTF8 ? Does Apple not sell Macs in countries other than the US?

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Andres Freund
On 2014-11-26 08:33:10 -0500, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: > > On Sun, Nov 23, 2014 at 3:38 PM, Andres Freund > > wrote: > > >> I'm not really particular about which way we go with the specific > > >> wording (suggestions welcome..) but the inconsistency sho

Re: [HACKERS] Follow up to irc on CREATE INDEX vs. maintenance_work_mem on 9.3

2014-11-26 Thread Stephen Frost
Alex, * Alex Shulgin (a...@commandprompt.com) wrote: > Tom, > > First of all, thanks for your help on IRC last time with that CREATE > INDEX memory consumption problem. Doubt it was Tom, but if it was, wanna share what channel on IRC it was? :D > Now my question, is it feasible to back-patch th

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: > On Sun, Nov 23, 2014 at 3:38 PM, Andres Freund wrote: > >> I'm not really particular about which way we go with the specific > >> wording (suggestions welcome..) but the inconsistency should be dealt > >> with. > > > > Meh. > > +1 for "meh". I don't

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Palle Girgensohn
> 26 nov 2014 kl. 11:44 skrev Jakob Egger : > > >> Am 26.11.2014 um 11:20 schrieb Dave Page : >> >> On Wed, Nov 26, 2014 at 10:13 AM, Jakob Egger wrote: >>> Am 26.11.2014 um 11:05 schrieb Dave Page : >>> >>> You may want to bear in mind that postgres.app is on the main PG >>> downloads page o

Re: [HACKERS] 9.2 recovery/startup problems

2014-11-26 Thread Alvaro Herrera
Jeff Janes wrote: > This is what I get in the log from the attempted restart: > > PST LOG: database system was interrupted; last known up at 2014-11-25 > 15:40:33 PST > PST LOG: database system was not properly shut down; automatic recovery in > progress > PST LOG: redo starts at 84/EF80 >

Re: [HACKERS] superuser() shortcuts

2014-11-26 Thread Robert Haas
On Sun, Nov 23, 2014 at 3:38 PM, Andres Freund wrote: >> I'm not really particular about which way we go with the specific >> wording (suggestions welcome..) but the inconsistency should be dealt >> with. > > Meh. +1 for "meh". I don't mind making things consistent if it can be done while mainta

[HACKERS] Follow up to irc on CREATE INDEX vs. maintenance_work_mem on 9.3

2014-11-26 Thread Alex Shulgin
Tom, First of all, thanks for your help on IRC last time with that CREATE INDEX memory consumption problem. As has been pointed out in a stackexchange answer to my question[1], it is indeed the limitation of pre-9.4 versions, but the limit is imposed on memtuples array, rather than total memory

Re: [HACKERS] Role Attribute Bitmask Catalog Representation

2014-11-26 Thread Stephen Frost
Adam, * Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote: > I am simply breaking this out into its own thread from the discussion on > additional role attributes ( > http://www.postgresql.org/message-id/20141015052259.gg28...@tamriel.snowman.net > ). Makes sense to me, thanks. >

Re: [HACKERS] Using RTLD_DEEPBIND to handle symbol conflicts in loaded libraries

2014-11-26 Thread Albe Laurenz
Ants Aasma wrote: > I had to make oracle_fdw work with PostgreSQL compiled using > --with-ldap. The issue there is that Oracle's client library has the > delightful property of linking against a ldap library they bundle that > has symbol conflicts with OpenLDAP. At PostgreSQL startup libldap is > l

Re: [HACKERS] proposal: plpgsql - Assert statement

2014-11-26 Thread Marko Tiikkaja
On 11/26/14 8:55 AM, Pavel Stehule wrote: * should be assertions globally enabled/disabled? - I have no personal preference in this question. I think so. The way I would use this function is to put expensive checks into strategic locations which would only run when developing locally (and ad

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Pavel Stehule
2014-11-26 9:58 GMT+01:00 Magnus Hagander : > On Wed, Nov 26, 2014 at 8:41 AM, Palle Girgensohn > wrote: > > Hi! > > > > This is indeed a very well tested patch as we've run it in production > for 8+ > > years on 20+ systems. > > > > It is not included upstreams mainly because I did ask for it to

Re: [HACKERS] PITR failing to stop before DROP DATABASE

2014-11-26 Thread Christoph Berg
Re: Heikki Linnakangas 2014-11-26 <54759bc0.4070...@vmware.com> > >Oh ok. So this is an artifact of the non-transactionality (is this a > >word?) of CREATE DATABASE. > > DROP DATABASE. CREATE DATABASE is a different story. It does similar > non-transactional tricks and has similar issues, but it's

[HACKERS] Using RTLD_DEEPBIND to handle symbol conflicts in loaded libraries

2014-11-26 Thread Ants Aasma
I had to make oracle_fdw work with PostgreSQL compiled using --with-ldap. The issue there is that Oracle's client library has the delightful property of linking against a ldap library they bundle that has symbol conflicts with OpenLDAP. At PostgreSQL startup libldap is loaded, so when libclntsh.so

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-11-26 Thread Syed, Rahila
Hello, I would like to contribute few points. >XLogInsertRecord(XLogRecData *rdata, XLogRecPtr fpw_lsn) > RedoRecPtr = Insert->RedoRecPtr; > } > doPageWrites = (Insert->fullPageWrites || Insert->forcePageWrites); > doPageCompression = (Insert->fullPageWrites == > F

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Jakob Egger
> Is it broken *worse* in 9.4 than it was in previous versions? No. Because the indices need to be rebuilt, the only realistic opportunity for applying this patch to Postgres.app is when releasing a major new version, since then people need to migrate their data anyway. That's why I wanted to

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Jakob Egger
> Am 26.11.2014 um 11:20 schrieb Dave Page : > > On Wed, Nov 26, 2014 at 10:13 AM, Jakob Egger wrote: >> Am 26.11.2014 um 11:05 schrieb Dave Page : >> >> You may want to bear in mind that postgres.app is on the main PG >> downloads page on the website. If you're patching Postgres to add a >> fe

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Magnus Hagander
On Wed, Nov 26, 2014 at 11:13 AM, Jakob Egger wrote: > Am 26.11.2014 um 11:05 schrieb Dave Page : > > You may want to bear in mind that postgres.app is on the main PG > downloads page on the website. If you're patching Postgres to add a > feature like this, it would become a fork and would have to

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Dave Page
On Wed, Nov 26, 2014 at 10:13 AM, Jakob Egger wrote: > Am 26.11.2014 um 11:05 schrieb Dave Page : > > You may want to bear in mind that postgres.app is on the main PG > downloads page on the website. If you're patching Postgres to add a > feature like this, it would become a fork and would have to

[HACKERS] issue in postgresql 9.1.3 in using arrow key in Solaris platform

2014-11-26 Thread M Tarkeshwar Rao
Hi all, We are facing following issue in postgresql 9.1.3 in using arrow key in Solaris platform. Can you please help us to resolve it or any new release has fix for this or any workaround for this? issue: psql client generates a core when up arrow is used twice. Platfrom: Solaris

  1   2   >