Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

On Sat, Nov 15, 2014 at 12:01 AM, Robert Haas wrote: > > On Fri, Nov 14, 2014 at 1:15 PM, Tom Lane wrote: > > Generally I'd be in favor of avoiding platform-dependent code where > > possible, but that doesn't represent a YES vote for this particular > > patch. It looks pretty messy in a quick lo

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

On Sat, Nov 15, 2014 at 12:03 AM, Alvaro Herrera wrote: > > Amit Kapila wrote: > > > 2. Symlink file format: > > > > 16387 E:\PostgreSQL\tbs > > > > Symlink file will contain entries for all the tablspaces > > under pg_tblspc directory. I have kept the file name as > > symlink_label (suggestion

Re: [HACKERS] WAL format and API changes (9.5)

On Fri, Nov 14, 2014 at 5:31 PM, Michael Paquier wrote: > 3) pg_xlogdump does not seem to work: > $ pg_xlogdump 0001000D > pg_xlogdump: FATAL: could not find a valid record after 0/D00 This one is a bad manipulation from my side. Please forget this comment. -- Michael -- S

Re: [HACKERS] New storage parameter pages_per_range not mentioned in CREATE INDEX doc

On Sat, Nov 15, 2014 at 1:27 PM, Alvaro Herrera wrote: > Michael Paquier wrote: >> Hi all, >> >> The new storage parameter pages_per_range is missing in the >> documentation of CREATE INDEX. The patch attached corrects that. > > Ah BTW I had pushed this earlier today. Thanks. -- Michael -- Sen

Re: [HACKERS] tracking commit timestamps

On 11/14/2014 08:21 PM, Simon Riggs wrote: The requested information is already available, as discussed. Logical decoding adds commit ordering for *exactly* the purpose of using it for replication, available to all solutions. This often requested feature has now been added and doesn't need to be

Re: [HACKERS] Useless dead struct in parse_func.h

Peter Geoghegan wrote: > It looks like commit 0e99be1c removed the final real use of the struct > InhPaths. Attached patch removes it entirely. I didn't verify the claim about 0e99be1c, but I pushed it anyway. Thanks. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Develo

Re: [HACKERS] New storage parameter pages_per_range not mentioned in CREATE INDEX doc

Michael Paquier wrote: > Hi all, > > The new storage parameter pages_per_range is missing in the > documentation of CREATE INDEX. The patch attached corrects that. Ah BTW I had pushed this earlier today. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 S

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

Michael Paquier wrote: > Btw, perhaps this diff should be pushed as a different patch as this is a > rather different thing: > - if (heapRelation->rd_rel->relpersistence == RELPERSISTENCE_UNLOGGED > && > + if (indexRelation->rd_rel->relpersistence == > RELPERSISTENCE_UNLOGGED && >

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

On Sat, Nov 15, 2014 at 2:21 AM, Peter Eisentraut wrote: > > On 11/13/14 4:33 PM, Peter Eisentraut wrote: > >> Is this still relevant after this commit? > >> > > >> > commit fb05f3ce83d225dd0f39f8860ce04082753e9e98 > >> > Author: Peter Eisentraut > >> > Date: Sat Feb 22 13:38:06 2014 -0500 > >>

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

* Noah Misch (n...@leadboat.com) wrote: > On Fri, Nov 14, 2014 at 08:39:28PM -0500, Stephen Frost wrote: > > I don't see the point in including them for --clean..? --clean states > > that DROP commands would be added, not that existing roles would be > > adjusted in some way. > > It does state th

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

On Fri, Nov 14, 2014 at 08:39:28PM -0500, Stephen Frost wrote: > * Noah Misch (n...@leadboat.com) wrote: > > So, if you desire to make this consistent, I recommend using > > rolreplication's > > treatment as the gold standard. That is to say, when dumping from an older > > version, set to false a

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

* Noah Misch (n...@leadboat.com) wrote: > On Fri, Nov 14, 2014 at 11:47:49AM -0500, Stephen Frost wrote: > > rolcreaterole uses usesuper, while rolreplication and rolbypassrls do > > not. Noah- would you argue that we should change rolcreaterole, which > > has this behavior in all released branche

[HACKERS] Useless dead struct in parse_func.h

It looks like commit 0e99be1c removed the final real use of the struct InhPaths. Attached patch removes it entirely. -- Peter Geoghegan diff --git a/src/include/parser/parse_func.h b/src/include/parser/parse_func.h index b9b06ae..4423bc0 100644 --- a/src/include/parser/parse_func.h +++ b/src/incl

Re: [HACKERS] tracking commit timestamps

On 14 November 2014 17:12, Robert Haas wrote: > We are not talking about loading 20 new > requirements on top of this patch; that would be intolerable. We're > talking about adding one additional piece of information that has been > requested multiple times over the years. The requested informa

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

On Fri, Nov 14, 2014 at 11:47:49AM -0500, Stephen Frost wrote: > > On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote: > > > I think Noah is arguing for leaving the pg_dumpall queries as they > > > stand. I disagree, but he's entitled to his opinion. > Ah, ok. I'm impartial, but I do note

Re: [HACKERS] END_OF_RECOVERY shutdowns and ResetUnloggedRelations()

On 2014-10-27 16:09:30 +0530, Abhijit Menon-Sen wrote: > At 2014-09-25 22:41:18 +0200, and...@2ndquadrant.com wrote: > > > > On 2014-09-24 17:06:05 +0530, Abhijit Menon-Sen wrote: > > > > > > 1. Move the call to ResetUnloggedRelations(UNLOGGED_RELATION_INIT) to > > >earlier in StartupXLOG. > >

Re: [HACKERS] initdb -S and tablespaces

On 2014-10-30 14:30:28 +0530, Abhijit Menon-Sen wrote: > Here's a proposed patch to initdb to make initdb -S fsync everything > under pg_tblspc. It introduces a new function that calls walkdir on > every entry under pg_tblspc. This is only one approach: I could have > also changed walkdir to follow

Re: [HACKERS] On the warpath again about ill-considered inclusion nests

All, * Stephen Frost (sfr...@snowman.net) wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Well, if you *only* move RowSecurityDesc and not RowSecurityPolicy, > > okay, but that seems a bit useless/inconsistent if I'm reading it > > right that RowSecurityDesc contains a List of RowSecurityPolic

Re: [HACKERS] Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

On Fri, Nov 14, 2014 at 2:51 PM, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: >> On Thu, Nov 13, 2014 at 6:32 PM, Tom Lane wrote: >> > What's bothering me is that I see this in pg_dumpall output from a 9.4 >> > or earlier database: >> > >> > ALTER ROLE postgres WITH SUPERUS

Re: [HACKERS] Idle transaction cancel/timeout and SSL revisited

Andres Freund writes: > > On 2014-11-15 00:11:36 +0300, Alex Shulgin wrote: >> After reading up through archives on the two $subj related TODO items >> I'm under impression that the patches[1,2] didn't make it mainly because >> of the risk of breaking SSL internals if we try to longjump out of t

Re: [HACKERS] Idle transaction cancel/timeout and SSL revisited

Hi, On 2014-11-15 00:11:36 +0300, Alex Shulgin wrote: > After reading up through archives on the two $subj related TODO items > I'm under impression that the patches[1,2] didn't make it mainly because > of the risk of breaking SSL internals if we try to longjump out of the > signal handler in the

[HACKERS] Idle transaction cancel/timeout and SSL revisited

Hello Hackers, After reading up through archives on the two $subj related TODO items I'm under impression that the patches[1,2] didn't make it mainly because of the risk of breaking SSL internals if we try to longjump out of the signal handler in the middle of a blocking SSL read and/or if we try

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

On 11/13/14 4:33 PM, Peter Eisentraut wrote: >> Is this still relevant after this commit? >> > >> > commit fb05f3ce83d225dd0f39f8860ce04082753e9e98 >> > Author: Peter Eisentraut >> > Date: Sat Feb 22 13:38:06 2014 -0500 >> > >> > pg_basebackup: Add support for relocating tablespaces > I be

Re: [HACKERS] New storage parameter pages_per_range not mentioned in CREATE INDEX doc

Michael Paquier wrote: > Hi all, > > The new storage parameter pages_per_range is missing in the > documentation of CREATE INDEX. The patch attached corrects that. Thanks! Pushed. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Serv

Re: [HACKERS] EXPLAIN ANALYZE output weird for Top-N Sort

On 14/11/14 14:54, Tom Lane wrote: > Jeremy Harris writes: >> On 14/11/14 00:46, Simon Riggs wrote: >>> Limit (cost= rows=20 width=175) (actual time= rows=20 loops=1) >>> -> Sort (cost= rows=568733 width=175) (actual time= >>> rows=20 loops=1) >>> Sort Method: top-N heapsort >

Re: [HACKERS] TODO request: log_long_transaction

On 11/7/14, 1:19 PM, Michael Banck wrote: Am Montag, den 27.10.2014, 19:29 + schrieb Thom Brown: >On 27 October 2014 19:21, Josh Berkus wrote: > >I just realized that there is one thing we can't log currently: > >transactions which last more than #ms. This is valuable diagnostic > >inform

Re: [HACKERS] printing table in asciidoc with psql

On 14 November 2014 20:57, Alvaro Herrera wrote: > Is anyone going to submit a new version of this patch? > > > Hi Alvaro, due to family issues I will not be able to work on it for the next 10 days. regards, Szymon

Re: [HACKERS] Question about RI checks

Kevin, are you handling this? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/p

Re: [HACKERS] printing table in asciidoc with psql

Is anyone going to submit a new version of this patch? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.p

Re: [HACKERS] Size of regression database

Alvaro Herrera writes: >> Tom Lane wrote: >>> A quick eyeball check says that that quintupling of the database size >>> is all in BRIN index tests. Could we dial that back to something a >>> bit saner please? > Done: > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=86cf9a56506

Re: [HACKERS] Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

* Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Nov 13, 2014 at 6:32 PM, Tom Lane wrote: > > What's bothering me is that I see this in pg_dumpall output from a 9.4 > > or earlier database: > > > > ALTER ROLE postgres WITH SUPERUSER INHERIT CREATEROLE CREATEDB LOGIN > > REPLICATION NOBYPASS

Re: [HACKERS] Size of regression database

Alvaro Herrera wrote: > Tom Lane wrote: > > I was testing backwards compatibility of pg_dumpall just now, and was > > somewhat astonished to notice the size of the output for the regression > > database compared to what it was not too long ago: > > > > -rw-rw-r--. 1 tgl tgl 4509135 Nov 13 16:19 d

Re: [HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

On 2014-11-15 03:25:16 +0900, Fujii Masao wrote: > On Fri, Nov 14, 2014 at 7:22 PM, wrote: > > Hi, > > > > "pg_ctl stop" does't work propley, if --slot option is specified when WAL > > is flushed only it has switched. > > These processes still continue even after the posmaster > > failed:pg_rec

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

Amit Kapila wrote: > 2. Symlink file format: > > 16387 E:\PostgreSQL\tbs > > Symlink file will contain entries for all the tablspaces > under pg_tblspc directory. I have kept the file name as > symlink_label (suggestion are welcome if you want some > different name for this file). I think sym

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

On Fri, Nov 14, 2014 at 1:15 PM, Tom Lane wrote: > Generally I'd be in favor of avoiding platform-dependent code where > possible, but that doesn't represent a YES vote for this particular > patch. It looks pretty messy in a quick look, even granting that the > #ifdef WIN32's would all go away.

Re: [HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

On Fri, Nov 14, 2014 at 7:22 PM, wrote: > Hi, > > "pg_ctl stop" does't work propley, if --slot option is specified when WAL is > flushed only it has switched. > These processes still continue even after the posmaster > failed:pg_receivexlog, walsender and logger. I could reproduce this problem

Re: [HACKERS] Add CREATE support to event triggers

On 2014-11-14 12:38:52 -0500, Robert Haas wrote: > >> This is basically the same problem as multi-master replication > >> conflicts, except with DDL. Resolving replication conflicts is not a > >> very easy thing to get right even if you're only concerned about the > >> rows in the tables. It's pr

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

Robert Haas writes: > On Fri, Nov 14, 2014 at 2:55 AM, Amit Kapila wrote: >> OTOH, if that is okay, then I think we can avoid few #ifdef WIN32 that >> this patch introduces and can have consistency for this operation on >> both linux and Windows. > Having one code path for everything seems appea

Re: [HACKERS] Add CREATE support to event triggers

On Thu, Nov 13, 2014 at 7:45 AM, Andres Freund wrote: >> Right. And that's why it's cool that logical decoding can operate >> through DDL differences. The apply side might not be able to cope >> with what pops out, but that's not logical decoding's fault, and >> different apply-sides can adopt d

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

On Fri, Nov 14, 2014 at 2:55 AM, Amit Kapila wrote: > On Fri, Nov 14, 2014 at 9:11 AM, Robert Haas wrote: >> On Thu, Nov 13, 2014 at 10:37 PM, Amit Kapila >> wrote: >> >> >> > >> > I have mentioned that this can be usable for Linux users as well on that >> > thread, however I think we might want

Re: [HACKERS] Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

On Thu, Nov 13, 2014 at 6:32 PM, Tom Lane wrote: > What's bothering me is that I see this in pg_dumpall output from a 9.4 > or earlier database: > > ALTER ROLE postgres WITH SUPERUSER INHERIT CREATEROLE CREATEDB LOGIN > REPLICATION NOBYPASSRLS; What about leaving out NOBYPASSRLS and letting it g

Re: [HACKERS] tracking commit timestamps

On Thu, Nov 13, 2014 at 6:55 PM, Simon Riggs wrote: > On 13 November 2014 21:24, Robert Haas wrote: >> On Thu, Nov 13, 2014 at 8:18 AM, Simon Riggs wrote: >>> Ordering transactions in LSN order is very precisly the remit of the >>> existing logical decoding API. Any user that wishes to see a com

Re: [HACKERS] alternative model for handling locking in parallel groups

Hi, On 2014-11-13 15:59:11 -0500, Robert Haas wrote: > Discussion of my incomplete group locking patch seems to have > converged around two points: (1) Everybody agrees that undetected > deadlocks are unacceptable. (2) Nobody agrees with my proposal to > treat locks held by group members as mutua

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

* Noah Misch (n...@leadboat.com) wrote: > On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote: > > Stephen Frost writes: > > > * Noah Misch (n...@leadboat.com) wrote: > > >> I'd agree for a new design, but I see too little to gain from changing > > >> it now. > > >> Today's behavior is fine.

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

On 2014-11-13 11:41:18 -0500, Robert Haas wrote: > On Wed, Nov 12, 2014 at 7:31 PM, Andres Freund wrote: > > But I think it won't work realistically. We have a *lot* of > > infrastructure that refers to indexes using it's primary key. I don't > > think we want to touch all those places to also dis

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote: > Stephen Frost writes: > > * Noah Misch (n...@leadboat.com) wrote: > >> I'd agree for a new design, but I see too little to gain from changing it > >> now. > >> Today's behavior is fine. > > > To clarify- you mean with the changes descri

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

Stephen Frost writes: > * Noah Misch (n...@leadboat.com) wrote: >> I'd agree for a new design, but I see too little to gain from changing it >> now. >> Today's behavior is fine. > To clarify- you mean with the changes described- using usesuper for > rolreplication and rolbypassrls instead of 'fa

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

* Noah Misch (n...@leadboat.com) wrote: > On Fri, Nov 14, 2014 at 08:35:25AM -0500, Stephen Frost wrote: > > Personally, I'm leaning towards the first as it's less clutter in the > > output of psql. > > I'd agree for a new design, but I see too little to gain from changing it now. > Today's behavi

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

On 2014-11-14 02:04:00 -0600, Jim Nasby wrote: > On 11/13/14, 3:50 PM, Andres Freund wrote: > Having been responsible for a site where downtime was a 6 figure > dollar amount per hour, I've spent a LOT of time worrying about lock > problems. The really big issue here isn't grabbing an exclusive loc

Re: [HACKERS] EXPLAIN ANALYZE output weird for Top-N Sort

Jeremy Harris writes: > On 14/11/14 00:46, Simon Riggs wrote: >> Limit (cost= rows=20 width=175) (actual time= rows=20 loops=1) >> -> Sort (cost= rows=568733 width=175) (actual time= >> rows=20 loops=1) >> Sort Method: top-N heapsort > Going off on a tangent, when I was playing

Re: [HACKERS] Teaching pg_dump to use NOT VALID constraints

Peter Eisentraut wrote: > On 11/13/14 5:07 AM, Simon Riggs wrote: > > On 13 November 2014 00:20, Jim Nasby wrote: > > > >> Isn't the real use-case here that if constraints were valid when you dumped > >> then we shouldn't have to *any* re-validate when we load? (Though, we'd > >> have > >> to be

Re: [HACKERS] Customized Options Threshold Error

writes: > When we specify a value which exceeds valid range in "Customized Options" , > its behavior is different from "Parameter Interaction via Configuration File" > behavior. > In case of "Parameter Interaction via Configuration File", it finish with > FATAL error when it get threshold error

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

On Fri, Nov 14, 2014 at 08:35:25AM -0500, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Noah Misch writes: > > > On Thu, Nov 13, 2014 at 08:24:36PM -0500, Stephen Frost wrote: > > >> Agreed. I'll take care of both and we'll make sure the new role > > >> attributes being added

Re: [HACKERS] Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

* Tom Lane (t...@sss.pgh.pa.us) wrote: > Noah Misch writes: > > On Thu, Nov 13, 2014 at 08:24:36PM -0500, Stephen Frost wrote: > >> Agreed. I'll take care of both and we'll make sure the new role > >> attributes being added will do the same for upgrades also. > > > That would make pg_dumpall les

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

On Fri, Nov 14, 2014 at 1:27 PM, Simon Riggs wrote: > On 12 November 2014 00:54, Robert Haas wrote: > > Interestingly, I have a fairly solid idea of what proisparallel is, > > but I have no clear idea what CONTAINS NO SQL is or why it's relevant. > > I would imagine that srandom() contains no SQ

Re: [HACKERS] EXPLAIN ANALYZE output weird for Top-N Sort

On 14/11/14 00:46, Simon Riggs wrote: > Limit (cost= rows=20 width=175) (actual time= rows=20 loops=1) >-> Sort (cost= rows=568733 width=175) (actual time= > rows=20 loops=1) > Sort Method: top-N heapsort Going off on a tangent, when I was playing with a merge-sort

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

> On 14 November 2014 07:37, Jim Nasby wrote: > > On 11/12/14, 1:54 AM, David Rowley wrote: > >> > >> On Tue, Nov 11, 2014 at 9:29 PM, Simon Riggs >> > wrote: > >> > >> > >> This plan type is widely used in reporting queries, so will hit the > >> mainline of

Re: [HACKERS] Size of regression database

Tom Lane wrote: > I was testing backwards compatibility of pg_dumpall just now, and was > somewhat astonished to notice the size of the output for the regression > database compared to what it was not too long ago: > > -rw-rw-r--. 1 tgl tgl 4509135 Nov 13 16:19 dumpall.83 > -rw-rw-r--. 1 tgl tgl

[HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

Hi, "pg_ctl stop" does't work propley, if --slot option is specified when WAL is flushed only it has switched. These processes still continue even after the posmaster failed:pg_receivexlog, walsender and logger. How to reproduce: 1.Start PostgreSQL 2.Create slot 3.Specify --slot option to pg_re

Re: [HACKERS] Unintended restart after recovery error

Fujii Masao wrote: > On Thu, Nov 13, 2014 at 8:30 AM, Robert Haas wrote: >> It's true that if the startup process dies we don't try to restart, >> but it's also true that if the checkpointer dies we do try to restart. >> I'm not sure why this specific situation should be an exception to >> that g

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

On 14 November 2014 01:51, David Rowley wrote: > When I mentioned this, I didn't mean to appear to be placing a road block.I > was just bringing to the table the information that COUNT(*) + COUNT(*) > works ok for merging COUNT(*)'s "sub totals", but AVG(n) + AVG(n) does not. > > Merge functions

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

On 14 November 2014 07:37, Jim Nasby wrote: > On 11/12/14, 1:54 AM, David Rowley wrote: >> >> On Tue, Nov 11, 2014 at 9:29 PM, Simon Riggs > > wrote: >> >> >> This plan type is widely used in reporting queries, so will hit the >> mainline of BI applications an

Re: [HACKERS] using custom scan nodes to prototype parallel sequential scan

On 14 November 2014 20:37, Jim Nasby wrote: > On 11/12/14, 1:54 AM, David Rowley wrote: > >> >> We'd also need to add some infrastructure to merge aggregate states >> together for this to work properly. This means that could also work for >> avg() and stddev etc. For max() and min() the merge fun

Re: [HACKERS] alter user/role CURRENT_USER

Hi, this is revised version. > Kyotaro HORIGUCHI wrote: > > > - Storage for new information > > > > The new struct NameId stores an identifier which telling what it > > logically is using the new enum NameIdTypes. > > I think NameId is a bad name for this. My point is that NameId, as it > stan

Re: [HACKERS] WAL format and API changes (9.5)

On Thu, Nov 13, 2014 at 10:33 PM, Heikki Linnakangas wrote: > In quick testing, this new WAL format is somewhat more compact than the 9.4 > format. That also seems to have more than bought back the performance > regression I saw earlier. Here are results from my laptop, using the > wal-update-test

Re: [HACKERS] Change in HEAP_NEWPAGE logging makes diagnosis harder

On 10/30/2014 04:12 PM, Andres Freund wrote: Hi, I've just once more looked at the WAL stream ans was briefly confused about all the XLOG_FPI records. Since 54685338e3 log_newpage/log_newpage_buffer and XLogSaveBufferForHint() use the same WAL record. I personally find that a bad idea because th

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

On 11/13/14, 3:50 PM, Andres Freund wrote: On November 13, 2014 10:23:41 PM CET, Peter Eisentraut wrote: On 11/12/14 7:31 PM, Andres Freund wrote: Yes, it sucks. But it beats not being able to reindex a relation with a primary key (referenced by a fkey) without waiting several hours by a cou

[HACKERS] Customized Options Threshold Error

Hi, When we specify a value which exceeds valid range in "Customized Options" , its behavior is different from "Parameter Interaction via Configuration File" behavior. In case of "Parameter Interaction via Configuration File", it finish with FATAL error when it get threshold error. But in "Cust