Re: [HACKERS] PDF builds broken again

2014-07-24 Thread Devrim Gündüz
Hi, On Wed, 2014-07-23 at 15:53 +0200, Magnus Hagander wrote: > I ended up splitting the paragraph in two in order to get the PDFs to > build. I've applied a patch for this to 9.0 only so we can keep > building PDFs. Thanks for looking at this -- you saved my time. Regards, -- Devrim GÜNDÜZ Pr

Re: [HACKERS] Use unique index for longer pathkeys.

2014-07-24 Thread Amit Kapila
On Tue, Jul 22, 2014 at 2:49 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > > Sorry , previous version has bugs. It stamps over the stack and > crashesX( The attached is the bug fixed version, with no > substantial changes. > > > On Tue, Jul 15, 2014 at 2:17 PM, Kyotaro HORIGUCHI

Re: [HACKERS] SKIP LOCKED DATA (work in progress)

2014-07-24 Thread Thomas Munro
On 24 July 2014 00:52, Thomas Munro wrote: > On 23 July 2014 13:15, David Rowley wrote: >> I'm also wondering about this block of code in general: >> >> if (erm->waitPolicy == RWP_WAIT) >> wait_policy = LockWaitBlock; >> else if (erm->waitPolicy == RWP_SKIP ) >> wait_policy = LockWaitSkip; >> els

Re: [HACKERS] Minor inaccuracy in jsonb_path_ops documentation

2014-07-24 Thread Peter Geoghegan
On Thu, Jul 24, 2014 at 3:02 PM, Tom Lane wrote: > The fact that the planner can avoid that in the presence of a > simple constant comparison value doesn't make it a good idea to > use jsonb_path_ops indexes if you do this type of query a lot, > because in some usages the planner won't see a const

Re: [HACKERS] Why does xlog.c not treat COMMIT_PREPARED/ABORT_PREPARED as commit/abort?

2014-07-24 Thread Andres Freund
On 2014-07-24 17:53:17 -0400, Tom Lane wrote: > There's a bunch of code in xlog.c that special-cases commit/abort records > for purposes of controlling replay, ie whether you can pause before/after > a particular xlog record, extract a timestamp from it, etc. This code > does not, and apparently n

Re: [HACKERS] Minor inaccuracy in jsonb_path_ops documentation

2014-07-24 Thread Tom Lane
Peter Geoghegan writes: > The jsonb documentation says of the jsonb_path_ops GIN opclass: > """ > A disadvantage of the jsonb_path_ops approach is that it produces no > index entries for JSON structures not containing any values, such as > {"a": {}}. If a search for documents containing such a str

[HACKERS] Why does xlog.c not treat COMMIT_PREPARED/ABORT_PREPARED as commit/abort?

2014-07-24 Thread Tom Lane
There's a bunch of code in xlog.c that special-cases commit/abort records for purposes of controlling replay, ie whether you can pause before/after a particular xlog record, extract a timestamp from it, etc. This code does not, and apparently never has, counted COMMIT_PREPARED or ABORT_PREPARED as

[HACKERS] Minor inaccuracy in jsonb_path_ops documentation

2014-07-24 Thread Peter Geoghegan
The jsonb documentation says of the jsonb_path_ops GIN opclass: """ A disadvantage of the jsonb_path_ops approach is that it produces no index entries for JSON structures not containing any values, such as {"a": {}}. If a search for documents containing such a structure is requested, it will requi

Re: [HACKERS] gaussian distribution pgbench -- splits Bv6

2014-07-24 Thread Alvaro Herrera
Fabien COELHO wrote: > I also have a problem with assert & Assert. I finally figured out > that Assert is not compiled in by default, thus it is generally > ignored. So it is more for debugging purposes when activated than > for guarding against some unexpected user errors. Yes, Assert() is for

Re: [HACKERS] Verbose output of pg_dump not show schema name

2014-07-24 Thread Fabrízio de Royes Mello
On Thu, Jul 24, 2014 at 4:36 PM, Robert Haas wrote: > > On Wed, Jul 23, 2014 at 5:48 PM, Fabrízio de Royes Mello > wrote: > > > > On Thu, Apr 17, 2014 at 9:15 PM, Michael Paquier < michael.paqu...@gmail.com> > > wrote: > >> > >> On Fri, Apr 18, 2014 at 4:29 AM, Fabrízio de Royes Mello > >> wrote

Re: [HACKERS] Least Active Transaction ID function

2014-07-24 Thread Rohit Goyal
Hi Robert, On Thu, Jul 24, 2014 at 9:32 PM, Robert Haas wrote: > On Wed, Jul 23, 2014 at 3:53 PM, Rohit Goyal wrote: > > Hi All, > > > > On Wed, Jul 23, 2014 at 5:01 PM, Rohit Goyal > wrote: > >> > >> Hi All, > >> > >> I am doing programming with postgresql source code. I want to find out > th

Re: [HACKERS] Verbose output of pg_dump not show schema name

2014-07-24 Thread Robert Haas
On Wed, Jul 23, 2014 at 5:48 PM, Fabrízio de Royes Mello wrote: > > On Thu, Apr 17, 2014 at 9:15 PM, Michael Paquier > wrote: >> >> On Fri, Apr 18, 2014 at 4:29 AM, Fabrízio de Royes Mello >> wrote: >> > >> > On Thu, Apr 17, 2014 at 12:46 PM, Bruce Momjian >> > wrote: >> >> >> >> On Thu, Apr 17

Re: [HACKERS] Least Active Transaction ID function

2014-07-24 Thread Robert Haas
On Wed, Jul 23, 2014 at 3:53 PM, Rohit Goyal wrote: > Hi All, > > On Wed, Jul 23, 2014 at 5:01 PM, Rohit Goyal wrote: >> >> Hi All, >> >> I am doing programming with postgresql source code. I want to find out the >> function which can give me Least active transaction id currenty in the >> system.

Re: [HACKERS] gaussian distribution pgbench -- splits Bv6

2014-07-24 Thread Fabien COELHO
Thank you for your grate documentation and fix working!!! It becomes very helpful for understanding our feature. Hopefully it will help make it, or part of it, pass through. I add two feature in gauss_B_4.patch. 1) Add gaussianProbability() function It is same as exponentialProbability(). A

Re: [HACKERS] parametric block size?

2014-07-24 Thread Fabien COELHO
Note that I was more asking about the desirability of the feature, the implementation is another, although also relevant, issue. To me it is really desirable given the potential performance impact, but maybe we should not care about 10%? 10% performance improvement sounds good, no doubt. What

Re: [HACKERS] Remove comment about manually flipping attnotnull

2014-07-24 Thread Tom Lane
Andres Freund writes: > catalogs.sgml has this comment: >This represents a not-null constraint. It is possible to >change this column to enable or disable the constraint. > Someone on irc just took that as "permission" to do so manually... Did anything especially bad happen? Ob

[HACKERS] Remove comment about manually flipping attnotnull

2014-07-24 Thread Andres Freund
Hi, catalogs.sgml has this comment: This represents a not-null constraint. It is possible to change this column to enable or disable the constraint. Someone on irc just took that as "permission" to do so manually... That comment has been there since 1efd7330c/2000-11-29, in the th

Re: [HACKERS] parametric block size?

2014-07-24 Thread Alvaro Herrera
Fabien COELHO wrote: Hi, > Note that I was more asking about the desirability of the feature, > the implementation is another, although also relevant, issue. To me > it is really desirable given the potential performance impact, but > maybe we should not care about 10%? 10% performance improveme

Re: [HACKERS] Some bogus results from prairiedog

2014-07-24 Thread Tom Lane
Robert Haas writes: > On Tue, Jul 22, 2014 at 8:14 PM, Tom Lane wrote: >> and it sure looks to me like that >> "ConflictsWithRelationFastPath(&lock->tag" is looking at the tag of the >> shared-memory lock object you just released. If someone else had managed >> to recycle that locktable entry fo

Re: [HACKERS] 9.4 docs current as of

2014-07-24 Thread Magnus Hagander
On Thu, Jul 24, 2014 at 5:17 PM, Tom Lane wrote: > Magnus Hagander writes: >> 9.4 beta docs are listed as "Current as of 2014-05-10". >> I'm assuming that's just a step we missed in the version stamping? > > No, what that means is that nobody has looked at the commit logs since > then to see if t

Re: [HACKERS] gaussian distribution pgbench -- splits v4

2014-07-24 Thread Mitsumasa KONDO
Hi, Thank you for your grate documentation and fix working!!! It becomes very helpful for understanding our feature. I add two feature in gauss_B_4.patch. 1) Add gaussianProbability() function It is same as exponentialProbability(). And the feature is as same as before. 2) Add result of "max/mi

Re: [HACKERS] [RFC] Should smgrtruncate() avoid sending sinval message for temp relations

2014-07-24 Thread Andres Freund
On 2014-07-24 11:17:15 -0400, Robert Haas wrote: > I think you might be approaching this problem from the wrong end, > though. Yep. > The question in my mind is: why does the > StartTransactionCommand() / CommitTransactionCommand() pair in > ProcessCatchupEvent() end up writing a commit record?

Re: [HACKERS] 9.4 docs current as of

2014-07-24 Thread Tom Lane
Magnus Hagander writes: > 9.4 beta docs are listed as "Current as of 2014-05-10". > I'm assuming that's just a step we missed in the version stamping? No, what that means is that nobody has looked at the commit logs since then to see if the 9.4 release notes need any updates. Since we don't rele

Re: [HACKERS] [RFC] Should smgrtruncate() avoid sending sinval message for temp relations

2014-07-24 Thread Robert Haas
On Wed, Jul 23, 2014 at 12:17 PM, MauMau wrote: > From: "Tom Lane" >> This seems like a pretty unsafe suggestion, because the smgr level doesn't >> know or care whether relations are temp; files are files. In any case it >> would only paper over one specific instance of whatever problem you're >

Re: [HACKERS] parametric block size?

2014-07-24 Thread Fabien COELHO
Resent: previous message was stalled because of a bad "From:". ISTM that a desirable and reasonably simple to implement feature would be to be able to set the blocksize at "initdb" time, and "postgres" could use the value found in the database instead of a compile-time one. I think you will f

Re: [HACKERS] Checkpointer crashes on slave in 9.4 on windows

2014-07-24 Thread Robert Haas
On Thu, Jul 24, 2014 at 5:38 AM, Amit Kapila wrote: > Revised patch initialize the WALInsertLocks and call > LWLockRegisterTranche() in XLOGShmemInit() which makes their > initialization similar to what we do at other places. OK, that seems all right. Will commit and back-patch. -- Robert Haas

Re: [HACKERS] parametric block size?

2014-07-24 Thread Robert Haas
On Tue, Jul 22, 2014 at 1:22 PM, Alvaro Herrera wrote: > Fabien wrote: >> ISTM that a desirable and reasonably simple to implement feature >> would be to be able to set the blocksize at "initdb" time, and >> "postgres" could use the value found in the database instead of a >> compile-time one. > >

Re: [HACKERS] Use unique index for longer pathkeys.

2014-07-24 Thread Robert Haas
On Tue, Jul 22, 2014 at 5:19 AM, Kyotaro HORIGUCHI wrote: > # By the way, this style of calling a person is quite common > # among Japanese since the first-name basis implies very close > # relationship or it frequently conveys offensive shade. But I'm > # not sure what should I call others who're

[HACKERS] shm_mq bug

2014-07-24 Thread Robert Haas
In testing some new code I'm working on that uses shm_mq to do Cool Stuff (TM), I discovered that my code was mysteriously failing assertions when I hit ^C in the middle of the test. This led me on a lengthy, mostly-misguided hunt for the culprit. I eventually discovered that the problem wasn't i

Re: [HACKERS] Some bogus results from prairiedog

2014-07-24 Thread Robert Haas
On Tue, Jul 22, 2014 at 8:14 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Jul 22, 2014 at 12:24 AM, Tom Lane wrote: >>> Anyway, to cut to the chase, the crash seems to be from this: >>> TRAP: FailedAssertion("!(FastPathStrongRelationLocks->count[fasthashcode] > >>> 0)", File: "lock.c",

Re: [HACKERS] Exporting Table-Specified BLOBs Only?

2014-07-24 Thread Braunstein, Alan
The reason this is needed from the export/dump side is that the database can become huge due to the number of datasheets added to the database. These datasheets are not necessary to troubleshoot the setup and, sometimes, the datasheets are secure-sensitive. In either case, they're not necessar

Re: [HACKERS] Production block comparison facility

2014-07-24 Thread Michael Paquier
On Thu, Jul 24, 2014 at 8:36 PM, Andres Freund wrote: > On 2014-07-24 20:35:04 +0900, Michael Paquier wrote: >> - FPW/page consistency check is done after converting them to hex. >> This is done only this way to facilitate viewing the page diffs with a >> debugger. A best method would be to perfor

Re: [HACKERS] Production block comparison facility

2014-07-24 Thread Andres Freund
On 2014-07-24 20:35:04 +0900, Michael Paquier wrote: > - FPW/page consistency check is done after converting them to hex. > This is done only this way to facilitate viewing the page diffs with a > debugger. A best method would be to perform the checks using > MASK_MARKER (which should be moved to b

Re: [HACKERS] Production block comparison facility

2014-07-24 Thread Michael Paquier
On Thu, Jul 24, 2014 at 12:35 AM, Simon Riggs wrote: > On 23 July 2014 15:14, Michael Paquier wrote: > >> I have spent some time digging more into this idea and finished with the >> patch attached > > Thank you for investigating the idea. I'll review by Monday. OK, thanks. Here are a couple of th

Re: [HACKERS] Exporting Table-Specified BLOBs Only?

2014-07-24 Thread Robert Haas
On Mon, Jul 21, 2014 at 2:14 PM, Braunstein, Alan wrote: > What do I need? > > A method of using pg_dump to selectively export BLOBs with OID’s used in the > tables specified with --table --table Hmm. If you take a full backup using pg_dump -Fc, you can then use pg_restore -l and pg_restore -L

[HACKERS] 9.4 docs current as of

2014-07-24 Thread Magnus Hagander
9.4 beta docs are listed as "Current as of 2014-05-10". I'm assuming that's just a step we missed in the version stamping? Needs to go on a checklist? Should we backpatch a fix for that? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-

Re: [HACKERS] Stating the significance of Lehman & Yao in the nbtree README

2014-07-24 Thread Amit Kapila
On Thu, Jul 24, 2014 at 9:28 AM, Peter Geoghegan wrote: > On Wed, Jul 23, 2014 at 8:52 PM, Amit Kapila wrote: > > As such there is no problem in saying the way you have mentioned, but > > I feel it would be better if we can mention the mechanism of _bt_search() > > as quoted by you upthread in th

Re: [HACKERS] Checkpointer crashes on slave in 9.4 on windows

2014-07-24 Thread Amit Kapila
On Thu, Jul 24, 2014 at 12:14 AM, Robert Haas wrote: > On Mon, Jul 21, 2014 at 4:16 AM, Amit Kapila wrote: > > So, this problem was introduced by Heikki's commit, > 68a2e52bbaf98f136a96b3a0d734ca52ca440a95, to replace XLogInsert slots > with regular LWLocks. I think the problem here is that the

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2014-07-24 Thread Shigeru Hanada
Hi Fujita-san, My coworker Takaaki EITOKU reviewed the patch, and here are some comments from him. 2014-07-08 16:07 GMT+09:00 Etsuro Fujita : ... > In the patch postgresPlanForeignModify has been modified so that if, in > addition to the above condition, the followings are satisfied, then the > F

Re: [HACKERS] [BUGS] BUG #9652: inet types don't support min/max

2014-07-24 Thread Asif Naeem
Hi Haribabu, Sorry for being late. Thank you for sharing updated patch, sgml changes seems not working i.e. postgres=# select max('192.168.1.5', '192.168.1.4'); > ERROR: function max(unknown, unknown) does not exist > LINE 1: select max('192.168.1.5', '192.168.1.4'); >^ > HINT: