Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Amit Kapila
On Mon, May 12, 2014 at 7:26 PM, Heikki Linnakangas wrote: > In theory, we could use a snapshot LSN as the cutoff-point for > HeapTupleSatisfiesVisibility(). Maybe it's just because this is new, but > that makes me feel uneasy. To accomplish this won't XID-CSN map table be required and how will i

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-05-12 Thread Amit Kapila
On Sun, May 11, 2014 at 10:17 PM, Tom Lane wrote: > Simon Riggs writes: >> On 11 May 2014 11:18, Andres Freund wrote: >>> I don't know. I'd find UPDATE/DELETE ORDER BY something rather >>> useful. > >> Perhaps if an index exists to provide an ordering that makes it clear >> what this means, then

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Rajeev rastogi
On 12 May 2014 19:27, Heikki Linnakangas Wrote: > On 01/24/2014 02:10 PM, Rajeev rastogi wrote: > > We are also planning to implement CSN based snapshot. > > So I am curious to know whether any further development is happening > on this. > > I started looking into this, and plan to work on this

Re: [HACKERS] A couple logical decoding fixes/patches

2014-05-12 Thread Noah Misch
On Sat, May 10, 2014 at 04:56:51PM +0200, Andres Freund wrote: > On 2014-05-10 00:59:59 -0400, Noah Misch wrote: > > Static functions having only one call site are especially vulnerable to > > inlining, so avoid naming them in the suppressions file. I do see > > ReorderBufferSerializeChange() inli

Re: [HACKERS] 9.4 release notes

2014-05-12 Thread Bruce Momjian
On Fri, May 9, 2014 at 02:50:05AM +0900, MauMau wrote: > From: "Bruce Momjian" > >I have completed the initial version of the 9.4 release notes. You can > >view them here: > > > >http://www.postgresql.org/docs/devel/static/release-9-4.html > > > >Feedback expected and welcomed. I expect to be m

Re: [HACKERS] 9.4 release notes

2014-05-12 Thread Bruce Momjian
On Thu, May 8, 2014 at 10:17:27AM +0900, Tatsuo Ishii wrote: > > I have completed the initial version of the 9.4 release notes. You can > > view them here: > > > > http://www.postgresql.org/docs/devel/static/release-9-4.html > > > > I will be adding additional markup in the next few days. >

Re: [HACKERS] 9.4 release notes

2014-05-12 Thread Bruce Momjian
On Tue, May 6, 2014 at 03:53:54PM +0200, Nicolas Barbier wrote: > 2014-05-05 Bruce Momjian : > > > On Mon, May 5, 2014 at 10:40:29AM -0700, Josh Berkus wrote: > > > >> * ALTER SYSTEM SET > >> > >> Lemme know if you need description text for any of the above. > > > > OK, great! Once I have the m

Re: [HACKERS] New timezones used in regression tests

2014-05-12 Thread Robert Haas
On Mon, May 12, 2014 at 7:16 PM, Tom Lane wrote: > I'm quite unimpressed by the dependency on Mars/Mons_Olympus, too ... that > might not fail *today*, but considering it's a real location, assuming it > is not in the IANA database seems like a recipe for future failure. > Maybe something like Neh

Re: [HACKERS] Compression of full-page-writes

2014-05-12 Thread Haribabu Kommi
On Tue, May 13, 2014 at 3:33 AM, Fujii Masao wrote: > On Sun, May 11, 2014 at 7:30 PM, Simon Riggs wrote: >> On 30 August 2013 04:55, Fujii Masao wrote: >> >>> My idea is very simple, just compress FPW because FPW is >>> a big part of WAL. I used pglz_compress() as a compression method, >>> but

Re: [HACKERS] New timezones used in regression tests

2014-05-12 Thread Gavin Flower
On 13/05/14 11:16, Tom Lane wrote: Christoph Berg writes: 84df54b22e8035addc7108abd9ff6995e8c49264 introduced timestamp constructors. In the regression tests, various time zones are tested, including America/Metlakatla. Now, if you configure using --with-system-tzdata, you'll get an error if th

Re: [HACKERS] New timezones used in regression tests

2014-05-12 Thread Tom Lane
Christoph Berg writes: > 84df54b22e8035addc7108abd9ff6995e8c49264 introduced timestamp > constructors. In the regression tests, various time zones are tested, > including America/Metlakatla. Now, if you configure using > --with-system-tzdata, you'll get an error if that zone isn't there. > Unfortu

Re: [HACKERS] Ignore src/tools/msvc/config.pl in code tree for MSVC compilation

2014-05-12 Thread Michael Paquier
On Tue, May 13, 2014 at 3:16 AM, Tom Lane wrote: > Michael Paquier writes: >> Actually I am sending an updated patch as buildenv.pl enters in the >> same category as config.pl. > > This seems sane to me; it's in the same category as src/Makefile.custom, > which we have a .gitignore entry for. I

Re: [HACKERS] New timezones used in regression tests

2014-05-12 Thread Christoph Berg
Re: To PostgreSQL Hackers 2014-05-12 <20140512214025.ga31...@msgid.df7cb.de> > 84df54b22e8035addc7108abd9ff6995e8c49264 introduced timestamp > constructors. In the regression tests, various time zones are tested, > including America/Metlakatla. Now, if you configure using > --with-system-tzdata, yo

[HACKERS] New timezones used in regression tests

2014-05-12 Thread Christoph Berg
84df54b22e8035addc7108abd9ff6995e8c49264 introduced timestamp constructors. In the regression tests, various time zones are tested, including America/Metlakatla. Now, if you configure using --with-system-tzdata, you'll get an error if that zone isn't there. Unfortunately, this is what I'm getting n

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Sergey Muraviov
Hi. I'll try to fix it tomorrow. 2014-05-12 18:42 GMT+04:00 Tom Lane : > Greg Stark writes: > > On Mon, May 12, 2014 at 2:12 PM, Greg Stark wrote: > >> Hm, there was an off by one error earlier in some cases, maybe we > >> fixed it by breaking other case. Will investigate. > > > Those spaces

Re: [HACKERS] Running DBT2 on postgresql

2014-05-12 Thread Josh Berkus
On 05/12/2014 10:16 AM, Rohit Goyal wrote: > Hi All, > > Please help me in running DBT2 on postgresql. I am doing it for the first > time. I am facing error while running dbt2 test. > > I installed dbt2 by following "install" file. Below some final lines of > terminal. You'll get more help on th

Re: [HACKERS] Ignore src/tools/msvc/config.pl in code tree for MSVC compilation

2014-05-12 Thread Tom Lane
Michael Paquier writes: > Actually I am sending an updated patch as buildenv.pl enters in the > same category as config.pl. This seems sane to me; it's in the same category as src/Makefile.custom, which we have a .gitignore entry for. I wondered whether there were any more such files, but the do

Re: [HACKERS] Compression of full-page-writes

2014-05-12 Thread Fujii Masao
On Sun, May 11, 2014 at 7:30 PM, Simon Riggs wrote: > On 30 August 2013 04:55, Fujii Masao wrote: > >> My idea is very simple, just compress FPW because FPW is >> a big part of WAL. I used pglz_compress() as a compression method, >> but you might think that other method is better. We can add >> s

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Tom Lane
Peter Eisentraut writes: > On 5/12/14, 12:42 PM, Tom Lane wrote: >> Peter Eisentraut writes: >>> You need plv8 master branch (unreleased), which fixes all these issues. >> How does it deal with the function declaration incompatibility problem? > commit df92ced297282ffbb13e95748543b6c52ad4d238 >

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 5/12/14, 12:42 PM, Tom Lane wrote: > > Peter Eisentraut writes: > >> You need plv8 master branch (unreleased), which fixes all these issues. > > > > How does it deal with the function declaration incompatibility problem? > > commit df92ced297282ffbb13e95748543b6c52ad

[HACKERS] Running DBT2 on postgresql

2014-05-12 Thread Rohit Goyal
Hi All, Please help me in running DBT2 on postgresql. I am doing it for the first time. I am facing error while running dbt2 test. I installed dbt2 by following "install" file. Below some final lines of terminal. Install the project... -- Install configuration: "" -- Installing: /home/abhi/dbt2_

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Ants Aasma
On Mon, May 12, 2014 at 7:10 PM, Greg Stark wrote: > Would it be useful to store the current WAL insertion point along with > the "about to commit" flag so it's effectively a promise that this > transaction will commit no earlier than XXX. That should allow most > transactions to decide if those r

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Peter Eisentraut
On 5/12/14, 12:42 PM, Tom Lane wrote: > Peter Eisentraut writes: >> You need plv8 master branch (unreleased), which fixes all these issues. > > How does it deal with the function declaration incompatibility problem? commit df92ced297282ffbb13e95748543b6c52ad4d238 Author: Hitoshi Harada Date:

Re: [HACKERS] Archive recovery won't be completed on some situation.

2014-05-12 Thread Fujii Masao
On Tue, May 13, 2014 at 1:36 AM, Tom Lane wrote: > Fujii Masao writes: >> On Mon, May 12, 2014 at 8:40 PM, Heikki Linnakangas >> wrote: >>> I agree the new behavior is better, and we should just remove the Open Items >>> entry. > >> Yes. I just removed that entry. > > Our practice in past years

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Tom Lane
Peter Eisentraut writes: > You need plv8 master branch (unreleased), which fixes all these issues. How does it deal with the function declaration incompatibility problem? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make ch

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Pavel Stehule
2014-05-12 18:36 GMT+02:00 Peter Eisentraut : > On 5/12/14, 11:05 AM, Pavel Stehule wrote: > > After returning back before this commit I cannot compile PL/V8 still but > > with more solvable bug > > > > g++ -Wall -O2 -I. -I./ -I/usr/local/pgsql/include/server > > -I/usr/local/pgsql/include/inter

Re: [HACKERS] Archive recovery won't be completed on some situation.

2014-05-12 Thread Tom Lane
Fujii Masao writes: > On Mon, May 12, 2014 at 8:40 PM, Heikki Linnakangas > wrote: >> I agree the new behavior is better, and we should just remove the Open Items >> entry. > Yes. I just removed that entry. Our practice in past years has been to move items to a separate "Resolved Issues" sectio

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Peter Eisentraut
On 5/12/14, 11:05 AM, Pavel Stehule wrote: > After returning back before this commit I cannot compile PL/V8 still but > with more solvable bug > > g++ -Wall -O2 -I. -I./ -I/usr/local/pgsql/include/server > -I/usr/local/pgsql/include/internal -D_GNU_SOURCE > -I/usr/include/libxml2 -fPIC -c -o pl

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Andres Freund
On 2014-05-12 19:14:55 +0300, Heikki Linnakangas wrote: > On 05/12/2014 06:26 PM, Andres Freund wrote: > >>>With the new "commit-in-progress" status in clog, we won't need the > >>>sub-committed clog status anymore. The "commit-in-progress" status will > >>>achieve the same thing. > >Wouldn't that

Re: [HACKERS] Archive recovery won't be completed on some situation.

2014-05-12 Thread Fujii Masao
On Mon, May 12, 2014 at 8:40 PM, Heikki Linnakangas wrote: > On 05/12/2014 02:29 PM, Fujii Masao wrote: >> >> Hmm.. probably I have the same opinion with you. If I understand this >> correctly, >> an immediate shutdown doesn't call CancelBackup() in 9.4 or before. But >> the >> commit 82233ce unin

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Heikki Linnakangas
On 05/12/2014 06:26 PM, Andres Freund wrote: >With the new "commit-in-progress" status in clog, we won't need the >sub-committed clog status anymore. The "commit-in-progress" status will >achieve the same thing. Wouldn't that cause many spurious waits? Because commit-in-progress needs to be wait

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Greg Stark
On Mon, May 12, 2014 at 2:56 PM, Heikki Linnakangas wrote: > Currently, before consulting the clog for an XID's status, it is necessary > to first check if the transaction is still in progress by scanning the proc > array. To get rid of that requirement, just before writing the commit record > in

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Ants Aasma
On Mon, May 12, 2014 at 6:09 PM, Robert Haas wrote: > However, I wonder what > happens if you write the commit record and then the attempt to update > pg_clog fails. I think you'll have to PANIC, which kind of sucks. CLOG IO error while commiting is already a PANIC, SimpleLruReadPage() does Slru

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Ants Aasma
On Mon, May 12, 2014 at 4:56 PM, Heikki Linnakangas wrote: > On 01/24/2014 02:10 PM, Rajeev rastogi wrote: >> >> We are also planning to implement CSN based snapshot. >> So I am curious to know whether any further development is happening on >> this. > > > I started looking into this, and plan to

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Robert Haas
On Mon, May 12, 2014 at 10:41 AM, Andres Freund wrote: > On 2014-05-12 16:56:51 +0300, Heikki Linnakangas wrote: >> On 01/24/2014 02:10 PM, Rajeev rastogi wrote: >> >We are also planning to implement CSN based snapshot. >> >So I am curious to know whether any further development is happening on >

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Pavel Stehule
2014-05-12 16:31 GMT+02:00 Tom Lane : > Andrew Dunstan writes: > > On 05/12/2014 07:10 AM, Pavel Stehule wrote: > >> I am trying to compile PL/v8 without success. I have Postgres > >> installed via compilation from source code. > > >> plv8.cc:50:56: error: declaration of ‘Datum > >> plv8_call_han

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Heikki Linnakangas
On 05/12/2014 05:41 PM, Andres Freund wrote: I haven't fully thought it through but I think it should make some of the decoding code simpler. And it should greatly simplify the hot standby code. Cool. I was worried it might conflict with the logical decoding stuff in some fundamental way, as I

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Tom Lane
Greg Stark writes: > On Mon, May 12, 2014 at 2:12 PM, Greg Stark wrote: >> Hm, there was an off by one error earlier in some cases, maybe we >> fixed it by breaking other case. Will investigate. > Those spaces are coming from the ascii wrapping indicators. i.e. the periods > in: Ah. I wonder

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Andres Freund
On 2014-05-12 16:56:51 +0300, Heikki Linnakangas wrote: > On 01/24/2014 02:10 PM, Rajeev rastogi wrote: > >We are also planning to implement CSN based snapshot. > >So I am curious to know whether any further development is happening on this. > > I started looking into this, and plan to work on thi

Re: [HACKERS] Select queries which violates table constrains

2014-05-12 Thread Heikki Linnakangas
On 05/10/2014 09:24 PM, Joni Martikainen wrote: Hi, I investigated some select query performance issues and noticed that postgresql misses some obvious cases while processing SELECT query. I mean the case where WHERE clause contains statement which condition would be against table structure. (ex

Re: [HACKERS] Select queries which violates table constrains

2014-05-12 Thread Tom Lane
Joni Martikainen writes: > I investigated some select query performance issues and noticed that > postgresql misses some obvious cases while processing SELECT query. I > mean the case where WHERE clause contains statement which condition > would be against table structure. (excuse my language,

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Tom Lane
Andrew Dunstan writes: > On 05/12/2014 07:10 AM, Pavel Stehule wrote: >> I am trying to compile PL/v8 without success. I have Postgres >> installed via compilation from source code. >> plv8.cc:50:56: error: declaration of ‘Datum >> plv8_call_handler(FunctionCallInfo) throw ()’ has a differe

Re: [HACKERS] Ignore src/tools/msvc/config.pl in code tree for MSVC compilation

2014-05-12 Thread Michael Paquier
On Mon, May 12, 2014 at 3:08 PM, Michael Paquier wrote: > Hi all, > > MSVC build uses two configuration perl files when running: > config_default.pl and config.pl. The former is mandatory and is > present in the code tree, while the latter can be used to override > settings with some custom parame

[HACKERS] Ignore src/tools/msvc/config.pl in code tree for MSVC compilation

2014-05-12 Thread Michael Paquier
Hi all, MSVC build uses two configuration perl files when running: config_default.pl and config.pl. The former is mandatory and is present in the code tree, while the latter can be used to override settings with some custom parameters. As far as I understand from the docs, config.pl should be used

[HACKERS] Select queries which violates table constrains

2014-05-12 Thread Joni Martikainen
Hi, I investigated some select query performance issues and noticed that postgresql misses some obvious cases while processing SELECT query. I mean the case where WHERE clause contains statement which condition would be against table structure. (excuse my language, look the code) Example: Le

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Pavel Stehule
2014-05-12 15:42 GMT+02:00 Andrew Dunstan : > > On 05/12/2014 07:10 AM, Pavel Stehule wrote: > >> Hello >> >> I am trying to compile PL/v8 without success. I have Postgres installed >> via compilation from source code. >> >> After make I got errors >> >> [pavel@localhost plv8-1.4.2]$ make >> g++ -

Re: [HACKERS] Proposal for CSN based snapshots

2014-05-12 Thread Heikki Linnakangas
On 01/24/2014 02:10 PM, Rajeev rastogi wrote: We are also planning to implement CSN based snapshot. So I am curious to know whether any further development is happening on this. I started looking into this, and plan to work on this for 9.5. It's a big project, so any help is welcome. The desig

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Andrew Dunstan
On 05/12/2014 07:10 AM, Pavel Stehule wrote: Hello I am trying to compile PL/v8 without success. I have Postgres installed via compilation from source code. After make I got errors [pavel@localhost plv8-1.4.2]$ make g++ -Wall -O2 -I. -I./ -I/usr/local/pgsql/include/server -I/usr/local/pgs

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Greg Stark
On Mon, May 12, 2014 at 2:12 PM, Greg Stark wrote: > Hm, there was an off by one error earlier in some cases, maybe we > fixed it by breaking other case. Will investigate. Those spaces are coming from the ascii wrapping indicators. i.e. the periods in: +-++ |

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-05-12 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: > On Sun, May 4, 2014 at 11:12:57AM -0400, Tom Lane wrote: > > Stephen Frost writes: > > > * Abhijit Menon-Sen (a...@2ndquadrant.com) wrote: > > >> 1. I wish it were possible to prevent even the superuser from disabling > > >> audit logging once it's enab

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Greg Stark
On Mon, May 12, 2014 at 2:00 PM, Tom Lane wrote: > but where did those leading spaces come from? The header line is > definitely not on board with that, and I think those spaces are > contributing to the lines being too long for the window. I think > possibly the code is also adding a space that

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Tom Lane
Emre Hasegeli writes: > Pavel Stehule : >> I am checking feature >> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=6513633b94173fc1d9e2b213c43f9422ddbf5faa >> >> It works perfect with pager "less", but it works badly with default "more" > I do not think so. It looks broken wit

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Pavel Stehule
2014-05-12 13:45 GMT+02:00 Michael Paquier : > On Mon, May 12, 2014 at 8:10 PM, Pavel Stehule > wrote: > > g++ -Wall -O2 -I. -I./ -I/usr/local/pgsql/include/server > > -I/usr/local/pgsql/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 > > -fPIC -c -o plv8.o plv8.cc > > plv8.cc:50:56: error

Re: [HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Michael Paquier
On Mon, May 12, 2014 at 8:10 PM, Pavel Stehule wrote: > g++ -Wall -O2 -I. -I./ -I/usr/local/pgsql/include/server > -I/usr/local/pgsql/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 > -fPIC -c -o plv8.o plv8.cc > plv8.cc:50:56: error: declaration of 'Datum > plv8_call_handler(FunctionCallIn

Re: [HACKERS] Archive recovery won't be completed on some situation.

2014-05-12 Thread Heikki Linnakangas
On 05/12/2014 02:29 PM, Fujii Masao wrote: Hmm.. probably I have the same opinion with you. If I understand this correctly, an immediate shutdown doesn't call CancelBackup() in 9.4 or before. But the commit 82233ce unintentionally changed an immediate shutdown so that it calls CancelBackup(). O

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Emre Hasegeli
Pavel Stehule : > Hello > > I am checking feature > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=6513633b94173fc1d9e2b213c43f9422ddbf5faa > > It works perfect with pager "less", but it works badly with default "more" > > see attached screenshots, pls > > It is expected behave?

Re: [HACKERS] Archive recovery won't be completed on some situation.

2014-05-12 Thread Fujii Masao
On Mon, May 12, 2014 at 4:52 PM, Heikki Linnakangas wrote: > On 05/09/2014 05:19 PM, Fujii Masao wrote: >> >> On Thu, Mar 20, 2014 at 11:38 PM, Alvaro Herrera >> wrote: >>> >>> Kyotaro HORIGUCHI escribió: Hi, I confirmed that 82233ce7ea4 surely did it. At Wed, 19 Mar 2014 09:3

Re: [HACKERS] pg_class.relpages/allvisible probably shouldn't be a int4

2014-05-12 Thread Tom Lane
Andres Freund writes: > On 2014-05-12 10:07:29 +0300, Heikki Linnakangas wrote: >> But I concur that in practice, if you're dealing with 16TB tables, it's time >> to partition. > Well, we need to improve our partitioning for that to be viable for all > relations. Not having usable foreign and uni

[HACKERS] cannot to compile PL/V8 on Fedora 20

2014-05-12 Thread Pavel Stehule
Hello I am trying to compile PL/v8 without success. I have Postgres installed via compilation from source code. After make I got errors [pavel@localhost plv8-1.4.2]$ make g++ -Wall -O2 -I. -I./ -I/usr/local/pgsql/include/server -I/usr/local/pgsql/include/internal -D_GNU_SOURCE -I/usr/include/li

Re: [HACKERS] Runing DBT2 on Postgresql

2014-05-12 Thread Rohit Goyal
On Thu, Apr 24, 2014 at 6:57 AM, Peter Geoghegan wrote: > On Wed, Apr 23, 2014 at 2:33 AM, Rohit Goyal wrote: > > I am trying to install dbt2 on postgresql database. > > > > cmake(configure) command work fine and but make command(build) give an > error > > given below. I have no idea about how t

Re: [HACKERS] Archive recovery won't be completed on some situation.

2014-05-12 Thread Heikki Linnakangas
On 05/09/2014 05:19 PM, Fujii Masao wrote: On Thu, Mar 20, 2014 at 11:38 PM, Alvaro Herrera wrote: Kyotaro HORIGUCHI escribió: Hi, I confirmed that 82233ce7ea4 surely did it. At Wed, 19 Mar 2014 09:35:16 -0300, Alvaro Herrera wrote Fujii Masao escribió: On Wed, Mar 19, 2014 at 7:57 PM, Heik

Re: [HACKERS] [COMMITTERS] pgsql: Clean up jsonb code.

2014-05-12 Thread Heikki Linnakangas
On 05/10/2014 01:32 AM, Tom Lane wrote: Peter Geoghegan writes: On Fri, May 9, 2014 at 2:54 PM, Tom Lane wrote: However, what it looks to me like we've got here is a very bad reimplementation of StringInfo buffers. There is for example no integer-overflow checking here. Rather than try to b

Re: [HACKERS] pg_class.relpages/allvisible probably shouldn't be a int4

2014-05-12 Thread Andres Freund
On 2014-05-12 10:07:29 +0300, Heikki Linnakangas wrote: > On 05/12/2014 12:30 AM, Andres Freund wrote: > >>>So if I were to take Andres' > >>>complaint seriously at all, I'd be thinking in terms of "do we need to > >>>widen BlockNumber to int64?", not "how do we make this print as > >>>unsigned?".

Re: [HACKERS] pg_class.relpages/allvisible probably shouldn't be a int4

2014-05-12 Thread Heikki Linnakangas
On 05/12/2014 12:30 AM, Andres Freund wrote: >So if I were to take Andres' >complaint seriously at all, I'd be thinking in terms of "do we need to >widen BlockNumber to int64?", not "how do we make this print as >unsigned?". But I doubt such a proposal would fly, because of the >negative impact