Re: [HACKERS] INSERT...ON DUPLICATE KEY LOCK FOR UPDATE

2013-12-25 Thread Peter Geoghegan
On Wed, Dec 25, 2013 at 6:25 AM, Andres Freund wrote: > So? I still have the fear that you approach will end up being way too > complicated and full of layering violations. I didn't say it's a no-go > (not that I have veto powers, even if I'd consider it one). Apart from not resulting in unprinci

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-25 Thread Tom Lane
"Erik Rijkers" writes: > I have a 200 GB dev database running under 9.4devel that I thought I could > now, for test purposes, compile a patched > postgres binary for (i.e.: a HEAD + > inverse_transition_functions_v1.5.patch.gz binary), so as to avoid an initdb > and use > the existing 200 GB d

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-25 Thread Erik Rijkers
On Wed, December 25, 2013 14:49, David Rowley wrote: > [ inverse_transition_functions_v1.5.patch.gz ] I ran into the following problem which is, I think, NOT a problem with your patch but with my setup. Still, if anyone can enlighten me on its cause I'd be thankful (it shows up every now and th

Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-25 Thread Oleg Bartunov
Yes, we got temp licence key from them and will provide full report. On Wed, Dec 25, 2013 at 4:38 PM, Joel Jacobson wrote: > As reported by Andrey Karpov in his article > http://www.viva64.com/en/b/0227/, the version number is expressed in > octal form 070100 should be changed to 70100. > > Attac

Re: [HACKERS] INSERT...ON DUPLICATE KEY LOCK FOR UPDATE

2013-12-25 Thread Andres Freund
Hi, On 2013-12-24 13:18:36 -0800, Peter Geoghegan wrote: > On Tue, Dec 24, 2013 at 4:09 AM, Andres Freund wrote: > > I don't really see the lack of review as being crucial at this point. At > > least I have quite some doubts about the approach you've chosen and I > > have voiced it - so have othe

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2013-12-25 Thread David Rowley
On Sun, Dec 22, 2013 at 2:42 AM, David Rowley wrote: > On Sun, Dec 22, 2013 at 1:01 AM, Erik Rijkers wrote: > >> On Sat, December 21, 2013 12:52, David Rowley wrote: >> > On Sun, Dec 22, 2013 at 12:49 AM, Erik Rijkers wrote: >> > >> >> On Sat, December 21, 2013 12:38, David Rowley wrote: >> >>

[HACKERS] [BUGFIX] Typos when using the memcmp() function.

2013-12-25 Thread Joel Jacobson
As reported by Andrey Karpov in his article http://www.viva64.com/en/b/0227/, a parenthesis has been misplaced. Attached patch fixes the problem. memcmp-parenthesis-typo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-25 Thread Joel Jacobson
As reported by Andrey Karpov in his article http://www.viva64.com/en/b/0227/, the version number is expressed in octal form 070100 should be changed to 70100. Attached patch fixes the reported issue. octal-typo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hacker

[HACKERS] [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0

2013-12-25 Thread Joel Jacobson
Hi, I've tried to fix some bugs reported by Andrey Karpov in an article at http://www.viva64.com/en/b/0227/ The value returned by socket() is unsigned on Windows and can thus not be checked if less than zero to detect an error, instead PGINVALID_SOCKET should be used, which is hard-coded to -1 on

[HACKERS] BDR-project

2013-12-25 Thread Andreas Joseph Krogh
Hi hackers.   Ref: http://wiki.postgresql.org/wiki/BDR_Project   Is implementing main BDR features into core Postgres a probable objective to version 9.4?   Thanks.   -- Andreas Joseph Krogh       mob: +47 909 56 963 Senior Software Developer / CTO - OfficeNet AS - http://www.officenet.no Publ

Re: [HACKERS] [bug fix] "pg_ctl stop" times out when it should respond quickly

2013-12-25 Thread MauMau
From: "Peter Eisentraut" This patch breaks the regression tests: xml ... ok test stats... ok == shutting down postmaster == pg_ctl: server does not shut down pg_regress: could not stop postmaster: exit code was

Re: [HACKERS] varattno remapping

2013-12-25 Thread Craig Ringer
On 12/24/2013 11:17 PM, Dean Rasheed wrote: > I don't think this bit is quite right. > > It's not correct to assume that all the view columns are simple > references to columns of the base relation --- auto-updatable views > may now contain a mix of updatable and non-updatable columns, so some > o

Re: [HACKERS] Fix typo in src/backend/utils/mmgr/README

2013-12-25 Thread Etsuro Fujita
Peter Eisentraut wrote: > On 12/24/13, 1:33 AM, Etsuro Fujita wrote: > > This is a small patch to fix a typo in src/backend/utils/mmgr/README. > I don't think that change is correct. I've fixed the patch, though that might be still wrong. I'm not a native English speaker ;). Please find attache