Re: [HACKERS] Proof of concept: standalone backend with full FE/BE protocol

2013-11-16 Thread Amit Kapila
On Fri, Nov 15, 2013 at 5:21 PM, Simon Riggs wrote: > On 14 November 2013 03:41, Amit Kapila wrote: > >> I have gone through the mail chain of this thread and tried to find >> the different concerns or open ends for this patch. > > Not enough. This feature is clearly being suggested as a way to o

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-16 Thread Amit Kapila
On Sat, Nov 16, 2013 at 4:35 PM, Haribabu kommi wrote: > On 16 November 2013 09:43 Amit Kapila wrote: >> On Fri, Nov 15, 2013 at 10:18 PM, Peter Eisentraut >> wrote: >> > On 11/14/13, 2:50 AM, Amit Kapila wrote: >> >> Find the rebased version attached with this mail. >> > > Please find review com

Re: [HACKERS] [PATCH] Use MAP_HUGETLB where supported (v3)

2013-11-16 Thread Sameer Kumar
I was recently running some tests with huge page tables. I ran them on two different architectures: x86 and PPC64. I saw some discussion going on over here so thought of sharing. I was using 3 Cores, 8GB RAM, 2 LUN for filesystem (1 for dbfiles and 1 for logfiles) for these tests... I had dedicat

Re: [HACKERS] Storing pg_stat_statements query texts externally, pg_stat_statements in core

2013-11-16 Thread Peter Geoghegan
On Sat, Nov 16, 2013 at 4:36 PM, Peter Geoghegan wrote: > I'll post a revision with fixes for those. Another concern is that I > see some race conditions that only occur when pg_stat_statements cache > is under a lot of pressure with a lot of concurrency, that wasn't > revealed by my original test

Re: [HACKERS] pre-commit triggers

2013-11-16 Thread Tom Lane
Hannu Krosing writes: > I have not looked at the patch, but does it also run pre-rollback ? error in trigger -> instant infinite loop. Besides, exactly what would you do in such a trigger? Not modify the database, for certain, because we're about to roll back. regards,

Re: [HACKERS] CREATE TABLE IF NOT EXISTS AS

2013-11-16 Thread Tom Lane
"David E. Wheeler" writes: > Co-worker asked a question I could not answer: Why is IF NOT EXISTS not > supported by CREATE TABLE AS? That's an even worse idea than plain CREATE IF NOT EXISTS (which was put in over vocal objections from me and some other people). Not only would you not have the

Re: [HACKERS] Storing pg_stat_statements query texts externally, pg_stat_statements in core

2013-11-16 Thread Peter Geoghegan
On Fri, Nov 15, 2013 at 8:51 AM, Peter Eisentraut wrote: > Compiler warnings with fortify settings: I'll post a revision with fixes for those. Another concern is that I see some race conditions that only occur when pg_stat_statements cache is under a lot of pressure with a lot of concurrency, tha

Re: [HACKERS] Improving avg performance for numeric

2013-11-16 Thread Tom Lane
Pavel Stehule writes: > [ numeric-optimize-v8.patch ] I've committed this with some adjustments. Aside from cosmetic changes and documentation/comment improvements: * I don't agree at all with the claim that aggtransspace is only useful for INTERNAL transition data. There are lots of cases wit

Re: [HACKERS] additional json functionality

2013-11-16 Thread Josh Berkus
On 11/16/2013 02:04 PM, Hannu Krosing wrote: > On 11/16/2013 10:30 PM, David E. Wheeler wrote: >> I still like JSONB best. > To me it feels redundant, like binarytextbinary > > the binary representation of JSON is JavaScript(-like) Object, not > "binary json" JSONB is as close as we can get to "

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Adrian Klaver
On 11/16/2013 03:46 PM, Marko Kreen wrote: On Sat, Nov 16, 2013 at 03:21:19PM -0800, Adrian Klaver wrote: On 11/16/2013 03:09 PM, Marko Kreen wrote: On Sat, Nov 16, 2013 at 02:54:22PM -0800, Adrian Klaver wrote: On 11/16/2013 02:41 PM, Marko Kreen wrote: If you don't see any other issues perh

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Marko Kreen
On Sat, Nov 16, 2013 at 03:21:19PM -0800, Adrian Klaver wrote: > On 11/16/2013 03:09 PM, Marko Kreen wrote: > >On Sat, Nov 16, 2013 at 02:54:22PM -0800, Adrian Klaver wrote: > >>On 11/16/2013 02:41 PM, Marko Kreen wrote: > >>>If you don't see any other issues perhaps they are ready for committer? >

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Adrian Klaver
On 11/16/2013 03:09 PM, Marko Kreen wrote: On Sat, Nov 16, 2013 at 02:54:22PM -0800, Adrian Klaver wrote: On 11/16/2013 02:41 PM, Marko Kreen wrote: If you don't see any other issues perhaps they are ready for committer? I do not have any other questions/issues at this point. I am new to the

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Marko Kreen
On Sat, Nov 16, 2013 at 02:54:22PM -0800, Adrian Klaver wrote: > On 11/16/2013 02:41 PM, Marko Kreen wrote: > >If you don't see any other issues perhaps they are ready for committer? > > I do not have any other questions/issues at this point. I am new to > the review process, so I am not quite sur

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Adrian Klaver
On 11/16/2013 02:41 PM, Marko Kreen wrote: On Sat, Nov 16, 2013 at 02:07:57PM -0800, Adrian Klaver wrote: On 11/16/2013 01:13 PM, Marko Kreen wrote: https://commitfest.postgresql.org/action/patch_view?id=1310 Got it, applied it. Results: openssl ciphers -v 'HIGH:!aNULL'|egrep '(RC4|SE

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Marko Kreen
On Sat, Nov 16, 2013 at 02:07:57PM -0800, Adrian Klaver wrote: > On 11/16/2013 01:13 PM, Marko Kreen wrote: > >https://commitfest.postgresql.org/action/patch_view?id=1310 > > Got it, applied it. > > Results: > > openssl ciphers -v 'HIGH:!aNULL'|egrep > '(RC4|SEED|DES-CBC|EXP|NULL|ADH|AECDH

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Adrian Klaver
On 11/16/2013 01:13 PM, Marko Kreen wrote: On Sat, Nov 16, 2013 at 01:03:05PM -0800, Adrian Klaver wrote: On 11/16/2013 12:37 PM, Marko Kreen wrote: Thanks for testing! On Sat, Nov 16, 2013 at 12:17:40PM -0800, Adrian Klaver wrote: On 11/16/2013 06:24 AM, Marko Kreen wrote: ssl-better-defaul

Re: [HACKERS] additional json functionality

2013-11-16 Thread Hannu Krosing
On 11/16/2013 10:30 PM, David E. Wheeler wrote: > On Nov 16, 2013, at 12:04 PM, Hannu Krosing wrote: > >> Then perhaps name the "new binary json" as jsob (JavaScript Object Binary) >> or just jsobj (JavaScript Object) and keep current json for what it is, >> namely >> JavaScript Object Notation. >

Re: [HACKERS] additional json functionality

2013-11-16 Thread David E. Wheeler
On Nov 16, 2013, at 12:04 PM, Hannu Krosing wrote: > Then perhaps name the "new binary json" as jsob (JavaScript Object Binary) > or just jsobj (JavaScript Object) and keep current json for what it is, > namely > JavaScript Object Notation. It’s still input and output as JSON, though. I still l

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Marko Kreen
On Sat, Nov 16, 2013 at 01:03:05PM -0800, Adrian Klaver wrote: > On 11/16/2013 12:37 PM, Marko Kreen wrote: > >Thanks for testing! > > > >On Sat, Nov 16, 2013 at 12:17:40PM -0800, Adrian Klaver wrote: > >>On 11/16/2013 06:24 AM, Marko Kreen wrote: > >>>ssl-better-default: > >>> SSL should stay wo

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Adrian Klaver
On 11/16/2013 12:37 PM, Marko Kreen wrote: Thanks for testing! On Sat, Nov 16, 2013 at 12:17:40PM -0800, Adrian Klaver wrote: On 11/16/2013 06:24 AM, Marko Kreen wrote: ssl-better-default: SSL should stay working, openssl ciphers -v 'value' should not contain any weak suites (RC4, SEED,

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.2

2013-11-16 Thread Peter Eisentraut
On Fri, 2013-11-15 at 20:47 +0100, Andres Freund wrote: > So, here's the next version of this patchset: The 0002 patch contains non-ASCII, non-UTF8 characters: 0002-Very-basic-atomic-ops-implementation.patch: line 609, char 1, byte offset 43: invalid UTF-8 code Please change that to ASCII, or U

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Marko Kreen
Thanks for testing! On Sat, Nov 16, 2013 at 12:17:40PM -0800, Adrian Klaver wrote: > On 11/16/2013 06:24 AM, Marko Kreen wrote: > >ssl-better-default: > > SSL should stay working, openssl ciphers -v 'value' should not contain > > any weak suites (RC4, SEED, DES-CBC, EXP, NULL) and no non-authe

Re: [HACKERS] pre-commit triggers

2013-11-16 Thread Andrew Dunstan
On 11/16/2013 03:00 PM, Hannu Krosing wrote: On 11/15/2013 07:01 PM, Andrew Dunstan wrote: Attached is a patch to provide a new event trigger that will fire on transaction commit. I have tried to make certain that it fires at a sufficiently early stage in the commit process that some of the

[HACKERS] Wildcard usage enhancements in .pgpass

2013-11-16 Thread Alexey Klyukin
Hi, Attached is the patch that improves usage of '*' wildcard in .pgpass, particularly in the host part. The use case is below. I work with multiple environments (like staging, production, performance and so on), each one containing tens of different database clusters, each cluster has its own su

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Adrian Klaver
On 11/16/2013 06:24 AM, Marko Kreen wrote: On Fri, Nov 15, 2013 at 02:16:52PM -0800, Adrian Klaver wrote: On 11/15/2013 11:49 AM, Marko Kreen wrote: On Fri, Nov 15, 2013 at 11:16:25AM -0800, Adrian Klaver wrote: The description of the GUCs show up in the documentation but I am not seeing the G

Re: [HACKERS] additional json functionality

2013-11-16 Thread Hannu Krosing
On 11/16/2013 12:15 AM, Josh Berkus wrote: > On 11/15/2013 02:59 PM, Merlin Moncure wrote: >> On Fri, Nov 15, 2013 at 4:31 PM, Hannu Krosing >> wrote: >> I think you may be on to something here. This might also be a way >> opt-in to fast(er) serialization (upthread it was noted this is >> unimp

[HACKERS] freeze cannot be finished

2013-11-16 Thread Миша Тюрин
Hello! Could anyone review patch suggested by Jeff Janes ? Initial thread http://www.postgresql.org/message-id/flat/1384356585.995240...@f50.i.mail.ru#1384356585.995240...@f50.i.mail.ru Thanks in advance! > > On Wed, Nov 13, 2013 at 3:53 PM, Sergey Burladyan < eshkin...@gmail.com > > wrote

Re: [HACKERS] pre-commit triggers

2013-11-16 Thread Hannu Krosing
On 11/15/2013 07:01 PM, Andrew Dunstan wrote: > > Attached is a patch to provide a new event trigger that will fire on > transaction commit. I have tried to make certain that it fires at a > sufficiently early stage in the commit process that some of the evils > mentioned in previous discussions on

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-16 Thread Fujii Masao
On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi wrote: > on 15 November 2013 17:26 Magnus Hagander wrote: > >>On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi >> wrote: > >>On 14 November 2013 23:59 Fujii Masao wrote: >>> On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi >>> wrote: >>> > Please fi

[HACKERS] CREATE TABLE IF NOT EXISTS AS

2013-11-16 Thread David E. Wheeler
Hackers, Co-worker asked a question I could not answer: Why is IF NOT EXISTS not supported by CREATE TABLE AS? Oversight, perhaps? Or maybe because one expects the table to have the data from the SELECT statement? If the latter, maybe OR REPLACE would be useful? Best, David -- Sent via pgsq

Re: [HACKERS] Review:Patch: SSL: prefer server cipher order

2013-11-16 Thread Marko Kreen
On Fri, Nov 15, 2013 at 02:16:52PM -0800, Adrian Klaver wrote: > On 11/15/2013 11:49 AM, Marko Kreen wrote: > >On Fri, Nov 15, 2013 at 11:16:25AM -0800, Adrian Klaver wrote: > >>The description of the GUCs show up in the documentation but I am > >>not seeing the GUCs themselves in postgresql.conf,

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-16 Thread Haribabu kommi
On 16 November 2013 09:43 Amit Kapila wrote: > On Fri, Nov 15, 2013 at 10:18 PM, Peter Eisentraut > wrote: > > On 11/14/13, 2:50 AM, Amit Kapila wrote: > >> Find the rebased version attached with this mail. > > > > Doesn't build: > > > > openjade -wall -wno-unused-param -wno-empty -wfully-tagged