[HACKERS] Small comment fix in sinvaladt.c

2013-07-30 Thread Hitoshi Harada
diff --git a/src/backend/storage/ipc/sinvaladt.c b/src/backend/storage/ipc/sinvaladt.c index 09f41c1..44d02c5 100644 --- a/src/backend/storage/ipc/sinvaladt.c +++ b/src/backend/storage/ipc/sinvaladt.c @@ -214,7 +214,7 @@ SInvalShmemSize(void) } /* - * SharedInvalBufferInit + * CreateSharedInvali

Re: [HACKERS] pass-through queries to foreign servers

2013-07-30 Thread Tom Lane
David Fetter writes: > On Tue, Jul 30, 2013 at 04:40:38PM -0700, David Gudeman wrote: >> When you write an application involving foreign tables, you frequently >> end up with queries that are just too inefficient because they bring >> too much data over from the foreign server. For a trivial examp

Re: [HACKERS] Backup throttling

2013-07-30 Thread Gibheer
On Wed, 24 Jul 2013 09:20:52 +0200 Antonin Houska wrote: > Hello, > the purpose of this patch is to limit impact of pg_backup on running > server. Feedback is appreciated. > > // Antonin Houska (Tony) Hi, That is a really nice feature. I took a first look at your patch and some empty lines yo

Re: [HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-07-30 Thread Peter Geoghegan
On Tue, Jul 30, 2013 at 10:33 AM, Greg Stark wrote: > I think there's some magic in gdb for this but I'm not sure how to > make it happen. If you figure it out I would think it would be > generally useful and we should find a way to put it in the source tree > so it works for everyone. You can wr

Re: [HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-07-30 Thread Andres Freund
Hi, On 2013-06-26 13:27:15 +0900, Amit Langote wrote: > Is it possible to compute VARSIZE_ANY(PTR) during debugging? > > - > #define VARSIZE_ANY(PTR) \ > (VARATT_IS_1B_E(PTR) ? VARSIZE_1B_E(PTR) : \ > (VARATT_IS_1B(PTR) ? VA

[HACKERS] Re: [COMMITTERS] pgsql: Add support for REFRESH MATERIALIZED VIEW CONCURRENTLY.

2013-07-30 Thread Andres Freund
Hi Kevin, On 2013-07-23 09:27:34 -0700, Kevin Grittner wrote: > Andres Freund wrote: > > > Hm. There seems to be more things that need some more improvement > > from a quick look. > > > > First, I have my doubts of the general modus operandy of > > CONCURRENTLY here. I think in many, many cases

Re: [HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-07-30 Thread Amit Langote
On Wed, Jul 31, 2013 at 2:33 AM, Greg Stark wrote: > I think there's some magic in gdb for this but I'm not sure how to > make it happen. If you figure it out I would think it would be > generally useful and we should find a way to put it in the source tree > so it works for everyone. > > You migh

Re: [HACKERS] pass-through queries to foreign servers

2013-07-30 Thread David Fetter
On Tue, Jul 30, 2013 at 04:40:38PM -0700, David Gudeman wrote: > When you write an application involving foreign tables, you frequently > end up with queries that are just too inefficient because they bring > too much data over from the foreign server. For a trivial example, > consider "SELECT coun

[HACKERS] pass-through queries to foreign servers

2013-07-30 Thread David Gudeman
When you write an application involving foreign tables, you frequently end up with queries that are just too inefficient because they bring too much data over from the foreign server. For a trivial example, consider "SELECT count(*) FROM t" where t is a foreign table. This will pull the entire tabl

Re: [HACKERS] Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Stephen Frost
* Greg Stark (st...@mit.edu) wrote: > I used to be a Debian package maintainer. I packaged kerberos and afs and a > number of smaller packages. I know why Debian separates config files. Ditto (though I suppose I'm still technically "active"). > If a file is automatically maintained then it's inte

Re: [HACKERS] [9.3 bug] disk space in pg_xlog increases during archive recovery

2013-07-30 Thread MauMau
From: "Fujii Masao" So, I think it is a bug that the disk space increases if not using cascading replication. Those who migrated from 9.1 and do not use 9.2 features would be surprised like me. Do you think this should be fixed? I think so. Thanks for your agreement. I'll try to submit

Re: [HACKERS] install libpq.dll in bin directory on Windows / Cygwin

2013-07-30 Thread MauMau
From: "Andrew Dunstan" I don't have a problem adding them to the bin directory. I'd be very slightly wary of removing them from the lib directory, for legacy reasons. Maybe these changes should be done for git tip and not backported (or maybe just to 9.3). Or we could just decide to clean this

[HACKERS] Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Greg Stark
On Jul 30, 2013 7:32 PM, "Josh Berkus" wrote: > > > I don't think you understood GSmith's argument. For Debian/Ubuntu > sysadmins, configuration files live in /etc/, *period*. Even ones which > were automatically generated. The packagers and scripters of that OS > have taken a significant amoun

Re: [HACKERS] Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Josh Berkus
On 07/30/2013 11:12 AM, Greg Stark wrote: > But if we're going to insist that conf.d be in PGDATA then I'm saying > we don't need a second conf.d just to contain that one file. And if we > let distributions and sysadmins drop files in there then we'll be back > to square 0 with wanting to separate

[HACKERS] Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Greg Stark
On Tue, Jul 30, 2013 at 6:40 PM, Josh Berkus wrote: > > On 07/30/2013 10:28 AM, Greg Stark wrote:> On Tue, Jul 30, 2013 at 6:10 > PM, Alvaro Herrera >> Well more to the point, if we conf.d for sysadmins to drop in extra >> snippets in a different place then we could drop conf.d in PGDATA >> since

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Josh Berkus
On 07/30/2013 10:10 AM, Alvaro Herrera wrote: >> Once we have consensus on these issues, then hopefully we can commit >> your patch. I don't *think* anyone is arguing with the code at this stage. > > There's one other thing, raised by Cédric upthread, about the multiple > files vs. single file.

Re: [HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-07-30 Thread Greg Stark
I think there's some magic in gdb for this but I'm not sure how to make it happen. If you figure it out I would think it would be generally useful and we should find a way to put it in the source tree so it works for everyone. You might find it useful to put breakpoints in heap_deformtuple() with

[HACKERS] Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Greg Stark
On Tue, Jul 30, 2013 at 6:10 PM, Alvaro Herrera wrote: > one for ALTER SYSTEM (living > in PGDATA), then the idea of going back to one setting per file is > perhaps not bad. Well more to the point, if we conf.d for sysadmins to drop in extra snippets in a different place then we could drop conf.d

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Alvaro Herrera
Josh Berkus escribió: > Amit, > > > I had already sent the updated patch based on recent suggestions. > > Yes, but there is no consensus yet on certain fundamental issues, such as: > > 1. what directory should postgresql.auto.conf live in? > > 2. should admins be able to turn it "off"? > > Onc

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Josh Berkus
Amit, > I had already sent the updated patch based on recent suggestions. Yes, but there is no consensus yet on certain fundamental issues, such as: 1. what directory should postgresql.auto.conf live in? 2. should admins be able to turn it "off"? Once we have consensus on these issues, then ho

Re: [HACKERS] ToDo: possible more rights to database owners

2013-07-30 Thread Pavel Stehule
2013/7/29 Pavel Stehule : > 2013/7/29 Stephen Frost : >> Szymon, >> >> * Szymon Guz (mabew...@gmail.com) wrote: >>> On 29 July 2013 11:25, Pavel Stehule wrote: >>> > In 9.3 super user can cancel all queries or user can cancel own sessions. >>> > >>> > Is possible enhance this possibility to databa

Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-30 Thread Tom Lane
"Arulappan, Arul Shaji" writes: > Given below is a design draft for this functionality: > Core new functionality (new code): > 1)Create and register independent NCHAR/NVARCHAR/NTEXT data types. > 2)Provide support for the new GUC nchar_collation to provide the > database with information about t

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Greg Smith
On 7/28/13 10:49 PM, Tom Lane wrote: Josh Berkus writes: I think if we can design conf.d separately for config files of management tools, then it is better to have postgresql.auto.conf to be in $PGDATA rather than in $PGDATA/conf.d One of the biggest current complaints about recovery.conf f

[HACKERS] Re: [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs

2013-07-30 Thread hubert depesz lubaczewski
On Tue, Jul 30, 2013 at 11:45:47AM +0100, Dean Rasheed wrote: > Quoting the manual: > > LOCAL: > New rows are only checked against the conditions defined directly in > the view itself. Any conditions defined on underlying base views are > not checked (unless they also specify the CHECK OPTION).

Re: [HACKERS] [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs

2013-07-30 Thread Dean Rasheed
On 30 July 2013 11:09, hubert depesz lubaczewski wrote: > On Tue, Jul 30, 2013 at 09:23:19AM +0100, Dean Rasheed wrote: >> >> > > create table some_data (id int4 primary key, payload text); >> >> > > create view first as select * from some_data where 0 = id % 2 with >> >> > > local check option;

[HACKERS] Re: [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs

2013-07-30 Thread hubert depesz lubaczewski
On Tue, Jul 30, 2013 at 09:23:19AM +0100, Dean Rasheed wrote: > >> > > create table some_data (id int4 primary key, payload text); > >> > > create view first as select * from some_data where 0 = id % 2 with > >> > > local check option; > >> > > create view second as select * from first where 0 = i

Re: [HACKERS] [COMMITTERS] pgsql: WITH CHECK OPTION support for auto-updatable VIEWs

2013-07-30 Thread Dean Rasheed
On 30 July 2013 01:24, Stephen Frost wrote: > depesz, > > * hubert depesz lubaczewski (dep...@depesz.com) wrote: >> On Mon, Jul 29, 2013 at 07:43:53PM -0400, Stephen Frost wrote: >> > * hubert depesz lubaczewski (dep...@depesz.com) wrote: >> > > create table some_data (id int4 primary key, payload

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Cédric Villemain
Le mardi 30 juillet 2013 05:27:12, Amit Kapila a écrit : > On Monday, July 29, 2013 7:15 PM Cédric Villemain wrote: > > Le lundi 29 juillet 2013 13:47:57, Amit Kapila a écrit : > > > On Sunday, July 28, 2013 11:12 AM Amit kapila wrote: > > > > On Friday, July 26, 2013 6:18 PM Tom Lane wrote: > > >

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-30 Thread Cédric Villemain
Le lundi 29 juillet 2013 18:03:21, Alvaro Herrera a écrit : > > Why not harcode in ParseConfigFp() that we should parse the auto.conf > > file at the end (and/or if USE_AUTO_CONF is not OFF) instead of > > hacking ProcessConfigFile() with data_directory ? (data_directory should > > be set at this

Re: [HACKERS] Patch for reserved connections for replication users

2013-07-30 Thread Gibheer
Hi, here is an update off my patch based on the discussion with Marko Tiikkaja and Andres Freund. Marko and I had the idea of introducing reserved connections based on roles as it would create a way to garantuee specific roles to connect when other roles use up all connections for whatever reason

Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-30 Thread Arulappan, Arul Shaji
> -Original Message- > From: Tatsuo Ishii [mailto:is...@postgresql.org] > > > Also I don't understand why you need UTF-16 support as a database encoding > because UTF-8 and UTF-16 are logically equivalent, they are just different > represention (encoding) of Unicode. That means if we alre