[HACKERS] Function to get size of notification queue?

2013-01-01 Thread Brendan Jurd
Hi folks, I have a project which uses Postgres asynchronous notifications pretty heavily. It has a particularly Fun failure mode which causes the notification queue to fill up. To better debug this problem I'd like to be able to monitor the size of the notification queue over time. It doesn't l

Re: Review of "pg_basebackup and pg_receivexlog to use non-blocking socket communication", was: Re: [HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2013-01-01 Thread Hari Babu
On January 01, 2013 10:19 PM Boszormenyi Zoltan wrote: >I am reviewing your patch. >• Is the patch in context diff format? >Yes. Thanks for reviewing the patch. >• Does it apply cleanly to the current git master? >Not quite cleanly but it doesn't produce rejects or fuzz, only offset warnings: W

Re: [HACKERS] [PATCH] Make pg_basebackup configure and start standby [Review]

2013-01-01 Thread Tom Lane
Boszormenyi Zoltan writes: > 2013-01-01 17:18 keltezéssel, Magnus Hagander írta: >> That way we can get around the whole need for changing memory allocation >> across all the >> frontends, no? Like the attached. > Sure it's simpler but then the consistent look of the code is lost. > What about

Re: [HACKERS] default SSL compression (was: libpq compression)

2013-01-01 Thread Tom Lane
Noah Misch writes: > On Tue, Jan 01, 2013 at 04:29:35PM +0100, Magnus Hagander wrote: >> On Thu, Aug 30, 2012 at 11:41 PM, Bruce Momjian wrote: >>> Do we want to change our ssl_ciphers default to 'DEFAULT'? Currently it >>> is 'ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH'. >> Did we ever get anywhere wit

Re: [HACKERS] dynamic SQL - possible performance regression in 9.2

2013-01-01 Thread Tom Lane
I wrote: > I'm inclined to think that Heikki's patch doesn't go far enough, if we > want to optimize behavior in this case. What we really want to happen > is that parsing, planning, and execution all happen in the caller's > memory context, with no copying of parse or plan trees at all - and we >

Re: [HACKERS] default SSL compression (was: libpq compression)

2013-01-01 Thread Noah Misch
On Tue, Jan 01, 2013 at 04:29:35PM +0100, Magnus Hagander wrote: > On Thu, Aug 30, 2012 at 11:41 PM, Bruce Momjian wrote: > > On Sun, Jun 17, 2012 at 11:45:54PM +0800, Magnus Hagander wrote: > > > Uh. We have the ! notation in our default *now*. What openssl also > > > supports is the text "DEFAUL

Re: [HACKERS] [PATCH] Make pg_basebackup configure and start standby [Review]

2013-01-01 Thread Boszormenyi Zoltan
2013-01-01 17:18 keltezéssel, Magnus Hagander írta: On Fri, Nov 30, 2012 at 10:13 AM, Boszormenyi Zoltan > wrote: Hi, now that PQconninfo() was committed, I rebased the subsequent patches. Actual code change was only in the last patch, to conform to th

Re: [HACKERS] [PATCH] Make pg_basebackup configure and start standby [Review]

2013-01-01 Thread Magnus Hagander
On Tue, Jan 1, 2013 at 7:13 PM, Boszormenyi Zoltan wrote: > 2013-01-01 18:25 keltezéssel, Magnus Hagander írta: > > > On Fri, Nov 30, 2012 at 10:13 AM, Boszormenyi Zoltan wrote: > >> Hi, >> >> now that PQconninfo() was committed, I rebased the subsequent >> patches. Actual code change was only i

Re: [HACKERS] dynamic SQL - possible performance regression in 9.2

2013-01-01 Thread Tom Lane
Peter Eisentraut writes: > On 12/28/12 5:11 PM, Heikki Linnakangas wrote: >> It looks like the regression is caused by extra copying of the parse >> tree and plan trees. Node-copy-related functions like AllocSetAlloc and >> _copy* are high in the profile, They are also high in the 9.1 profile, >>

Re: [HACKERS] [PATCH] Make pg_basebackup configure and start standby [Review]

2013-01-01 Thread Boszormenyi Zoltan
2013-01-01 18:25 keltezéssel, Magnus Hagander írta: On Fri, Nov 30, 2012 at 10:13 AM, Boszormenyi Zoltan > wrote: Hi, now that PQconninfo() was committed, I rebased the subsequent patches. Actual code change was only in the last patch, to conform to th

Re: [HACKERS] [PATCH] Make pg_basebackup configure and start standby [Review]

2013-01-01 Thread Magnus Hagander
On Fri, Nov 30, 2012 at 10:13 AM, Boszormenyi Zoltan wrote: > Hi, > > now that PQconninfo() was committed, I rebased the subsequent > patches. Actual code change was only in the last patch, to > conform to the committed PQconninfo() API. > > I've applied a modified version of the "tar unification

Re: [HACKERS] pg_retainxlog for inclusion in 9.3?

2013-01-01 Thread Dimitri Fontaine
Magnus Hagander writes: > Is this a tool that people would like to see included in the general > toolchain? If so, I'll reformat it to work in the general build > environment and submit it for the last commitfest. Please do. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Ex

Review of "pg_basebackup and pg_receivexlog to use non-blocking socket communication", was: Re: [HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2013-01-01 Thread Boszormenyi Zoltan
Hi, 2012-11-15 14:59 keltezéssel, Amit kapila írta: On Monday, November 12, 2012 8:23 PM Fujii Masao wrote: On Fri, Nov 9, 2012 at 3:03 PM, Amit Kapila wrote: On Thursday, November 08, 2012 10:42 PM Fujii Masao wrote: On Thu, Nov 8, 2012 at 5:53 PM, Amit Kapila wrote: On Thursday, November

Re: [HACKERS] PATCH: optimized DROP of multiple tables within a transaction

2013-01-01 Thread Tomas Vondra
On 1.1.2013 17:35, Alvaro Herrera wrote: > There was an earlier suggestion by Andres Freund to use memcmp() > instead, but I don't see that in the latest posted version of the patch; > was there a specific rationale for taking it out or it was just lost in > the shuffle? No, I've tried that approa

Re: [HACKERS] PATCH: optimized DROP of multiple tables within a transaction

2013-01-01 Thread Alvaro Herrera
There was an earlier suggestion by Andres Freund to use memcmp() instead, but I don't see that in the latest posted version of the patch; was there a specific rationale for taking it out or it was just lost in the shuffle? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL De

Re: [HACKERS] [PATCH] Make pg_basebackup configure and start standby [Review]

2013-01-01 Thread Magnus Hagander
On Fri, Nov 30, 2012 at 10:13 AM, Boszormenyi Zoltan wrote: > Hi, > > now that PQconninfo() was committed, I rebased the subsequent > patches. Actual code change was only in the last patch, to > conform to the committed PQconninfo() API. So, finally coming back to this one. What happened to Al

Re: [HACKERS] [PATCH] Change Windows build docs to point to flex and bison from msys

2013-01-01 Thread Heikki Linnakangas
On 31.12.2012 08:53, Craig Ringer wrote: Hi all For some time it's been impossible to build PostgreSQL on 64-bit Windows by following the documentation's advice, as the version of Flex we distribute on the PostgreSQL FTP site does not work on 64-bit Windows hosts. See this 2011 message ( http://

Re: [HACKERS] pg_retainxlog for inclusion in 9.3?

2013-01-01 Thread Hannu Krosing
On 01/01/2013 04:10 PM, Magnus Hagander wrote: So, it turns out the reason I got no feedback on this tool, was that I forgot both to email about and to actually push the code to github :O So this is actually code that's almost half a year old and that I was supposed to submit for the first or sec

Re: [HACKERS] default SSL compression (was: libpq compression)

2013-01-01 Thread Magnus Hagander
On Thu, Aug 30, 2012 at 11:41 PM, Bruce Momjian wrote: > On Sun, Jun 17, 2012 at 11:45:54PM +0800, Magnus Hagander wrote: > > On Sun, Jun 17, 2012 at 11:42 PM, Tom Lane wrote: > > > Magnus Hagander writes: > > >> Is there a reason why we don't have a parameter on the client > > >> mirroring ssl

[HACKERS] pg_retainxlog for inclusion in 9.3?

2013-01-01 Thread Magnus Hagander
So, it turns out the reason I got no feedback on this tool, was that I forgot both to email about and to actually push the code to github :O So this is actually code that's almost half a year old and that I was supposed to submit for the first or second commitfest. Oops. So, the tool and a README