Re: [HACKERS] My first patch! (to \df output)

2012-10-27 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 > This was actually kind of anti-climactic, since it only > took about 5 minutes to make the change and get it > working. Didn't really feel the way I expected it to ;) Well, we can reject your patch and start bike-shedding it for the next f

Re: [HACKERS] Logical to physical page mapping

2012-10-27 Thread Gavin Flower
On 28/10/12 07:41, Heikki Linnakangas wrote: On 27.10.2012 16:43, Tom Lane wrote: Jan Wieck writes: The reason why we need full_page_writes is that we need to guard against torn pages or partial writes. So what if smgr would manage a mapping between logical page numbers and their physical loca

Re: [HACKERS] Logical to physical page mapping

2012-10-27 Thread Tom Lane
Claudio Freire writes: > On Sat, Oct 27, 2012 at 3:41 PM, Heikki Linnakangas > wrote: >>> I think you're just moving the atomic-write problem from the data pages >>> to wherever you keep these pointers. >> If the pointers are stored as simple 4-byte integers, you probably could >> assume that th

Re: [HACKERS] Logical to physical page mapping

2012-10-27 Thread Claudio Freire
On Sat, Oct 27, 2012 at 3:41 PM, Heikki Linnakangas wrote: > >> I think you're just moving the atomic-write problem from the data pages >> to wherever you keep these pointers. > > > If the pointers are stored as simple 4-byte integers, you probably could > assume that they're atomic, and won't be

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2012-10-27 Thread Heikki Linnakangas
On 27.10.2012 14:27, Amit Kapila wrote: On Saturday, October 27, 2012 4:03 AM Noah Misch wrote: In my previous review, I said: Given [not relying on the executor to know which columns changed], why not treat the tuple as an opaque series of bytes and not worry about datum

Re: [HACKERS] Logical to physical page mapping

2012-10-27 Thread Heikki Linnakangas
On 27.10.2012 16:43, Tom Lane wrote: Jan Wieck writes: The reason why we need full_page_writes is that we need to guard against torn pages or partial writes. So what if smgr would manage a mapping between logical page numbers and their physical location in the relation? At the moment where w

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2012-10-27 Thread Noah Misch
On Sat, Oct 27, 2012 at 04:57:46PM +0530, Amit Kapila wrote: > On Saturday, October 27, 2012 4:03 AM Noah Misch wrote: > > Could you elaborate on your reason for continuing to treat TOAST as a > > special > > case? As best I recall, the only reason to do so before was the fact > > that > > TOAST c

Re: [HACKERS] proposal - assign result of query to psql variable

2012-10-27 Thread Pavel Stehule
Hello > > My first review... > > Patch applied cleanly to master and make check was fine. > > I tested it out and it operates as advertised. There were a couple > things that stood out to me though. > > 1) NULL values are not displayed properly after \pset null is run. > > postgres=# \pset null '(

Re: [HACKERS] My first patch! (to \df output)

2012-10-27 Thread Pavel Stehule
Hello 2012/10/27 Jon Erdman : > > Hello Hackers! > > So, currently the only way to see if a function is security definer or not is > to directly query pg_proc. This is both irritating, and I think perhaps > dangerous since security definer functions can be so powerful. I thought > that rectify

[HACKERS] My first patch! (to \df output)

2012-10-27 Thread Jon Erdman
Hello Hackers! So, currently the only way to see if a function is security definer or not is to directly query pg_proc. This is both irritating, and I think perhaps dangerous since security definer functions can be so powerful. I thought that rectifying that would make an excellent first patc

Re: [HACKERS] Logical to physical page mapping

2012-10-27 Thread Tom Lane
Jan Wieck writes: > The reason why we need full_page_writes is that we need to guard against > torn pages or partial writes. So what if smgr would manage a mapping > between logical page numbers and their physical location in the relation? > At the moment where we today require a full page writ

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2012-10-27 Thread Amit Kapila
On Saturday, October 27, 2012 4:03 AM Noah Misch wrote: > On Thu, Oct 25, 2012 at 05:34:14PM +, Amit kapila wrote: > > I have fixed all the review comments raised in delta encoding approach > raised by you (for needs toast, for now I have kept the code as it will > not go in patch of encoding f