Re: [HACKERS] Use of rsync for data directory copying

2012-07-14 Thread Stephen Frost
Bruce, * Bruce Momjian (br...@momjian.us) wrote: > On Sat, Jul 14, 2012 at 09:17:22PM -0400, Stephen Frost wrote: > > So, can you explain which case you're specifically worried about? > > OK. The basic problem is that I previously was not clear about how > reliant our use of rsync (without --che

Re: [HACKERS] Use of rsync for data directory copying

2012-07-14 Thread Bruce Momjian
On Sat, Jul 14, 2012 at 09:17:22PM -0400, Stephen Frost wrote: > Bruce, > > * Bruce Momjian (br...@momjian.us) wrote: > > If two writes happens in the middle of a file in the same second, it > > seems one might be missed. Yes, I suppose the WAL does fix that during > > replay, though if both serv

Re: [HACKERS] Schema version management

2012-07-14 Thread Joel Jacobson
On Sat, Jul 14, 2012 at 12:34 PM, Joel Jacobson wrote: > On Sat, Jul 14, 2012 at 11:25 AM, Peter Eisentraut wrote: >> Well, of course everyone uses directories in moderation. But you might >> want to take a look at the gcc source code. You'll love it. ;-) [505][joel.Joel-Jacobsons-iMac-2: /Use

Re: [HACKERS] Use of rsync for data directory copying

2012-07-14 Thread Stephen Frost
Bruce, * Bruce Momjian (br...@momjian.us) wrote: > If two writes happens in the middle of a file in the same second, it > seems one might be missed. Yes, I suppose the WAL does fix that during > replay, though if both servers were shut down cleanly, WAL would not be > replayed. > > If you using

Re: [HACKERS] [PERFORM] DELETE vs TRUNCATE explanation

2012-07-14 Thread Jeff Janes
On Thu, Jul 12, 2012 at 9:55 PM, Jeff Janes wrote: > I've moved this thread from performance to hackers. > > The topic was poor performance when truncating lots of small tables > repeatedly on test environments with fsync=off. > > On Thu, Jul 12, 2012 at 6:00 PM, Jeff Janes wrote: > >> I think th

Re: [HACKERS] Synchronous Standalone Master Redoux

2012-07-14 Thread Josh Berkus
So, here's the core issue with degraded mode. I'm not mentioning this to block any patch anyone has, but rather out of a desire to see someone address this core problem with some clever idea I've not thought of. The problem in a nutshell is: indeterminancy. Assume someone implements degraded mode

Re: [HACKERS] elog/ereport noreturn decoration

2012-07-14 Thread Tom Lane
Peter Eisentraut writes: > A small sidetrack here. I've managed to set up the Solaris Studio > compiler on Linux and tried this out. It turns out these "statement not > reached" warnings have nothing to do with knowledge about library > functions such as abort() or exit() not returning. The war

Re: [HACKERS] elog/ereport noreturn decoration

2012-07-14 Thread Peter Eisentraut
On lör, 2012-06-30 at 10:52 -0400, Tom Lane wrote: > Peter Eisentraut writes: > > But my point was, there aren't any unused code warnings. None of the > > commonly used compilers issue any. I'd be interested to know if there > > is any recent C compiler supported by PostgreSQL that issues some k

[HACKERS] Getting rid of pre-assignment of index names in CREATE TABLE LIKE

2012-07-14 Thread Tom Lane
In bug #6734 we have a complaint about a longstanding misfeature of CREATE TABLE LIKE. Ordinarily, this command doesn't select names for copied indexes, but leaves that to be done at runtime by DefineIndex. But if it's copying comments, and an index of the source table has a comment, it's forced t

[HACKERS] Re: Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-07-14 Thread Heikki Linnakangas
On 26.06.2012 18:06, Fujii Masao wrote: On Wed, Mar 28, 2012 at 10:08 AM, Fujii Masao wrote: On Wed, Mar 28, 2012 at 12:30 AM, Alvaro Herrera wrote: Excerpts from Fujii Masao's message of mar mar 27 06:40:34 -0300 2012: Anyway, should I add this patch into the next CF? Or is anyone planni

Re: [HACKERS] sign mismatch in walreceiver.c

2012-07-14 Thread Heikki Linnakangas
On 12.07.2012 23:57, Peter Eisentraut wrote: This looks suspicious static TimeLineID recvFileTLI = -1; because TimeLineID is uint32. The Solaris compiler complains about the sign mismatch. Maybe 0 would be a better initial value? Agreed, fixed, thanks. -- Heikki Linnakangas Enterpris

Re: [HACKERS] Support for XLogRecPtr in expand_fmt_string?

2012-07-14 Thread Robert Haas
On Jul 13, 2012, at 2:34 PM, Peter Eisentraut wrote: > I would rather get rid of this %X/%X notation. I know we have all grown > to like it, but it's always been a workaround. We're now making the > move to simplify this whole business by saying, the WAL location is an > unsigned 64-bit number -

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings.

2012-07-14 Thread Jan Urbański
On 13/07/12 13:38, Jan Urbański wrote: On 12/07/12 11:08, Heikki Linnakangas wrote: On 07.07.2012 00:12, Jan Urbański wrote: So you're in favour of doing unicode -> bytes by encoding with UTF-8 and then using the server's encoding functions? Sounds reasonable to me. The extra conversion betwe

Re: [HACKERS] Synchronous Standalone Master Redoux

2012-07-14 Thread Jose Ildefonso Camargo Tolosa
On Sat, Jul 14, 2012 at 12:42 AM, Amit kapila wrote: >> From: Jose Ildefonso Camargo Tolosa [ildefonso.cama...@gmail.com] >> Sent: Saturday, July 14, 2012 9:36 AM >>On Fri, Jul 13, 2012 at 11:12 PM, Amit kapila wrote: >> From: pgsql-hackers-ow...@postgresql.org >> [pgsql-hackers-ow...@postgresql

Re: [HACKERS] [PATCH] Allow breaking out of hung connection attempts

2012-07-14 Thread Heikki Linnakangas
On 13.07.2012 14:35, Ryan Kelly wrote: On Mon, Jul 09, 2012 at 05:35:15PM +0900, Shigeru HANADA wrote: On Mon, Jun 25, 2012 at 9:00 PM, Ryan Kelly wrote: - Copying only "select()" part of pqSocketPoll seems not enough, should we use poll(2) if it is supported? I did not think the additional c

Re: [HACKERS] Schema version management

2012-07-14 Thread Joel Jacobson
On Sat, Jul 14, 2012 at 11:25 AM, Peter Eisentraut wrote: > Well, of course everyone uses directories in moderation. But you might > want to take a look at the gcc source code. You'll love it. ;-) Yes, but GCC was also created by someone who picks stuff from his bare foot and eats it. ;-) --

Re: [HACKERS] pg_prewarm

2012-07-14 Thread Cédric Villemain
> c) isn't necessarily safe in production (I've crashed Linux with Fincore > in the recent past). fincore is another soft, please provide a bugreport if you hit issue with pgfincore, I then be able to fix it and all can benefit. -- Cédric Villemain +33 (0)6 20 30 22 52 http://2ndQuadrant.fr/ Po

Re: [HACKERS] Schema version management

2012-07-14 Thread Peter Eisentraut
On lör, 2012-07-14 at 10:41 +0200, Joel Jacobson wrote: > On Fri, Jul 13, 2012 at 9:41 PM, Peter Eisentraut wrote: > > > Personally, I hate this proposed nested directory structure. I would > > like to have all objects in one directory. > > > > But there is a lot of "personally" in this thread,

Re: [HACKERS] Schema version management

2012-07-14 Thread Joel Jacobson
On Fri, Jul 13, 2012 at 9:41 PM, Peter Eisentraut wrote: > Personally, I hate this proposed nested directory structure. I would > like to have all objects in one directory. > > But there is a lot of "personally" in this thread, of course. Why do you hate it? It's a bit like saying, - I hate

Re: [HACKERS] [PATCH] lock_timeout and common SIGALRM framework

2012-07-14 Thread Boszormenyi Zoltan
2012-07-14 00:36 keltezéssel, Tom Lane írta: Alvaro Herrera writes: For what it's worth, I would appreciate it if you would post the lock timeout patch for the upcoming commitfest. +1. I think it's reasonable to get the infrastructure patch in now, but we are running out of time in this commi