Re: [HACKERS] 16-bit page checksums for 9.2

2011-12-27 Thread Heikki Linnakangas
On 28.12.2011 01:39, Simon Riggs wrote: On Tue, Dec 27, 2011 at 8:05 PM, Heikki Linnakangas wrote: On 25.12.2011 15:01, Kevin Grittner wrote: I don't believe that. Double-writing is a technique to avoid torn pages, but it requires a checksum to work. This chicken-and-egg problem requires t

Re: [HACKERS] Review of VS 2010 support patches

2011-12-27 Thread Magnus Hagander
On Wed, Dec 28, 2011 at 05:09, Brar Piening wrote: > Brar Piening wrote: >> >> I have to admit that it's currently broken (it builds but fails during >> regression tests becuse it can't connect) when building with Visual Studio >> 2010 or Windows SDK 7.1 because of commit >> 1a0c76c32fe470142d3663

Re: [HACKERS] Collect frequency statistics for arrays

2011-12-27 Thread Noah Misch
On Tue, Dec 20, 2011 at 04:37:37PM +0400, Alexander Korotkov wrote: > On Wed, Nov 16, 2011 at 1:43 AM, Nathan Boley wrote: > > > FYI, I've added myself as the reviewer for the current commitfest. > > > How is going review now? I will examine this patch within the week. -- Sent via pgsql-hacker

Re: [HACKERS] Review of VS 2010 support patches

2011-12-27 Thread Brar Piening
Brar Piening wrote: I have to admit that it's currently broken (it builds but fails during regression tests becuse it can't connect) when building with Visual Studio 2010 or Windows SDK 7.1 because of commit 1a0c76c32fe470142d3663dd84ac960d75a4e8db (Enable compiling with the mingw-w64 32 bit c

Re: [HACKERS] 16-bit page checksums for 9.2

2011-12-27 Thread Simon Riggs
On Sun, Dec 25, 2011 at 1:01 PM, Kevin Grittner wrote: > This chicken-and-egg > problem requires the checksum to be implemented first. v2 of checksum patch, using a conditional copy if checksumming is enabled, so locking is removed. Thanks to Andres for thwacking me with the cluestick, though I

Re: [HACKERS] Misleading CREATE TABLE error

2011-12-27 Thread Thom Brown
On 27 December 2011 20:16, Peter Eisentraut wrote: > It's not only the error message that's misleading, but the whole code, > because the entire code for CREATE TABLE ... (LIKE ...) claims to do > "inheritance" based on an ancient understanding of the SQL standard.  I > know this has confused me m

[HACKERS] pgstat wait timeout

2011-12-27 Thread Steve Crawford
I have a system (9.0.4 on Ubuntu Server 10.04 LTS x86_64) that is currently in test/dev mode. I'm currently seeing the following messages occurring every few seconds: ... Dec 27 17:43:22 foo postgres[23693]: [6-1] : WARNING: pgstat wait timeout Dec 27 17:43:27 foo postgres[27324]: [71400-1] :

Re: [HACKERS] Page Checksums + Double Writes

2011-12-27 Thread Jeff Davis
On Tue, 2011-12-27 at 16:43 -0600, Merlin Moncure wrote: > On Tue, Dec 27, 2011 at 1:24 PM, Jeff Davis wrote: > > 3. Attack hint bits problem. > > A large number of problems would go away if the current hint bit > system could be replaced with something that did not require writing > to the tuple

Re: [HACKERS] 16-bit page checksums for 9.2

2011-12-27 Thread Simon Riggs
On Tue, Dec 27, 2011 at 8:05 PM, Heikki Linnakangas wrote: > On 25.12.2011 15:01, Kevin Grittner wrote: >> >> I don't believe that.  Double-writing is a technique to avoid torn >> pages, but it requires a checksum to work.  This chicken-and-egg >> problem requires the checksum to be implemented fi

Re: [HACKERS] Page Checksums + Double Writes

2011-12-27 Thread Merlin Moncure
On Tue, Dec 27, 2011 at 1:24 PM, Jeff Davis wrote: > 3. Attack hint bits problem. A large number of problems would go away if the current hint bit system could be replaced with something that did not require writing to the tuple itself. FWIW, moving the bits around seems like a non-starter -- yo

Re: [HACKERS] Misleading CREATE TABLE error

2011-12-27 Thread Peter Eisentraut
On tis, 2011-11-08 at 21:49 +, Thom Brown wrote: > I found the following error message misleading: > > test=# create table cows2 (LIKE cows); > ERROR: inherited relation "cows" is not a table > STATEMENT: create table cows2 (LIKE cows); > > I'm not trying to inherit a relation, I'm trying t

Re: [HACKERS] 16-bit page checksums for 9.2

2011-12-27 Thread Heikki Linnakangas
On 25.12.2011 15:01, Kevin Grittner wrote: I don't believe that. Double-writing is a technique to avoid torn pages, but it requires a checksum to work. This chicken-and-egg problem requires the checksum to be implemented first. I don't think double-writes require checksums on the data pages

Re: [HACKERS] sorting table columns

2011-12-27 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar dic 20 22:23:36 -0300 2011: > > Alvaro Herrera writes: > > Excerpts from Tom Lane's message of mar dic 20 18:24:29 -0300 2011: > >> You do *not* want to store either of the latter two numbers in > >> parse-time Var nodes, because then you can't rearrange c

[HACKERS] improve line-breaking and indentation of foreign options dump

2011-12-27 Thread Peter Eisentraut
Currently, pg_dump dumps foreign options in a single line, for example CREATE SERVER cluster FOREIGN DATA WRAPPER plproxy OPTIONS (p0 'host=host0', p1 'host=host1', p2 'host=host2', p3 'host=host3'); I think it would be nicer if it looked more like this: CREATE SERVER cluster FOREIGN DATA WRAPP

Re: [HACKERS] Page Checksums + Double Writes

2011-12-27 Thread Jeff Davis
On Thu, 2011-12-22 at 03:50 -0600, Kevin Grittner wrote: > Now, on to the separate-but-related topic of double-write. That > absolutely requires some form of checksum or CRC to detect torn > pages, in order for the technique to work at all. Adding a CRC > without double-write would work fine if y

Re: [HACKERS] Page Checksums

2011-12-27 Thread Jeff Davis
On Sun, 2011-12-25 at 22:18 +, Greg Stark wrote: > 2) The i/o system was in the process of writing out blocks and the > system lost power or crashed as they were being written out. In this > case there will probably only be 0 or 1 torn pages -- perhaps as many > as the scsi queue depth if there

Re: [HACKERS] Page Checksums

2011-12-27 Thread Jeff Davis
On Mon, 2011-12-19 at 22:18 +0200, Heikki Linnakangas wrote: > Or you could just use a filesystem that does CRCs... That just moves the problem. Correct me if I'm wrong, but I don't think there's anything special that the filesystem can do that we can't. The filesystems that support CRCs are more

Re: [HACKERS] Page Checksums

2011-12-27 Thread Jeff Davis
On Mon, 2011-12-19 at 01:55 +, Greg Stark wrote: > On Sun, Dec 18, 2011 at 7:51 PM, Jesper Krogh wrote: > > I dont know if it would be seen as a "half baked feature".. or similar, > > and I dont know if the hint bit problem is solvable at all, but I could > > easily imagine checksumming just "

Re: [HACKERS] Page Checksums

2011-12-27 Thread Jeff Davis
On Mon, 2011-12-19 at 07:50 -0500, Robert Haas wrote: > I > think it would be regrettable if everyone had to give up 4 bytes per > page because some people want checksums. I can understand that some people might not want the CPU expense of calculating CRCs; or the upgrade expense to convert to new

Re: [HACKERS] reprise: pretty print viewdefs

2011-12-27 Thread Andrew Dunstan
On 12/22/2011 06:14 PM, Andrew Dunstan wrote: On 12/22/2011 06:11 PM, Andrew Dunstan wrote: On 12/22/2011 02:17 PM, Andrew Dunstan wrote: On 12/22/2011 01:05 PM, Tom Lane wrote: Maybe, though I fear it might complicate the ruleutils code a bit. You'd probably have to build the output f

Re: [HACKERS] Standalone synchronous master

2011-12-27 Thread Alexander Björnhagen
Okay, Here’s version 3 then, which piggy-backs on the existing flag : synchronous_commit = on | off | local | fallback Where “fallback” now means “fall back from sync replication when no (suitable) standbys are connected”. This was done on input from Guillaume Lelarge. > That said, I agree it'

Re: [HACKERS] CLOG contention

2011-12-27 Thread Simon Riggs
On Sat, Dec 24, 2011 at 9:25 AM, Simon Riggs wrote: > On Thu, Dec 22, 2011 at 4:20 PM, Robert Haas wrote: >> Also, if it is that, what do we do about it?  I don't think any of the >> ideas proposed so far are going to help much. > > If you don't like guessing, don't guess, don't think. Just meas