Re: GiST for range types (was Re: [HACKERS] Range Types - typo + NULL string constructor)

2011-11-25 Thread Jeff Davis
On Wed, 2011-11-09 at 20:24 +0400, Alexander Korotkov wrote: > New version of GiST for range types patch is here. This version seems > to be complete and ready for review. > There's been some significant change in rangetypes_gist.c, can you please rebase this patch? I like the patch conceptually,

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Jaime Casanova
On Fri, Nov 25, 2011 at 4:28 PM, Alvaro Herrera wrote: > > Excerpts from Dean Rasheed's message of vie nov 25 13:45:34 -0300 2011: > >> Looking back at Thom's original example, it seems odd to allow this >> syntax at all: >> >> CREATE TABLE a ( >>    num integer, >>    CONSTRAINT meow CHECK ((num

Re: [HACKERS] Displaying accumulated autovacuum cost

2011-11-25 Thread Robert Haas
On Fri, Nov 25, 2011 at 11:39 AM, Alvaro Herrera wrote: > I'm going to push this now anyway, thanks. This patch adds a count of the number of buffers dirtied to VACUUM, but it strikes me that it would be useful to add similar tracking to pgBufferUsage. Attached is a patch for that. You can see

Re: [HACKERS] Measuring relation free space

2011-11-25 Thread Jeff Janes
On Mon, Nov 14, 2011 at 2:02 PM, Jaime Casanova wrote: > On Wed, Nov 9, 2011 at 7:58 AM, Alvaro Herrera > wrote: >> >> Excerpts from Jaime Casanova's message of mar nov 08 18:12:25 -0300 2011: >>> On Sun, Nov 6, 2011 at 5:38 AM, Magnus Hagander wrote: >>> > >>> > Looks pretty useful. >>> >>> tha

Re: [HACKERS] disable prompting by default in createuser

2011-11-25 Thread Robert Haas
On Fri, Nov 25, 2011 at 6:28 PM, Peter Eisentraut wrote: > I propose that we change createuser so that it does not prompt for > anything by default.  We can arrange options so that you can get prompts > for whatever is missing, but by default, a call to createuser should > just run CREATE USER wit

[HACKERS] Re: Add pg_upgrade ENABLE_SAME_CATVERSION_UPGRADES macro for testing to

2011-11-25 Thread Bruce Momjian
Peter Eisentraut wrote: > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=5df1403b0f2b44235c8f401bd49dab9a8cf6bf90 > > This patch doesn't do what it says. What it does is allow downgrades. > Upgrades to the same catversion already worked. Oh, you are correct. Macro patch removed.

[HACKERS] disable prompting by default in createuser

2011-11-25 Thread Peter Eisentraut
I propose that we change createuser so that it does not prompt for anything by default. We can arrange options so that you can get prompts for whatever is missing, but by default, a call to createuser should just run CREATE USER with default options. The fact that createuser issues prompts is alw

[HACKERS] separate initdb -A options for local and host

2011-11-25 Thread Peter Eisentraut
I think it would be useful to have separate initdb -A options for local and host entries. In 9.1, we went out of our way to separate the "peer" and "ident" methods, but we have moved the confusion into the initdb -A option, where "ident" sometimes means "peer", and "peer" sometimes means "ident".

[HACKERS] Re: Add pg_upgrade ENABLE_SAME_CATVERSION_UPGRADES macro for testing to

2011-11-25 Thread Peter Eisentraut
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=5df1403b0f2b44235c8f401bd49dab9a8cf6bf90 This patch doesn't do what it says. What it does is allow downgrades. Upgrades to the same catversion already worked. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Inserting heap tuples in bulk in COPY

2011-11-25 Thread Jeff Janes
On Fri, Nov 25, 2011 at 12:53 PM, Jeff Janes wrote: > Hi Heikki, > > Thanks for this patch.  Doing bulk copies in parallel for me is now > limited by the IO subsystem rather than the CPU. > > This patch, commit number d326d9e8ea1d69, causes fillfactor to be > ignored for the copy command.  Is thi

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Alvaro Herrera
Excerpts from Dean Rasheed's message of vie nov 25 13:45:34 -0300 2011: > Looking back at Thom's original example, it seems odd to allow this > syntax at all: > > CREATE TABLE a ( >num integer, >CONSTRAINT meow CHECK ((num < 20)) NOT VALID > ); > > It's not documented, but is currently

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Alvaro Herrera
Excerpts from Dean Rasheed's message of vie nov 25 13:16:29 -0300 2011: > There is a similar problem with NOT VALID check constraints on > domains. These are still being dumped as part of the CREATE DOMAIN > statement, which is invalid syntax, so they need to be dumped > separately from the domai

Re: [HACKERS] xpath_table

2011-11-25 Thread Bruce Momjian
Robert Haas wrote: > On Tue, Nov 22, 2011 at 6:19 PM, magti...@juno.com wrote: > > I noticed in the Postgres 9.1 manual that the xml2 module has been removed. > > No, it hasn't. We talked about it, but we didn't do it. We're still > "planning" to remove it three releases ago. > > http://www.po

Re: [HACKERS] Inserting heap tuples in bulk in COPY

2011-11-25 Thread Jeff Janes
On Mon, Oct 24, 2011 at 7:46 AM, Heikki Linnakangas wrote: > > Thanks! Here's an updated version of the patch, fixing that, and all the > other issues pointed out this far. > > I extracted the code that sets oid and tuple headers, and invokes the > toaster, into a new function that's shared by hea

Re: [HACKERS] pg_dump vs malloc

2011-11-25 Thread Bruce Momjian
Bruce Momjian wrote: > I developed the attached patch to handle this. I moved the catalog code > from common.c into dumpcatalog.c, so there are just memory routines now > in common.c. I created new memory routines in pg_dumpall.c because > there is no AH structure in pg_dumpall.c. I then modifie

Re: [HACKERS] pg_upgrade relation OID mismatches

2011-11-25 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of vie nov 25 17:05:09 -0300 2011: > OK, it turns out that exclusion contraints used in pre-9.2 regression > tests were deleted before the regression tests finished, which means > they were not tested by me. (This might be a good reason _not_ to have > the r

Re: [HACKERS] pg_upgrade relation OID mismatches

2011-11-25 Thread Bruce Momjian
Bruce Momjian wrote: > Bruce Momjian wrote: > > Heikki Linnakangas wrote: > > > On 24.11.2011 07:01, Bruce Momjian wrote: > > > > Bruce Momjian wrote: > > > >> OK, that is a heap table. My only guess is that the heap is being > > > >> created without binary_upgrade_next_heap_pg_class_oid being set

Re: [HACKERS] [PATCH] optional cleaning queries stored in pg_stat_statements

2011-11-25 Thread Jeff Janes
On Sat, Nov 5, 2011 at 8:42 PM, Tomas Vondra wrote: > Dne 6.11.2011 03:16, Peter Geoghegan napsal(a): >> 2011/11/6 Tomas Vondra : >>> Hi everyone, >> >>> The patch implements a simple "cleaning" that replaces the parameter >>> values with generic strings - e.g. numbers are turned to ":n", so the >

Re: [HACKERS] proposal: use errcontext for custom exception too

2011-11-25 Thread Pavel Stehule
2011/11/25 Tom Lane : > Robert Haas writes: >> On Thu, Nov 24, 2011 at 12:30 PM, Pavel Stehule >> wrote: >>> There are small issue in PL/pgSQL and custom exceptions. Custom >>> exception doesn't set a CONTEXT field. I propose change this behave >>> for WARNING or EXCEPTION level. The goal is sam

Re: [HACKERS] proposal: use errcontext for custom exception too

2011-11-25 Thread Tom Lane
Robert Haas writes: > On Thu, Nov 24, 2011 at 12:30 PM, Pavel Stehule > wrote: >> There are small issue in PL/pgSQL and custom exceptions. Custom >> exception doesn't set a CONTEXT field. I propose change this behave >> for WARNING or EXCEPTION level. The goal is same behave for custom >> except

Re: [HACKERS] proposal : backend startup hook / after logon trigger

2011-11-25 Thread Tom Lane
"Tomas Vondra" writes: > On 25 Listopad 2011, 2:44, Robert Haas wrote: >> I've thought of this before, but I'm not exactly clear on what the use >> cases are. > The startup hook is useful for initializing an extension written in C, > when the extension was loaded from postgresql.conf. If you need

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Dean Rasheed
On 25 November 2011 16:16, Dean Rasheed wrote: > On 24 November 2011 21:50, Alvaro Herrera wrote: >> >> Excerpts from Alvaro Herrera's message of vie nov 11 00:32:33 -0300 2011: >>> Excerpts from Thom Brown's message of jue nov 10 21:28:06 -0300 2011: >>> > >>> > On 10 November 2011 23:56, Thom B

Re: [HACKERS] Displaying accumulated autovacuum cost

2011-11-25 Thread Alvaro Herrera
Excerpts from Greg Smith's message of mié nov 16 04:37:43 -0300 2011: > On 10/05/2011 03:02 AM, Greg Smith wrote: > > Presumably you meant to ask if this makes sense to show when cost > > accounting isn't enabled, because the code doesn't do that right now. > > No cost accounting, no buffer usa

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Dean Rasheed
On 24 November 2011 21:50, Alvaro Herrera wrote: > > Excerpts from Alvaro Herrera's message of vie nov 11 00:32:33 -0300 2011: >> Excerpts from Thom Brown's message of jue nov 10 21:28:06 -0300 2011: >> > >> > On 10 November 2011 23:56, Thom Brown wrote: >> >> > > The dump correctly contains: >>

Re: [HACKERS] proposal: use errcontext for custom exception too

2011-11-25 Thread Robert Haas
On Fri, Nov 25, 2011 at 1:14 AM, Pavel Stehule wrote: > A some option via #option or GUC has sense for lower levels like > NOTICE or WARNING. I think what we discussed before was adding some bit of optional syntax to RAISE that would indicate that the user wants CONTEXT suppressed. -- Robert Ha

Re: [HACKERS] Storing hot members of PGPROC out of the band

2011-11-25 Thread Robert Haas
On Thu, Nov 24, 2011 at 11:54 PM, Pavan Deolasee wrote: > +1. These are independent patches and should be pursued like that. > BTW, I reviewed the pgxact-v2.patch and I have no objections to that > and it looks good to go in. Thanks Robert for making the necessary > changes and also running the be

Re: [HACKERS] proposal : backend startup hook / after logon trigger

2011-11-25 Thread Tomas Vondra
On 25 Listopad 2011, 2:44, Robert Haas wrote: > 2011/11/10 Tomas Vondra : >> Is there any particular reason why there's not a "backend start hook", >> executed right after a backend is initialized? I've tried a very simple >> PoC (basically just a new hook definition, called from PostgresMain(), >>

Re: [HACKERS] pgsql_fdw, FDW for PostgreSQL server

2011-11-25 Thread Etsuro Fujita
Hi Hanada-san, (2011/11/16 1:55), Shigeru Hanada wrote: > Attached are revised version of pgsql_fdw patches. I'm still under reviewing, so the following is not all. I'm sorry. estimate_costs() have been implemented to ask a remote postgres server for the result of EXPLAIN for a remote query to g