Re: [HACKERS] flex on win64 - workaround for "flex: fatal internal error, exec failed"

2011-07-03 Thread Brar Piening
schrieb Craig Ringer: I haven't managed to figure out exactly what's broken. For the benefit of anyone else having problems like this or who might find this via a search later, though: just install msys and use the current flex from msys. It works perfectly in Pg's build environment and it's ea

Re: [HACKERS] Full GUID support

2011-07-03 Thread Dave Page
Should be in 9.0.5/9.1b3 On Sunday, July 3, 2011, Michael Gould wrote: > Does this look to be something that will surface around for 9.1 > > Sent from Samsung mobile > > Dave Page wrote: > >>On Sunday, July 3, 2011, Michael Gould >> wrot

Re: [HACKERS] Crash dumps

2011-07-03 Thread Craig Ringer
On 15/06/2011 2:37 AM, Radosław Smogura wrote: Hello, Because, I work a little bit on streaming protocol and from time to time I have crashes. I want ask if you wont crash reporting (this is one of minors products from mmap playing) those what I have there is mmaped areas, and call stacks, and s

Re: [HACKERS] Online base backup from the hot-standby

2011-07-03 Thread Fujii Masao
2011/7/1 Jun Ishiduka : > >> On this commitfest, the goal of the patch is to be able to be >> recovered using "Minimum recovery ending location" in the control file. > > Done. When the standby restarts after it crashes during recovery, it always checks whether recovery has reached the backup end l

Re: [HACKERS] per-column generic option

2011-07-03 Thread Shigeru Hanada
(2011/07/03 18:50), Kohei KaiGai wrote: > I checked the per-column generic option patch. > Right now, I have nothing to comment on anymore. > So, it should be reviewed by committers. Thanks for the review!. Regards, -- Shigeru Hanada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgr

Re: [HACKERS] relpersistence and temp table

2011-07-03 Thread Robert Haas
On Fri, Jul 1, 2011 at 1:59 PM, Robert Haas wrote: > On Fri, Jul 1, 2011 at 10:32 AM, Robert Haas wrote: >> On Fri, Jul 1, 2011 at 8:06 AM, Amit Khandekar >> wrote: >>> In 9.1, if a table is created using an explicit pg_temp qualification, >>> the pg_class.relpersistence is marked 'p', not 't'.

[HACKERS] flex on win64 - workaround for "flex: fatal internal error, exec failed"

2011-07-03 Thread Craig Ringer
Hi all On my win64 build machine I've been suffering from hard to track down errors from flex like: "flex: fatal internal error, exec failed" ... even though I have m4 properly installed and whether or not the M4 environment variable is set to point to my M4 executable. It all works fine

Re: [HACKERS] plpgsql extension install nitpick

2011-07-03 Thread Tom Lane
Robert Haas writes: > On Sun, Jul 3, 2011 at 12:33 PM, Tom Lane wrote: >> Well, if I'm in the minority I'll yield gracefully.  Anybody else have >> an opinion? > I don't see any harm in commenting it in both places. OK, done. I did not add comment commands to the "upgrade" scripts. We could d

[HACKERS] non-superuser reserved connections? connection pools?

2011-07-03 Thread Michael Glaesemann
It would be nice to be able to set aside a few connections for non-superusers, such as stats-monitoring connections. There's often no reason to grant these users superuser privileges (they're just observers, and security-definer functions can make anything visible that they may need)), but at th

Re: [HACKERS] Full GUID support

2011-07-03 Thread Michael Gould
Does this look to be something that will surface around for 9.1 Sent from Samsung mobile Dave Page wrote: >On Sunday, July 3, 2011, Michael Gould > wrote: >> Peter, >> >> I don't believe that the library that the contrib module runs with can run >> on Window 64 bit servers or even Windows 7 64

Re: [HACKERS] [COMMITTERS] pgsql: Make the visibility map crash-safe.

2011-07-03 Thread Robert Haas
On Thu, Jun 30, 2011 at 6:19 PM, Jeff Davis wrote: > On Thu, 2011-06-30 at 07:50 -0400, Robert Haas wrote: >> I compare the performance of commit >> 431ab0e82819b31fcd1e33ecb52c2cd3b4b41da7 (post-patch) with commit >> 431ab0e82819b31fcd1e33ecb52c2cd3b4b41da7 (pre-patch). > > I believe that is a co

Re: [HACKERS] %ENV warnings during builds

2011-07-03 Thread Brar Piening
schrieb Magnus Hagander: I think you've stumbled on just about all the bits of the MSVC build system we haven't perlized. Maybe we should complete that task, and turn clean.bat, pgbison.bat and pgflex.bat into pure one-line wrappers. (It was done for builddoc just a few weeks ago). Yeah, give nth

Re: [HACKERS] Full GUID support

2011-07-03 Thread Tom Lane
Dave Page writes: > Even If that weren't the case, integrating the type wouldn't fix the > problem anyway, unless you're suggesting we implement our own UUID > generator (which isn't nearly as straightforward as it might seem, as > I understand it).. Yeah. If there were One True Way to create a

Re: [HACKERS] Full GUID support

2011-07-03 Thread Dave Page
On Sunday, July 3, 2011, Michael Gould wrote: > Peter, > > I don't believe that the library that the contrib module runs with can run > on Window 64 bit servers or even Windows 7 64 bit.  That is problem as most > shops are using 64 bit OS and if Window the contrib module is going to fail. >  Taki

Re: [HACKERS] Full GUID support

2011-07-03 Thread Michael Gould
Peter, I don't believe that the library that the contrib module runs with can run on Window 64 bit servers or even Windows 7 64 bit. That is problem as most shops are using 64 bit OS and if Window the contrib module is going to fail. Taking the responsibility to handle this internally means that

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-03 Thread Simon Riggs
On Sun, Jul 3, 2011 at 7:51 PM, Peter Eisentraut wrote: > On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: >> Robert Hass (whose name I misspelled in the commit message above) just >> mentioned to me (in an answer to my apologizing about it) that he >> didn't think that mentioning sponsors

Re: [HACKERS] Deriving release notes from git commit messages

2011-07-03 Thread Andres Freund
On Sunday, July 03, 2011 09:18:52 PM Magnus Hagander wrote: > On Sun, Jul 3, 2011 at 20:04, Andres Freund wrote: > > On Sunday, July 03, 2011 06:46:15 PM Tom Lane wrote: > >> A look at the git-notes man page says that you can only have one note > >> per commit, but you can edit that note, and git

Re: [HACKERS] Deriving release notes from git commit messages

2011-07-03 Thread Magnus Hagander
On Sun, Jul 3, 2011 at 20:04, Andres Freund wrote: > On Sunday, July 03, 2011 06:46:15 PM Tom Lane wrote: >> A look at the git-notes man page says that you can only have one note >> per commit, but you can edit that note, and git does track the revision >> history of each note. >> >> I think that

Re: [HACKERS] plpgsql extension install nitpick

2011-07-03 Thread Robert Haas
On Sun, Jul 3, 2011 at 12:33 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On lör, 2011-07-02 at 23:22 -0400, Tom Lane wrote: >>> [ don't want to put duplicate comments on PLs and their extensions ] > >> Well, you still write functions in the language and refer to it in the >> SQL commands, s

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-03 Thread Magnus Hagander
On Sun, Jul 3, 2011 at 20:51, Peter Eisentraut wrote: > On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: >> Robert Hass (whose name I misspelled in the commit message above) just >> mentioned to me (in an answer to my apologizing about it) that he >> didn't think that mentioning sponsors f

Re: [HACKERS] Full GUID support

2011-07-03 Thread Peter Eisentraut
On sön, 2011-07-03 at 13:42 -0500, Michael Gould wrote: > I would like to request that full support for the UUID data type can added. > I think that even though there is a contrib module, since this is a standard > datatype that Postgres ought to be the one actually assigning the value. What diff

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-03 Thread Peter Eisentraut
On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: > Robert Hass (whose name I misspelled in the commit message above) just > mentioned to me (in an answer to my apologizing about it) that he > didn't think that mentioning sponsors for patch development was a good > idea. > > I don't think w

[HACKERS] Full GUID support

2011-07-03 Thread Michael Gould
I would like to request that full support for the UUID data type can added.  I think that even though there is a contrib module, since this is a standard datatype that Postgres ought to be the one actually assigning the value. Best Regards Michael Gould -- Michael Gould, Managing Partner Inte

Re: [HACKERS] Deriving release notes from git commit messages

2011-07-03 Thread Andres Freund
On Sunday, July 03, 2011 06:46:15 PM Tom Lane wrote: > A look at the git-notes man page says that you can only have one note > per commit, but you can edit that note, and git does track the revision > history of each note. > > I think that we should adopt "git notes" as a better solution than > ma

Re: [HACKERS] plpgsql extension install nitpick

2011-07-03 Thread Tom Lane
Josh Kupershmidt writes: > On Sat, Jul 2, 2011 at 11:22 PM, Tom Lane wrote: >> Josh Kupershmidt writes: >>> [ plpgsql's comment is now attached to the extension, not the PL itself ] >>> ... And if you're wondering why I care >>> about any of this, it's because I'd like to fix up psql's \dL comma

Re: [HACKERS] Deriving release notes from git commit messages

2011-07-03 Thread Tom Lane
Martijn van Oosterhout writes: > On Sat, Jul 02, 2011 at 03:45:03PM -0400, Robert Haas wrote: >>> There are git notes which you can attach to a commit after the fact... I >>> like >>> the fact that they would keep the information in the repository (where they >>> seem to belong). >> Yeah, but I

Re: [HACKERS] plpgsql extension install nitpick

2011-07-03 Thread Tom Lane
Peter Eisentraut writes: > On lör, 2011-07-02 at 23:22 -0400, Tom Lane wrote: >> [ don't want to put duplicate comments on PLs and their extensions ] > Well, you still write functions in the language and refer to it in the > SQL commands, so it is reasonable to know about the language as opposed

Re: [HACKERS] %ENV warnings during builds

2011-07-03 Thread Andrew Dunstan
On Sun, July 3, 2011 8:54 am, Peter Eisentraut wrote: > On sön, 2011-07-03 at 20:14 +0800, Craig Ringer wrote: >> It looks like pgflex.bat and pgbison.bat in the win32 build files would >> benefit from a tweak to eliminate a complaint from Perl. >> >> Perl emits the error: >> >>Hash %ENV missi

Re: [HACKERS] %ENV warnings during builds

2011-07-03 Thread Magnus Hagander
On Sun, Jul 3, 2011 at 13:06, Andrew Dunstan wrote: > On Sun, July 3, 2011 8:14 am, Craig Ringer wrote: >> Hi folks >> >> It looks like pgflex.bat and pgbison.bat in the win32 build files would >> benefit from a tweak to eliminate a complaint from Perl. >> >> Perl emits the error: >> >>    Hash %E

Re: [HACKERS] plpgsql extension install nitpick

2011-07-03 Thread Peter Eisentraut
On lör, 2011-07-02 at 23:22 -0400, Tom Lane wrote: > We just went through an exercise to suppress comments on functions > that are meant to be accessed through operators, and this seems like > much the same kind of situation. I think it will not be long before > COMMENT ON PROCEDURAL LANGUAGE is a

Re: [HACKERS] `make world` exit code

2011-07-03 Thread Peter Eisentraut
On lör, 2011-07-02 at 22:36 -0700, David E. Wheeler wrote: > Hackers, > > I'm building a new server using 9.1beta2. My build script includes these two > line: > > make world -j3 || exit $? > make install-world || exit $? > > Much to my annoyance, `make world` seems to succeed, but the s

Re: [HACKERS] %ENV warnings during builds

2011-07-03 Thread Peter Eisentraut
On sön, 2011-07-03 at 20:14 +0800, Craig Ringer wrote: > It looks like pgflex.bat and pgbison.bat in the win32 build files would > benefit from a tweak to eliminate a complaint from Perl. > > Perl emits the error: > >Hash %ENV missing the % in argument 1 of each() at -e line 1 > > on the li

Re: [HACKERS] %ENV warnings during builds

2011-07-03 Thread Andrew Dunstan
On Sun, July 3, 2011 8:14 am, Craig Ringer wrote: > Hi folks > > It looks like pgflex.bat and pgbison.bat in the win32 build files would > benefit from a tweak to eliminate a complaint from Perl. > > Perl emits the error: > >Hash %ENV missing the % in argument 1 of each() at -e line 1 > > on th

[HACKERS] %ENV warnings during builds

2011-07-03 Thread Craig Ringer
Hi folks It looks like pgflex.bat and pgbison.bat in the win32 build files would benefit from a tweak to eliminate a complaint from Perl. Perl emits the error: Hash %ENV missing the % in argument 1 of each() at -e line 1 on the lines that process buildenv.pl. This is because % in batch fil

Re: [HACKERS] Deriving release notes from git commit messages

2011-07-03 Thread Martijn van Oosterhout
On Sat, Jul 02, 2011 at 03:45:03PM -0400, Robert Haas wrote: > > There are git notes which you can attach to a commit after the fact... I > > like > > the fact that they would keep the information in the repository (where they > > seem to belong). > > Yeah, but I think it's still basically append

Re: [HACKERS] per-column generic option

2011-07-03 Thread Kohei KaiGai
Hanada-san, I checked the per-column generic option patch. Right now, I have nothing to comment on anymore. So, it should be reviewed by committers. Thanks, 2011年6月27日16:47 Shigeru Hanada : > (2011/06/26 18:34), Kohei KaiGai wrote: >> I checked your patch. > > Thanks for the review! Please find

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 2

2011-07-03 Thread Kohei KaiGai
The simplified version of fix-leaky-view patch. The part of reloptions for views got splitted out into the part-0 patch, so it needs to be applied prior to this patch. Rest of logic to prevent unexpected pushing down across security barrier is not changed. Thanks, 2011/6/6 Kohei Kaigai : > This p

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-07-03 Thread Dave Page
On Sun, Jul 3, 2011 at 8:28 AM, Brar Piening wrote: > Perhaps someone who routinely does 64-bit builds could help out with a > config.pl and some info from where to get the 64-bit libraries to build > with. Here's what we use for the installers. # Configuration arguments for vcbuild. use strict;

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-07-03 Thread Brar Piening
schrieb Craig Ringer: I'd appreciate it if you'd post the config.pl you're building with, mainly so I can see what libraries and optional features you are or are not using with your test builds. I've already posted it here: http://archives.postgresql.org/message-id/4dcda3cd.4030...@gmx.de