Hackers,
I'm building a new server using 9.1beta2. My build script includes these two
line:
make world -j3 || exit $?
make install-world || exit $?
Much to my annoyance, `make world` seems to succeed, but the script exits with
no error message. So the second line never executes. I comm
On Sat, Jul 2, 2011 at 11:22 PM, Tom Lane wrote:
> Josh Kupershmidt writes:
>> [ plpgsql's comment is now attached to the extension, not the PL itself ]
>
>> So, basically, I would like to have that comment show up for the first
>> query. I imagine this could be fixed quite easily by adding:
>>
Josh Kupershmidt writes:
> [ plpgsql's comment is now attached to the extension, not the PL itself ]
> So, basically, I would like to have that comment show up for the first
> query. I imagine this could be fixed quite easily by adding:
> COMMENT ON PROCEDURAL LANGUAGE plpgsql IS 'PL/pgSQL proc
Hi all,
I noticed that the plpgsql extension gets installed with an extension
comment of 'PL/pgSQL procedural language', which comes from
plpgsql.control. That seems fine and dandy, but take a look at the
following query (modified from psql's \dL query):
SELECT l.lanname AS "Name",
pg_cata
On 11-06-28 02:14 PM, Martin Pihlak wrote:
Thanks for the review!
I have since simplified the patch to assume that partial SSL writes are
disabled -- according to SSL_write(3) this is the default behaviour.
Now the SSL retry buffer only holds the data to be retried, the
remainder is moved to the
On 2/07/2011 11:54 PM, Magnus Hagander wrote:
On Sat, Jul 2, 2011 at 17:51, Craig Ringer wrote:
Hi folks
I've noticed while testing the VC 2010 patches that clean.pl in
src/tools/msvc doesn't remove files generated by flex. I landed up with a
broken configuration while testing my x64 builds th
On Sat, Jul 2, 2011 at 3:46 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Sat, Jul 2, 2011 at 1:54 PM, Kohei KaiGai wrote:
>>> BTW, regarding to the statement support for security barrier views,
>>> the following syntax might be more consistent with existing ones:
>>> CREATE VIEW view_name WI
On Wed, Jun 29, 2011 at 12:15 PM, Merlin Moncure wrote:
> Patch applies clean, does what it is supposed to do, and matches other
> conventions in describe.c Passing to committer. pg_comments may be
> a better way to go, but that is a problem for another day...
Thanks for the review, and sorry
Robert Haas writes:
> On Sat, Jul 2, 2011 at 5:20 PM, Tom Lane wrote:
>> Peter Eisentraut writes:
>>> Most importantly, operator optimization information could be attached to
>>> procedures,
>> We should definitely do that someday, but there are far less invasive
>> ways to do it than fundament
On Sat, Jul 2, 2011 at 5:20 PM, Tom Lane wrote:
> Peter Eisentraut writes:
>> This thought reemerged in me during the recent discussion of the regular
>> expression matching operators: A lot of things could be better if
>> pg_proc and pg_operator were merged together.
>
> Like what? I think this
Peter Eisentraut writes:
> This thought reemerged in me during the recent discussion of the regular
> expression matching operators: A lot of things could be better if
> pg_proc and pg_operator were merged together.
Like what? I think this would result in a huge amount of code churn
(including l
This thought reemerged in me during the recent discussion of the regular
expression matching operators: A lot of things could be better if
pg_proc and pg_operator were merged together.
Most importantly, operator optimization information could be attached to
procedures, so developers and users woul
I wrote:
> I noticed while wrapping 9.1beta2 that plpython tries to build a file
> spiexceptions.h to be included in the tarballs, but no such file is
> actually appearing therein. The reason is that src/pl/Makefile doesn't
> recurse into the plpython subdirectory unless with_python is set.
> Whic
Robert Haas writes:
> On Sat, Jul 2, 2011 at 1:54 PM, Kohei KaiGai wrote:
>> BTW, regarding to the statement support for security barrier views,
>> the following syntax might be more consistent with existing ones:
>> CREATE VIEW view_name WITH ( param [=value]) AS query ... ;
>> rather than
>>
On Sat, Jul 2, 2011 at 10:19 AM, Andres Freund wrote:
> On Saturday, July 02, 2011 06:10:43 AM Tom Lane wrote:
>> I wouldn't have a problem with establishing a convention that we
>> write credits in commit messages in a more standardized way, ie put
>> something like "Author: Joe Blow " in the bod
On Sat, Jul 2, 2011 at 1:54 PM, Kohei KaiGai wrote:
> BTW, regarding to the statement support for security barrier views,
> the following syntax might be more consistent with existing ones:
> CREATE VIEW view_name WITH ( param [=value]) AS query ... ;
> rather than
> CREATE SECURITY VIEW view_na
Heikki Linnakangas writes:
> Ah, that opens the door to do something I considered earlier but
> rejected because of alignment: instead of three 32-bit word fetches, we
> could fetch one 64-bit word and 32-bit word. Might shave a few more
> cycles...
Hm ... I suspect that might be a small win o
On 02.07.2011 21:07, Tom Lane wrote:
I wrote:
I tweaked the patch a bit further (don't pessimize the boundary case
where there's exactly 4n+1 trigrams, avoid forcing trg1 into memory,
improve the comment) and attach that version below. This is a little
bit faster but I still wonder if it's wort
I wrote:
> I tweaked the patch a bit further (don't pessimize the boundary case
> where there's exactly 4n+1 trigrams, avoid forcing trg1 into memory,
> improve the comment) and attach that version below. This is a little
> bit faster but I still wonder if it's worth the price of adding an
> obscu
BTW, regarding to the statement support for security barrier views,
the following syntax might be more consistent with existing ones:
CREATE VIEW view_name WITH ( param [=value]) AS query ... ;
rather than
CREATE SECURITY VIEW view_name AS query ...;
Any comments?
2011/7/2 Noah Misch :
> On S
Magnus Hagander writes:
> On Sat, Jul 2, 2011 at 17:51, Craig Ringer
> wrote:
>> I've noticed while testing the VC 2010 patches that clean.pl in
>> src/tools/msvc doesn't remove files generated by flex.
> clean.pl? I don't even have that file, I only have clean.bat...
> And if you're talking a
On Sat, Jul 2, 2011 at 17:51, Craig Ringer wrote:
> Hi folks
>
> I've noticed while testing the VC 2010 patches that clean.pl in
> src/tools/msvc doesn't remove files generated by flex. I landed up with a
> broken configuration while testing my x64 builds that caused the creation of
> zero-size ou
Hi folks
I've noticed while testing the VC 2010 patches that clean.pl in
src/tools/msvc doesn't remove files generated by flex. I landed up with
a broken configuration while testing my x64 builds that caused the
creation of zero-size outputs for bootscanner.c etc. These weren't
re-generated o
On Saturday, July 02, 2011 06:10:43 AM Tom Lane wrote:
> I wouldn't have a problem with establishing a convention that we
> write credits in commit messages in a more standardized way, ie put
> something like "Author: Joe Blow " in the body of the
> commit message. However, the points that were ra
On Sat, Jul 02, 2011 at 12:48:32PM +0200, Kohei KaiGai wrote:
> > Let's see. ?Every qual list will have some depth d such that all quals
> > having
> > depth >= d are security-relevant, and all others are not security-relevant.
> > (This does not hold for all means of identifying security-relevant
On Thu, Jun 30, 2011 at 6:25 PM, Robert Haas wrote:
>> I think the time problems are more complex than said. The patch relies
>> upon transaction completion times, but not all WAL records have a time
>> attached to them. Plus you only used commits anyway, not sure why.
>
> For the same reason we
On Fri, Jul 01, 2011 at 07:31:30PM +0200, Torello Querci wrote:
> 2011/6/2 Noah Misch :
> > Having thought about this some more, I do now see a risk. ?Currently, a
> > SECURITY
> > DEFINER function (actually any function, but that's where it matters) can
> > trap
> > query_canceled. ?By doing so
>> > I was referring to this paragraph:
>> >
>> > ?On the technical side, I am pretty doubtful that the approach of adding a
>> > ?nestlevel to FuncExpr and RelOptInfo is the right way to go. ?I believe we
>> > ?have existing code (to handle left joins) that prevents quals from being
>> > ?pushed d
The attached patch re-defines pg_seclabel.provider as NameData, instead of Text,
and revert changes of catcache.c about collations; to keep consistency with the
security label support on shared objects.
All the format changes are hidden by (Get|Set)SecurityLabel(), so no
need to change
on the patch
Hi
I'm getting set up to test your VS 2010 support patches. Sorry it's
taken me so long - work decided to take this opportunity to become ...
rather hectic.
I'd appreciate it if you'd post the config.pl you're building with,
mainly so I can see what libraries and optional features you are or
2011/7/2 Hitoshi Harada :
> 2011/6/29 Yeb Havinga :
>>
>> On 2011-06-17 09:54, Hitoshi Harada wrote:
>>>
>>> While reviewing the gist/box patch, I found some planner APIs that can
>>> replace parts in my patch. Also, comments in includes wasn't updated
>>> appropriately. Revised patch attached.
>>
2011/6/29 Yeb Havinga :
>
> On 2011-06-17 09:54, Hitoshi Harada wrote:
>>
>> While reviewing the gist/box patch, I found some planner APIs that can
>> replace parts in my patch. Also, comments in includes wasn't updated
>> appropriately. Revised patch attached.
>
> Hello Hitoshi-san,
>
> I read you
32 matches
Mail list logo
