Re: [HACKERS] SSI tuning points

2011-06-18 Thread Robert Haas
On Fri, Jun 17, 2011 at 5:50 PM, Kevin Grittner wrote: > The attached patch addresses one of the open non-blockers for beta3. > > These are tuning points which emerged in testing.  The first is more > likely to be helpful.  The second may be very important in a few > types of transaction mixes, bu

Re: [HACKERS] creating CHECK constraints as NOT VALID

2011-06-18 Thread Robert Haas
On Sat, Jun 18, 2011 at 2:57 AM, Jaime Casanova wrote: >> looks good to me... at least it compiles, and function as i would expect... >> tomorrow i will read the code more carefully and look at the docs, but >> probably this is just fine to be commited... > > I think that this paragraph is confusi

Re: [HACKERS] Identifying no-op length coercions

2011-06-18 Thread Robert Haas
On Sat, Jun 18, 2011 at 11:12 PM, Robert Haas wrote: > On Sat, Jun 18, 2011 at 11:06 PM, Noah Misch wrote: >> On Sat, Jun 18, 2011 at 10:57:13PM -0400, Robert Haas wrote: >>> On Sat, Jun 11, 2011 at 5:13 PM, Noah Misch wrote: >>> > Sounds good. ?Updated patch attached, incorporating your ideas.

Re: [HACKERS] patch for 9.2: enhanced errors

2011-06-18 Thread Steve Singer
On 11-06-18 06:36 PM, Steve Singer wrote: On 11-06-08 04:14 PM, Pavel Stehule wrote: Here is my review of this patch Submission Review: The patch applies cleanly against master The patch does not include any documentation updates (see note below to update config.sgml)

Re: [HACKERS] Identifying no-op length coercions

2011-06-18 Thread Robert Haas
On Sat, Jun 18, 2011 at 11:06 PM, Noah Misch wrote: > On Sat, Jun 18, 2011 at 10:57:13PM -0400, Robert Haas wrote: >> On Sat, Jun 11, 2011 at 5:13 PM, Noah Misch wrote: >> > Sounds good. ?Updated patch attached, incorporating your ideas. ?Before >> > applying >> > it, run this command to update

Re: [HACKERS] plpgsql performance - SearchCatCache issue

2011-06-18 Thread Robert Haas
On Sat, Jun 18, 2011 at 9:21 AM, Pavel Stehule wrote: > Is this profile expected? I've certainly seen profiles before where the catcache overhead was significant. I don't think that I've seen SearchCatCache() quite this high on any of the profiling I've done, but then again I don't tend to profi

Re: [HACKERS] Identifying no-op length coercions

2011-06-18 Thread Noah Misch
On Sat, Jun 18, 2011 at 10:57:13PM -0400, Robert Haas wrote: > On Sat, Jun 11, 2011 at 5:13 PM, Noah Misch wrote: > > Sounds good. ?Updated patch attached, incorporating your ideas. ?Before > > applying > > it, run this command to update the uninvolved pg_proc.h DATA entries: > > ?perl -pi -e 's/

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-06-18 Thread Robert Haas
On Sat, Jun 18, 2011 at 1:43 PM, Josh Kupershmidt wrote: >> Regarding to the data-type of objnamespace, how about an idea to define a new >> data type such as 'regschema' and cast objnamespace into this type? >> If we have such data type, user can reference string expression of schema >> name, >>

Re: [HACKERS] crash-safe visibility map, take five

2011-06-18 Thread Robert Haas
On Sat, Jun 18, 2011 at 10:41 PM, Noah Misch wrote: > This version of the patch has some bogus hunks in int.c, int8.c, and heap.c > reverting a few of your other recent commits. Woops, good catch. Corrected version attached, in case anyone else wants to take a look at it. > Looks good otherwise

Re: [HACKERS] Identifying no-op length coercions

2011-06-18 Thread Robert Haas
On Sat, Jun 11, 2011 at 5:13 PM, Noah Misch wrote: > Sounds good.  Updated patch attached, incorporating your ideas.  Before > applying > it, run this command to update the uninvolved pg_proc.h DATA entries: >  perl -pi -e 's/PGUID(\s+\d+){4}/$& 0/' src/include/catalog/pg_proc.h This doesn't qui

Re: [HACKERS] [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address

2011-06-18 Thread Robert Haas
On Tue, Jun 14, 2011 at 8:06 AM, Kohei KaiGai wrote: > The attached patch is a preparation to rework implementation of DROP statement > using a common code. That intends to apply get_object_address() to resolve > name > of objects to be removed, and eventually minimizes the number of places to pu

Re: [HACKERS] crash-safe visibility map, take five

2011-06-18 Thread Noah Misch
On Sat, Jun 18, 2011 at 10:04:52PM -0400, Robert Haas wrote: > On Sat, Jun 18, 2011 at 9:37 AM, Noah Misch wrote: > > Indeed. ?If we conflicted on the xmin of the most-recent all-visible tuple > > when setting the bit, all-visible on the standby would become a superset of > > all-visible on the ma

Re: [HACKERS] crash-safe visibility map, take five

2011-06-18 Thread Robert Haas
On Sat, Jun 18, 2011 at 9:37 AM, Noah Misch wrote: > Indeed.  If we conflicted on the xmin of the most-recent all-visible tuple > when setting the bit, all-visible on the standby would become a superset of > all-visible on the master, and we could cease to ignore the bits.  This is an > excellent

Re: [HACKERS] patch for 9.2: enhanced errors

2011-06-18 Thread Steve Singer
On 11-06-08 04:14 PM, Pavel Stehule wrote: Hello Attached patch implements a new erros's fields that describes table, colums related to error. This enhanced info is limited to constraints and RI. Here is my review of this patch Submission Review: The patch applies cl

Re: [HACKERS] Range Types and extensions

2011-06-18 Thread Jeff Davis
On Sat, 2011-06-18 at 22:19 +0200, Florian Pflug wrote: > Yes, that seems necessary for consistency. That leaves the question > of what to do if someone tries to modify a textrange's collation with > a COLLATE clause. For example, > > For example, whats the result of > 'Ä' in '[A,Z']::textrange_

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

2011-06-18 Thread Tom Lane
Bruce Momjian writes: > Perhaps we should recommend: > cd /path && test ! -f %f && cp %p %f > That is shorter and removes the duplicate problem. Um ... %p is relative to the database directory. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hacker

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

2011-06-18 Thread Bruce Momjian
Bruce Momjian wrote: > Andrew Dunstan wrote: > > > > > > On 06/18/2011 09:19 AM, Tom Lane wrote: > > > Thom Brown writes: > > >> On 18 June 2011 04:13, Bruce Momjian wrote: > > >>> I tested on FreeBSD 7.4 and saw a 1 error return: > > >> And on a Mac (so through Darwin 10.7.0 a BSD version too)

Re: [HACKERS] pika buildfarm member failure on isolationCheck tests

2011-06-18 Thread Andrew Dunstan
On 06/18/2011 11:57 AM, Rémi Zara wrote: Hi, Pika failed at the isolationCheck phase, hitting an assertion: TRAP: FailedAssertion("!(!((oldSerXidControl->tailXid) != ((TransactionId) 0)) || TransactionIdFollows(xid, oldSerXidControl->tailXid))", File: "predicate.c", Line: 991) see http://w

Re: [HACKERS] Range Types and extensions

2011-06-18 Thread Florian Pflug
On Jun18, 2011, at 10:10 , Jeff Davis wrote: > On Fri, 2011-06-10 at 00:26 +0200, Florian Pflug wrote: > So, I believe that you are proposing to change the concept of a range > value from "a contiguous set of values" to "a pair of bounds". Yeah. Mostly though because I figured that'd make defining

[HACKERS] Grouping Sets

2011-06-18 Thread Mariano Mara
Hi hackers (and specially Pavel Stehule), I could really use the grouping set feature for some complex queries I'm migrating from other db vendor. If my WEB searching is precise, this wiki page [1] and this thread[2] are the last updates on the subject. I'm willing to test how these functions

Re: [HACKERS] XPATH evaluation

2011-06-18 Thread Radosław Smogura
Nicolas Barbier Friday 17 of June 2011 17:29:57 > 2011/6/17, Andrew Dunstan : > > On 06/17/2011 10:55 AM, Radosław Smogura wrote: > >> XML canonization preservs whitespaces, if I remember > >> well, I think there is example. > >> > >> In any case if I will store image in XML (I've seen this), pre

Re: [HACKERS] .gitignore for some of cygwin files

2011-06-18 Thread Magnus Hagander
On Thu, Jun 16, 2011 at 12:36, Peter Eisentraut wrote: > On tor, 2011-06-09 at 16:25 +0200, Magnus Hagander wrote: >> Based on this list, a global exclude for "*.exe" and "lib*dll.def" >> seems reasonable. > > We already have finer-grained excludes for various lib*dll.def > variations in the libpq

[HACKERS] pika buildfarm member failure on isolationCheck tests

2011-06-18 Thread Rémi Zara
Hi, Pika failed at the isolationCheck phase, hitting an assertion: TRAP: FailedAssertion("!(!((oldSerXidControl->tailXid) != ((TransactionId) 0)) || TransactionIdFollows(xid, oldSerXidControl->tailXid))", File: "predicate.c", Line: 991) see http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=pi

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-06-18 Thread Kohei KaiGai
I checked the v4 patch. At first, I noticed three missing object classes although COMMENT ON allows to set a description on 'collation', 'extension' and 'foreign table'. In addition, this pg_comments system view supports 'access method' class, but we cannot set a comment on access methods using CO

Re: [HACKERS] proposal: a validator for configuration files

2011-06-18 Thread Florian Pflug
On Jun16, 2011, at 22:34 , Alexey Klyukin wrote: > Attached is the v2 of the patch to show all parse errors at postgresql.conf. > Changes (per review and suggestions from Florian): > > - do not stop on the first error during postmaster's start. > - fix errors in processing files from include direc

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

2011-06-18 Thread Bruce Momjian
Andrew Dunstan wrote: > > > On 06/18/2011 09:19 AM, Tom Lane wrote: > > Thom Brown writes: > >> On 18 June 2011 04:13, Bruce Momjian wrote: > >>> I tested on FreeBSD 7.4 and saw a 1 error return: > >> And on a Mac (so through Darwin 10.7.0 a BSD version too): > > Yeah, see yesterday's discussio

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

2011-06-18 Thread Andrew Dunstan
On 06/18/2011 09:19 AM, Tom Lane wrote: Thom Brown writes: On 18 June 2011 04:13, Bruce Momjian wrote: I tested on FreeBSD 7.4 and saw a 1 error return: And on a Mac (so through Darwin 10.7.0 a BSD version too): Yeah, see yesterday's discussion on pgsql-admin. I think the behavior with t

Re: [HACKERS] crash-safe visibility map, take five

2011-06-18 Thread Noah Misch
On Fri, Jun 17, 2011 at 01:21:17PM -0400, Robert Haas wrote: > On Thu, Jun 16, 2011 at 11:17 PM, Noah Misch wrote: > > I suggest revisiting the suggestion in > > http://archives.postgresql.org/message-id/27743.1291135...@sss.pgh.pa.us and > > including a latestRemovedXid in xl_heap_visible. ?The r

Re: [HACKERS] pg_upgrade using appname to lock out other users

2011-06-18 Thread Bruce Momjian
Bruce Momjian wrote: > I meant the PGPASSWORD environment variable: > > >PGPASSWORD > > PGPASSWORD behaves the same as thelinkend="libpq-connect-password"> connection parameter. > Use of this environment variable > is not recommended for security rea

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

2011-06-18 Thread Bruce Momjian
Tom Lane wrote: > Thom Brown writes: > > On 18 June 2011 04:13, Bruce Momjian wrote: > >> I tested on FreeBSD 7.4 and saw a 1 error return: > > > And on a Mac (so through Darwin 10.7.0 a BSD version too): > > Yeah, see yesterday's discussion on pgsql-admin. I think the behavior > with the erro

[HACKERS] plpgsql performance - SearchCatCache issue

2011-06-18 Thread Pavel Stehule
Hello I tried to optimize repeated assign in plpgsql with elimination unnecessary palloc/free calls. I tested changes on simple bublesort postgres=# \sf buble CREATE OR REPLACE FUNCTION public.buble(integer[]) RETURNS integer[] LANGUAGE plpgsql AS $function$ declare unsorted bool := true;

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

2011-06-18 Thread Tom Lane
Thom Brown writes: > On 18 June 2011 04:13, Bruce Momjian wrote: >> I tested on FreeBSD 7.4 and saw a 1 error return: > And on a Mac (so through Darwin 10.7.0 a BSD version too): Yeah, see yesterday's discussion on pgsql-admin. I think the behavior with the error return may be a BSD-ism. In a

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

2011-06-18 Thread Dickson S. Guedes
2011/6/18 Thom Brown : [.. cut ..] > And on a Mac (so through Darwin 10.7.0 a BSD version too): > > toucan:tmp thom$ touch x y > toucan:tmp thom$ cp -i x y; echo $? > overwrite y? (y/n [n]) n > not overwritten > 1 On AIX 5.3 bash-3.00$ touch x y bash-3.00$ cp -i x y; echo $? overwrite y? n 0 --

Re: [HACKERS] Another swing at JSON

2011-06-18 Thread Bernd Helmle
--On 17. Juni 2011 18:06:58 -0400 Joseph Adams wrote: Done. Note that this module builds, tests, and installs successfully with USE_PGXS=1. However, building without USE_PGXS=1 produces the following: CREATE EXTENSION json; ERROR: incompatible library "/usr/lib/postgresql/json.s

Re: [HACKERS] Range Types and extensions

2011-06-18 Thread Jeff Davis
On Fri, 2011-06-10 at 00:26 +0200, Florian Pflug wrote: > Maybe that check should just be removed? If one views the range > '[L, U)' as a concise way of expressing "L <= x AND x < U" for some > x, then allowing the case L > U seems quite natural. There won't > be any such x of course, but the range

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

2011-06-18 Thread Thom Brown
On 18 June 2011 04:13, Bruce Momjian wrote: > Bruce Momjian wrote: >> >> Wow, this is the first I am hearing GNU cp -i can return zero exit if it >> doesn't do the copy.  I tested this on Ubuntu 10.04 using cp 7.4 and >> got: >> >>       $ touch x y >>       $ cp -i x y; echo $? >>       cp: overw