Re: [HACKERS] DOMAINs and CASTs

2011-05-16 Thread Darren Duncan
Jaime Casanova wrote: On Sun, May 15, 2011 at 9:14 PM, Robert Haas wrote: we should probably try to agree on which of the various options you mention makes most sense. well... my original patch only handle the simplest case, namely, try to make the cast that the user wants and if none is defi

Re: [HACKERS] DOMAINs and CASTs

2011-05-16 Thread Jaime Casanova
On Sun, May 15, 2011 at 9:14 PM, Robert Haas wrote: > > we should probably try to agree on which > of the various options you mention makes most sense. > well... my original patch only handle the simplest case, namely, try to make the cast that the user wants and if none is defined fall to the ba

[HACKERS] Cannot build docs of 9.1 on Windows

2011-05-16 Thread MauMau
Hello, I posted the following mail to pgsql-docs, but let me re-post it here because I'm afraid much less people watch pgsql-docs and pgsql-docs might be inactive. And the problem is not about the contents of docs but about the build system, so I thought here might be better. I'm developing

Re: [HACKERS] Extensions in schemas

2011-05-16 Thread Dimitri Fontaine
Magnus Hagander writes: > Is there any particular reason why we can't/don't auto-create schema > bar when you run "CREATE EXTENSION foo SCHEMA bar"? We do it when the schema is given in the control file. I'm not sure off hand but we maybe only do that when the extension is *not* relocatable. Th

Re: [HACKERS] Fix for Perl 5.14

2011-05-16 Thread Alex Hunsaker
On Sat, Apr 23, 2011 at 07:00, Andrew Dunstan wrote: > This looks OK, but I think we need to wait until they remove the RC tag. 5.14.0 is out now, Ive retested with 5.14.0 (x86-64), 5.12.3 (x86-64) and 5.10.1 (i386). No changes are needed. [ if you missed it ] The Devel::PPPort guy said patches

Re: [HACKERS] pg_upgrade permission check

2011-05-16 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> "full access permissions" seems unhelpfully vague. Why not say > >> "you must have both read and write access to the current directory"? > > > OK, I can do that, but they need execute permission in that directory > > too to look up

Re: [HACKERS] pg_upgrade permission check

2011-05-16 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> "full access permissions" seems unhelpfully vague. Why not say >> "you must have both read and write access to the current directory"? > OK, I can do that, but they need execute permission in that directory > too to look up file names in there. Should

Re: [HACKERS] pg_upgrade permission check

2011-05-16 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > I have added the attached patch to pg_upgrade to print a clear error > > message if you don't have read/write/execute permission in the current > > directory, which is needed for pg_upgrade to read/write temporary files. > > "full access permissions" se

Re: [HACKERS] pg_upgrade permission check

2011-05-16 Thread Tom Lane
Bruce Momjian writes: > I have added the attached patch to pg_upgrade to print a clear error > message if you don't have read/write/execute permission in the current > directory, which is needed for pg_upgrade to read/write temporary files. "full access permissions" seems unhelpfully vague. Why

[HACKERS] use less space in xl_xact_commit patch

2011-05-16 Thread Leonardo Francalanci
Hi, following the conversation at http://postgresql.1045698.n5.nabble.com/switch-UNLOGGED-to-LOGGED-tp4290461p4382333.html I tried to remove some bytes from xl_xact_commit. The way I did it needs palloc+memcpy. I guess it could be done reusing the memory for smgrGetPendingDeletes. But I don

[HACKERS] pg_upgrade permission check

2011-05-16 Thread Bruce Momjian
I have added the attached patch to pg_upgrade to print a clear error message if you don't have read/write/execute permission in the current directory, which is needed for pg_upgrade to read/write temporary files. This is based on a bug report I received from EnterpriseDB usage testing. -- Bruc

[HACKERS] pg_dump vs casts in extensions

2011-05-16 Thread Tom Lane
A discussion over in pgsql-admin led me to realize that there's a corner case bug in pg_dump for casts that belong to extensions. Namely, pg_dump has a rather ad-hoc rule for deciding whether to dump a cast, and that rule could result in not dumping a cast belonging to an extension (if the extensio

Re: [HACKERS] DETOAST Datum

2011-05-16 Thread Nick Raj
On Mon, May 16, 2011 at 7:52 PM, Tom Lane wrote: > Robert Haas writes: > > On Mon, May 16, 2011 at 3:41 AM, Nick Raj wrote: > >> "How to get arguments toastable??" and even my table > pg_class.reltoastrelid > >> entry is zero. > > > It's pretty hard to guess what's going wrong here from the inf

Re: [HACKERS] pg_upgrade and PGPORT

2011-05-16 Thread Bruce Momjian
Bruce Momjian wrote: > Bruce Momjian wrote: > > > >> ? ? ? Performing Consistency Checks > > > >> ? ? ? - > > > >> ? ? ? ignoring libpq environment variable PGPORT > > > > > > > > I haven't tried it, but I suppose option.c will now make use of PGPORT > > > > and then lat

Re: [HACKERS] Extensions in schemas

2011-05-16 Thread Tom Lane
Magnus Hagander writes: > Is there any particular reason why we can't/don't auto-create schema > bar when you run "CREATE EXTENSION foo SCHEMA bar"? That was considered, and rejected for reasons that I probably don't recall all of, but I do remember one argument: 99.44% of the time you want an ex

Re: [HACKERS] DETOAST Datum

2011-05-16 Thread Tom Lane
Robert Haas writes: > On Mon, May 16, 2011 at 3:41 AM, Nick Raj wrote: >> "How to get arguments toastable??" and even my table pg_class.reltoastrelid >> entry is zero. > It's pretty hard to guess what's going wrong here from the information > you've provided. But reltoastid should not be 0 if y

Re: [HACKERS] DETOAST Datum

2011-05-16 Thread Robert Haas
On Mon, May 16, 2011 at 3:41 AM, Nick Raj wrote: > When i called my function, it gives NDBOX to be null > On debugging, i found out ,FunctionInvokeCall invokes fmgr_oldstyle > function, for getting argument > > if (fnextra->arg_toastable[i])    //this returns false, not able to get > arguments >  

Re: [HACKERS] Extensions in schemas

2011-05-16 Thread Robert Haas
On Mon, May 16, 2011 at 3:59 AM, Magnus Hagander wrote: > Is there any particular reason why we can't/don't auto-create schema > bar when you run "CREATE EXTENSION foo SCHEMA bar"? OK, I'll ask the obvious question. Should we also auto-create the schema when a user says CREATE TABLE bar.foo()?

Re: [HACKERS] Exporting closePGconn from libpq

2011-05-16 Thread Merlin Moncure
On Sat, May 14, 2011 at 11:23 AM, Leon Smith wrote: > A minor issue has come up in creating low-level bindings to libpq for > safe garbage-collected languages,  namely that PQfinish is the only > (AFAICT) way to close a connection but also de-allocates the memory > used to represent the database c

Re: [HACKERS] Exporting closePGconn from libpq

2011-05-16 Thread Markus Wanner
Leon, On 05/14/2011 05:23 PM, Leon Smith wrote: > A minor issue has come up in creating low-level bindings to libpq for > safe garbage-collected languages, namely that PQfinish is the only > (AFAICT) way to close a connection but also de-allocates the memory > used to represent the database conne

Re: [HACKERS] Isolation checks under MSVC

2011-05-16 Thread Magnus Hagander
On Mon, May 16, 2011 at 06:14, Andrew Dunstan wrote: > > I've committed a bunch of changes both in the Postgres code and the > buildfarm code to enable running the isolation checks under MSVC. There's > one hurdle that I haven't overcome: the code tries to call > "./isolationtester" and Windows ba

[HACKERS] Extensions in schemas

2011-05-16 Thread Magnus Hagander
Is there any particular reason why we can't/don't auto-create schema bar when you run "CREATE EXTENSION foo SCHEMA bar"? --  Magnus Hagander  Me: http://www.hagander.net/  Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

[HACKERS] DETOAST Datum

2011-05-16 Thread Nick Raj
Hi, I have defined some function and also used NDBOX structure that having variable length. typedef struct NDBOX { int32vl_len_;/* varlena length */ unsigned int dim; doublex[1]; } NDBOX; When i called my function, it gives NDBOX to be null On debugging, i foun

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-16 Thread Magnus Hagander
On Mon, May 16, 2011 at 01:03, Jaime Casanova wrote: > On Thu, May 5, 2011 at 10:59 AM, Tom Lane wrote: >> Magnus Hagander writes: So even if people don't believe in the rationale behind the patch, would allowing it harm anything at this point? >> >>> Adding it for the sake of upgrades