On tis, 2010-06-08 at 16:17 -0400, Robert Haas wrote:
> > Perhaps
> > ->
>
> That's already in use to mean something else.
Btw., the SQL standard also defines -> for something else, so if you
wanted to be really visionary, you could deprecate that one as an
operator at the same time.
--
Sent v
On tor, 2010-06-10 at 09:52 -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > Quick testing shows that clang doesn't get through the configure stage
> > on this Debian system -- it looks like some amount of better integration
> > with glibc might be needed. Building with llvm-gcc works fine,
Peter Eisentraut wrote:
> Some new warnings, however:
>
> xlog.c:7759:22: warning: self-comparison always results in a constant
> value
> max_locks_per_xact != max_locks_per_xact)
>^
>
> Looks like a bug.
Ah, it should be compared with the s
Peter Eisentraut writes:
> [ assorted LLVM warnings ]
> dt_common.c:818:75: warning: more data arguments than '%' conversions
> [-Wformat-extra-args]
> sprintf(str + strlen(str), (min != 0) ?
> "%+03d:%02d" : "%+03d", hour, min);
> ~~~^
> [and a few mo
On Fri, Jun 11, 2010 at 1:01 AM, Heikki Linnakangas
wrote:
> We're talking about a corrupt record (incorrect CRC, incorrect backlink
> etc.), not errors within redo functions. During crash recovery, a corrupt
> record means you've reached end of WAL. In standby mode, when streaming WAL
> from mast
On tor, 2010-06-10 at 11:55 +0300, Peter Eisentraut wrote:
> Quick testing shows that clang doesn't get through the configure stage
> on this Debian system -- it looks like some amount of better
> integration with glibc might be needed.
Some details on this ...
configure has two problems. The fi
Robert Haas writes:
> On Thu, Jun 10, 2010 at 5:54 PM, Jim Nasby wrote:
>> So there's no way to see if a particular privilege has been granted to
>> public. ISTM 'public' should be accepted, since you can't use it as a role
>> name anyway...
> It's a bit sticky - you could make that work for
>
On Fri, Jun 11, 2010 at 11:20 AM, Takahiro Itagaki
wrote:
>
> Bruce Momjian wrote:
>
>> > how about showing actual waiting time instead?
>> > " waiting for max_standby_delay (%d ms)",
>> > MaxStandbyDelay)
>>
>> Sounds interesting, but how often would the ps statust disp
Hi,
vacuum_defer_cleanup_age is categorized as "Statement Behavior"
parameter in the document. On the other hand, it's categorized
as "Hot Standby" one in postgresql.conf. Why do we need to do so?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
On Fri, Jun 11, 2010 at 1:48 AM, Josh Berkus wrote:
> On 06/09/2010 07:36 PM, Mark Kirkwood wrote:
>>
>> On 10/06/10 14:07, Tatsuo Ishii wrote:
>>>
>>> The one of top 3 questions I got
>>> when we propose them our HA solution is, "how long will it take to
>>> do failover when the master DB crashes
Bruce Momjian wrote:
> > how about showing actual waiting time instead?
> > " waiting for max_standby_delay (%d ms)",
> > MaxStandbyDelay)
>
> Sounds interesting, but how often would the ps statust display be
> updated? I hope not too often.
We can change the interv
Jan Wieck writes:
> Depends. Specifically on transaction profiles and how long the blocks
> linger around before being written. If you can set the all visible bit
> by the time, the page is written the first time, what bit including the
> is-frozen one cannot be set at that time too?
All-visib
Takahiro Itagaki wrote:
> Hi,
>
> We have codes to change ps display for recovery process during hot standby.
> The current code always shows max_standby_delay for the message, but how
> about showing actual waiting time instead? Since DBAs can always get the
> parameter from postgresql.conf they
On 6/4/10, Robert Haas wrote:
> On Fri, Jun 4, 2010 at 10:44 AM, Greg Stark wrote:
> > A function which takes a starting xid and a number of transactions to
> > return seems very tied to one particular application. I could easily
> > see other systems such as a multi-master system instead only
test...@workbook=# select has_table_privilege( 'public', 'test', 'SELECT' );
ERROR: role "public" does not exist
test...@workbook=#
So there's no way to see if a particular privilege has been granted to public.
ISTM 'public' should be accepted, since you can't use it as a role name
anyway...
On Thu, Jun 10, 2010 at 5:54 PM, Jim Nasby wrote:
> test...@workbook=# select has_table_privilege( 'public', 'test', 'SELECT' );
> ERROR: role "public" does not exist
> test...@workbook=#
>
> So there's no way to see if a particular privilege has been granted to
> public. ISTM 'public' should be
Tom Lane wrote:
Heikki Linnakangas writes:
In a steady-state situation new WAL files are not created very often
because we recycle old ones, so it probably doesn't make much difference.
Yeah. We really don't worry too much about the performance of the
new-WAL-file-creation code path
Excerpts from Andrew Dunstan's message of jue jun 10 11:26:59 -0400 2010:
> Why are you cloning over http? Here is the best way to clone, which
> seems to be working:
>
> [and...@sophia ]$ git clone --mirror
> git://git.postgresql.org/git/postgresql.git
> Initialized empty Git reposi
On Thu, 2010-06-10 at 22:49 +0300, Heikki Linnakangas wrote:
> On 10/06/10 22:24, Dimitri Fontaine wrote:
> > Heikki Linnakangas writes:
> >> Maybe we could add a new pg_cleanuparchive binary, but we'll need some
> >> discussion...
> >
> > Would this binary ever be used manually, not invoked by Po
Heikki Linnakangas writes:
> Maybe we could add a new pg_cleanuparchive binary, but we'll need some
> discussion...
Would this binary ever be used manually, not invoked by PostgreSQL? As
it depends on the %r option to be given and to be right, I don't think
so.
Therefore my take on this problem
On Thu, Jun 3, 2010 at 11:41 AM, Greg Stark wrote:
> I think to make it work you need to store a whole 64-bit reference
> transaction id consisting of both a cycle counter and a transaction
> id. The invariant for the page is that every xid on the page can be
> compared to that reference transacti
On 10/06/10 22:24, Dimitri Fontaine wrote:
Heikki Linnakangas writes:
Maybe we could add a new pg_cleanuparchive binary, but we'll need some
discussion...
Would this binary ever be used manually, not invoked by PostgreSQL? As
it depends on the %r option to be given and to be right, I don't th
Seems I underestimated the importance of forensic breadcrumbs.
On 6/9/2010 12:09 PM, Tom Lane wrote:
I do like the idea of using a status bit rather than FrozenXid to mark a
frozen tuple, because that eliminates the conflict between wanting to
freeze aggressively for performance reasons and wan
On Thu, Jun 10, 2010 at 18:20, Stephen Frost wrote:
> * Andrew Dunstan (and...@dunslane.net) wrote:
>> I don't see why not. Buildfarm members are going to have to reset their
>> repos when we finally cut over in a few months. Luckily, this is a
>> fairly painless operation - blow away the repo and
On Thu, Jun 10, 2010 at 12:49 PM, Greg Stark wrote:
> On Thu, Jun 10, 2010 at 5:13 PM, Robert Haas wrote:
>> At this point you should have a working HS/SR setup. Now:
>>
>> 8. shut the slave down
>> 9. move recovery.conf out of the way
>> 10. restart the slave - it will do recovery and enter nor
On Thu, Jun 10, 2010 at 5:13 PM, Robert Haas wrote:
> At this point you should have a working HS/SR setup. Now:
>
> 8. shut the slave down
> 9. move recovery.conf out of the way
> 10. restart the slave - it will do recovery and enter normal running
> 11. make some database changes
> 12. stop the
On 06/09/2010 07:36 PM, Mark Kirkwood wrote:
On 10/06/10 14:07, Tatsuo Ishii wrote:
The one of top 3 questions I got
when we propose them our HA solution is, "how long will it take to
do failover when the master DB crashes?"
Same here +1
In that case, wouldn't they set max_standby_delay to
It's this patch:
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e7eb1113f8a95e9927fdbe9cc6fb0ac101612be2#patch7
It should probably be mentioned in the incompatibilities section of the
9.0 release notes.
Addition will be included in my release notes patch, coming today.
--
* Andrew Dunstan (and...@dunslane.net) wrote:
> I don't see why not. Buildfarm members are going to have to reset their
> repos when we finally cut over in a few months. Luckily, this is a
> fairly painless operation - blow away the repo and change the config
> file and the script will resync
Stephen Frost wrote:
* Andrew Dunstan (and...@dunslane.net) wrote:
Luxenberg, Scott I. wrote:
I have been trying to create/run a build farm as part of a project I am
working on.
That seems an odd thing to do since we have one ...
To clarify, he's setting up a build farm
On Thu, Jun 10, 2010 at 12:01 PM, Heikki Linnakangas
wrote:
> We're talking about a corrupt record (incorrect CRC, incorrect backlink
> etc.), not errors within redo functions. During crash recovery, a corrupt
> record means you've reached end of WAL. In standby mode, when streaming WAL
> from mas
On 10/06/10 17:38, Tom Lane wrote:
Robert Haas writes:
On Mon, Jun 7, 2010 at 9:21 AM, Fujii Masao wrote:
When an error is found in the WAL streamed from the master, a warning
message is repeated without interval forever in the standby. This
consumes CPU load very much, and would interfere wi
On Wed, Jun 9, 2010 at 8:01 PM, Alvaro Herrera
wrote:
> Thanks for clearing the list. There are only 5 remaining items, which
> is kinda exciting, though Tom's assertion that HS is still bug-ridden is
> a bit off-putting.
It's a big piece of subtle code and it's quite possible it contains
bugs.
Heikki Linnakangas writes:
> In a steady-state situation new WAL files are not created very often
> because we recycle old ones, so it probably doesn't make much difference.
Yeah. We really don't worry too much about the performance of the
new-WAL-file-creation code path because of this.
On 10/06/10 18:17, Mark Wong wrote:
On Jun 9, 2010, at 11:25 PM, Heikki Linnakangas
wrote:
I don't think POSIX_FADV_DONTNEED does what you think it does. It
tells the kernel that "you don't need to keep these pages in the cache
anymore, I won't be accessing them anymore". If you call it when yo
Heikki Linnakangas wrote:
On 10/06/10 17:38, Andrew Dunstan wrote:
I think my logic needs a tiny piece of adjustment, to ignore the
timeline segment of the file name.
I'm not sure you should ignore it. Presumably anything in an older
timeline is indeed not required anymore and can be remove
Luxenberg, Scott I. wrote:
Greetings all,
I have been trying to create/run a build farm as part of a project I am
working on.
That seems an odd thing to do since we have one ...
However, I have noticed the primary git repostitory,
git.postgresql.org/git, does not seem to be working. Namel
On 10/06/10 17:38, Andrew Dunstan wrote:
I think my logic needs a tiny piece of adjustment, to ignore the
timeline segment of the file name.
I'm not sure you should ignore it. Presumably anything in an older
timeline is indeed not required anymore and can be removed, and anything
in a newer t
On Jun 9, 2010, at 11:25 PM, Heikki Linnakangas > wrote:
On 10/06/10 06:47, Mark Wong wrote:
I wanted to propose a fix for to xlog.c regarding the use of
posix_fadvise() for 9.1 (unless someone feels it's ok for 9.0).
Currently posix_fadvise() is used right before a log file is closed
so
Greetings all,
I have been trying to create/run a build farm as part of a project I am
working on. However, I have noticed the primary git repostitory,
git.postgresql.org/git, does not seem to be working. Namely, whenever I
try to clone the directory, I receive this error:
Error: Unable to find 5
Robert Haas wrote:
It won't kill us to change that sentence. "pg_standby is only used now
within the cleanup command" etc
pg_standby already contains the exact logic we need here. Having two
sets of code for the same thing isn't how we do things.
Well, we could factor out that part of t
Robert Haas writes:
> On Mon, Jun 7, 2010 at 9:21 AM, Fujii Masao wrote:
>> When an error is found in the WAL streamed from the master, a warning
>> message is repeated without interval forever in the standby. This
>> consumes CPU load very much, and would interfere with read-only queries.
>> To
On Thu, Jun 10, 2010 at 3:28 AM, Simon Riggs wrote:
> On Thu, 2010-06-10 at 10:18 +0300, Heikki Linnakangas wrote:
>> On 09/06/10 10:21, Simon Riggs wrote:
>> > On Tue, 2010-06-08 at 18:30 -0400, Andrew Dunstan wrote:
>> >
>> >> I prefer archive_cleanup_command. We should name things after their
>
Heikki Linnakangas writes:
> Even then, we wouldn't need to start from the beginning of the WAL
> segment AFAICS. The point is to start from the Redo pointer, not from
> the checkpoint record, because as soon as we read the checkpoint record
> we'll need to start applying WAL from the Redo poin
On Mon, Jun 7, 2010 at 9:21 AM, Fujii Masao wrote:
> When an error is found in the WAL streamed from the master, a warning
> message is repeated without interval forever in the standby. This
> consumes CPU load very much, and would interfere with read-only queries.
> To fix this problem, we should
Peter Eisentraut writes:
> Quick testing shows that clang doesn't get through the configure stage
> on this Debian system -- it looks like some amount of better integration
> with glibc might be needed. Building with llvm-gcc works fine, but I
> understand that using llvm-gcc with native code gen
(moving to -hackers)
On Wed, Jun 9, 2010 at 4:11 PM, Tom Lane wrote:
> Robert Haas writes:
>> In going back through emails I had marked as possibly needing another
>> look before 9.0 is released, I came across this issue again. As I
>> understand it, analyze (or analyse) now collects statistics
On Wed, Jun 9, 2010 at 10:26 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Wed, Jun 9, 2010 at 5:02 PM, Robert Haas wrote:
>>> I believe that the comment code is probably right, because I think
>>> IConst can only handle values < 2^31, whereas OIDs can be as large as
>>> 2^32-1.
>
>> I investi
On Thu, Jun 10, 2010 at 7:19 PM, Heikki Linnakangas
wrote:
>> --- 1902,1908
>> for standby purposes, and the number of old WAL segments
>> available
>> for standbys is determined based only on the location of the
>> previous
>> checkpoint and status of WAL archiving
On Thu, Jun 10, 2010 at 9:58 AM, Takahiro Itagaki
wrote:
>
> Fujii Masao wrote:
>
>> > 1. Reset max_standby_delay = 0 in postgresql.conf
>> > 2. pg_ctl reload
>> > 3. Create a trigger file
>>
>> As far as I read the HS code, SIGHUP is not checked while a recovery
>> is waiting for queries :( So
On Thu, Jun 10, 2010 at 5:06 AM, Tom Lane wrote:
> Josh Berkus writes:
>> The fact that failover current does *not* terminate existing queries and
>> transactions was regarded as a feature by the audience, rather than a
>> bug, when I did demos of HS/SR. Of course, they might not have been
>> th
On 10/06/10 09:14, Fujii Masao wrote:
On Thu, Jun 10, 2010 at 12:09 AM, Heikki Linnakangas
wrote:
BTW, should there be doc changes for this? I didn't find anything explaining
how restartpoints are triggered, we should add a paragraph somewhere.
+1
What about the attached patch?
> (descrip
On 10/06/10 11:37, Fujii Masao wrote:
On Thu, Jun 10, 2010 at 5:04 PM, Heikki Linnakangas
wrote:
I believe that starting from the beginning of the WAL segment is just
paranoia, to avoid creating a WAL file that's missing some data from the
beginning. Right?
Only when the recovery starting re
On tis, 2010-06-08 at 12:12 +0200, P. Caillaud wrote:
> I'd like to experiment on compiling postgres with LLVM (either llvm-gcc or
> clang) on Linux, is it supported ? Where should I start ?
The way to choose a compiler is
./configure CC=your-cc ...other...options...
We support a fair amount o
On ons, 2010-06-09 at 09:59 +0200, Florian Pflug wrote:
> The most heavily platform dependent part of the code is the spinlock
> implementation. You might want to check that it actually uses the
> version optimized for your platform, not the (much slower) generic
> implementation based on semaphore
On Thu, Jun 10, 2010 at 5:04 PM, Heikki Linnakangas
wrote:
>>> Should we:
>>> 1. Just document that,
>>> 2. Change pg_last_xlog_location() to not move backwards in that case, or
>>> 3. Change the behavior so that we start streaming at the exact byte
>>> location
>>> where we left off?
>>
>> I'm fo
On 10/06/10 10:43, Fujii Masao wrote:
On Thu, Jun 10, 2010 at 4:07 PM, Heikki Linnakangas
wrote:
BTW, the docs claim about pg_last_xlog_location() that "While streaming
replication is in progress this will increase monotonically." That's a bit
misleading: when the replication connection is bro
On 10/06/10 10:25, Fujii Masao wrote:
Currently the variable TriggerFile is declared as extern, but
it's not used in other source file than xlog.c. How about
declaring it as static? Here is the patch.
Thanks, applied.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
--
Sen
On Thu, Jun 10, 2010 at 4:07 PM, Heikki Linnakangas
wrote:
> Ah, I just committed a patch to do the same, before seeing your email.
> Thanks anyway.
Yeah, thanks a lot!
> BTW, the docs claim about pg_last_xlog_location() that "While streaming
> replication is in progress this will increase monot
On Thu, 2010-06-10 at 10:18 +0300, Heikki Linnakangas wrote:
> On 09/06/10 10:21, Simon Riggs wrote:
> > On Tue, 2010-06-08 at 18:30 -0400, Andrew Dunstan wrote:
> >
> >> I prefer archive_cleanup_command. We should name things after their
> >> principal function, not an implementation detail, IMNSH
Hi,
Currently the variable TriggerFile is declared as extern, but
it's not used in other source file than xlog.c. How about
declaring it as static? Here is the patch.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
definition_triggerfile_v1.p
On 09/06/10 10:21, Simon Riggs wrote:
On Tue, 2010-06-08 at 18:30 -0400, Andrew Dunstan wrote:
I prefer archive_cleanup_command. We should name things after their
principal function, not an implementation detail, IMNSHO.
More importantly, we should include an example in the docs. I created
one
On 10/06/10 09:42, Fujii Masao wrote:
On Thu, Jun 10, 2010 at 11:56 AM, Tom Lane wrote:
Robert Haas writes:
On Wed, Jun 9, 2010 at 9:46 PM, Takahiro Itagaki
wrote:
I found a term "InvalidXLogRecPtr" in 9.0 docs.
http://developer.postgresql.org/pgdocs/postgres/functions-admin.html#FUNCTIONS
On 10/06/10 05:56, Tom Lane wrote:
Robert Haas writes:
On Wed, Jun 9, 2010 at 9:46 PM, Takahiro Itagaki
wrote:
I found a term "InvalidXLogRecPtr" in 9.0 docs.
http://developer.postgresql.org/pgdocs/postgres/functions-admin.html#FUNCTIONS-RECOVERY-INFO-TABLE
| ... then the return value will b
64 matches
Mail list logo