Re: [HACKERS] psql: edit function, show function commands patch

2010-03-31 Thread Pavel Stehule
2010/4/1 Bruce Momjian : > > I have added this to the next commit-fest. > thank you Pavel > --- > > Pavel Stehule wrote: >> Hello >> >> this simple patch allow to specify cursor row when some function is >> opened in editor. >

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 10:34 PM, Robert Haas wrote: > On Wed, Mar 31, 2010 at 3:29 PM, Dave Page wrote: >> On Wed, Mar 31, 2010 at 7:52 PM, Robert Haas wrote: >>> I can snap a tarball tonight if you want.  I'm going to be leaving >>> town tomorrow afternoon, though. >> >> Works for me. I'll stu

Re: [HACKERS] Proposal: Add JSON support

2010-03-31 Thread Joseph Adams
I ended up reinventing the wheel and writing another JSON library: http://constellationmedia.com/~funsite/static/json-0.0.1.tar.bz2 This is a first release, and it doesn't really have a name besides "json". It's very similar to cJSON, except it is (sans unknown bugs) more reliable, more correct,

Re: [HACKERS] Alias to rollback keyword

2010-03-31 Thread Bruce Momjian
Robert Haas wrote: > On Wed, Mar 31, 2010 at 10:34 PM, Bruce Momjian wrote: > > Matthew Altus wrote: > >> Hey, > >> > >> After dealing with a production fault and having to rollback all the time, > >> I > >> kept typing a different word instead of rollback. ?So I created a patch to > >> accept th

Re: [HACKERS] Alias to rollback keyword

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 10:34 PM, Bruce Momjian wrote: > Matthew Altus wrote: >> Hey, >> >> After dealing with a production fault and having to rollback all the time, I >> kept typing a different word instead of rollback.  So I created a patch to >> accept this word as an alias for rollback.  Obvi

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 3:29 PM, Dave Page wrote: > On Wed, Mar 31, 2010 at 7:52 PM, Robert Haas wrote: >> I can snap a tarball tonight if you want.  I'm going to be leaving >> town tomorrow afternoon, though. > > Works for me. I'll stuff it into our shiny new 9.0 build machine tomorrow. Marc is

Re: [HACKERS] Alias to rollback keyword

2010-03-31 Thread Bruce Momjian
Matthew Altus wrote: > Hey, > > After dealing with a production fault and having to rollback all the time, I > kept typing a different word instead of rollback. So I created a patch to > accept this word as an alias for rollback. Obviously it's not part of the > sql > standard, but could be

Re: [HACKERS] Alias to rollback keyword

2010-03-31 Thread David E. Wheeler
On Mar 31, 2010, at 5:42 PM, Matthew Altus wrote: > After dealing with a production fault and having to rollback all the time, I > kept typing a different word instead of rollback. So I created a patch to > accept this word as an alias for rollback. Obviously it's not part of the > sql > sta

[HACKERS] Alias to rollback keyword

2010-03-31 Thread Matthew Altus
Hey, After dealing with a production fault and having to rollback all the time, I kept typing a different word instead of rollback. So I created a patch to accept this word as an alias for rollback. Obviously it's not part of the sql standard, but could be a nice extension for postgresql. Se

Re: [HACKERS] [DOCS] Streaming replication document improvements

2010-03-31 Thread Fujii Masao
On Thu, Apr 1, 2010 at 11:00 AM, Robert Haas wrote: > On Wed, Mar 31, 2010 at 9:58 PM, Fujii Masao wrote: >> On Thu, Apr 1, 2010 at 10:52 AM, Robert Haas wrote: >>> On Wed, Mar 31, 2010 at 9:50 PM, Fujii Masao wrote: > That's an interesting point, do streaming replication connections >

Re: [HACKERS] [DOCS] Streaming replication document improvements

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 9:58 PM, Fujii Masao wrote: > On Thu, Apr 1, 2010 at 10:52 AM, Robert Haas wrote: >> On Wed, Mar 31, 2010 at 9:50 PM, Fujii Masao wrote: That's an interesting point, do streaming replication connections consume superuser_reserved_connections slots? >>> >>> Yes.

Re: [HACKERS] [DOCS] Streaming replication document improvements

2010-03-31 Thread Fujii Masao
On Thu, Apr 1, 2010 at 10:52 AM, Robert Haas wrote: > On Wed, Mar 31, 2010 at 9:50 PM, Fujii Masao wrote: >>> That's an interesting point, do streaming replication connections >>> consume superuser_reserved_connections slots? >> >> Yes. Since SR connection is superuser connection, setting >> supe

Re: [HACKERS] [DOCS] Streaming replication document improvements

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 9:50 PM, Fujii Masao wrote: >> That's an interesting point, do streaming replication connections >> consume superuser_reserved_connections slots? > > Yes. Since SR connection is superuser connection, setting > superuser_reserved_connections appropriately would be useful > t

Re: [HACKERS] [DOCS] Streaming replication document improvements

2010-03-31 Thread Fujii Masao
On Thu, Apr 1, 2010 at 5:39 AM, Heikki Linnakangas wrote: > Fujii Masao wrote: >> *** >> *** 829,834 if (!triggered) >> --- 826,834 >>         >>          Set the maximum number of concurrent connections from the standby >> servers >>          (see for details). >> +      

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Bruce Momjian
Robert Haas wrote: > After snapshotting my master using hot backup to create a workable > slave instance, I created recovery.conf on the slave and tried to get > it to connect to the master and stream WAL. > > This led to the message "sorry, too many standbys already", which did > not immediately

Re: [HACKERS] pgindent excluded files list

2010-03-31 Thread Bruce Momjian
Andrew Dunstan wrote: > > I propose that we create a file containing the list of patterns to > exclude from pgindent runs. It would look like this: > > #list of file patterns to exclude from pg_indent runs > /s_lock\.h$ > /ecpg/test/expected/ > /snowball/libstemmer/ > /ecpg/i

Re: [HACKERS] Parameter name standby_mode

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 9:01 PM, Fujii Masao wrote: > Agreed. But what log message is repeated depends on the situation. > So message without any location might be output. BTW, In my testing, > the following message was repeated. > >    LOG:  invalid magic number in log file 0, segment 14, of

Re: [SPAM]Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Bruce Momjian
Takahiro Itagaki wrote: > > "Robert Haas" wrote: > > > > * (seq_page_cost/(random_page_cost)) > > > * EXCLUDE constraints has no tags to be linked. > > > * "EXCLUDE constraints" is not indexed from the Index page. > > > CREATE TABLE ... CONSTRAINT ... EXCLUDE rather than CREATE TABLE > > CONSTR

Re: [SPAM]Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Bruce Momjian
Takahiro Itagaki wrote: > > "Robert Haas" wrote: > > > > * (seq_page_cost/(random_page_cost)) > > > * EXCLUDE constraints has no tags to be linked. > > > * "EXCLUDE constraints" is not indexed from the Index page. > > > CREATE TABLE ... CONSTRAINT ... EXCLUDE rather than CREATE TABLE > > CONSTR

Re: [HACKERS] Parameter name standby_mode

2010-03-31 Thread Fujii Masao
On Thu, Apr 1, 2010 at 6:04 AM, Robert Haas wrote: >> I wouldn't recommend setting up a standby server like that, but it's not >> totally unreasonable. So the standby always has a potential source of >> WAL, pg_xlog. > > OK. OK, too. I turn down the patch. > Is it reasonable to think that we can

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 11:24 AM, Thom Brown wrote: > [patch] As a general rule, I really appreciate people being willing to take the time to put proposed changes into patch form, even if they're small, but this three-line patch contains two bugs. :-( Thanks for your many typo corrections, thou

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Bruce Momjian
Alvaro Herrera wrote: > > Also, where are we on using full names rather than first names only? I > don't see the point in omitting the last names. Are we trying to > obscure to outsiders who is really working on our code? You are the third person to ask for this and I was holding up that change

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 8:23 PM, Bruce Momjian wrote: > Robert Haas wrote: >> On Wed, Mar 31, 2010 at 8:19 PM, Bruce Momjian wrote: >> >> * "EXCLUDE constraints" is not indexed from the Index page. >> >> Should we have for it? Unique Constraints have a section for them: >> >> http://developer.pos

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Bruce Momjian
Robert Haas wrote: > On Wed, Mar 31, 2010 at 8:19 PM, Bruce Momjian wrote: > >> * "EXCLUDE constraints" is not indexed from the Index page. > >> Should we have for it? Unique Constraints have a section for them: > >> http://developer.postgresql.org/pgdocs/postgres/ddl-constraints.html#AEN2431 > >

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 8:21 PM, Bruce Momjian wrote: > Kevin Grittner wrote: >> Robert Haas wrote: >> >> > I thought it was referring to all pairs of rows, but I see >> > now it's referring to pairs of columns, so it's correct. >> >> If it confused you, I suspect it will confuse others.  Offhand

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Bruce Momjian
Kevin Grittner wrote: > Robert Haas wrote: > > > I thought it was referring to all pairs of rows, but I see > > now it's referring to pairs of columns, so it's correct. > > If it confused you, I suspect it will confuse others. Offhand, > I can't see how to improve the language, though. I hav

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 8:19 PM, Bruce Momjian wrote: >> * "EXCLUDE constraints" is not indexed from the Index page. >> Should we have for it? Unique Constraints have a section for them: >> http://developer.postgresql.org/pgdocs/postgres/ddl-constraints.html#AEN2431 > > I am unclear if exclude rea

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Bruce Momjian
Takahiro Itagaki wrote: > Hi, I have some questions about 9.0 release note. > I'd like to work for some of them if required. Comments welcome. > > * Allow per-tablespace sequential and random page cost variables > (seq_page_cost/(random_page_cost)) via ALTER TABLESPACE ... SET/RESET That is a b

Re: [HACKERS] psql: edit function, show function commands patch

2010-03-31 Thread Bruce Momjian
I have added this to the next commit-fest. --- Pavel Stehule wrote: > Hello > > this simple patch allow to specify cursor row when some function is > opened in editor. > > \e aaa.txt > \a aaa.txt 3 ... move cursor on 3nd l

Re: [HACKERS] Parameter name standby_mode

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 5:23 PM, Heikki Linnakangas wrote: > Robert Haas wrote: >> Is it reasonable to think that we can find a way to make it not print >> the duplicate messages over and over again? >> >> LOG:  record with zero length at 0/3006B28 >> >> Maybe only print that if the location has a

Re: [HACKERS] Parameter name standby_mode

2010-03-31 Thread Heikki Linnakangas
Robert Haas wrote: > Is it reasonable to think that we can find a way to make it not print > the duplicate messages over and over again? > > LOG: record with zero length at 0/3006B28 > > Maybe only print that if the location has advanced since the last such > message? Yeah, seems reasonable.

Re: [HACKERS] Parameter name standby_mode

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 4:54 PM, Heikki Linnakangas wrote: > Robert Haas wrote: >> Agreed.  I think if the server starts up in standby mode and it is an >> inconsistent state with no source of WAL, then the startup process >> should exit with a suitable error message, which AIUI will result in >>

Re: [HACKERS] Parameter name standby_mode

2010-03-31 Thread Heikki Linnakangas
Robert Haas wrote: > Agreed. I think if the server starts up in standby mode and it is an > inconsistent state with no source of WAL, then the startup process > should exit with a suitable error message, which AIUI will result in > the whole server shutting down. However if there is no source of

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 4:39 PM, Josh Berkus wrote: >> I can snap a tarball tonight if you want.  I'm going to be leaving >> town tomorrow afternoon, though. > > Please do. If someone could email me off list where they would like the tarball put, with login credentials, I will put it there. Othe

Re: [HACKERS] [DOCS] Streaming replication document improvements

2010-03-31 Thread Heikki Linnakangas
Fujii Masao wrote: > *** > *** 829,834 if (!triggered) > --- 826,834 > > Set the maximum number of concurrent connections from the standby > servers > (see for details). > +Since those connections are for superusers, > + should be >

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Josh Berkus
Robert, > I can snap a tarball tonight if you want. I'm going to be leaving > town tomorrow afternoon, though. Please do. -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.c

Re: [HACKERS] Patch for 9.1: initdb -C option

2010-03-31 Thread Bruce Momjian
I have added this to the 9.1 commit-fest: https://commitfest.postgresql.org/action/commitfest_view?id=6 --- David Christensen wrote: > Hackers, > > Enclosed is a patch to add a -C option to initdb to allow you to e

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Dave Page
On Wed, Mar 31, 2010 at 7:52 PM, Robert Haas wrote: > I can snap a tarball tonight if you want.  I'm going to be leaving > town tomorrow afternoon, though. Works for me. I'll stuff it into our shiny new 9.0 build machine tomorrow. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com --

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Devrim GÜNDÜZ
On Wed, 2010-03-31 at 10:46 -0700, Josh Berkus wrote: > > Not with any amount of testing as we'd normally give any build > before > > releasing it anyway. I can certainly stuff a tarball into the new > > build machine and see what comes out the next morning. > > That would be good enough for Satur

[HACKERS] CHAR(10) - Clustering, High Availability and Replication conference

2010-03-31 Thread Simon Riggs
http://www.char10.org/ announced today... PostgreSQL CHAR(10) Conference is in Oxford, UK on 1-3 July 2010, at Oriel College, Oxford University. CHAR(10) stands for Clustering, High Availability, Replication, though includes all forms of Parallel, Distributed and Grid architectures. The Call f

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 2:33 PM, Dave Page wrote: > On Wed, Mar 31, 2010 at 6:46 PM, Josh Berkus wrote: >> Dave, >> >>> Not with any amount of testing as we'd normally give any build before >>> releasing it anyway. I can certainly stuff a tarball into the new >>> build machine and see what comes

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Dave Page
On Wed, Mar 31, 2010 at 6:46 PM, Josh Berkus wrote: > Dave, > >> Not with any amount of testing as we'd normally give any build before >> releasing it anyway. I can certainly stuff a tarball into the new >> build machine and see what comes out the next morning. > > That would be good enough for Sa

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Aidan Van Dyk
* Kevin Grittner [100331 13:18]: > If it confused you, I suspect it will confuse others. Offhand, > I can't see how to improve the language, though. How about a simple: s/these/the colomn or expression/ Leaving: ... not all of the column or expression comparisons ... "These" isn't

Re: [HACKERS] TODO list updates

2010-03-31 Thread Hitoshi Harada
2010/3/27 Tom Lane : > Robert Haas writes: >> In reading through the TODO list, I noticed a few things that I think >> are done, may be done, or may be partially done.  See below. >> Thoughts?  ...Robert > >> Implement full support for window framing clauses. >> - Not sure if we made any progress

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Josh Berkus
Dave, > Not with any amount of testing as we'd normally give any build before > releasing it anyway. I can certainly stuff a tarball into the new > build machine and see what comes out the next morning. That would be good enough for Saturday; we're going to test it after all. Let me know which s

Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Kevin Grittner
Robert Haas wrote: > I thought it was referring to all pairs of rows, but I see > now it's referring to pairs of columns, so it's correct. If it confused you, I suspect it will confuse others. Offhand, I can't see how to improve the language, though. -Kevin -- Sent via pgsql-hackers maili

Re: [SPAM]Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 1:07 PM, Kevin Grittner wrote: > Robert Haas wrote: > >> This says: >> >> Exclusion constraints ensure that that if any two rows are >> compared on the specified column(s) or expression(s) using the >> specified operator(s), not all of these comparisons will return >> TRUE

Re: [SPAM]Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Kevin Grittner
Robert Haas wrote: > This says: > > Exclusion constraints ensure that that if any two rows are > compared on the specified column(s) or expression(s) using the > specified operator(s), not all of these comparisons will return > TRUE. > > I think that's backwards - the last clause should say "n

Re: [SPAM]Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 2:56 AM, Takahiro Itagaki wrote: > > "Robert Haas" wrote: > >> > * (seq_page_cost/(random_page_cost)) >> > * EXCLUDE constraints has no tags to be linked. >> > * "EXCLUDE constraints" is not indexed from the Index page. > >> CREATE TABLE ... CONSTRAINT ... EXCLUDE rather t

Re: [HACKERS] Performance Enhancement/Fix for Array Utility Functions

2010-03-31 Thread Mike Lewis
On Wed, Mar 31, 2010 at 8:28 AM, Robert Haas wrote: > > Neat.  Please add it here: > > https://commitfest.postgresql.org/action/commitfest_view/open > > ...Robert > Thanks. Added it. https://commitfest.postgresql.org/action/patch_view?id=292 -Mike -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Proposal: Add JSON support

2010-03-31 Thread Chris Browne
robertmh...@gmail.com (Robert Haas) writes: > On Tue, Mar 30, 2010 at 8:58 PM, Josh Berkus wrote: >>> I'd think that you could get quite a long ways on this, at least doing >>> something like dbslayer without *necessarily* needing to do terribly >>> much work inside the DB engine. >> >> There's ac

Re: [HACKERS] TODO list updates

2010-03-31 Thread Bruce Momjian
Robert Haas wrote: > In reading through the TODO list, I noticed a few things that I think > are done, may be done, or may be partially done. See below. > Thoughts? ...Robert > > Add missing operators for geometric data types > - this is at least partly done. not sure if it is entirely done. >

Re: [HACKERS] TODO list updates

2010-03-31 Thread Bruce Momjian
Tom Lane wrote: > Robert Haas writes: > > In reading through the TODO list, I noticed a few things that I think > > are done, may be done, or may be partially done. See below. > > Thoughts? ...Robert > > > Add missing operators for geometric data types > > - this is at least partly done. not s

Re: [HACKERS] Performance Enhancement/Fix for Array Utility Functions

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 5:08 AM, Mike Lewis wrote: > Woops. I sent the wrong patch. My apologies.  Attached is the real > patch.  Sorry, also forgot this is made against 9.0 alpha 4 tag. Neat. Please add it here: https://commitfest.postgresql.org/action/commitfest_view/open ...Robert -- Sent

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Thom Brown
On 31 March 2010 15:45, Robert Haas wrote: > On Wed, Mar 31, 2010 at 10:44 AM, Tom Lane wrote: > > Robert Haas writes: > >> On Wed, Mar 31, 2010 at 12:54 AM, Fujii Masao > wrote: > >>>could not accept connection from the standby because max_wal_senders > is 0 > > > >> Well, that might stil

Re: pending patch: Re: [HACKERS] HS/SR and smart shutdown

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 5:02 AM, Simon Riggs wrote: >> > >From what I have seen, the comment about PM_WAIT_BACKENDS is incorrect. >> > "backends might be waiting for the WAL record that conflicts with their >> > queries to be replayed". Recovery sometimes waits for backends, but >> > backends neve

Re: [HACKERS] pgindent excluded files list

2010-03-31 Thread David Fetter
On Wed, Mar 31, 2010 at 10:27:03AM -0400, Andrew Dunstan wrote: > > I propose that we create a file containing the list of patterns to > exclude from pgindent runs. It would look like this: > >#list of file patterns to exclude from pg_indent runs >/s_lock\.h$ >/ecpg/test/expected/ >

[HACKERS] mremap and bus error

2010-03-31 Thread Pavel Stehule
Hi, I playing with mmap. I have a problem with mremap function. It doesn't allocate correct memory. All others work well. static void * mmap_realloc(void *ptr, Size size) { Size oldsize; void *result; int i; char *x; ptr = (char *) ptr - MAXALIGN(siz

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 10:44 AM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Mar 31, 2010 at 12:54 AM, Fujii Masao wrote: >>>    could not accept connection from the standby because max_wal_senders is 0 > >> Well, that might still leave someone confused if they had one standby >> and were

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Tom Lane
Robert Haas writes: > On Wed, Mar 31, 2010 at 12:54 AM, Fujii Masao wrote: >>    could not accept connection from the standby because max_wal_senders is 0 > Well, that might still leave someone confused if they had one standby > and were trying to bring up a second one. I'd suggest something li

[HACKERS] pgindent excluded files list

2010-03-31 Thread Andrew Dunstan
I propose that we create a file containing the list of patterns to exclude from pgindent runs. It would look like this: #list of file patterns to exclude from pg_indent runs /s_lock\.h$ /ecpg/test/expected/ /snowball/libstemmer/ /ecpg/include/(sqlda|sqltypes)\.h$ /ecpg/includ

Re: [HACKERS] booleans in recovery.conf

2010-03-31 Thread Bruce Momjian
Simon Riggs wrote: > On Tue, 2010-03-23 at 19:43 -0400, Bruce Momjian wrote: > > Is there a reason that recovery.conf uses true/false, while > > postgresql.conf uses on/off? > > > > #recovery_target_inclusive = 'true' # 'true' or 'false' > > > > or are these settings more boolean

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 12:54 AM, Fujii Masao wrote: > On Wed, Mar 31, 2010 at 12:06 PM, Robert Haas wrote: >> After snapshotting my master using hot backup to create a workable >> slave instance, I created recovery.conf on the slave and tried to get >> it to connect to the master and stream WAL.

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Alvaro Herrera
Robert Haas escribió: > On Wed, Mar 31, 2010 at 8:19 AM, Magnus Hagander wrote: > > How about using errhint to tell the user which parameter to use? > > I thought about that. I noticed that the error message from the > master gets displayed on the slave. I didn't check if an errhint > would als

Re: [HACKERS] Parameter name standby_mode

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 1:47 AM, Fujii Masao wrote: > On Wed, Mar 31, 2010 at 12:21 PM, Robert Haas wrote: >> I just tested this and it seems to just sit there doing this over and >> over again: >> >> LOG:  record with zero length at 0/3006B28 >> >> I'm not sure that we should forbid this configu

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 8:19 AM, Magnus Hagander wrote: > How about using errhint to tell the user which parameter to use? I thought about that. I noticed that the error message from the master gets displayed on the slave. I didn't check if an errhint would also propagate over. ...Robert --

Re: pending patch: Re: [HACKERS] HS/SR and smart shutdown

2010-03-31 Thread Robert Haas
On Wed, Mar 31, 2010 at 4:00 AM, Simon Riggs wrote: > Please add some docs that a) explains what the patch does and b) notes > any changes from behaviour in previous releases. ISTM this is a major > change in behaviour. I guess I see this a little bit differently. If you do a smart shutdown on 8

Re: [HACKERS] sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

2010-03-31 Thread Magnus Hagander
2010/3/31 Fujii Masao : > On Wed, Mar 31, 2010 at 12:06 PM, Robert Haas wrote: >> After snapshotting my master using hot backup to create a workable >> slave instance, I created recovery.conf on the slave and tried to get >> it to connect to the master and stream WAL. >> >> This led to the message

Re: [HACKERS] Problems with variable cursorname in ecpg

2010-03-31 Thread Boszormenyi Zoltan
Michael Meskes írta: > On Wed, Mar 31, 2010 at 10:35:31AM +0200, Boszormenyi Zoltan wrote: > >>> I think we should make the error message/documentation a little bit >>> clearer as >>> people have stumbled over it. >>> >> Yes, we need to document it. >> > > I changed the error messa

Re: [HACKERS] Problems with variable cursorname in ecpg

2010-03-31 Thread Boszormenyi Zoltan
Boszormenyi Zoltan írta: > Boszormenyi Zoltan írta: > >> I think you forget that in this case, only global variables are >> usable in the DECLARE in this case, no local variables in >> functions preceding the DECLARE are visible to it. >> >> What we need here is an extra check in ECPGdump_a_type

Re: [HACKERS] Problems with variable cursorname in ecpg

2010-03-31 Thread Boszormenyi Zoltan
Boszormenyi Zoltan írta: > I think you forget that in this case, only global variables are > usable in the DECLARE in this case, no local variables in > functions preceding the DECLARE are visible to it. > > What we need here is an extra check in ECPGdump_a_type(). > We need to raise an error if >

Re: [HACKERS] ECPG pointer vs array

2010-03-31 Thread Michael Meskes
On Wed, Mar 31, 2010 at 10:37:13AM +0200, Boszormenyi Zoltan wrote: > It would be good if libecpg to support e.g. "char **strings" instead of > "char *strings[]" for preallocated strings and the array of those. > ... I'm open to improvements. The way ecpg accesses variables hasn't been changed for

Re: [HACKERS] Problems with variable cursorname in ecpg

2010-03-31 Thread Michael Meskes
On Wed, Mar 31, 2010 at 10:35:31AM +0200, Boszormenyi Zoltan wrote: > > I think we should make the error message/documentation a little bit > > clearer as > > people have stumbled over it. > > Yes, we need to document it. I changed the error message and documented a possible improvement in the

Re: pending patch: Re: [HACKERS] HS/SR and smart shutdown

2010-03-31 Thread Fujii Masao
On Wed, Mar 31, 2010 at 6:02 PM, Simon Riggs wrote: > On Wed, 2010-03-31 at 17:48 +0900, Fujii Masao wrote: >> On Wed, Mar 31, 2010 at 5:00 PM, Simon Riggs wrote: >> > Please add some docs that a) explains what the patch does and b) notes >> > any changes from behaviour in previous releases. ISTM

Re: [HACKERS] Performance Enhancement/Fix for Array Utility Functions

2010-03-31 Thread Mike Lewis
Woops. I sent the wrong patch. My apologies. Attached is the real patch. Sorry, also forgot this is made against 9.0 alpha 4 tag. Thanks, Mike -- Michael Lewis lolrus.org mikelikes...@gmail.com On Wed, Mar 31, 2010 at 12:39 AM, Mike Lewis wrote: > I noticed while doing work with very large

Re: pending patch: Re: [HACKERS] HS/SR and smart shutdown

2010-03-31 Thread Simon Riggs
On Wed, 2010-03-31 at 17:48 +0900, Fujii Masao wrote: > On Wed, Mar 31, 2010 at 5:00 PM, Simon Riggs wrote: > > Please add some docs that a) explains what the patch does and b) notes > > any changes from behaviour in previous releases. ISTM this is a major > > change in behaviour. > > How about a

Re: pending patch: Re: [HACKERS] HS/SR and smart shutdown

2010-03-31 Thread Fujii Masao
On Wed, Mar 31, 2010 at 5:00 PM, Simon Riggs wrote: > Please add some docs that a) explains what the patch does and b) notes > any changes from behaviour in previous releases. ISTM this is a major > change in behaviour. How about adding the following description into "17.5. Shutting Down the Serv

[HACKERS] ECPG pointer vs array

2010-03-31 Thread Boszormenyi Zoltan
Hi, It would be good if libecpg to support e.g. "char **strings" instead of "char *strings[]" for preallocated strings and the array of those. IIRC, the first version overwrote my stack in a test programme, as these two are treated the same but they are not. Also, as "numeric" is supposed to be a

Re: [HACKERS] Problems with variable cursorname in ecpg

2010-03-31 Thread Boszormenyi Zoltan
Michael Meskes írta: >> The interpretation of the standard in the above way (DECLARE is declarative, >> ... >> > > It's not just interpretation, but also a regression if we were to change this. > Obviously. >> The uniqueness problem can only be solved with modifying >> the runtime library

Re: pending patch: Re: [HACKERS] HS/SR and smart shutdown

2010-03-31 Thread Simon Riggs
On Wed, 2010-03-31 at 10:48 +0900, Fujii Masao wrote: > On Wed, Mar 31, 2010 at 9:47 AM, Robert Haas wrote: > > On Tue, Mar 30, 2010 at 5:09 AM, Fujii Masao wrote: > >> I rebased the patch to HEAD. Is the patch still required for 9.0? > >> If not, I'd remove the open item of the smart shutdown du

Re: [HACKERS] Alpha release this week?

2010-03-31 Thread Dave Page
On Tue, Mar 30, 2010 at 1:04 AM, Magnus Hagander wrote: > Last i heard from Dave on that topic is that there's no chance of that > happening that quickly. He's on a plane now but I'm sure he'll confirm that > when he lands. Not with any amount of testing as we'd normally give any build before rel

[HACKERS] Performance Enhancement/Fix for Array Utility Functions

2010-03-31 Thread Mike Lewis
I noticed while doing work with very large arrays that several functions such as array_length detoast the entire array instead of only what is required. I found the solution to be just unpacking the header portion of the array and ignoring the rest. Since the header (including the dimensions) is

Re: [SPAM]Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Thom Brown
On 31 March 2010 07:56, Takahiro Itagaki wrote: > > "Robert Haas" wrote: > >> > * (seq_page_cost/(random_page_cost)) >> > * EXCLUDE constraints has no tags to be linked. >> > * "EXCLUDE constraints" is not indexed from the Index page. > >> CREATE TABLE ... CONSTRAINT ... EXCLUDE rather than CREAT