Re: [HACKERS] _WIN32_WINNT should be 0x0501 in win32.h

2009-09-06 Thread Itagaki Takahiro
Magnus Hagander wrote: > Have you verified that binaries compiled that way still run on windows > 2000? I had checking that on my list before making this change... No, I don't have Windows 2000. BTW, there is no Windows 2000 animal in the BuildFarm. We cannot support win2k at all, no? Regards

Re: [HACKERS] _WIN32_WINNT should be 0x0501 in win32.h

2009-09-06 Thread Magnus Hagander
On Monday, September 7, 2009, Itagaki Takahiro wrote: > We should define _WIN32_WINNT as 0x0500 in src/include/port/win32.h, > but it should be 0x0501 (Windows XP) because IPPROTO_IPV6 will be > defined only if _WIN32_WINNT >= 0x0501 in the recent Micosoft SDKs. Hi! Have you verified that binari

Re: [HACKERS] LATERAL

2009-09-06 Thread David Fetter
On Sun, Sep 06, 2009 at 11:59:22PM -0400, Robert Haas wrote: > I've attempted to search the archives for references to the SQL > LATERAL feature, which AIUI is fairly-frequently requested. > [snip] > Has anyone poked at this at all? I believe Andrew (RhodiumToad) Gierth is taking a look at impleme

[HACKERS] LATERAL

2009-09-06 Thread Robert Haas
I've attempted to search the archives for references to the SQL LATERAL feature, which AIUI is fairly-frequently requested. Most of the discussion that I've found harks back to 2003, and that seems to discuss more the need for eventual support of the feature than exactly what it is or how to imple

Re: [HACKERS] Patch: update Bonjour support to the newer non-deprecated API

2009-09-06 Thread David E. Wheeler
On Sep 6, 2009, at 8:17 PM, Tom Lane wrote: In principle this might enable use of Bonjour on non-Apple OSes, but I'm not personally interested enough to test that ... Comments, objections? +1 Seems like a no-brainer. Best, David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgre

[HACKERS] Patch: update Bonjour support to the newer non-deprecated API

2009-09-06 Thread Tom Lane
I've grown a bit tired of reading the "'DNSServiceRegistrationCreate' is deprecated" warnings in OS X builds, and I'm also wondering whether any of the recently reported problems with Snow Leopard might trace to our use of an API that Apple has been deprecating since 2003. Hence, attached is a pat

[HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-06 Thread Itagaki Takahiro
Here is a patch to implement the following items in our ToDo list: * Add CREATE TABLE LIKE ... INCLUDING COMMENTS * Have CREATE TABLE LIKE copy column storage parameters The syntax is: CREATE TABLE clone_table (LIKE template_table INCLUDING COMMENTS) -- also copy comments on column

[HACKERS] Rename StrNCpy to avoid conflictions on win32

2009-09-06 Thread Itagaki Takahiro
We define StrNCpy() macro in c.h, but it conflicts another macro defined in Microsoft SDKs: C:\Program Files\Microsoft SDKs\Windows\v6.1\Include\shlwapi.h(435) : warning C4005: 'StrNCpy' : macro redefinition Can we rename StrNCpy() macro to another name? (ex. pg_strncpy) There might b

[HACKERS] _WIN32_WINNT should be 0x0501 in win32.h

2009-09-06 Thread Itagaki Takahiro
We should define _WIN32_WINNT as 0x0500 in src/include/port/win32.h, but it should be 0x0501 (Windows XP) because IPPROTO_IPV6 will be defined only if _WIN32_WINNT >= 0x0501 in the recent Micosoft SDKs. [ws2def.h] #if(_WIN32_WINNT >= 0x0501) IPPROTO_IPV6 = 41, // IPv6 header Index:

Re: [HACKERS] Triggers on columns

2009-09-06 Thread Itagaki Takahiro
Here is a updated version of column-trigger patch. Changes from the previous patch: * Add dependency of columns with recordDependencyOn(). Regression tests are also adjusted. * Recheck columns if NEW values are modified, but each trigger will be firec only one per row. Peter Eisentra

Re: [HACKERS] [PATCH] Largeobject access controls

2009-09-06 Thread KaiGai Kohei
The attached patch is an update of largeobject access controls. It adds a new guc variable to turn on/off compatible behavior in largeobejct access controls. largeobject_compat_dac = [on | off] (default: off) If the variable is turned on, all the new access control features on largeobjects are

Re: [HACKERS] match_unsorted_outer() vs. cost_nestloop()

2009-09-06 Thread Robert Haas
On Sep 6, 2009, at 10:45 AM, Tom Lane wrote: Robert Haas writes: And, by the way, is the algorithm proposed in the comment sensible anyway? Under what circumstances would it make sense to materialize a sequential scan? Expensive filter conditions, for example. Ah, right. Yeah that co

Re: [HACKERS] Time zone abbreviations fix

2009-09-06 Thread Tom Lane
Joachim Wieland writes: > this is a reply to the following post: > http://archives.postgresql.org/message-id/7867.1219793...@sss.pgh.pa.us > which is also a TODO item: > [E] Revise the src/timezone/tznames abbreviation files: > * to add missing abbreviations > * to find abbreviations tha

Re: [HACKERS] match_unsorted_outer() vs. cost_nestloop()

2009-09-06 Thread Tom Lane
Robert Haas writes: > And, by the way, is the algorithm proposed in the comment sensible > anyway? Under what circumstances would it make sense to materialize a > sequential scan? Expensive filter conditions, for example. I've occasionally wondered if this code isn't outright wrong anyway: when

Re: [HACKERS] 8.5 release timetable, again

2009-09-06 Thread Kristian Larsson
On Thu, Aug 27, 2009 at 12:03:05AM +0200, Dimitri Fontaine wrote: > Hi, > > Peter Eisentraut writes: > > On ons, 2009-08-26 at 14:26 -0400, Robert Haas wrote: > >> Sure, but an aimless mandate to do testing for 4 (or 8, or 12) months > >> doesn't necessarily buy you much, either. I'm good at foc

Re: [HACKERS] community decision-making & 8.5

2009-09-06 Thread Kristian Larsson
On Wed, Sep 02, 2009 at 07:22:27PM -0400, Robert Haas wrote: > On Wed, Sep 2, 2009 at 5:55 PM, Josh Berkus wrote: > >> That implies that we need a release manager. Electing one would be the > >> first step. That's a lot of work and responsibility, with lots of > >> potential for making people cross

[HACKERS] Time zone abbreviations fix

2009-09-06 Thread Joachim Wieland
Hi all, this is a reply to the following post: http://archives.postgresql.org/message-id/7867.1219793...@sss.pgh.pa.us which is also a TODO item: [E] Incomplete itemRevise the src/timezone/tznames abbreviation files: * to add missing abbreviations * to find abbreviations that can be sa