Re: [HACKERS] Randomly placed definition of S_ISDIR() in psql/copy.c

2009-04-25 Thread Magnus Hagander
Tom Lane wrote: > Why does psql/copy.c contain this? > > #if defined(WIN32) && !defined(S_ISDIR) > #define __S_ISTYPE(mode, mask)(((mode) & S_IFMT) == (mask)) > #define S_ISDIR(mode) __S_ISTYPE((mode), S_IFDIR) > #endif > > Surely a better place for such a thing is src/include/port/win32

Re: [HACKERS] RFE: Transparent encryption on all fields

2009-04-25 Thread tomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sat, Apr 25, 2009 at 11:43:14AM +0100, Sam Halliday wrote: > Please continue to CC me on this thread as I have disabled receiving > messages from this list, although remain subscribed. OK [...] > Remember, the threat case here is a stolen server

Re: [HACKERS] WIP: to_char, support for EEEE format

2009-04-25 Thread Pavel Stehule
Hi Brendan this looks well, so please, add it to commitfest page regards Pavel Stehule 2009/4/26 Brendan Jurd : > On Sat, Apr 11, 2009 at 3:51 AM, Pavel Stehule > wrote: >> So, please, if you can, propose these error messages (with hints)- >> result will be much better. >> > > Hi Pavel, hacker

Re: [HACKERS] HashJoin w/option to unique-ify inner rel

2009-04-25 Thread Robert Haas
On Fri, Apr 24, 2009 at 10:49 PM, Tom Lane wrote: > Robert Haas writes: >> As far as I can tell, the focus on trying to estimate the number of >> tuples per bucket is entirely misguided.  Supposing the relation is >> mostly unique so that the values don't cluster too much, the right >> answer is

Re: [HACKERS] HashJoin w/option to unique-ify inner rel

2009-04-25 Thread Robert Haas
On Sat, Apr 25, 2009 at 6:42 AM, Grzegorz Jaskiewicz wrote: > On 25 Apr 2009, at 04:52, Robert Haas wrote: >> blow the hash-join plan out of the water anyway... but Stephen Frost >> was telling me at JDcon East that he sometimes sets it to something >> like 8GB when he's the only user on his appar

Re: [HACKERS] WIP: to_char, support for EEEE format

2009-04-25 Thread Brendan Jurd
On Sat, Apr 11, 2009 at 3:51 AM, Pavel Stehule wrote: > So, please, if you can, propose these error messages (with hints)- > result will be much better. > Hi Pavel, hackers. I've done some work updating Pavel's sci notation patch for to_char(). I've attached a patch against HEAD (_2.diff.bz

Re: [HACKERS] Randomly placed definition of S_ISDIR() in psql/copy.c

2009-04-25 Thread David Fetter
On Sat, Apr 25, 2009 at 04:35:21PM -0400, Tom Lane wrote: > Why does psql/copy.c contain this? > > #if defined(WIN32) && !defined(S_ISDIR) > #define __S_ISTYPE(mode, mask)(((mode) & S_IFMT) == (mask)) > #define S_ISDIR(mode) __S_ISTYPE((mode), S_IFDIR) > #endif > > Surely a better place

[HACKERS] Randomly placed definition of S_ISDIR() in psql/copy.c

2009-04-25 Thread Tom Lane
Why does psql/copy.c contain this? #if defined(WIN32) && !defined(S_ISDIR) #define __S_ISTYPE(mode, mask) (((mode) & S_IFMT) == (mask)) #define S_ISDIR(mode)__S_ISTYPE((mode), S_IFDIR) #endif Surely a better place for such a thing is src/include/port/win32.h ... where indeed there already is

Re: [HACKERS] Copyright waiver from Helios (fix for non-BSD copyright)

2009-04-25 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > OK, I thought there was some uncertainty about whether people were using > > the AIX code. > > Somebody suggested that the code might be needed on pre-5.3 AIX. But > after I looked into the files and found out the code is only needed > pre *4.3*, I thi

Re: [HACKERS] RFE: Transparent encryption on all fields

2009-04-25 Thread Sam Halliday
Please continue to CC me on this thread as I have disabled receiving messages from this list, although remain subscribed. On 25 Apr 2009, at 05:52, to...@tuxteam.de wrote: Sure, there are challenges, but there are methods to work through all of those challenges. I seem to be less optimistic

Re: [HACKERS] HashJoin w/option to unique-ify inner rel

2009-04-25 Thread Grzegorz Jaskiewicz
On 25 Apr 2009, at 04:52, Robert Haas wrote: blow the hash-join plan out of the water anyway... but Stephen Frost was telling me at JDcon East that he sometimes sets it to something like 8GB when he's the only user on his apparently-quite-awesome hardware...) For the record, because most querie