Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread ITAGAKI Takahiro
Emmanuel Cecchet wrote: > I think there is a misunderstanding on how the trigger works. You have 1 > trigger per child table and they are all chained on the parent table. Oops, I misunderstand your patch, sorry. > > Is it possible to expand all of child paritions from pg_inherits and > > dete

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Emmanuel Cecchet
ITAGAKI Takahiro wrote: Emmanuel Cecchet wrote In the meantime, I have made some more tests with the trigger in C (see attached patch). Hmm... The inserting partition is passed by trigger arguments. Actually this is just a fallback option. The preferred option is to name the trigger

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Emmanuel Cecchet
Nikhil Sontakke wrote: A similar DELETE trigger should be pretty easy to write up in C. I think the main challenge is with UPDATE triggers especially if the new row will fall into another child table - but we can always throw an error for such a case initially. I agree. A first implementation c

Re: [HACKERS] Function with defval returns error

2008-12-15 Thread Rushabh Lathia
When we find the (pathpos < prevResult->pathpos) into FuncnameGetCandidates(), we just replacing the prevResult with the newResult. While replacing the previous with new we do not replace the args. I think in case of default we need to take care for the args as well. Thanks, Rushabh On Tue, Dec

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread ITAGAKI Takahiro
Emmanuel Cecchet wrote: > In the meantime, I have made some more tests with the trigger in C (see > attached patch). Hmm... The inserting partition is passed by trigger arguments. Users must replace triggers when the target is changed (ex. every month). Is it possible to expand all of child pa

Re: [HACKERS] Function with defval returns error

2008-12-15 Thread Pavel Stehule
Hello I'll write patch that block creating all ambiguous overloading. Regards Pavel Stehule 2008/12/16 Rushabh Lathia : > > Another issue found on CVS head > > CREATE USER test WITH PASSWORD 'test'; > CREATE SCHEMA AUTHORIZATION test; > > CREATE OR REPLACE FUNCTION f_test(x in numeric) RETU

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Nikhil Sontakke
Hi, > I will be working on a roadmap for the partitioning features. I think that > there are different needs and that we will not be able to address them all > in 8.5 or even 8.6. > The goal will be to get things done step by step but possibly with a design > that will not require major refactori

Re: [HACKERS] Function with defval returns error

2008-12-15 Thread Rushabh Lathia
Another issue found on CVS head CREATE USER test WITH PASSWORD 'test'; CREATE SCHEMA AUTHORIZATION test; CREATE OR REPLACE FUNCTION f_test(x in numeric) RETURNS numeric as $$ BEGIN RETURN x; END; $$ language plpgsql; select f_test(10); \c postgres test; select f_test(10); CREATE OR REPLA

Re: [HACKERS] lifetime of TubleTableSlot* returned by ExecProcNode

2008-12-15 Thread Bramandia Ramadhana
After reading the source code for nodeHash.c and tuplesort.c, I decided to create new struct containing MinimumTuple and few members. I am still wondering in one thing: typedef struct HashJoinTupleData { struct HashJoinTupleData *next;/* link to next tuple in same bucket */ uint32

[HACKERS] Coding TODO for 8.4: Synch Rep

2008-12-15 Thread Fujii Masao
Hi, I'd like to clarify the coding TODO of Synch Rep for 8.4. If indispensable TODO item is not listed, please feel free to let me know. 1. replication_timeout_action (GUC) This is new GUC to specify the reaction to replication_timeout. In the latest patch, the user cannot configure the reaction

Re: [HACKERS] Proposed Patch to Improve Performance of Multi-Batch Hash Join for Skewed Data Sets

2008-12-15 Thread Robert Haas
I have to admit that I haven't fully grokked what this patch is about just yet, so what follows is mostly a coding style review at this point. It would help a lot if you could add some comments to the new functions that are being added to explain the purpose of each at a very high level. There's

Re: [HACKERS] 8.4 replication questions

2008-12-15 Thread Fujii Masao
Hi, On Tue, Dec 16, 2008 at 7:10 AM, Kevin Grittner wrote: > Forgive me if this is clear to everyone else, but regarding the new > replication options in 8.4: > > Will existing PITR backup techniques work without modification? Yes. > > Will existing techniques for warm standby with a custom scr

Re: [HACKERS] WAL documentation changes

2008-12-15 Thread Bruce Momjian
Josh Berkus wrote: > > >> First, none of the general purpose filesystems I've seen so far do data > >> journalling per default, since it's a huge performance penalty, even for > >> non-RDBMS workloads. The feature you talk about is ext3 specific (and > >> should be pointed out as such) and only di

Re: [HACKERS] Multiplexing SUGUSR1

2008-12-15 Thread Fujii Masao
Hi, Sorry for this late reply. On Thu, Dec 11, 2008 at 3:12 PM, Heikki Linnakangas wrote: > Fujii Masao wrote: >> >> On Thu, Dec 11, 2008 at 10:55 AM, Fujii Masao >> wrote: >>> >>> I will update the patch based on yours, and add the support for auxiliary >>> processes into it. >> >> Or, should

Re: [HACKERS] DTrace probes patch

2008-12-15 Thread Bruce Momjian
Should I apply this or hold it for 8.5? --- Robert Lor wrote: > > The attached patch contains a couple of fixes in the existing probes and > includes a few new ones. > > - Fixed compilation errors on OS X for probes that

Re: [HACKERS] Mostly Harmless: Welcoming our C++ friends

2008-12-15 Thread Bruce Momjian
Added to TODO: Allow C++ code to more easily access backend code * http://archives.postgresql.org/pgsql-hackers/2008-12/msg00302.php --- Kurt Harriman wrote: > > Is there anything in the source that would

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Fujii Masao
Hi, Sorry for this late reply. And, thanks for the hot discussion ;) On Tue, Dec 16, 2008 at 1:24 AM, Simon Riggs wrote: > > Fujii-san, > > Just repeating this in case you lost this comment: > > On Mon, 2008-12-15 at 09:40 +, Simon Riggs wrote: > >> Fujii-san, please can we incorporate those

Re: [HACKERS] DROP ROLE dependency tracking ...

2008-12-15 Thread Bruce Momjian
Alvaro Herrera wrote: > Hans-Juergen Schoenig wrote: > > > when thinking of REASSIGNED OWNED people tend to think about tables > > rather than about CONNECT rights. > > i would suggest to make DROP ROLE just kill the role unless there is a > > real object depending on it. > > i would not see a

Re: [HACKERS] stat() vs cygwin

2008-12-15 Thread Bruce Momjian
Where are we on this? The patch was not acceptable for several reasons; for one: > And finally: > -VALUE?"OriginalFilename",?"libpq.dll\0" > +VALUE?"OriginalFilename",?"cygpq.dll\0" > > This obviously has to be done another way, because that change will > affect the win3

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Emmanuel Cecchet
Hi all, I will be working on a roadmap for the partitioning features. I think that there are different needs and that we will not be able to address them all in 8.5 or even 8.6. The goal will be to get things done step by step but possibly with a design that will not require major refactoring

Re: [HACKERS] planner issue with constraint exclusion

2008-12-15 Thread Tom Lane
"Joshua D. Drake" writes: > On Mon, 2008-12-15 at 14:28 -0500, Tom Lane wrote: >> "Joshua D. Drake" writes: >>> Of the functions the only one that will use constraint_exclusion is the >>> one that explicitly passes the date value. >> >> Since you haven't shown us the constraints you're talking a

Re: [HACKERS] Mostly Harmless: Welcoming our C++ friends

2008-12-15 Thread Tom Lane
Josh Berkus writes: > Ron Mayer wrote: >> The one use-case I can think of that imports a pile of C++ code >> is the GEOS library that PostGIS uses (used?): > There are also quite a number of OSS algorithms, useful for query > optimization or otherwise, which are written in C++. For example, the

Re: [HACKERS] Looking for someone with MinGW

2008-12-15 Thread Andrew Dunstan
Michael Meskes wrote: On Sun, Dec 14, 2008 at 11:36:21AM -0500, Andrew Dunstan wrote: See below ... Thanks. The backtrace is kind of strange, but I might have found it. Could you please update from CVS and re-run? same result ;-( cheers andrew -- Sent via pgsql-hackers mail

Re: [HACKERS] Patch to eliminate duplicate b64 code from pgcrypto

2008-12-15 Thread Bruce Momjian
Would someone who understand pgcrypto please review this? http://archives.postgresql.org/message-id/1216335149.11208.9.ca...@bloodnok.com --- Marc Munro wrote: -- Start of PGP signed section. > I am attaching a patch to el

Re: [HACKERS] Any reason not to return row_count in cursor of plpgsql?

2008-12-15 Thread Bruce Momjian
laser wrote: > hi all, > > I read the code that it seems easy for the cursor in plpgsql to return > ROW_COUNT after > MOVE LAST etc. The SPI_processed variable already there, but didn't put > it into estate > structure, any reason for that? [ Sorry for the delay.] Would some tests how Oracl

Re: [HACKERS] TODO item: Have psql show current values for a sequence

2008-12-15 Thread Bruce Momjian
Sorry for the delay on this. What I did was to mark the simple TODO items as done and add an additional TODO item to list all sequence settings: D o Have psql show current values for a sequence o Have psql \ds show all sequences and their settings * ht

Re: [HACKERS] [DOCS] [ADMIN] shared_buffers and shmmax

2008-12-15 Thread Bruce Momjian
I have added this TODO item: Rationalize the discrepancy between settings that use values in bytes and SHOW that returns the object count * http://archives.postgresql.org/pgsql-docs/2008-07/msg7.php ---

Re: [HACKERS][PATCHES] odd output in restore mode

2008-12-15 Thread Simon Riggs
On Mon, 2008-12-15 at 17:10 -0500, Bruce Momjian wrote: > > > > Why no backpatch to 8.3? Seems like a clear bugfix to me. > > I knew that was going to be asked. 8.3 is really where this is needed. 8.4 has almost no need of this. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Train

Re: [HACKERS] upper()/lower() truncates the result under Japanese Windows

2008-12-15 Thread Hiroshi Inoue
Tom Lane wrote: > Hiroshi Inoue writes: >> Upper(), lower() or initcap() function truncates the result >> under Japanese Windows with e.g. the server encoding=UTF-8 >> and the LC_CTYPE setting Japanese_japan.932 . > > Hmm, I guess that makes sense, since the LC_CTYPE implies an encoding > other t

Re: [HACKERS][PATCHES] odd output in restore mode

2008-12-15 Thread Bruce Momjian
Tom Lane wrote: > "Heikki Linnakangas" writes: > > Martin Zaun wrote: > >> With these avenues to be explored, can the pg_standby patch on the > >> CommitFest wiki be moved to the "Returned with Feedback" section? > > > Yes, I think we can conclude that we don't want this patch as it is. > > Inst

Re: [HACKERS][PATCHES] odd output in restore mode

2008-12-15 Thread Bruce Momjian
Magnus Hagander wrote: > Bruce Momjian wrote: > > Martin Zaun wrote: > >> 4. Issue: missing break in switch, silent override of '-l' argument? > >> > >> This behaviour has been in there before and is not addresses by the > >> patch: The user-selected Win32 "mklink" command mode is never applied > >

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Simon Riggs
On Mon, 2008-12-15 at 13:06 -0800, Josh Berkus wrote: > Peter Eisentraut wrote: > > Simon Riggs wrote: > >> I am truly lost to understand why the *name* "synchronous replication" > >> causes so much discussion, yet nobody has discussed what they would > >> actually like the software to *do* > > >

[HACKERS] 8.4 replication questions

2008-12-15 Thread Kevin Grittner
Forgive me if this is clear to everyone else, but regarding the new replication options in 8.4: Will existing PITR backup techniques work without modification? Will existing techniques for warm standby with a custom script (not using pg_standby) work without modification? We will want to cont

Re: [HACKERS][PATCHES] odd output in restore mode

2008-12-15 Thread Bruce Momjian
Since this patch was rejected, I have added the attached documentation to pg_standby to mention the sleep() we do. --- Martin Zaun wrote: > > Below my comments on the CommitFest patch: >pg_standby minor changes for Wind

Re: [HACKERS][PATCHES] odd output in restore mode

2008-12-15 Thread Magnus Hagander
Bruce Momjian wrote: > Martin Zaun wrote: >> 4. Issue: missing break in switch, silent override of '-l' argument? >> >> This behaviour has been in there before and is not addresses by the >> patch: The user-selected Win32 "mklink" command mode is never applied >> due to a missing 'break' in Customi

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Josh Berkus
Simon, I've explained this twice now on different parts of this thread. Could I politely direct your attention to those posts? Chill. I was just explaining that the *goal* of sync standby was not complicated or really something to be argued about. It's pretty clear. --Josh -- Sent via p

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Simon Riggs
On Mon, 2008-12-15 at 13:43 -0800, Josh Berkus wrote: > > Isn't the "queryable read-only" feature totally orthogonal with > > how synchronous the replication is? > > Yes. However, it introduces specific difficult issues which an > unreadable synchronous slave does not have. Don't think it's hu

Re: [HACKERS] Mostly Harmless: Welcoming our C++ friends

2008-12-15 Thread Josh Berkus
Ron Mayer wrote: Tom Lane wrote: I am, btw, still waiting for an actually plausible use-case for this. AFAICS the setjmp-vs-exceptions thing puts a very serious crimp in what you could hope to accomplish by importing a pile of C++ code. The one use-case I can think of that imports a pile of C+

Re: [HACKERS] Mostly Harmless: Welcoming our C++ friends

2008-12-15 Thread Ron Mayer
Tom Lane wrote: I am, btw, still waiting for an actually plausible use-case for this. AFAICS the setjmp-vs-exceptions thing puts a very serious crimp in what you could hope to accomplish by importing a pile of C++ code. The one use-case I can think of that imports a pile of C++ code is the GEOS

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Josh Berkus
Isn't the "queryable read-only" feature totally orthogonal with how synchronous the replication is? Yes. However, it introduces specific difficult issues which an unreadable synchronous slave does not have. --Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To ma

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Ron Mayer
Josh Berkus wrote: Hmmm. I thought this was pretty clear. There's three levels of synch which are useful features: 1) "synchronus" standby which is really asynchronous, but only has a gap of < 100ms. 2) Synchronous standby which guarentees that all committed transactions are on the fail

Re: [HACKERS][PATCHES] odd output in restore mode

2008-12-15 Thread Bruce Momjian
Martin Zaun wrote: > 4. Issue: missing break in switch, silent override of '-l' argument? > > This behaviour has been in there before and is not addresses by the > patch: The user-selected Win32 "mklink" command mode is never applied > due to a missing 'break' in CustomizableInitialize(): > >

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Josh Berkus
Peter Eisentraut wrote: Simon Riggs wrote: I am truly lost to understand why the *name* "synchronous replication" causes so much discussion, yet nobody has discussed what they would actually like the software to *do* It's the color of the bikeshed ... Hmmm. I thought this was pretty clear.

Re: [HACKERS] planner issue with constraint exclusion

2008-12-15 Thread Stephen Frost
* Joshua D. Drake (j...@commandprompt.com) wrote: > On Mon, 2008-12-15 at 14:28 -0500, Tom Lane wrote: > > "Joshua D. Drake" writes: > > > Of the functions the only one that will use constraint_exclusion is the > > > one that explicitly passes the date value. > > > > Since you haven't shown us th

Re: [HACKERS] SQL/MED compatible connection manager

2008-12-15 Thread Peter Eisentraut
On Monday 15 December 2008 22:30:19 Jonah H. Harris wrote: > On Fri, Dec 12, 2008 at 7:55 AM, Peter Eisentraut wrote: > > Now I have a question about the FDW C interface. The way I understand > > it, an SQL/MED-enabled server and a FDW each have a specific API by which > > they communicate. Supp

Re: [HACKERS] Function with defval returns error

2008-12-15 Thread Peter Eisentraut
On Monday 15 December 2008 15:43:00 Tom Lane wrote: > Peter Eisentraut writes: > > Rushabh Lathia wrote: > >> I think this should not return error as the input args here is > >> timestamp... inputs? > > > > In theory yes, but it's currently not that smart. > > This is truly horrid. Was that patch

Re: [HACKERS] SQL/MED compatible connection manager

2008-12-15 Thread Jonah H. Harris
On Fri, Dec 12, 2008 at 7:55 AM, Peter Eisentraut wrote: > Now I have a question about the FDW C interface. The way I understand it, > an SQL/MED-enabled server and a FDW each have a specific API by which they > communicate. Supposedly, each database vendor should be able to ship a > binary libr

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Jeff Davis
On Mon, 2008-12-15 at 09:19 -0500, Robert Haas wrote: > I understand you're point, but I think there's still a use case. The > idea is that declaring the secondary dead is a rare event, and there's > some mechanism by which you're enabled to page your network staff, and > they hightail it into th

Re: [HACKERS] planner issue with constraint exclusion

2008-12-15 Thread Joshua D. Drake
On Mon, 2008-12-15 at 14:28 -0500, Tom Lane wrote: > "Joshua D. Drake" writes: > > Of the functions the only one that will use constraint_exclusion is the > > one that explicitly passes the date value. > > Since you haven't shown us the constraints you're talking about, or the > resulting plans,

Re: [HACKERS] Mostly Harmless: Welcoming our C++ friends

2008-12-15 Thread Tom Lane
[ just realized that I set this message aside to reply to later, and then forgot about it --- apologies ] Kurt Harriman writes: > Tom Lane wrote: >> There is no such option, and won't be. > Yours is the first comment anyone has posted to the list > regarding my proposed c++configure patch, and

Re: [HACKERS] planner issue with constraint exclusion

2008-12-15 Thread Tom Lane
"Joshua D. Drake" writes: > Of the functions the only one that will use constraint_exclusion is the > one that explicitly passes the date value. Since you haven't shown us the constraints you're talking about, or the resulting plans, it's difficult for anyone to guess what's going on.

[HACKERS] planner issue with constraint exclusion

2008-12-15 Thread Joshua D. Drake
Hello, I ran into this problem recently: https://projects.commandprompt.com/public/replicator/pastebin?show=f1288d4d8%0D Of the functions the only one that will use constraint_exclusion is the one that explicitly passes the date value. I kind of get why except for the one that uses EXECUTE. As E

Re: [HACKERS] Mostly Harmless: Welcoming our C++ friends

2008-12-15 Thread Kevin Grittner
>>> Kurt Harriman wrote: > That's why I have instead offered some patches to enable C++ > for new extensions and add-on development with minimal > impact to the C core. I've been a bit confused by this thread. We wrote a couple PostgreSQL functions (pdftotext and pdfisok) which use libpoppler.

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Alvaro Herrera
Joshua D. Drake escribió: > On Mon, 2008-12-15 at 14:29 -0300, Alvaro Herrera wrote: > > Joshua D. Drake escribió: > > > > > If we can't fix the issue, then yeah let's rip it out but as it sits we > > > have a hurdle that needs to be overcome not a new feature that needs to > > > be implemented. >

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Jaime Casanova
On Mon, Dec 15, 2008 at 1:46 PM, Gregory Stark wrote: > Josh Berkus writes: > >> Hackers, >> >> We don't yet seem to have a clear specification for this feature, and the >> Other >> Open Source DB has shown us how problematic it is to get auto-partitioning >> wrong. >> >> Should we defer auto-pa

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Gregory Stark
Josh Berkus writes: > Hackers, > > We don't yet seem to have a clear specification for this feature, and the > Other > Open Source DB has shown us how problematic it is to get auto-partitioning > wrong. > > Should we defer auto-partitioning to 8.5? If we're serious about having a "next generati

Re: [HACKERS] pre-MED

2008-12-15 Thread Tom Lane
David Fetter writes: > On Mon, Dec 15, 2008 at 08:50:25AM -0500, Tom Lane wrote: >> I'm sorry, but I have far too much work in front of me reviewing >> patches that have a chance of getting into 8.4. I do not have time >> to do pre-implementation research for a patch that doesn't. > You took on

Re: [HACKERS] pre-MED

2008-12-15 Thread Joshua D. Drake
On Mon, 2008-12-15 at 09:12 -0800, David Fetter wrote: > On Mon, Dec 15, 2008 at 08:50:25AM -0500, Tom Lane wrote: > > David Fetter writes: > > > Tom, > > > Since you're the one who brought this up, I think it's on you to > > > flesh it out at least a little bit, or at least to describe it in > >

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Josh Berkus
Hackers, We don't yet seem to have a clear specification for this feature, and the Other Open Source DB has shown us how problematic it is to get auto-partitioning wrong. Should we defer auto-partitioning to 8.5? --Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) T

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Jonah H. Harris
On Mon, Dec 15, 2008 at 12:30 PM, Alvaro Herrera wrote: >> How hard would it be to just take an exclusive lock on the page when setting >> all these hint bits? > > I guess it will be intolerably slow then. If we were to say "we have > CRC now, but if you enable it you have 1% of the performance"

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Joshua D. Drake
On Mon, 2008-12-15 at 14:29 -0300, Alvaro Herrera wrote: > Joshua D. Drake escribió: > > > If we can't fix the issue, then yeah let's rip it out but as it sits we > > have a hurdle that needs to be overcome not a new feature that needs to > > be implemented. > > Ideas for solving the hurdle are w

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Alvaro Herrera
Gregory Stark escribió: > Alvaro Herrera writes: > > > Jonah H. Harris escribió: > >> Now, in the case where hint bits have been updated and a WAL record is > >> required because the buffer is being flushed, requiring the WAL to be > >> flushed up to that point may be a killer on performance. Ha

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Alvaro Herrera
Joshua D. Drake escribió: > If we can't fix the issue, then yeah let's rip it out but as it sits we > have a hurdle that needs to be overcome not a new feature that needs to > be implemented. Ideas for solving the hurdle are welcome. > Agreed, shall we remove the replication and se postgres patc

Re: [HACKERS] Restore enforce_generic_type_consistency's breaks a farms

2008-12-15 Thread Tom Lane
"Robert Haas" writes: > On Mon, Dec 15, 2008 at 11:38 AM, Tom Lane wrote: >> So my proposal is to change the OID-accepting variants of >> has_table_privilege and friends, as well as pg_table_is_visible and >> friends, to silently return FALSE instead of failing when given a >> bad OID. I had ori

Re: [HACKERS] visibility map and reltuples

2008-12-15 Thread Greg Smith
On Mon, 15 Dec 2008, Greg Stark wrote: I wonder if we should switch to keeping reltuplesperpage instead. It would be preferrable to not touch the user side of reltuples if possible, since it's the only instant way to get a good estimate of the number of rows in a table right now. That's bee

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Joshua D. Drake
On Mon, 2008-12-15 at 10:13 -0500, Bruce Momjian wrote: > Jonah H. Harris wrote: > > >> Alvaro, have you given up on the patch or are you just busy on > > >> something else at the moment? > > > > > > I've given up until we find a good way to handle hint bits. Various > > > schemes have been propos

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Gregory Stark
Alvaro Herrera writes: > Jonah H. Harris escribió: >> Now, in the case where hint bits have been updated and a WAL record is >> required because the buffer is being flushed, requiring the WAL to be >> flushed up to that point may be a killer on performance. Has anyone >> tested it? > > I didn't

Re: [HACKERS] plperl: Documentation on BYTEA decoding is wrong

2008-12-15 Thread Robert Treat
On Monday 28 January 2008 05:37:03 Florian Weimer wrote: > * Robert Treat: > > Note we've been using Theo's plperl bytea patch on one of our > > production servers for some time; if anyone wants access to that > > lmk. > > I'm interested. Could you post a pointer to this code, please? I had to do

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Alvaro Herrera
Jonah H. Harris escribió: > It is pretty late in the process to continue with this design-related > discussion, but I really wanted to see it in 8.4. Well, it's hard to blame anyone but me, because I started working on this barely two weeks before the final commitfest IIRC. -- Alvaro Herrera

Re: [HACKERS] pre-MED

2008-12-15 Thread David Fetter
On Mon, Dec 15, 2008 at 08:50:25AM -0500, Tom Lane wrote: > David Fetter writes: > > Tom, > > > I know you've been busy with lots of stuff, so here's a little > > reminder. I talked with a couple of people who know the back-end > > much better than I do. One said the above was way > > under-spe

Re: [HACKERS] Restore enforce_generic_type_consistency's breaks a farms

2008-12-15 Thread Robert Haas
On Mon, Dec 15, 2008 at 11:38 AM, Tom Lane wrote: > I wrote: >> ... But this type of problem has come >> up before. I wonder if we shouldn't do what was previously discussed: >> make has_table_privilege and related functions silently return FALSE, >> instead of throwing error, when given a "nonex

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Jonah H. Harris
On Mon, Dec 15, 2008 at 11:50 AM, Alvaro Herrera wrote: > That only does heap hint bits, but it does nothing about pd_flags, the > btree flags (btpo_cycleid I think), and something else I don't recall at > the moment. This was all solvable however. The big problem with it was > that it was using

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Alvaro Herrera
Jonah H. Harris escribió: > On Mon, Dec 15, 2008 at 11:29 AM, Tom Lane wrote: > > We don't really have an acceptable solution for the conflict with hint > > bit behavior. The shutdown issue is minor, agreed, but that's not the > > stumbling block. > > Agreed on the shutdown issue. But, didn't

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Jonah H. Harris
On Mon, Dec 15, 2008 at 11:29 AM, Tom Lane wrote: > "Jonah H. Harris" writes: >> On Mon, Dec 15, 2008 at 10:13 AM, Bruce Momjian wrote: >>> Feature freeze is not the time to be looking for new ideas. I suggest >>> we save this for 8.5. > >> Well, we may not need a new idea. > > We don't really

Re: [HACKERS] Restore enforce_generic_type_consistency's breaks a farms

2008-12-15 Thread Tom Lane
I wrote: > ... But this type of problem has come > up before. I wonder if we shouldn't do what was previously discussed: > make has_table_privilege and related functions silently return FALSE, > instead of throwing error, when given a "nonexistent" OID. On checking the archives, it seems most of

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Alvaro Herrera
Jonah H. Harris escribió: > Well, we may not need a new idea. Currently, the problem I see with > the checkpoint-at-shutdown looks like it could possibly be easily > solved. Though, there may be other issues I'm not familiar with. Has > anyone reviewed this yet? I didn't investigate the shutdo

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Tom Lane
"Jonah H. Harris" writes: > On Mon, Dec 15, 2008 at 10:13 AM, Bruce Momjian wrote: >> Feature freeze is not the time to be looking for new ideas. I suggest >> we save this for 8.5. > Well, we may not need a new idea. We don't really have an acceptable solution for the conflict with hint bit be

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Jaime Casanova
On Mon, Dec 15, 2008 at 10:19 AM, Tom Lane wrote: > > Well, one thing you should try is > >select 'wieck'::text < 'wiech'::text; >select 'wieck'::text > 'wiech'::text; > administra...@casanova10 ~/pg.build/8.4dev $ bin/psql -a -f test.sql postgres select 'wieck'::text < 'wiech'::t

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Tom Lane
I wrote: > But I don't see this sorting behavior with glibc on Linux (Fedora 9 to > be exact, testing LC_COLLATE=es_ES.utf8). BTW, I *do* see wieck < wiech in es_ES locale on HPUX 10.20, released ~1996. So I think we have correctly identified the core issue, and the only interesting question is w

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Simon Riggs
Fujii-san, Just repeating this in case you lost this comment: On Mon, 2008-12-15 at 09:40 +, Simon Riggs wrote: > Fujii-san, please can we incorporate those two options, rather than just > one choice "synchronous_replication = on". They look like two commonly > requested options. I see the

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Jonah H. Harris
On Mon, Dec 15, 2008 at 10:13 AM, Bruce Momjian wrote: > Jonah H. Harris wrote: >> >> Alvaro, have you given up on the patch or are you just busy on >> >> something else at the moment? >> > >> > I've given up until we find a good way to handle hint bits. Various >> > schemes have been proposed bu

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Tom Lane
Alvaro Herrera writes: > Jaime Casanova wrote: >> while 'ch' and 'll' are independent letters they sort as they were 'c' >> and 'l'... that means that 'ch' should go before 'ck' > Interesting. So they are both wrong, glibc and teachers. We can file a > bug with glibc but I'm not sure we can do

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Alvaro Herrera
Jaime Casanova wrote: > On Mon, Dec 15, 2008 at 10:26 AM, Alvaro Herrera > wrote: > > It was sane behavior a couple of decades ago -- dictionaries used to > > sort like this ("ch" was considered an independent letter, and sorted > > between c and d). > > while 'ch' and 'll' are independent lette

Re: [HACKERS] visibility map and reltuples

2008-12-15 Thread Tom Lane
Heikki Linnakangas writes: > Greg Stark wrote: >> I wonder if we should switch to keeping reltuplesperpage instead. Then a >> partial vacuum could update it by taking the average number of tuples >> per page forbthe pages it saw. Perhaps adjusting it to the weights >> average between the old va

Re: [HACKERS] Looking for someone with MinGW

2008-12-15 Thread Michael Meskes
On Sun, Dec 14, 2008 at 11:36:21AM -0500, Andrew Dunstan wrote: > See below > ... Thanks. The backtrace is kind of strange, but I might have found it. Could you please update from CVS and re-run? Thanks again. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Jaime Casanova
On Mon, Dec 15, 2008 at 10:26 AM, Alvaro Herrera wrote: > Tom Lane wrote: >> "Jaime Casanova" writes: >> > On Mon, Dec 15, 2008 at 8:59 AM, Tom Lane wrote: >> >> What locale is this running in? >> >> > Seems this is Spanish_Spain.1252 and the encoding WIN1252 >> >> What it looks like is that the

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Alvaro Herrera
Tom Lane wrote: > "Jaime Casanova" writes: > > On Mon, Dec 15, 2008 at 8:59 AM, Tom Lane wrote: > >> What locale is this running in? > > > Seems this is Spanish_Spain.1252 and the encoding WIN1252 > > What it looks like is that the locale is intentionally sorting h after k > (or more likely the

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Tom Lane
"Jaime Casanova" writes: > On Mon, Dec 15, 2008 at 10:12 AM, Tom Lane wrote: >> What it looks like is that the locale is intentionally sorting h after k >> (or more likely the rule is ch after ck). My Spanish is just about gone >> ... is that a sane behavior at all? > not at all... where can i

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Jaime Casanova
On Mon, Dec 15, 2008 at 10:12 AM, Tom Lane wrote: > What it looks like is that the locale is intentionally sorting h after k > (or more likely the rule is ch after ck). My Spanish is just about gone > ... is that a sane behavior at all? > not at all... where can i check those rules? -- Atenta

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Bruce Momjian
Jonah H. Harris wrote: > >> Alvaro, have you given up on the patch or are you just busy on > >> something else at the moment? > > > > I've given up until we find a good way to handle hint bits. Various > > schemes have been proposed but they all have more or less fatal flaws. > > Agreed. Though,

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Tom Lane
"Jaime Casanova" writes: > On Mon, Dec 15, 2008 at 8:59 AM, Tom Lane wrote: >> What locale is this running in? > Seems this is Spanish_Spain.1252 and the encoding WIN1252 What it looks like is that the locale is intentionally sorting h after k (or more likely the rule is ch after ck). My Spani

Re: [HACKERS] Stats target increase vs compute_tsvector_stats()

2008-12-15 Thread Tom Lane
=?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= writes: > Tom Lane wrote: >> I came across this bit in ts_typanalyze.c: >> >> /* We want statistic_target * 100 lexemes in the MCELEM array */ >> num_mcelem = stats->attr->attstattarget * 100; >> >> I wonder whether the multiplier here should be changed

Re: [HACKERS] Block-level CRC checks

2008-12-15 Thread Jonah H. Harris
On Mon, Dec 15, 2008 at 7:24 AM, Alvaro Herrera wrote: >> Here's an updated patch against head. > > Thanks. No problemo. >> NOTE, it appears that this (and the previous) patch PANIC with >> "concurrent transaction log activity while database system is shutting >> down" on shutdown if checksummin

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Jaime Casanova
On Mon, Dec 15, 2008 at 8:59 AM, Tom Lane wrote: > "Jaime Casanova" writes: >> i'm seeing a fail in the rules regression, seems like it is not >> ordering the results right even when the regression has an explicit >> order by... > > What locale is this running in? > Seems this is Spanish_Spain.1

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Robert Haas
> So you'd want all commits to wait until the transaction is safely replicated > in the standby. But if there's a network glitch, or the standby is > restarted, you're happy to reply to the client that it's committed if it's > only safely committed in the primary. Essentially, you wait for the repl

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-15 Thread Aidan Van Dyk
* Robert Haas [081215 07:32]: > > In fact, waiting for reply from standby server before acknowledging a commit > > to the client is a bit pointless otherwise. It puts you in a strange > > situation, where you're waiting for the commits in normal operation, but if > > there's a network glitch or th

Re: [HACKERS] rules regression test failed on mingw

2008-12-15 Thread Tom Lane
"Jaime Casanova" writes: > i'm seeing a fail in the rules regression, seems like it is not > ordering the results right even when the regression has an explicit > order by... What locale is this running in? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] pre-MED

2008-12-15 Thread Tom Lane
David Fetter writes: > Tom, > I know you've been busy with lots of stuff, so here's a little > reminder. I talked with a couple of people who know the back-end much > better than I do. One said the above was way under-specified, and the > other said he'd started work on it, but hasn't had much

[HACKERS] rules regression test failed on mingw

2008-12-15 Thread Jaime Casanova
Hi, i'm seeing a fail in the rules regression, seems like it is not ordering the results right even when the regression has an explicit order by... i'm in a mingw32 5.1 on xp sp2 using msys 1.0.10 and gcc 3.4.2 attached the regression.diffs please make me know if i can provide more info -- Ate

Re: [HACKERS] Function with defval returns error

2008-12-15 Thread Tom Lane
Peter Eisentraut writes: > Rushabh Lathia wrote: >> I think this should not return error as the input args here is >> timestamp... inputs? > In theory yes, but it's currently not that smart. This is truly horrid. Was that patch *really* ready to commit? I noticed some comments added to polymor

  1   2   >