Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Hannu Krosing
On Wed, 2008-09-03 at 20:01 -0400, Alvaro Herrera wrote: > Hannu Krosing escribió: > > > I mean, there is no known written standard, which says that Mb is > > megabit, not megabyte or that you can (or can't) write kilo as K, but > > some people just believe that kB is "the Way" and allowing people

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Robert Treat
On Wednesday 03 September 2008 16:12:29 Joshua Drake wrote: > On Wed, 03 Sep 2008 23:10:24 +0300 > > Hannu Krosing <[EMAIL PROTECTED]> wrote: > > > That would equally solve > > > this problem, as well as many others. > > > > AFAIK the config file is checked now, and if the check fails, the > > data

Re: [HACKERS] Our CLUSTER implementation is pessimal

2008-09-03 Thread Simon Riggs
On Mon, 2008-09-01 at 00:25 +0100, Gregory Stark wrote: > One thing that's been annoying me for a while is that our CLUSTER > implementation is really very slow. When I say very slow I mean it's really > very very very slow. Does this implementation work towards being able to do CREATE INDEX .

Re: [HACKERS] New FSM patch

2008-09-03 Thread Simon Riggs
On Fri, 2008-08-29 at 10:47 +0300, Heikki Linnakangas wrote: > Here's an updated FSM patch. Can I check some aspects of this related to Hot Standby? Some of them sound obvious, but worth double checking. * There will be no need to read FSM by any normal operation of a read-only transaction, so

Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Greg Smith
On Wed, 3 Sep 2008, Tom Lane wrote: Greg Smith <[EMAIL PROTECTED]> writes: First question--how about if I changed that description to read: "Default value used at server startup if the parameter is not explicitly set"? "... not otherwise set" would probably be an accurate phrasing. (I'm th

Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Greg Smith
Before I respond to Tom's comments, let me step back a second and add the intro the deadline didn't leave me time for. There are two specific things the bit I added to this GUC patch is aimed at: 1) Somebody has a postgresql.conf from a random source (saw it on the Internet and pasted dubious

Re: [HACKERS] Extending grant insert on tables to sequences

2008-09-03 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: > Stephen Frost <[EMAIL PROTECTED]> writes: > > * Jaime Casanova ([EMAIL PROTECTED]) wrote: > >> updating the patch with one that only extends inserts. though, i > >> haven't look at the col level privs patch yet. > > > At least initially I wasn't planning to

Re: [HACKERS] pg_dump roles support

2008-09-03 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: > =?ISO-8859-1?Q?Benedek_L=E1szl=F3?= <[EMAIL PROTECTED]> writes: > > pg_dumpall now just passes the --role option to pg_dump. What do you > > think, is it enough > > or it should issue the SET ROLE TO ... command in its own session too? > > I think it would

Re: [HACKERS] Extending grant insert on tables to sequences

2008-09-03 Thread Tom Lane
Stephen Frost <[EMAIL PROTECTED]> writes: > * Jaime Casanova ([EMAIL PROTECTED]) wrote: >> updating the patch with one that only extends inserts. though, i >> haven't look at the col level privs patch yet. > At least initially I wasn't planning to support column-level privileges > for sequences, s

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Alvaro Herrera
Hannu Krosing escribió: > I mean, there is no known written standard, which says that Mb is > megabit, not megabyte or that you can (or can't) write kilo as K, but > some people just believe that kB is "the Way" and allowing people to > write kilobytes as KB or kb is evil and should be punished.

Re: [HACKERS] Conflict resolution in Multimaster replication(Postgres-R)

2008-09-03 Thread Robert Hodges
Hi Srinivas, Multi-master replication in Postgres-R is handled using a process called certification that ensures there are no serializability violations. Look at the paper by Kemme and Alonzo entitled "Don't be Lazy, Be Consistent..." (http://www.cs.mcgill.ca/~kemme/papers/vldb00.html). In th

[HACKERS] Conflict resolution in Multimaster replication(Postgres-R)

2008-09-03 Thread M2Y
Hello, My basic question is: in multimaster replication, if each site goes ahead and does the modifications issued by the transaction and then sends the writeset to others in the group, how the ACID properties be maintained? Details: Suppose there are two sites in the group, lets say, A and B and

Re: [HACKERS] Our CLUSTER implementation is pessimal

2008-09-03 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > There are a couple problems with this: > a) We need some way to decide *when* to do a sort and when to do an index > scan. The planner has all this machinery but we don't really have all the > pieces handy to use it in a utility statement. Why not? You

Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Tom Lane
Greg Smith <[EMAIL PROTECTED]> writes: > First question--how about if I changed that description to read: > "Default value used at server startup if the parameter is not explicitly > set"? "... not otherwise set" would probably be an accurate phrasing. (I'm thinking of corner cases like stuff ab

Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Tom Lane
Joshua Drake <[EMAIL PROTECTED]> writes: > I guess I would ask, "Who else would we be targeting this for?". DBAs > seem to be the only logical choice. Regular users look at pg_settings too, you know. Maybe *you* only get questions from DBAs... regards, tom lane -- Sent

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Joshua Drake
On Thu, 04 Sep 2008 01:26:44 +0300 Hannu Krosing <[EMAIL PROTECTED]> wrote: > So Andrews opinion was that Mb (meaning Mbit) is different from MB > (for megabyte) and that if someone thinks that we define shared > buffers in megabits can get confused and order wrong kind of network > card ? I was

Re: [HACKERS] [PATCH] In case module has wrong magic, report exact problem

2008-09-03 Thread Tom Lane
Marko Kreen <[EMAIL PROTECTED]> writes: > In case module and server magic blocks do not match > report exact parameters that differ. Applied with revisions --- your patch produced a message that wasn't localizable and didn't follow the style guidelines. Also it assumed that all the fields would b

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Hannu Krosing
On Wed, 2008-09-03 at 11:45 -0700, Joshua Drake wrote: > On Wed, 3 Sep 2008 19:36:19 +0100 > Greg Stark <[EMAIL PROTECTED]> wrote: > > > Sure if people want to do it the right way more power to them. What > > you're talking about is punishing people when they don't live up to > > your standard

Re: [HACKERS] IN vs EXISTS equivalence

2008-09-03 Thread Kevin Grittner
>>> Tom Lane <[EMAIL PROTECTED]> wrote: > If you're still interested in testing CVS HEAD's handling of EXISTS, > I've about finished what I wanted to do with it. It's been hectic here, but I've managed to let some stuff run in the background using an old test case from here: http://archives.po

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Alvaro Herrera
Hannu Krosing escribió: > On Wed, 2008-09-03 at 13:48 -0400, Alvaro Herrera wrote: > > I think the energy wasted in this discussion would be better spent in > > working a the check-the-config-file feature. > > What kind of checks do you have in mind. Would this be something that > works at restar

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Joshua Drake
On Wed, 03 Sep 2008 23:10:24 +0300 Hannu Krosing <[EMAIL PROTECTED]> wrote: > > That would equally solve > > this problem, as well as many others. > > AFAIK the config file is checked now, and if the check fails, the > database won't start. Like apachectl configcheck ... E.g; we have the ability

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Hannu Krosing
On Wed, 2008-09-03 at 13:48 -0400, Alvaro Herrera wrote: > Hannu Krosing escribió: > > On Wed, 2008-09-03 at 09:10 -0700, Joshua Drake wrote: > > > > If we are going to make sweeping statements (anyone on this thread) > > > about user-hostile and most people, then we better define what those > > >

Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Joshua Drake
On Wed, 3 Sep 2008 16:04:12 -0400 (EDT) Greg Smith <[EMAIL PROTECTED]> wrote: > Section question: with those changes, would it then be reasonable to > you to keep that column named "default" instead of giving it a less > common name? > > > You are adopting a very narrow mindset, which seems to

Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Greg Smith
On Wed, 3 Sep 2008, Tom Lane wrote: "Default value if the parameter is not explicitly set" If that statement were the truth, the whole truth, and nothing but the truth, and if it didn't ignore the point about "explicitly set WHERE?", I'd be fine with it. First question--how about if I changed

Re: [HACKERS] pg_dump roles support

2008-09-03 Thread Tom Lane
=?ISO-8859-1?Q?Benedek_L=E1szl=F3?= <[EMAIL PROTECTED]> writes: > pg_dumpall now just passes the --role option to pg_dump. What do you > think, is it enough > or it should issue the SET ROLE TO ... command in its own session too? I think it would have to, in the general case. Consider the possib

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 > You do realize that misspelling unit name can cause downtime of several > minutes instead of couple seconds? We can easily do restart in couple of > seconds but the restart, look logs, launch editor, find value, change, > save, restart cycle

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Tom Lane
Greg Smith <[EMAIL PROTECTED]> writes: > On Tue, 2 Sep 2008, Tom Lane wrote: >>> How about having two new columns "reset value" and "boot value"? >> >> Like it better than "default value" ... > It's being a bit pedantic at the expense of the user, but I don't really > care that much here. I exp

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Joshua Drake
On Wed, 3 Sep 2008 19:36:19 +0100 Greg Stark <[EMAIL PROTECTED]> wrote: > Sure if people want to do it the right way more power to them. What > you're talking about is punishing people when they don't live up to > your standards. I think I will defer to Andrew and Alvaro's opinion on the matt

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Greg Stark
Sure if people want to do it the right way more power to them. What you're talking about is punishing people when they don't live up to your standards. greg On 3 Sep 2008, at 16:20, "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: Greg Stark wrote: I don't think worrying about the message we s

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Greg Stark
I don't think worrying about the message we send to users is reasonable. We can take responsibilty for the messages we output but punishing our users to teach them a lesson is being actively user- hostile greg On 3 Sep 2008, at 15:52, "Joshua D. Drake" <[EMAIL PROTECTED]> wrote: Hannu Kro

[HACKERS] Testers: 8.4 snapshot RPMs are available

2008-09-03 Thread Devrim GÜNDÜZ
Hi, If you are a Fedora-9 or RHEL/CentOS 5 user and want to test new features of PostgreSQL 8.4 and help development team, you may use the packages that I have just released, based on today's CVS snapshot. I am planning to push new packages each weekend during commitfest. Please note that these p

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Greg Smith
On Tue, 2 Sep 2008, Tom Lane wrote: How about having two new columns "reset value" and "boot value"? Like it better than "default value" ... It's being a bit pedantic at the expense of the user, but I don't really care that much here. I exposed the boot_val and described it in the documen

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Andrew Sullivan
On Wed, Sep 03, 2008 at 01:48:18PM -0400, Alvaro Herrera wrote: > I think the energy wasted in this discussion would be better spent in > working a the check-the-config-file feature. That would equally solve > this problem, as well as many others. This seems like a good idea to me. A -- Andre

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Alvaro Herrera
Hannu Krosing escribió: > On Wed, 2008-09-03 at 09:10 -0700, Joshua Drake wrote: > > If we are going to make sweeping statements (anyone on this thread) > > about user-hostile and most people, then we better define what those > > mean. > > Not user-hostile but rather hostile to an overworked DBA

Re: [HACKERS] Function call order dependency

2008-09-03 Thread pgsql
> [EMAIL PROTECTED] writes: >> I need to perform an operation during query time and there are multiple >> results based on the outcome. For instance: (Lets try this) > >> select myrank(t1.column1, t2.column2, 1) as rank, >> myscore(t1.column1,t2.column2, 1) as score from t1, t2 where >> myrank(t1.c

[HACKERS] Commitfest has started, y'all

2008-09-03 Thread Josh Berkus
Folks, If you hadn't noticed, the CommitFest started this week. I'm currently assigning patches to reviewers, but if there's a patch you especially want to tackle, please put your name down right away. If you can't actually review the patch *this week*, please don't put your name down. Th

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Hannu Krosing
On Wed, 2008-09-03 at 09:10 -0700, Joshua Drake wrote: > If someone doesn't know the difference between Mb and MB on a > production system, I would not want them anywhere near any instance of > a production system. I for one can make the difference, once I can zen that we are in a domain, where M

Re: [HACKERS] Function call order dependency

2008-09-03 Thread pgsql
>> I was kind of afraid of that. So, how could one implement such a >> function >> set? > > Write a function (say, score_contains) that returns NULL whenever > contains would return false, and the score otherwise. > > SELECT * FROM ( > SELECT *, score_contains(mytable.title, 'Winding Road', 1)

Re: [HACKERS] Function call order dependency

2008-09-03 Thread Tom Lane
[EMAIL PROTECTED] writes: > I need to perform an operation during query time and there are multiple > results based on the outcome. For instance: (Lets try this) > select myrank(t1.column1, t2.column2, 1) as rank, > myscore(t1.column1,t2.column2, 1) as score from t1, t2 where > myrank(t1.column1,t

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-03 Thread Andrew Chernow
Alvaro Herrera wrote: Andrew Chernow escribió: Alvaro Herrera wrote: (I also removed PQresultAlloc.) Nooo ... removing PQresultAlloc breaks libpqtypes! It also removes some of the use cases provided by PQsetvalue, which allows one to add to a result (in our case from scratch). I don'

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Andrew Sullivan
On Wed, Sep 03, 2008 at 06:37:29PM +0300, Hannu Krosing wrote: > On Wed, 2008-09-03 at 08:20 -0700, Joshua D. Drake wrote: > > There is no arguing that MB != Mb; > > The whole point of this discussion is, that mostly people expect > MB == Mb = mb == mB, especially if they see weird constructs li

Re: [HACKERS] Function call order dependency

2008-09-03 Thread pgsql
> [EMAIL PROTECTED] writes: >> For example I'll use the Oracle "contains" function, though this is not >> exactly what I'm doing, it just illustrates the issue clearly. > >> select *, score(1) from mytable where contains(mytable.title, 'Winding >> Road', 1) order by score(1); > >> The "contains" fu

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-03 Thread Alvaro Herrera
Andrew Chernow escribió: > Alvaro Herrera wrote: >> (I also removed PQresultAlloc.) > > Nooo ... removing PQresultAlloc breaks libpqtypes! It also removes > some of the use cases provided by PQsetvalue, which allows one to add to > a result (in our case from scratch). I don't really see th

Re: [HACKERS] Function call order dependency

2008-09-03 Thread Robert Haas
> I was kind of afraid of that. So, how could one implement such a function > set? Write a function (say, score_contains) that returns NULL whenever contains would return false, and the score otherwise. SELECT * FROM ( SELECT *, score_contains(mytable.title, 'Winding Road', 1) AS score FROM m

Re: [HACKERS] Function call order dependency

2008-09-03 Thread pgsql
> [EMAIL PROTECTED] writes: >> For example I'll use the Oracle "contains" function, though this is not >> exactly what I'm doing, it just illustrates the issue clearly. > >> select *, score(1) from mytable where contains(mytable.title, 'Winding >> Road', 1) order by score(1); > >> The "contains" fu

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Joshua Drake
On Wed, 03 Sep 2008 18:32:16 +0300 Hannu Krosing <[EMAIL PROTECTED]> wrote: > > We have had this discussion before, I even submitted a patch to > > make them case insensitive. In retrospect I was wrong to submit > > that patch. SQL may be case insensitive but units are not. MB != > > Mb != mb , >

Re: [HACKERS] Window functions doc patch

2008-09-03 Thread Hitoshi Harada
2008/9/4 Erikj <[EMAIL PROTECTED]>: > Dear Hitoshi, > > I noticed the folowing typo in the doc sgml: > > 'rownumber()', instead of 'row_number()' ( 2x ) > > hth > > Erik Rijkers > > > > *** doc/src/sgml/func.sgml.orig 2008-09-03 17:20:28.130229027 +0200 > --- doc/src/sgml/func.sgml 2008-09-03

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Hannu Krosing
On Wed, 2008-09-03 at 08:20 -0700, Joshua D. Drake wrote: > Greg Stark wrote: > > I don't think worrying about the message we send to users is reasonable. > > We can take responsibilty for the messages we output but punishing our > > users to teach them a lesson is being actively user-hostile >

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Hannu Krosing
On Wed, 2008-09-03 at 07:52 -0700, Joshua D. Drake wrote: > Hannu Krosing wrote: > > On Tue, 2008-09-02 at 16:50 +0300, Peter Eisentraut wrote: > >> Gregory Stark wrote: > >>> Peter Eisentraut <[EMAIL PROTECTED]> writes: > > > Are you really afraid that someone would want to use mb to mean > > mil

[HACKERS] Window functions doc patch

2008-09-03 Thread Erikj
Dear Hitoshi, I noticed the folowing typo in the doc sgml: 'rownumber()', instead of 'row_number()' ( 2x ) hth Erik Rijkers *** doc/src/sgml/func.sgml.orig 2008-09-03 17:20:28.130229027 +0200 --- doc/src/sgml/func.sgml 2008-09-03 17:21:01.331907454 +0200 *** *** 10092,1010

Re: [HACKERS] Question regarding the database page layout.

2008-09-03 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > I could do the janitorial work again if we're interested. I think it'd make more sense to do it incrementally rather than in one big-bang patch ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgre

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Joshua D. Drake
Greg Stark wrote: I don't think worrying about the message we send to users is reasonable. We can take responsibilty for the messages we output but punishing our users to teach them a lesson is being actively user-hostile There is no arguing that MB != Mb; nor is there anything user-hostile b

Re: [HACKERS] Function call order dependency

2008-09-03 Thread Stephen R. van den Berg
[EMAIL PROTECTED] wrote: >Would it be something like: "where" clause first, left to right, followed >by select terms, left to right, and lastly the "order by" clause? I don't know what ANSI says, nor do I know what PostgreSQL exactly does at the moment, but, the only thing you can reasonably count

Re: [HACKERS] Function call order dependency

2008-09-03 Thread Tom Lane
[EMAIL PROTECTED] writes: > For example I'll use the Oracle "contains" function, though this is not > exactly what I'm doing, it just illustrates the issue clearly. > select *, score(1) from mytable where contains(mytable.title, 'Winding > Road', 1) order by score(1); > The "contains" function do

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Joshua D. Drake
Hannu Krosing wrote: On Tue, 2008-09-02 at 16:50 +0300, Peter Eisentraut wrote: Gregory Stark wrote: Peter Eisentraut <[EMAIL PROTECTED]> writes: Are you really afraid that someone would want to use mb to mean millibits ? As SQL is generally case insensitive, it is quite surprising to most

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-03 Thread Andrew Chernow
Alvaro Herrera wrote: There's one thing that seems a bit baroque, which is the PG_COPYRES_USE_ATTRS stuff in PQcopyResult. I think that flag introduces different enough behavior that it should be a routine of its own, say PQcopyResultAttrs. That way you would leave out the two extra params in

[HACKERS] Function call order dependency

2008-09-03 Thread pgsql
Is there a knowable order in which functions are called within a query in PostgreSQL? For example I'll use the Oracle "contains" function, though this is not exactly what I'm doing, it just illustrates the issue clearly. select *, score(1) from mytable where contains(mytable.title, 'Winding Road'

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-03 Thread Hitoshi Harada
2008/9/3 Heikki Linnakangas <[EMAIL PROTECTED]>: > Hitoshi Harada wrote: >> >>> I'd suggest: >>> >>> 1. Implement Window node, with the capability to invoke an aggregate >>> function, using the above API. Implement required parser/planner changes. >>> Implement a few simple ranking aggregates using

Re: [HACKERS] Question regarding the database page layout.

2008-09-03 Thread Gregory Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> Tom Lane <[EMAIL PROTECTED]> writes: >>> BTW, there are at least two copies of that code to be changed. I'd >>> suggest grepping for assignments to t_hoff to be sure there aren't more. > >> I did send in a patch a

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Hannu Krosing
On Tue, 2008-09-02 at 16:50 +0300, Peter Eisentraut wrote: > Gregory Stark wrote: > > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > > >> Marko Kreen wrote: > >>> In the meantime, here is simple patch for case-insensivity. > >> You might be able to talk me into accepting various unambiguous, com

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Marko Kreen
On 9/3/08, Heikki Linnakangas <[EMAIL PROTECTED]> wrote: > Marko Kreen wrote: > > On 9/2/08, Peter Eisentraut <[EMAIL PROTECTED]> wrote: > > > Marko Kreen wrote: > > > > In the meantime, here is simple patch for case-insensivity. > > > > > > > You might be able to talk me into accepting various un

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Asko Oja
On Wed, Sep 3, 2008 at 11:20 AM, Heikki Linnakangas < [EMAIL PROTECTED]> wrote: > Marko Kreen wrote: > >> On 9/2/08, Peter Eisentraut <[EMAIL PROTECTED]> wrote: >> >>> Marko Kreen wrote: >>> In the meantime, here is simple patch for case-insensivity. >>> You might be able to talk me int

Re: [HACKERS] IN vs EXISTS equivalence

2008-09-03 Thread Asko Oja
On Wed, Sep 3, 2008 at 9:17 AM, daveg <[EMAIL PROTECTED]> wrote: > On Thu, Aug 14, 2008 at 06:50:09PM +0100, Simon Riggs wrote: > > > > On Fri, 2008-08-08 at 16:23 -0400, Tom Lane wrote: > > > > > NOT IN is a lot trickier, > > > condition: you must also assume that the comparison operator involved

Re: [HACKERS] [PATCH] Cleanup of GUC units code

2008-09-03 Thread Heikki Linnakangas
Marko Kreen wrote: On 9/2/08, Peter Eisentraut <[EMAIL PROTECTED]> wrote: Marko Kreen wrote: In the meantime, here is simple patch for case-insensivity. You might be able to talk me into accepting various unambiguous, common alternative spellings of various units. But for instance allowing M

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-03 Thread Simon Riggs
On Wed, 2008-09-03 at 09:51 +0300, Heikki Linnakangas wrote: > Simon Riggs wrote: > > On Tue, 2008-09-02 at 15:51 +0300, Heikki Linnakangas wrote: > > > >> The needs of access to the rows are so different that it seems best to > >> me to delegate the buffering to the window function. > > > > Tha

Re: [HACKERS] Window functions patch v04 for the September commit fest

2008-09-03 Thread Heikki Linnakangas
Hitoshi Harada wrote: 2008/9/2 Heikki Linnakangas <[EMAIL PROTECTED]>: Hitoshi Harada wrote: 2008/9/2 Heikki Linnakangas <[EMAIL PROTECTED]>: In my understanding, the "Window Frame" is defined by clauses such like "ROWS BETWEEN ... ", "RANGE BETWEEN ... " or so, contrast to "Window Partition" d