Tom Lane wrote:
Thomas Hallgren <[EMAIL PROTECTED]> writes:
Tom, could you please elaborate where you see a security hole?
The problem that we've seen in the past shows up when the user lies in
the CREATE TYPE command, specifying type representation properties that
are different from w
Andrew Gierth <[EMAIL PROTECTED]> writes:
> One more oversight: the patch isn't updating the ECPG preproc.y other
> than trivially, so WITH queries aren't working in ecpg:
> test.pgc:111: ERROR: syntax error at or near "recursive"
By and large we don't expect core patches to worry about fixing th
> "Tom" == Tom Lane <[EMAIL PROTECTED]> writes:
>> Tom, could you please elaborate where you see a security hole?
Tom> The problem that we've seen in the past shows up when the user
Tom> lies in the CREATE TYPE command, specifying type representation
Tom> properties that are different fro
> "Tatsuo" == Tatsuo Ishii <[EMAIL PROTECTED]> writes:
>> At David's request I've been looking through this patch.
>>
>> Regarding documentation: if it would help, I can write some; I
>> have already made a start on writing down what is going on
>> internally in order to understand it my
Thomas Hallgren <[EMAIL PROTECTED]> writes:
> Tom, could you please elaborate where you see a security hole?
The problem that we've seen in the past shows up when the user lies in
the CREATE TYPE command, specifying type representation properties that
are different from what the underlying functio
It seems perfectly safe to me too for the reason that Kris mentions.
Tom, could you please elaborate where you see a security hole?
Regards,
Thomas Hallgren
Tom Lane wrote:
Kris Jurka <[EMAIL PROTECTED]> writes:
On Wed, 30 Jul 2008, Alvaro Herrera wrote:
I do agree that creating base
Alvaro Herrera wrote:
Greg Smith wrote:
One tiny change I'd suggest here: if you look at the code for checkpoint
buffer writing there are traces for two points in the process:
CheckPointBuffers(int flags)
{
+ TRACE_POSTGRESQL_BUFFER_CHECKPOINT_START(flags);
CheckpointStats.
Tom Lane wrote:
> BTW, doesn't this patch leak memory at freePGconn() time?
Doh -- right, fixed.
> I also think that more of it should be inside #ifdef USE_SSL --- ie,
> the options should be treated like requiressl not sslmode, and not
> exist in a non-SSL build.
I wondered about that too, and
Greg Smith wrote:
> One tiny change I'd suggest here: if you look at the code for checkpoint
> buffer writing there are traces for two points in the process:
>
> CheckPointBuffers(int flags)
> {
> + TRACE_POSTGRESQL_BUFFER_CHECKPOINT_START(flags);
> CheckpointStats.ckpt_write_t =
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > I've hacked up a couple of SGML paragraphs to serve as documentation.
> > The patch is attached. I'll revise it (and make sure it compiles
> > properly) and see about committing it later today.
>
> Weren't there a couple of other po
BTW, doesn't this patch leak memory at freePGconn() time? I also
think that more of it should be inside #ifdef USE_SSL --- ie,
the options should be treated like requiressl not sslmode, and
not exist in a non-SSL build.
regards, tom lane
--
Sent via pgsql-hackers mailing
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> I've hacked up a couple of SGML paragraphs to serve as documentation.
> The patch is attached. I'll revise it (and make sure it compiles
> properly) and see about committing it later today.
Weren't there a couple of other points in ams' review that we
One tiny change I'd suggest here: if you look at the code for checkpoint
buffer writing there are traces for two points in the process:
CheckPointBuffers(int flags)
{
+ TRACE_POSTGRESQL_BUFFER_CHECKPOINT_START(flags);
CheckpointStats.ckpt_write_t = GetCurrentTimestamp();
Abhijit Menon-Sen wrote:
> At 2008-07-08 08:27:29 +0530, [EMAIL PROTECTED] wrote:
> >
> > (The patch is whitespace-damaged and the one fe-secure.c hunk doesn't
> > apply cleanly to the latest source, but I'm ignoring both problems for
> > the moment.)
>
> It wasn't hard to fix those, so I've attac
Martijn van Oosterhout <[EMAIL PROTECTED]> writes:
> On Thu, Jul 31, 2008 at 08:54:49PM -0400, Tom Lane wrote:
>> So while I was fooling with Steve Midgley's problem I got a bit of a bee
>> in my bonnet about the way that the parser emits ORDER BY, GROUP BY,
>> and DISTINCT lists.
> There's an ope
On Thu, Jul 31, 2008 at 08:54:49PM -0400, Tom Lane wrote:
> So while I was fooling with Steve Midgley's problem I got a bit of a bee
> in my bonnet about the way that the parser emits ORDER BY, GROUP BY,
> and DISTINCT lists.
There's an open TODO item in this area: namely that a GROUP BY referring
Gregory Stark <[EMAIL PROTECTED]> writes:
> So ASC/DESC is represented by using > for sortop?
Yes --- that's always been true.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgr
Alvaro Herrera wrote:
Alvaro Herrera wrote:
Applied.
I forgot to mention that I renamed the sort_end probe to sort_done, to
keep the naming convention. It is a backwards-incompatible change, but
there were plenty other probes renamed so my guess is that one more does
not matter all t
"Tom Lane" <[EMAIL PROTECTED]> writes:
> Gregory Stark <[EMAIL PROTECTED]> writes:
>> These two files seem to be getting updated every time I do a CVS update.
>
> Doesn't happen here --- maybe something odd in your local CVS state?
Huh, indeed. I needed rsync --delete. I'm surprised it hasn't cau
"Gustavo Tonini" <[EMAIL PROTECTED]> writes:
> I read the archives, but I can't find the instructions for adding new
> catalogs to the system.
That's probably because there aren't any. Look at recent patches
that added a new catalog to get an idea of what you need to do.
The enum patch might be a
Alvaro Herrera wrote:
Applied.
Thanks!
How come "Oid" works for FLUSH_START but not READ_START and READ_DONE?
I'll get the answer for this.
Also, I wonder if there's any proof that this works at all on Mac OS X,
given that the rule to create probes.o from probes.d is conditionally
Gregory Stark <[EMAIL PROTECTED]> writes:
> These two files seem to be getting updated every time I do a CVS update.
Doesn't happen here --- maybe something odd in your local CVS state?
> If that's true then we should just cvs delete them.
We already did, according to the cvsweb view.
These two files seem to be getting updated every time I do a CVS update. I
think what's happened is that they've become generated files and are being
deleted by "make clean" but CVS thinks they're still under revision control
and puts back some old version.
If that's true then we should just cvs
Tom Lane wrote:
> Perhaps have PGAC_PATH_TCLSH do
>
> AC_PATH_PROGS(TCLSH, [tclsh tcl tclsh8.5 tclsh8.4 tclsh8.3])
>
> or some such.
Applied.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 suppo
Hello,
I read the archives, but I can't find the instructions for adding new
catalogs to the system.
Where can I find those instructions? Is there a document about this?
Thanks,
Gustavo.
P.S: Please CC to me on reply
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
Alvaro Herrera wrote:
> Applied.
I forgot to mention that I renamed the sort_end probe to sort_done, to
keep the naming convention. It is a backwards-incompatible change, but
there were plenty other probes renamed so my guess is that one more does
not matter all that much.
Also, it seems I cann
Robert Lor wrote:
> I made some changes to the sed script so it works with the sed on
> Solaris & OS X. I tested this patch on both Solaris and OS X with DTrace
> enabled and disabled and also verified that the sed script works with
> GNU sed. I hope this is the final change for this patch.
"Tom Lane" <[EMAIL PROTECTED]> writes:
> typedef struct SortGroupClause
> {
> NodeTag type;
> Index tleSortGroupRef;/* reference into targetlist */
> Oid eqop; /* the equality operator ('=' op) */
> Oid sortop; /* the ordering
"Tom Lane" <[EMAIL PROTECTED]> writes:
> This is important for making the world safe for hashed DISTINCT, since
> AFAICS we probably can't ever use hashing for DISTINCT ON --- its definition
> is too dependent on the assumption of sorting.
I don't think that's true. We could store the sort key in
Tom Lane wrote:
> The fine manual claims that the "base dn" part of an LDAP URL
> is meaningful:
>
> The server will bind to the distinguished name specified as base
> dn using the user name supplied by the client. If prefix and
> suffix is specified, it will be prepended and app
Henry B. Hotz wrote:
>
> On Jul 31, 2008, at 7:58 AM, Magnus Hagander wrote:
>
>> Stephen Frost wrote:
>>> * Henry B. Hotz ([EMAIL PROTECTED]) wrote:
I'm making no promises, but what would people think of a hostgss hba
option?
>>>
>>> As described, sounds like a win to me. It'd be very
Hello,
I'd like to use NDirectFileRead and NDirectFileWrite statistics counters
for counting reads and writes in BufFile. They are defined, but not used
now. BufFile is used for tuple sorting or materializing, so we could use
NDirectFileRead/Write to retrieve how many I/Os are done in temp tablesp
32 matches
Mail list logo