Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: I am afraid the phrase "tab completion" is too complex for the type of people who need help. :-) Agreed, especially considering that it might be disabled depending on build and context. I think "Type help for help

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Tom Lane wrote: I'm not against shortening the banner. What I'm against is turning this thing into a camel (a horse designed by a committee). We should take one approach or the other one, not both. O.k. that makes sense. I have zero desire to take away from the work that Peter did. However,

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I am afraid the phrase "tab completion" is too complex for > > the type of people who need help. :-) > > Agreed, especially considering that it might be disabled depending > on build and context. > > I think "Type help for help." is

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Tom Lane
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > Peter's patch is certainly useful but this is something quite different > but affecting some of the same behavior. My idea is all about the 99% of > people that don't use a .psqlrc. Should we not provide a simpler > interface that provides succinct

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I am afraid the phrase "tab completion" is too complex for > the type of people who need help. :-) Agreed, especially considering that it might be disabled depending on build and context. I think "Type help for help." is *exactly* the right amount of d

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Yes, we could do that, but in our last discussion of help we didn't want > 'help' to do anything but print pointers to the correct commands. Yeah, but that discussion wasn't considering the context of shortening or eliminating the welcome banner. The id

Re: [HACKERS] How to submit a patch

2008-04-19 Thread Greg Smith
On Sat, 19 Apr 2008, Joshua D. Drake wrote: Greg Smith wrote: One small change I'd suggest on the main site: http://www.postgresql.org/developer/coding links to http://wiki.postgresql.org/wiki/Developer_and_Contributor_Resources which is now a redirect to the above page. This request shou

Re: [HACKERS] TODO, FAQs to Wiki?

2008-04-19 Thread Joshua D. Drake
Magnus Hagander wrote: Alvaro Herrera wrote: The FAQs are another matter however. I suggested some time back moving those to DocBook XML. A friend was working on a script to do the initial conversion automatically. The nice thing about it is that we can then use the xml2po tools to create PO

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Bruce Momjian wrote: Joshua D. Drake wrote: Actually in thinking about this more... I almost thing the default prompt should be: Does Win32 have tab completion? I am wondering if we should lose the tab and just print: I don't think it currently does but keep in mind that "most" windows us

Re: [HACKERS] TODO, FAQs to Wiki?

2008-04-19 Thread Alvaro Herrera
Magnus Hagander wrote: > Looking at the state of many of our non-english FAQs today, I don't put > too much faith into a system that'll just show people "this is not > translated". I think it's more likely to get better if the people can > just edit the translations directly instead of having to p

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Bruce Momjian
Joshua D. Drake wrote: > Actually in thinking about this more... I almost thing the default > prompt should be: > > - > psql version 8.2.7, server version 8.3.1 (some features may not work) > SSL: On {cert info} > Type help to get help (tab complete enabled) > - > > So on the prompt they can do:

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Bruce Momjian
Joshua D. Drake wrote: > > How about: > > > > \? for psql help, \h for SQL help > > \g or ';' to execute a query > > \q to quit > > > > This would be more in line with our current process sure. However > something a little more radical might be cool :) > > help > returns: > \

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
help returns: \g to execute query help psql for psql help help sql for sql help Of course we would keep the pre-existing key sequences for those of us that have done this for the last decade :) Actually in thinking about this more... I almost thing the default prompt should be:

Re: [HACKERS] TODO, FAQs to Wiki?

2008-04-19 Thread Magnus Hagander
Alvaro Herrera wrote: > The FAQs are another matter however. I suggested some time back > moving those to DocBook XML. A friend was working on a script to do > the initial conversion automatically. The nice thing about it is > that we can then use the xml2po tools to create PO files for > transl

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Bruce Momjian wrote: I realize that, but my point is that when they type 'help', they don't get help; they just get details on the help options, and then they get help. oh... hmpf. How about: \? for psql help, \h for SQL help \g or ';' to execute a query \q to quit

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > > I realize that, but my point is that when they type 'help', they don't > > get help; they just get details on the help options, and then they get > > help. > > So let's improve "help", For instance with an introductory text on the > difference o

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Alvaro Herrera
Bruce Momjian wrote: > I realize that, but my point is that when they type 'help', they don't > get help; they just get details on the help options, and then they get > help. So let's improve "help", For instance with an introductory text on the difference of psql commands and SQL commands. > H

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Bruce Momjian
Joshua D. Drake wrote: > Bruce Momjian wrote: > > > I am thinking 'help' is too much indirection for users -- it just tells > > them another command. How about: > > > > \g or ';' to execute a query\n" > > \? and \h for help > > \q to quit > > I have to disagree here. \h is completel

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Bruce Momjian wrote: I am thinking 'help' is too much indirection for users -- it just tells them another command. How about: \g or ';' to execute a query\n" \? and \h for help \q to quit I have to disagree here. \h is completely counterintuitive to a "user", let alo

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Bruce Momjian
Alvaro Herrera wrote: > Peter Eisentraut wrote: > > > --- 326,337 > > printf(_("Welcome to %s %s, the PostgreSQL > > interactive terminal.\n\n"), > >pset.progname, PG_VERSION); > > > > ! if (!(var_welcom

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Alvaro Herrera
Peter Eisentraut wrote: > --- 326,337 > printf(_("Welcome to %s %s, the PostgreSQL > interactive terminal.\n\n"), > pset.progname, PG_VERSION); > > ! if (!(var_welcome_message && > strcmp(var_welco

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Tom Lane wrote: Yes. Which was part of the discussion: ... a rejected part of the discussion, according to Peter's conclusion. Obviously not to others. It certainly doesn't make very much sense to do it in combination with this patch, since if the standard help text is cut to one line who's

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Tom Lane
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> So you're arguing to change the default. > Yes. Which was part of the discussion: ... a rejected part of the discussion, according to Peter's conclusion. It certainly doesn't make very much sense to do it in combination with this

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Bruce Momjian
Peter Eisentraut wrote: > Joshua D. Drake wrote: > > My thoughts are to have the initial prompt look something like this: > > > > -- > > psql 8.1.10 - Server version 8.2.7 (some features may not work) > > > > Type: \h for SQL help, \? for psql help, \q to quit > > > > SSL: On {cert info} > > -- >

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Peter Eisentraut wrote: Joshua D. Drake wrote: My thoughts are to have the initial prompt look something like this: -- psql 8.1.10 - Server version 8.2.7 (some features may not work) Type: \h for SQL help, \? for psql help, \q to quit SSL: On {cert info} -- I think the information that you

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Peter Eisentraut
Joshua D. Drake wrote: > My thoughts are to have the initial prompt look something like this: > > -- > psql 8.1.10 - Server version 8.2.7 (some features may not work) > > Type: \h for SQL help, \? for psql help, \q to quit > > SSL: On {cert info} > -- I think the information that you use \g or sem

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Tom Lane wrote: "Joshua D. Drake" <[EMAIL PROTECTED]> writes: My thoughts are to have the initial prompt look something like this: So you're arguing to change the default. Yes. Which was part of the discussion: http://archives.postgresql.org/pgsql-hackers/2008-04/msg01250.php http://archive

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Tom Lane
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > My thoughts are to have the initial prompt look something like this: So you're arguing to change the default. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your s

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Tom Lane wrote: "Joshua D. Drake" <[EMAIL PROTECTED]> writes: I would like to submit a further patch that has the one line screen (although I think it will be two), Um, what's the point? Someone who knows enough to set WELCOME_MESSAGE in ~/.psqlrc is unlikely to need a one-line help reminder,

Re: [HACKERS] TODO, FAQs to Wiki?

2008-04-19 Thread Pavel Stehule
Hello > > Magnus has started moving the Developer's FAQ to a wiki. I am thinking > we should move the main FAQ and the TODO list to a wiki as well if the > community is in agreement. > Czech translation of FAQ is on wiki one year - and it's much more maintainable than HTML. http://www.pgsql.cz

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Tom Lane
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > I would like to submit a further patch that has the one line screen > (although I think it will be two), Um, what's the point? Someone who knows enough to set WELCOME_MESSAGE in ~/.psqlrc is unlikely to need a one-line help reminder, so I don't see

Re: [HACKERS] TODO, FAQs to Wiki?

2008-04-19 Thread Joshua D. Drake
Bruce Momjian wrote: The FAQs are another matter however. I suggested some time back moving those to DocBook XML. A friend was working on a script to do the initial conversion automatically. The nice thing about it is that we can then use the xml2po tools to create PO files for translation.

Re: [HACKERS] TODO, FAQs to Wiki?

2008-04-19 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > I am impressed at the state of the May wiki patch queue: > > > > http://wiki.postgresql.org/wiki/CommitFest:May > > > > It is even tracking the psql wrap patch I am working on now. > > Thanks. We've put a certain amount of effort on it. Cred

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Joshua D. Drake
Tom Lane wrote: Peter Eisentraut <[EMAIL PROTECTED]> writes: I think everyone will find a mode they like here. +1. A marginal style suggestion: if you did var_welcome_message = GetVariable(pset.vars, "WELCOME_MESSAGE"); if (!var_welcome_message) var_welcome_me

Re: [HACKERS] TODO, FAQs to Wiki?

2008-04-19 Thread Alvaro Herrera
Bruce Momjian wrote: > I am impressed at the state of the May wiki patch queue: > > http://wiki.postgresql.org/wiki/CommitFest:May > > It is even tracking the psql wrap patch I am working on now. Thanks. We've put a certain amount of effort on it. Credit for the templating system goes to

[HACKERS] TODO, FAQs to Wiki?

2008-04-19 Thread Bruce Momjian
I am impressed at the state of the May wiki patch queue: http://wiki.postgresql.org/wiki/CommitFest:May It is even tracking the psql wrap patch I am working on now. Magnus has started moving the Developer's FAQ to a wiki. I am thinking we should move the main FAQ and the TODO list to a

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > I think everyone will find a mode they like here. +1. A marginal style suggestion: if you did var_welcome_message = GetVariable(pset.vars, "WELCOME_MESSAGE"); if (!var_welcome_message) var_welcome_message = ""; then

[HACKERS] TODO.detail removed

2008-04-19 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Log Message: > > --- > > Remove TODO.detail references; instead add TODO URLs pointing to the > > archives. We have been using URLs for a while for new items. > > Thanks, this was a good move. I should have done it a long time ago. I sta

Re: [HACKERS] How to submit a patch

2008-04-19 Thread Joshua D. Drake
Greg Smith wrote: On Wed, 16 Apr 2008, Heikki Linnakangas wrote: One small change I'd suggest on the main site: http://www.postgresql.org/developer/coding links to http://wiki.postgresql.org/wiki/Developer_and_Contributor_Resources which is now a redirect to the above page. This request

Re: [HACKERS] get rid of psql welcome message

2008-04-19 Thread Peter Eisentraut
Stephen Frost wrote: > I'd recommend an option in .psqlrc to disable it, if possible. That > would be in line with what alot of other "splash-screen" type things do. I like that idea. Here is a minimal patch that allows you to put \set WELCOME_MESSAGE none or \set WELCOME_MESSAGE terse into

Re: [HACKERS] How to submit a patch

2008-04-19 Thread Greg Smith
On Wed, 16 Apr 2008, Heikki Linnakangas wrote: Based on my observations, there's basically three different workflows a patch can follow (assuming the patch gets committed in the end) This list was so good that I used it as the basis for a new page on the wiki: http://wiki.postgresql.org/wiki