Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix free space map to correctly track the total amount of FSM

2007-10-03 Thread Tatsuo Ishii
> On Tue, Oct 02, 2007 at 09:07:54PM -0400, Alvaro Herrera wrote: > > Decibel! wrote: > > > > > Hrm... what about adding output to vacuum verbose that indicates how many > > > pages in a relation have free space? That would allow something like > > > pgfouine to see how many FSM pages were neede

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix free space map to correctly track the total amount of FSM

2007-10-03 Thread Decibel!
On Tue, Oct 02, 2007 at 09:07:54PM -0400, Alvaro Herrera wrote: > Decibel! wrote: > > > Hrm... what about adding output to vacuum verbose that indicates how many > > pages in a relation have free space? That would allow something like > > pgfouine to see how many FSM pages were needed. It would

[HACKERS] Not *quite* there on ecpg fixes

2007-10-03 Thread Tom Lane
Buildfarm member brown_bat (cygwin/gcc) still isn't happy: gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -g -I../include -I../../../../src/interfaces/ecpg/include -I../../../../src/include/utils -I../../../../src/

Re: [HACKERS] Use of "postmaster"

2007-10-03 Thread Brendan Jurd
On 10/4/07, Tom Lane <[EMAIL PROTECTED]> wrote: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: > > Now that we've renamed the server binary to "postgres", what is the > > status on use of the name "postmaster"? Is it now deprecated? And if > > not, is there any point in keeping it around? > > We sh

Re: [HACKERS] Use of "postmaster"

2007-10-03 Thread Ron Mayer
Brendan Jurd wrote: > Seems it would be best to apply this > nomenclature consistently, and simply drop the name "postmaster" from > use. > +1 I agree the term postmaster references in the docs, etc should go away - with perhaps the exception of one faq that say that postmaster's a deprecated na

Re: [HACKERS] Getting to 8.3 beta1

2007-10-03 Thread Tom Lane
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > Alvaro Herrera wrote: >> Too late. Tom already did a lot of the work. See >> http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release.sgml?r1=1.508&r2=1.509 > Right... I believe... that was first run though, at which point he asked > f

Re: [HACKERS] First steps with 8.3 and autovacuum launcher

2007-10-03 Thread Alvaro Herrera
I came up with the following patch. What this does is cancel any ANALYZE started by autovacuum, at the top of ALTER TABLE. There is a new function relation_openrv_cav(). This is the same as relation_openrv, except that it will also cancel analyzes. I'm still wondering if I should merge the two

Re: [HACKERS] Use of "postmaster"

2007-10-03 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > Now that we've renamed the server binary to "postgres", what is the > status on use of the name "postmaster"? Is it now deprecated? And if > not, is there any point in keeping it around? I'm certainly not for removing the term from either the code or

[HACKERS] Use of "postmaster"

2007-10-03 Thread Brendan Jurd
Now that we've renamed the server binary to "postgres", what is the status on use of the name "postmaster"? Is it now deprecated? And if not, is there any point in keeping it around? I've come across the occasional reference to "postmaster" in the FAQs and I was thinking that this would confuse

Re: [HACKERS] Getting to 8.3 beta1

2007-10-03 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alvaro Herrera wrote: > Joshua D. Drake wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Greg Smith wrote: >>> On Thu, 27 Sep 2007, Tom Lane wrote: >>> Also, I spent a dreary two or three hours this afternoon examining the CVS

Re: [HACKERS] Getting to 8.3 beta1

2007-10-03 Thread Alvaro Herrera
Joshua D. Drake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Greg Smith wrote: > > On Thu, 27 Sep 2007, Tom Lane wrote: > > > >> Also, I spent a dreary two or three hours this afternoon examining the > >> CVS commit logs since 8.3 branched...I tried to post that info to > >> pgsql

Re: [HACKERS] Getting to 8.3 beta1

2007-10-03 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Greg Smith wrote: > On Thu, 27 Sep 2007, Tom Lane wrote: > >> Also, I spent a dreary two or three hours this afternoon examining the >> CVS commit logs since 8.3 branched...I tried to post that info to >> pgsql-docs but it broke the list's message siz

Re: [HACKERS] ECPG regression tests

2007-10-03 Thread Andrew Dunstan
Magnus Hagander wrote: Bingo. With that, all the ECPG regression tests now pass on MSVC builds. Andrew - please enable it for the buildfarm :-) Yes, when I have had a chance to test it. Might be a day or so. cheers andrew ---(end of broadcast)

Re: [HACKERS] First steps with 8.3 and autovacuum launcher

2007-10-03 Thread Alvaro Herrera
Alvaro Herrera escribió: > I think this is doable. We would need to add a phase 0 to ALTER TABLE > processing, which grabs a less strong (than AccessExclusive) lock on the > table, then goes over the list of commands and determine if at least one > of them requires exclusive access to the table (

Re: [HACKERS] First steps with 8.3 and autovacuum launcher

2007-10-03 Thread Alvaro Herrera
Tom Lane escribió: > >> It might be possible to solve this if we reduce the strength of the lock > >> used for ALTER TABLE. We'd have to go through all the commands > >> potentially issued by a pg_dump script and see if they could all be made > >> to run concurrently with autovac, which is a bit

Re: [HACKERS] [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL

2007-10-03 Thread Magnus Hagander
On Tue, Oct 02, 2007 at 10:04:19AM -0400, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > >> I thought of a compromise. We can put back a check if the file exists > >> without using bio. That would cover some 99 percent of the messages coming > >> out of that > >> routine, I bet.

Re: [HACKERS] ECPG regression tests

2007-10-03 Thread Michael Meskes
On Wed, Oct 03, 2007 at 02:34:59PM +0200, Magnus Hagander wrote: > With that, all the ECPG regression tests now pass on MSVC builds. Great! Thanks a lot for your help Magnus. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) ICQ: 179140304, AI

Re: [HACKERS] ECPG regression tests

2007-10-03 Thread Magnus Hagander
On Wed, Oct 03, 2007 at 02:12:50PM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 01:54:50PM +0200, Magnus Hagander wrote: > > Getting much further now - now they all build :-) But I'm getting a couple > > of failures in autoprep and oldexec. Diffs attached. > > > > Pointers? > > Looks l

Re: [HACKERS] ECPG regression tests

2007-10-03 Thread Michael Meskes
On Wed, Oct 03, 2007 at 01:54:50PM +0200, Magnus Hagander wrote: > Getting much further now - now they all build :-) But I'm getting a couple > of failures in autoprep and oldexec. Diffs attached. > > Pointers? Looks like we're almost there. oldexec needs the additional option "-r questionmarks

[HACKERS] ECPG regression tests

2007-10-03 Thread Magnus Hagander
Getting much further now - now they all build :-) But I'm getting a couple of failures in autoprep and oldexec. Diffs attached. Pointers? //Magnus *** ./expected/preproc-autoprep.stderr 2007-10-01 10:57:37.532045600 +0200 --- ./results/preproc-autoprep.stderr 2007-10-03 13:53:13.898609200 +0

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-03 Thread Trevor Talbot
Note that unless there's some tools issue, DllMain doesn't need to be exported to function properly. A DLL's initialization routine is marked as the entry point in the PE header, same as main() in classic C. It might be simpler to just get rid of the export. ---(end of br

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-03 Thread Magnus Hagander
On Wed, Oct 03, 2007 at 09:35:51AM +0200, Hannes Eder wrote: > Magnus Hagander schrieb: > >>>Since this is an actual API library, perhaps a proper fix is to create a > >>>.def file listing the exports in it, the same way we do for libpq? And > >>>then > >>>we could (should!) also filter the export

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-03 Thread Hannes Eder
Magnus Hagander schrieb: Since this is an actual API library, perhaps a proper fix is to create a .def file listing the exports in it, the same way we do for libpq? And then we could (should!) also filter the exports the same ways as we do for libpq these days. (see the exports.txt file in libpq