Re: [HACKERS] contrib regression failures after recent money type changes

2007-01-02 Thread Tom Lane
Jeremy Drake <[EMAIL PROTECTED]> writes: > Seems that the contrib regression tests, namely the cash and oid tests of > the btree_gist contrib module, are failing after the recent commit to > widen the money type to 64 bits. Between D'Arcy and Bruce, there is not *any* buildfarm member passing toni

Re: [HACKERS] contrib regression failures after recent money type

2007-01-02 Thread Jeremy Drake
On Tue, 2 Jan 2007, Jeremy Drake wrote: > Seems that the contrib regression tests, namely the cash and oid tests of > the btree_gist contrib module, are failing after the recent commit to > widen the money type to 64 bits. Example: > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoose&dt=2

[HACKERS] contrib regression failures after recent money type changes

2007-01-02 Thread Jeremy Drake
Seems that the contrib regression tests, namely the cash and oid tests of the btree_gist contrib module, are failing after the recent commit to widen the money type to 64 bits. Example: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoose&dt=2007-01-03%2005:30:01 Also, on a slightly off-top

Re: [HACKERS] Loose ends in PG XML patch

2007-01-02 Thread Christopher Kings-Lynne
* Shouldn't the xml type support binary I/O? Right now it is the only standard datatype that doesn't. I have no idea whether there is an appropriate representation besides text, but if not we could define the binary representation to be the same as text. There is an effort to develop a binary

Re: [HACKERS] Sync Scan update

2007-01-02 Thread Jim C. Nasby
On Tue, Jan 02, 2007 at 09:48:22AM -0800, Jeff Davis wrote: > On Sat, 2006-12-30 at 13:35 -0600, Jim C. Nasby wrote: > > > My current implementation relies on the scans to stay close together > > > once they start close together. If one falls seriously behind, it will > > > fall outside of the main

Re: [HACKERS] WITH support

2007-01-02 Thread Jonah H. Harris
On 12/30/06, Mark Cave-Ayland <[EMAIL PROTECTED]> wrote: In short, if people don't mind waiting for my free cycles to come along then I will continue to chip away at it; otherwise if it's considered an essential for 8.3 with an April deadline then I will happily hand over to Jonah. I'd say it's

Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

2007-01-02 Thread Tom Lane
Bill Moran <[EMAIL PROTECTED]> writes: > In response to Alvaro Herrera <[EMAIL PROTECTED]>: >> Please change things to save the stat() syscall when the feature is not >> in use. > Do you have a suggestion on how to do that and still have the PG_TRACE1() > work? That was specifically requested by

Re: [HACKERS] SearchSysCache

2007-01-02 Thread Tom Lane
uwcssa <[EMAIL PROTECTED]> writes: > My program (indirectly) calls the following function twice, > tuple = SearchSysCache(STATRELATT, ObjectIdGetDatum(relid), > Int16GetDatum(colnum), 0, 0); > The first time it assigns NULL to tuple, while the second time it > assigns a valid pointer. Why is it li

[HACKERS] SearchSysCache

2007-01-02 Thread uwcssa
My program (indirectly) calls the following function twice, tuple = SearchSysCache(STATRELATT, ObjectIdGetDatum(relid), Int16GetDatum(colnum), 0, 0); The first time it assigns NULL to tuple, while the second time it assigns a valid pointer. Why is it like that? BTW, my program only optimize q

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread David Boreham
Martijn van Oosterhout wrote: - Thread safety (GnuTLS is thread-safe by design, no locks needed) - Proper layering (creating your own I/O function is trivial) - Seperate namespace - Non-blocking support from the get-go were taken care of. Since people are citing maintainability as a concern, I

[HACKERS] Upcoming back-branch releases

2007-01-02 Thread Tom Lane
It seems to be about time to put out 8.2.1, since the flow of new bug reports has ebbed. We're also overdue for updates of the back branches --- for instance, we recently realized that the current 8.0.x and 8.1.x releases don't know about the Canadian DST changes coming into effect in March, and t

Re: [HACKERS] [PATCHES] xlog directory at initdb time

2007-01-02 Thread Alvaro Herrera
Tom Lane wrote: > Casey Duncan <[EMAIL PROTECTED]> writes: > > I guess the downside there is that it won't work on platforms that > > don't support symlinks, whereas the postmaster switch would. Not that > > I condone using such platforms ;^) > > Well, we already bit that bullet with respect t

Re: [HACKERS] [PATCHES] xlog directory at initdb time

2007-01-02 Thread Tom Lane
Casey Duncan <[EMAIL PROTECTED]> writes: > I guess the downside there is that it won't work on platforms that > don't support symlinks, whereas the postmaster switch would. Not that > I condone using such platforms ;^) Well, we already bit that bullet with respect to tablespaces, and haven't g

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Stephen Frost
* Andrew Dunstan ([EMAIL PROTECTED]) wrote: > Bruce Momjian wrote: > >Keep in mind in most cases OpenSSL is already part of the operating > >system, unless you are using Win32. > > My understanding is that the Debian people are saying the exception for > libraries shipped with the OS does NOT app

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Andrew Dunstan
Bruce Momjian wrote: Keep in mind in most cases OpenSSL is already part of the operating system, unless you are using Win32. My understanding is that the Debian people are saying the exception for libraries shipped with the OS does NOT apply to *other* libraries or programs that are shipp

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Stephen Frost
* Bruce Momjian ([EMAIL PROTECTED]) wrote: > Stephen Frost wrote: > > Ah, this does sound rather ugly and not something we'd want. The > > particular library doesn't make a whole heck of alot of difference to me > > provided it has the general functionality necessary and a compatible > > license (

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Martijn van Oosterhout
On Tue, Jan 02, 2007 at 01:29:35PM -0500, Stephen Frost wrote: > Would a patch to implement dual-support for OpenSSL and NSS be > acceptable? Would just replacing OpenSSL support with NSS support be When I was looking into this I looked at NSS, and eventually decided on GnuTLS. Why? Because I rea

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Bruce Momjian
Stephen Frost wrote: -- Start of PGP signed section. > * David Boreham ([EMAIL PROTECTED]) wrote: > > Stephen Frost wrote: > > >erm, I'm not really sure what you're saying here but perhaps I can > > >clarify: I wasn't suggesting to add any serious amount of source code > > >to PostgreSQL - NSS wou

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Stephen Frost
* David Boreham ([EMAIL PROTECTED]) wrote: > Stephen Frost wrote: > >erm, I'm not really sure what you're saying here but perhaps I can > >clarify: I wasn't suggesting to add any serious amount of source code > >to PostgreSQL - NSS would be used just as OpenSSL is today, and as > >GNUTLS support

Re: [HACKERS] [PATCHES] xlog directory at initdb time

2007-01-02 Thread Casey Duncan
On Jan 2, 2007, at 7:18 AM, Tom Lane wrote: Peter Eisentraut <[EMAIL PROTECTED]> writes: Am Mittwoch, 27. Dezember 2006 02:56 schrieb Euler Taveira de Oliveira: This simple patch lets someone specifies the xlog directory at initdb time. It uses symlinks to do it, and create and/or set per

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread David Boreham
Stephen Frost wrote: Also, do we really want to import the NSPR into Postgres? I suspect not. Of course, the only thing that people are tripping over license-wise is libpq. But I think we would want to keep that as lean and mean as possible, too. erm, I'm not really sure what you're say

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Stephen Frost
* David Boreham ([EMAIL PROTECTED]) wrote: > Andrew Dunstan wrote: > > >I suspect most postgres developers and companies would like to keep > >things as BSDish as possible. > > Right, hence OpenSSL would be the obvious best choice. > In respect of licencing however, NSS is no 'worse' than GNU T

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Stephen Frost
* Andrew Dunstan ([EMAIL PROTECTED]) wrote: > I suspect most postgres developers and companies would like to keep > things as BSDish as possible. Dealing with a multitude of licenses might > be fun for some, but many of us find it a pain in the neck. It'd be great if PostgreSQL could use an SSL

Re: [HACKERS] 8.2 Crash on Query

2007-01-02 Thread Tom Lane
"D. Hageman" writes: > I have been able to crash the database consistently on a Fedora Core 5 > machine running postgresql 8.2.0. Yeah, LIMIT ALL is known broken in 8.2.0 :-(. It's been fixed for awhile, will be in 8.2.1. regards, tom lane ---(e

Re: [HACKERS] Rare corruption of pg_class index

2007-01-02 Thread Tom Lane
"Greg Sabino Mullane" <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Oh! Duh, that's your issue right there, I'll bet. The problem is that >> relcache-open tries to read the pg_class row under SnapshotNow rules, >> and if there is another xact concurrently modifying the row, it is >> entirely p

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread David Boreham
Andrew Dunstan wrote: I suspect most postgres developers and companies would like to keep things as BSDish as possible. Right, hence OpenSSL would be the obvious best choice. In respect of licencing however, NSS is no 'worse' than GNU TLS because it may be distributed under the GPL and LGPL.

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Lukas Kahwe Smith
Tom Lane wrote: Lukas Kahwe Smith <[EMAIL PROTECTED]> writes: Err, I think you misunderstood what I said. My implementation uses SAVEPOINTs already. The point is having some API where you do not have to care of you are already in a transaction or not. It's not that hard, is it? if (P

Re: [HACKERS] [PATCHES] xlog directory at initdb time

2007-01-02 Thread Bruce Momjian
Tom Lane wrote: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > Am Mittwoch, 27. Dezember 2006 02:56 schrieb Euler Taveira de Oliveira: > >> This simple patch lets someone specifies the xlog directory at initdb > >> time. It uses symlinks to do it, and create and/or set permissions at > >> the d

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Also, do we really want to import the NSPR into Postgres? I suspect not. > Of course, the only thing that people are tripping over license-wise is > libpq. But I think we would want to keep that as lean and mean as > possible, too. Yeah, requiring NS

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread David Boreham
Stephen Frost wrote: * David Boreham ([EMAIL PROTECTED]) wrote: Stephen Frost wrote: Not sure what license that's under, From http://www.mozilla.org/projects/security/pki/nss/: 'NSS is available under the Mozilla Public License, the GNU General Public License, and the GNU Les

[HACKERS] 8.2 Crash on Query

2007-01-02 Thread D. Hageman
I have been able to crash the database consistently on a Fedora Core 5 machine running postgresql 8.2.0. The attached files are an example database (crash.shema) and the query that is used (crash.sql) as well as the log output from turning on all the debugging (crash.log). I have a couple

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Andrew Dunstan
David Boreham wrote: Stephen Frost wrote: * David Boreham ([EMAIL PROTECTED]) wrote: Fascinating thread for the holidays. I found it interesting that nobody has mentioned NSS (former Netscape SSL library). It has its own bag of problems of course, but for me is potentially more attractive

Re: [HACKERS] Rare corruption of pg_class index

2007-01-02 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tom Lane wrote: > Oh! Duh, that's your issue right there, I'll bet. The problem is that > relcache-open tries to read the pg_class row under SnapshotNow rules, > and if there is another xact concurrently modifying the row, it is > entirely possible

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread Stephen Frost
* David Boreham ([EMAIL PROTECTED]) wrote: > Stephen Frost wrote: > >Not sure what license that's under, > > > From http://www.mozilla.org/projects/security/pki/nss/: > 'NSS is available under the Mozilla Public License, the GNU General > Public License, and the GNU Lesser General Public License.'

Re: [HACKERS] TODO: GNU TLS

2007-01-02 Thread David Boreham
Stephen Frost wrote: * David Boreham ([EMAIL PROTECTED]) wrote: Fascinating thread for the holidays. I found it interesting that nobody has mentioned NSS (former Netscape SSL library). It has its own bag of problems of course, but for me is potentially more attractive than GNU TLS. e.g. it

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Gurjeet Singh
On 1/2/07, Joshua D. Drake <[EMAIL PROTECTED]> wrote: E.g., no GUC parameter. Just change the behavior or don't. Please refer the conversation beginning at: http://archives.postgresql.org/pgsql-hackers/2006-05/msg00249.php That is where this TODO item came from. In the conversation, it was u

Re: [HACKERS] Sync Scan update

2007-01-02 Thread Jeff Davis
On Sat, 2006-12-30 at 13:35 -0600, Jim C. Nasby wrote: > > My current implementation relies on the scans to stay close together > > once they start close together. If one falls seriously behind, it will > > fall outside of the main "cache trail" and cause the performance to > > degrade due to disk

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Tom Lane
Lukas Kahwe Smith <[EMAIL PROTECTED]> writes: > Err, I think you misunderstood what I said. My implementation uses > SAVEPOINTs already. The point is having some API where you do not have > to care of you are already in a transaction or not. It's not that hard, is it? if (PQtransactionS

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Joshua D. Drake
On Tue, 2007-01-02 at 11:53 +0100, Peter Eisentraut wrote: > Am Donnerstag, 28. Dezember 2006 18:57 schrieb Bruce Momjian: > > I think you can make the case that this should be an error, or at least > > that's how it got on the TODO list. I can always remove it if people > > don't want the item co

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Lukas Kahwe Smith
Alvaro Herrera wrote: news.postgresql.org wrote: While we are on the topic, I have implemented a poor mans nested transaction feature into my database access layer. essentially subsequent calls to begin a transaction after the initial begin simply increase an internal counter and set a savepo

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Alvaro Herrera
news.postgresql.org wrote: > While we are on the topic, I have implemented a poor mans nested > transaction feature into my database access layer. essentially > subsequent calls to begin a transaction after the initial begin simply > increase an internal counter and set a savepoint. as you comm

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread news.postgresql.org
Tom Lane wrote: Peter Eisentraut <[EMAIL PROTECTED]> writes: Am Donnerstag, 28. Dezember 2006 18:57 schrieb Bruce Momjian: I think you can make the case that this should be an error, or at least that's how it got on the TODO list. I can always remove it if people don't want the item completed.

Re: [HACKERS] effective_cache_size vs units

2007-01-02 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Am Donnerstag, 28. Dezember 2006 13:25 schrieb Jim C. Nasby: >> Yes, and I can't think of a single reason why we'd let people specify >> anything in millibytes, or kilobits. > How about a configuration option related to connection throughput, which is

Re: [HACKERS] [PATCHES] xlog directory at initdb time

2007-01-02 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Am Mittwoch, 27. Dezember 2006 02:56 schrieb Euler Taveira de Oliveira: >> This simple patch lets someone specifies the xlog directory at initdb >> time. It uses symlinks to do it, and create and/or set permissions at >> the directory as appropriate.

Re: [HACKERS] Reverse-sort indexes and NULLS FIRST/LAST sorting

2007-01-02 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas <[EMAIL PROTECTED]> writes: I'd like to see this implemented with more general collation support in mind. I'm really not prepared to buy into that, simply because it puts ICU or some equivalent large chunk of new code into the critical path to finish what I'm

Re: [HACKERS] Status of Fix Domain Casting TODO

2007-01-02 Thread Andrew Dunstan
Jim C. Nasby wrote: On Mon, Jan 01, 2007 at 06:30:40PM -0600, Andrew Dunstan wrote: Tom Lane wrote: "Jim C. Nasby" <[EMAIL PROTECTED]> writes: FWIW, I'm running into this trying to create a 'raw' domain that would automagically convert hex strings into actual binary data for sto

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Am Donnerstag, 28. Dezember 2006 18:57 schrieb Bruce Momjian: >> I think you can make the case that this should be an error, or at least >> that's how it got on the TODO list. I can always remove it if people >> don't want the item completed. > The r

Re: [HACKERS] Reverse-sort indexes and NULLS FIRST/LAST sorting

2007-01-02 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > I'd like to see this implemented with more general collation support in > mind. I'm really not prepared to buy into that, simply because it puts ICU or some equivalent large chunk of new code into the critical path to finish what I'm doing. The fa

Re: [HACKERS] Reverse-sort indexes and NULLS FIRST/LAST sorting

2007-01-02 Thread Tom Lane
Martijn van Oosterhout writes: > Issues which you havn't addressed are: > - Pathkeys: How is the forward/reverse/nulls first/last going to be > encoded in the pathkey? I'm envisioning a struct with operator OID and null-ordering flag. If we implement the explicit REVERSE variant then we'd have t

Re: [HACKERS] float8 width_bucket function

2007-01-02 Thread Neil Conway
Jeremy Drake said: > http://momjian.us/mhonarc/patches_hold/msg00162.html > > There is no patch or anything associated with it, just the > suggestion that it be put in when 8.3 devel starts up. Right -- this is on my TODO list for 8.3. I'm traveling at the moment, but I can send a patch for this i

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Peter Eisentraut
Am Donnerstag, 28. Dezember 2006 18:57 schrieb Bruce Momjian: > I think you can make the case that this should be an error, or at least > that's how it got on the TODO list. I can always remove it if people > don't want the item completed. The reason this was added is that modular applications ex

Re: [HACKERS] TODO: Add a GUC to control whether BEGIN inside

2007-01-02 Thread Peter Eisentraut
Am Donnerstag, 28. Dezember 2006 19:52 schrieb Tom Lane: > Not only is it overzealous, but the proposal to have one reflects a > failure to learn from history. GUC variables that change > transaction-boundary semantics are a bad idea, period: see autocommit. But this option would not, in fact, ch

Re: [HACKERS] effective_cache_size vs units

2007-01-02 Thread Peter Eisentraut
Am Donnerstag, 28. Dezember 2006 13:25 schrieb Jim C. Nasby: > Yes, and I can't think of a single reason why we'd let people specify > anything in millibytes, or kilobits. How about a configuration option related to connection throughput, which is typically measured in bits? -- Peter Eisentraut

Re: [HACKERS] [PATCHES] xlog directory at initdb time

2007-01-02 Thread Peter Eisentraut
Am Mittwoch, 27. Dezember 2006 02:56 schrieb Euler Taveira de Oliveira: > This simple patch lets someone specifies the xlog directory at initdb > time. It uses symlinks to do it, and create and/or set permissions at > the directory as appropriate. We already had this functionality in initdb a few

Re: [HACKERS] Loose ends in PG XML patch

2007-01-02 Thread Peter Eisentraut
Am Sonntag, 24. Dezember 2006 02:44 schrieb Tom Lane: > * Isn't mapping XMLSERIALIZE to a cast completely wrong? Aside from > the issue already noted in the code that it won't reverse-list > correctly, this loses the DOCUMENT-vs-CONTENT flag, which I suppose > must be important. It is important,

Re: [HACKERS] Reverse-sort indexes and NULLS FIRST/LAST sorting

2007-01-02 Thread Heikki Linnakangas
I'd like to see this implemented with more general collation support in mind. In general, each index column can be ordered by one collation. A query matching the index collation can use the index directly, a query asking for another collation needs to convert. The trivial way to convert from

Re: [HACKERS] Status of Fix Domain Casting TODO

2007-01-02 Thread Jim C. Nasby
On Mon, Jan 01, 2007 at 06:30:40PM -0600, Andrew Dunstan wrote: > Tom Lane wrote: > > "Jim C. Nasby" <[EMAIL PROTECTED]> writes: > >> FWIW, I'm running into this trying to create a 'raw' domain that would > >> automagically convert hex strings into actual binary data for storage in > >> a bytea. >

Re: [HACKERS] Reverse-sort indexes and NULLS FIRST/LAST sorting

2007-01-02 Thread Martijn van Oosterhout
On Mon, Jan 01, 2007 at 05:53:35PM -0500, Tom Lane wrote: > The SQL2003 spec adds optional "NULLS FIRST" and "NULLS LAST" modifiers > for ORDER BY clauses. Teodor proposed an implementation here: > http://archives.postgresql.org/pgsql-patches/2006-12/msg00019.php > which I didn't care for at all: