Re: [HACKERS] Google SoC--Idea Request

2006-04-20 Thread Christopher Kings-Lynne
I think Martin Oosterhout's nearby email on coverity bug reports might make a good SoC project, but should it also be added to the TODO list? I may as well put up phpPgAdmin for it. We have plenty of projects available in phpPgAdmin... Chris ---(end of broadcast)--

Re: [HACKERS] Checking assumptions

2006-04-20 Thread Christopher Kings-Lynne
I havn't been able to find any more serious issues in the Coverity report, now that they've fixed the ereport() issue. A number of the issues it complains about are things we already Assert() for. For the rest, as long as the following assumptions are true we're done (well, except for ECPG). I thi

[HACKERS] UPDATE on many-column tables (was Re: [PERFORM] Performance decrease)

2006-04-20 Thread Tom Lane
"Radovan Antloga" <[EMAIL PROTECTED]> writes: >> 190 fields in a table seems like rather a lot ... is that actually >> representative of your intended applications? > Test table is like table I use in production > with Firebird and Oracle db. Table has a lot of smallint > and integer fields. I di

Re: [HACKERS] Google SoC--Idea Request

2006-04-20 Thread Martijn van Oosterhout
On Sat, Apr 15, 2006 at 03:05:20PM -0400, Jonah H. Harris wrote: > Hey everyone, > > I know we started a discussion a month or so ago regarding ideas for > SoC projects. However, after reading through the thread, I didn't see > us nail down any actual items. Here's an idea: Get the ECPG test pro

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Bort, Paul
Some of the SysInternals tools might be a start. ProcessExplorer provides information about processes: http://www.sysinternals.com/Utilities/ProcessExplorer.html DebugView shows Debugging output (not sure if PG uses this): http://www.sysinternals.com/Utilities/DebugView.html Also, I haven't use

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Jim C. Nasby
On Thu, Apr 20, 2006 at 02:17:35PM -0500, Larry Rosenman wrote: > > It seems to hang up just fine on my XPSP2, PG 8.1.2 HTT box. > > > > :( > > > > LER > > I may have spoken too soon :( I took a look and in fact the machine was just disk bound, so it appears that either HT doesn't exhibit this

Re: [HACKERS] TODO item pg_hba.conf

2006-04-20 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > It should be easy to make this code understand a new privilege type. Another point worth making: most of the actual patch will probably consist of teaching the ACL datatype code about another possible bit-value in ACL masks. A lot of the generic GRANT/

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Larry Rosenman
Larry Rosenman wrote: > Jim C. Nasby wrote: >> On Thu, Apr 20, 2006 at 08:06:30PM +0200, Magnus Hagander wrote: >>> It reuqires a multi-CPU box, right? I don't hav eone with pgwin32 on >>> ATM. Do you know if it's enough with hyperthreading? >> >> Hrm... not sure. Let me see if I can find a box wi

Re: [HACKERS] TODO item pg_hba.conf

2006-04-20 Thread Gevik Babakhani
Cool :) Thank you :) On Thu, 2006-04-20 at 15:05 -0400, Alvaro Herrera wrote: > Gevik Babakhani wrote: > > > > I'm not sure if you realize it, but this should be an extremely small > > > patch. In particular, if you think you need to change the parser then > > > you are already off on the wrong

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Larry Rosenman
Jim C. Nasby wrote: > On Thu, Apr 20, 2006 at 08:06:30PM +0200, Magnus Hagander wrote: >> It reuqires a multi-CPU box, right? I don't hav eone with pgwin32 on >> ATM. Do you know if it's enough with hyperthreading? > > Hrm... not sure. Let me see if I can find a box with HT here and test > it. Run

Re: [HACKERS] TODO item pg_hba.conf

2006-04-20 Thread Alvaro Herrera
Gevik Babakhani wrote: > > I'm not sure if you realize it, but this should be an extremely small > > patch. In particular, if you think you need to change the parser then > > you are already off on the wrong track. The parser doesn't know > > anything about specific privilege types (as of 8.1 an

Re: [HACKERS] TODO item pg_hba.conf

2006-04-20 Thread Gevik Babakhani
On Thu, 2006-04-20 at 14:14 -0400, Tom Lane wrote: > "Gevik Babakhani" <[EMAIL PROTECTED]> writes: > > Would it be correct to state that: only the authentication > > is checked (username and password) when connecting to the > > server and not the any kind of privilege to access a database. > > Wel

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Jim C. Nasby
On Thu, Apr 20, 2006 at 08:06:30PM +0200, Magnus Hagander wrote: > It reuqires a multi-CPU box, right? I don't hav eone with pgwin32 on > ATM. Do you know if it's enough with hyperthreading? Hrm... not sure. Let me see if I can find a box with HT here and test it. Running the following batch file

Re: [HACKERS] Suggestion: Which Binary?

2006-04-20 Thread David Wheeler
On Apr 3, 2006, at 14:37, Tom Lane wrote: I would suggest handling this strictly as an addition to our installation.sgml docs. Finally got 'round to this. Patch attached. There are quite a few environment variables in the list that Peter sent to me that I know nothing about. These I've lis

Re: [HACKERS] TODO item pg_hba.conf

2006-04-20 Thread Tom Lane
"Gevik Babakhani" <[EMAIL PROTECTED]> writes: > Would it be correct to state that: only the authentication > is checked (username and password) when connecting to the > server and not the any kind of privilege to access a database. Well, that would be the typical usage, ie, people relying on CONNE

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Magnus Hagander
> > > pgbench) just stops doing work (CPU usage drops to > nothing, as does > > > disk activity). I've been able to repro this on 2 Intel > boxes (one a > > > 2 way, one a 4 way), and a dual Opteron, all running the > latest windows binary. > > > A 50 connection test running 1000 transactions

Re: [HACKERS] Google SoC--Idea Request

2006-04-20 Thread Jim C. Nasby
Another idea; add the ability for buildfarm machines to do a pgbench run to stress-test the code. Such a test would probably have found the windows pgbench issue I reported some time ago. This would have to be optional, as not all buildfarm machines/owners would tolerate the benchmark. -- Jim C.

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Tom Lane
Martijn van Oosterhout writes: > On Thu, Apr 20, 2006 at 12:17:07PM -0500, Jim C. Nasby wrote: >> Here's one to add to the list: running pgbench with a moderately heavy >> load on an SMP box likes to trigger a state where the database (or >> pgbench) just stops doing work (CPU usage drops to nothi

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Jim C. Nasby
On Thu, Apr 20, 2006 at 07:25:15PM +0200, Martijn van Oosterhout wrote: > On Thu, Apr 20, 2006 at 12:17:07PM -0500, Jim C. Nasby wrote: > > Here's one to add to the list: running pgbench with a moderately heavy > > load on an SMP box likes to trigger a state where the database (or > > pgbench) just

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> Apparently it won't work at all if TMP >> isn't set? > I'm not *too* concerned about that, since TMP is normally set by the OS > itself. There's one set in the "system environment" (to c:\windows\temp > or whatrever) and then it's overridden by one

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> > Ok. Should be easy enough once the code is fine - can you > comment on > > the patch as sent, if the code itself looks right provided > i wrap it > > up in a function in port/? > > Not sure if the error handling is adequate --- are there any > cases besides EEXIST that should loop? Well,

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Martijn van Oosterhout
On Thu, Apr 20, 2006 at 12:17:07PM -0500, Jim C. Nasby wrote: > Here's one to add to the list: running pgbench with a moderately heavy > load on an SMP box likes to trigger a state where the database (or > pgbench) just stops doing work (CPU usage drops to nothing, as does disk > activity). I've be

Re: [HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Jim C. Nasby
Here's one to add to the list: running pgbench with a moderately heavy load on an SMP box likes to trigger a state where the database (or pgbench) just stops doing work (CPU usage drops to nothing, as does disk activity). I've been able to repro this on 2 Intel boxes (one a 2 way, one a 4 way), and

Re: [HACKERS] Checking assumptions

2006-04-20 Thread Tom Lane
> Martijn van Oosterhout writes: >> src/backend/utils/adt/selfuncs.c function like_selectivity >> Assume this function is never called with a zero length bytea >> constant. It just looks wierd to set patt to NULL only to Assert() it >> three lines down. > This may be a real bug --- I'm not sure

Re: [HACKERS] float8 regression test failure in head

2006-04-20 Thread Tom Lane
Patrick Welche <[EMAIL PROTECTED]> writes: >>> canary, gazelle, and osprey all pass this test just fine. Before >>> accepting any patches in this area we'd better find out the difference >>> between the OP's netbsd system and those machines. > Quoting from my original post "NetBSD-3.99.17/i386" -

Re: [HACKERS] float8 regression test failure in head

2006-04-20 Thread Patrick Welche
On Thu, Apr 20, 2006 at 11:56:29AM -0400, Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Don't we have some of these platforms on the build farm. Are they > > > failing? > > > > canary, gazelle, and osprey all pass this test just fine. Before > > accepting any patches in

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Ok. Should be easy enough once the code is fine - can you comment on the > patch as sent, if the code itself looks right provided i wrap it up in a > function in port/? Not sure if the error handling is adequate --- are there any cases besides EEXIST

Re: [HACKERS] float8 regression test failure in head

2006-04-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Don't we have some of these platforms on the build farm. Are they > > failing? > > canary, gazelle, and osprey all pass this test just fine. Before > accepting any patches in this area we'd better find out the difference > between the OP's netbsd syst

Re: [HACKERS] Google SoC--Idea Request

2006-04-20 Thread Tom Lane
Martijn van Oosterhout writes: > About the only thing in the backend I found interesting was this: > src/backend/utils/hash/dynahash.c function hash_create I wonder if we shouldn't just remove the hash_destroy calls in hash_create's failure paths. hash_destroy is explicitly not gonna work on a s

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> > I have repeated the problem with CVS head on XP SP2. It > *does* create > > it there (or rather, it tries to). > > > tmpnam() returns a file in the current dir per documentation, but I > > see it generating one in the root instead. > > tempnam() uses TMP environment variable. > > > tmpfile

Re: [HACKERS] Google SoC--Idea Request

2006-04-20 Thread Martijn van Oosterhout
On Thu, Apr 20, 2006 at 11:04:31AM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > On Thu, Apr 20, 2006 at 08:51:25AM -0400, Robert Treat wrote: > >> I think Martin Oosterhout's nearby email on coverity bug reports might > >> make a > >> good SoC project, but should it also be added t

[HACKERS] TODO item pg_hba.conf

2006-04-20 Thread Gevik Babakhani
Hi, I read the discussion thread once again and unless I am absolutely and totally on the wrong track this is what I understood from the general plan to be. The current pg_hba.conf provides the famous the host based mechanism to connect to a database. In order to add the discussed functionality we

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > I have repeated the problem with CVS head on XP SP2. It *does* create it > there (or rather, it tries to). > tmpnam() returns a file in the current dir per documentation, but I see > it generating one in the root instead. > tempnam() uses TMP environ

Re: [HACKERS] Google SoC--Idea Request

2006-04-20 Thread Tom Lane
Martijn van Oosterhout writes: > On Thu, Apr 20, 2006 at 08:51:25AM -0400, Robert Treat wrote: >> I think Martin Oosterhout's nearby email on coverity bug reports might make a >> good SoC project, but should it also be added to the TODO list? > ... > In any case, after you weed out the false-posit

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> > If the implementation is such that it tries to create the file in a > > directory that the user does not have write permission to, > it's a bug. > > Well, I think it would be a valid implementation on Unix to > always try to create the file in /tmp, which'd likely fail if > someone had rev

Re: [HACKERS] Checking assumptions

2006-04-20 Thread Tom Lane
Martijn van Oosterhout writes: > randomAccess is set if EXEC_FLAG_BACKWARD is set, but does that > guarentee it will never be tried? If it were tried, that would be caller error. Think of it as an Assert ;-) > src/backend/optimizer/plan/planner.c function inheritance_planner=20 > If the b

Re: [HACKERS] float8 regression test failure in head

2006-04-20 Thread Tom Lane
Bruce Momjian writes: > Don't we have some of these platforms on the build farm. Are they > failing? canary, gazelle, and osprey all pass this test just fine. Before accepting any patches in this area we'd better find out the difference between the OP's netbsd system and those machines.

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Yoshiyuki Asaba
From: Tom Lane <[EMAIL PROTECTED]> Subject: Re: [HACKERS] pg_dump -Ft failed on Windows XP Date: Thu, 20 Apr 2006 10:00:48 -0400 > "Magnus Hagander" <[EMAIL PROTECTED]> writes: > >> Win32's tmpfile() creates the file into root folder. But > >> non-administrator users can't create files into root

Re: [HACKERS] please change url for czech postgresql site

2006-04-20 Thread Pavel Stehule
I think you mean "updated" not "actualized" right? In any case, I've changed the url in cvs, it should appear on the next site build. yes, I am sorry. Thank you btw, I hope that site is running postgresql as a backend :-) Not yet :-(. I had big problems get good free hosting with php5. A

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > If the implementation is such that it tries to create the file in a directory > that the user does not have write permission to, it's a bug. Well, I think it would be a valid implementation on Unix to always try to create the file in /tmp, which'd lik

Re: [HACKERS] Google SoC--Idea Request

2006-04-20 Thread Martijn van Oosterhout
On Thu, Apr 20, 2006 at 08:51:25AM -0400, Robert Treat wrote: > On Wednesday 19 April 2006 12:09, Jonah H. Harris wrote: > > On 4/19/06, John DeSoi <[EMAIL PROTECTED]> wrote: > > > Alvaro indicated he would be willing to provide direction on this > > > with testing support from me. He also said the

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> >> Win32's tmpfile() creates the file into root folder. But > >> non-administrator users can't create files into root folder. > > In other words, tmpfile() doesn't work at all on Win32? > Seems like the appropriate place to be filing a bug report is > at microsoft.com. If works if you're an

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> Win32's tmpfile() creates the file into root folder. But >> non-administrator users can't create files into root folder. In other words, tmpfile() doesn't work at all on Win32? Seems like the appropriate place to be filing a bug report is at micros

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> > It's not buggy. It's well documented behaviour,and per my linux > > manpage for the file it's also OK per spec: > > > >The standard does not specify the directory that tmpfile() > >will use. Glibc will try the path prefix P_tmpdir defined > >in , and if that fails the

Re: [HACKERS] please change url for czech postgresql site

2006-04-20 Thread Robert Treat
On Thursday 20 April 2006 03:40, Pavel Stehule wrote: > Hello, > > please change url on http://www.postgresql.org/community/international from > postgresql.ok.cz to http://postgresql.interweb.cz I actualized content for > 8.1 and migrated to wiki and new site. Older site exists still, but isn't > a

Re: [HACKERS] Google SoC--Idea Request

2006-04-20 Thread Robert Treat
On Wednesday 19 April 2006 12:09, Jonah H. Harris wrote: > On 4/19/06, John DeSoi <[EMAIL PROTECTED]> wrote: > > Alvaro indicated he would be willing to provide direction on this > > with testing support from me. He also said there are several other > > possible PL/PHP issues that would warrant a S

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Peter Eisentraut
Am Donnerstag, 20. April 2006 13:21 schrieb Magnus Hagander: > It's not buggy. It's well documented behaviour,and per my linux manpage > for the file it's also OK per spec: > >The standard does not specify the directory that tmpfile() >will use. Glibc will try the path prefix P_tmpd

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> > Question: Is the use of O_TEMPORARY to open() portable? (my > win32 docs > > say it will make the file automatically deleted when the last > > descriptor is closed, which I didn't know before. That > would make the > > patch much simpler, but might require #ifdefs?) > > I think it would b

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Peter Eisentraut
Am Donnerstag, 20. April 2006 13:03 schrieb Magnus Hagander: > Question: Is the use of O_TEMPORARY to open() portable? (my win32 docs > say it will make the file automatically deleted when the last descriptor > is closed, which I didn't know before. That would make the patch much > simpler, but mig

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> > > Indeed, that's definitly a bug. Quick patch attached. It > > does appear > > > to work, but there may be a better way? > > > > This patch introduces a security hole because an attacker could > > create, say, a suitable symlink between the time the name > is generated > > and the file is o

[HACKERS] Checking assumptions

2006-04-20 Thread Martijn van Oosterhout
I havn't been able to find any more serious issues in the Coverity report, now that they've fixed the ereport() issue. A number of the issues it complains about are things we already Assert() for. For the rest, as long as the following assumptions are true we're done (well, except for ECPG). I thin

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> > Indeed, that's definitly a bug. Quick patch attached. It > does appear > > to work, but there may be a better way? > > This patch introduces a security hole because an attacker > could create, say, a suitable symlink between the time the > name is generated and the file is opened. Good po

[HACKERS] Unresolved Win32 bug reports

2006-04-20 Thread Bruce Momjian
Folks, my mailbox is filling with unresolved Win32 bug reports, specifically: integer division shared memory statistics collector rename fsync I have put the emails at the bottom of the patches_hold queue: http://momjian.postgresql.org/cgi-bin/pgpa

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Peter Eisentraut
Am Donnerstag, 20. April 2006 10:47 schrieb Magnus Hagander: > Indeed, that's definitly a bug. Quick patch attached. It does appear to > work, but there may be a better way? This patch introduces a security hole because an attacker could create, say, a suitable symlink between the time the name i

Re: [HACKERS] float8 regression test failure in head

2006-04-20 Thread Bruce Momjian
Patrick Welche wrote: > On Mon, Mar 22, 2004 at 11:03:38PM -0500, Neil Conway wrote: > > Christopher Kings-Lynne wrote: > > >This has not yet been fixed... > > > > Attached is a patch for this issue. I've checked with Chris, and this > > patch allows the regression tests to pass on his machine. I

Re: [HACKERS] pg_dump -Ft failed on Windows XP

2006-04-20 Thread Magnus Hagander
> I got the following message when I ran pg_dump with -Ft > option on Windows XP. > > > pg_dump -V > pg_dump (PostgreSQL) 8.1.2 > > > pg_dump -Ft test > C:\backup\xxx.out > pg_dump: [tar archiver] could not generate temporary file > name: Permission denied > > > pg_dump calls tmpfile() in pg_

[HACKERS] please change url for czech postgresql site

2006-04-20 Thread Pavel Stehule
Hello, please change url on http://www.postgresql.org/community/international from postgresql.ok.cz to http://postgresql.interweb.cz I actualized content for 8.1 and migrated to wiki and new site. Older site exists still, but isn't actualized. Thank you Pavel Stehule ___

[HACKERS] pgfoundry - news - is working?

2006-04-20 Thread Pavel Stehule
Hello yesterday I did one news notice on my orafunc page. But it isn't on main page yet. Why? Can someboody explain mechanism of publishing messages on pgfoundry? Regards Pavel Stehule _ Citite se osamele? Poznejte nekoho vyjmec