Re: [HACKERS] Fulltextindex

2002-08-29 Thread Christopher Kings-Lynne
OK, I was probably a little aggressive in my pruning...BTW, this code was not written by me... struct varlena *data; char*word = "john"; char*cur_pos= NULL; int cur_pos_length = 0; data = (struct varlena *) palloc(VARHDRSZ + column

Re: [HACKERS] RULE regression test failure

2002-08-29 Thread Christopher Kings-Lynne
> That seems substantially the same plan as I see here. I guess > that the different output order must reflect a platform-specific > difference in qsort()'s treatment of equal keys. > > Probably the best answer is to add "ORDER BY shoename" to the test > query to eliminate the platform dependenc

Re: [HACKERS] RULE regression test failure

2002-08-29 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: >> Hm, what do you get from >> explain SELECT * FROM shoe_ready WHERE total_avail >= 2; >> in the regression database? > > [this plan] That seems substantially the same plan as I see here. I guess that the different output order must reflect

Re: [HACKERS] Fulltextindex

2002-08-29 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > struct varlena *data; > char*word = NULL; > char*cur_pos= NULL; > int cur_pos_length = 0; > data = (struct varlena *) palloc(column_length); > while(cur_pos > word) > { > cur_pos_length = strlen(cur_pos)

Re: [HACKERS] RULE regression test failure

2002-08-29 Thread Christopher Kings-Lynne
Attached. Chris > -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED]] > Sent: Friday, 30 August 2002 2:31 PM > To: Christopher Kings-Lynne > Cc: Hackers > Subject: Re: [HACKERS] RULE regression test failure > > > "Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > > Wit

[HACKERS] Fulltextindex

2002-08-29 Thread Christopher Kings-Lynne
An aside. In the fulltextindex code I'm trying to figure out what's breaking the attached code segment. Basically the data->vl_len line causes a segfault on the second time thru the while loop. I can't figure it out. I can't write to the value, but why? Basically with a word like 'john', it i

Re: [HACKERS] RULE regression test failure

2002-08-29 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > U...how do I make the regression database!? Do I have to do > installcheck instead of check? That's the easiest way; or you can restart the temp postmaster that the regression script starts and kills. regards, t

Re: [HACKERS] RULE regression test failure

2002-08-29 Thread Gavin Sherry
On Fri, 30 Aug 2002, Christopher Kings-Lynne wrote: > U...how do I make the regression database!? Do I have to do > installcheck instead of check? yes Database is 'regression' g ---(end of broadcast)--- TIP 1: subscribe and unsubscribe com

Re: [HACKERS] RULE regression test failure

2002-08-29 Thread Christopher Kings-Lynne
U...how do I make the regression database!? Do I have to do installcheck instead of check? Chris > -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED]] > Sent: Friday, 30 August 2002 2:31 PM > To: Christopher Kings-Lynne > Cc: Hackers > Subject: Re: [HACKERS] RULE regressi

Re: [HACKERS] RULE regression test failure

2002-08-29 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > With the recent talk of RULE regression failures, I thought I'd bring back > up that I _always_ have a rule failure on Freebsd/alpha. Hm, what do you get from explain SELECT * FROM shoe_ready WHERE total_avail >= 2; in the regression

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Would you please retest this. I have attached my email showing a > simpler test that is less error-prone. What did you consider less error-prone, exactly? Neil's original test considered the case where both the value being set and the buffer length (s

Re: [HACKERS] C vs. C++ contributions

2002-08-29 Thread Mario Weilguni
> > The nice part is it has an varying number of arguments, and can > > used within "sort". Very useful sometimes. > > With our CASE, you create a column using the CASE, then ODER BY on that > column. Not exactly, you have to create a column for this, and it will be in the select list. Oracle do

Re: [HACKERS] contrib features during beta period

2002-08-29 Thread Christopher Kings-Lynne
Well basically we have it all done, except neither of us has time to test at the moment. Florian is free after sept 1st. Basically it adds full word match support, stop words but keeps full backward compatibility. We are getting a segfault in the new function (fti2) but the old is still working

Re: [HACKERS] contrib features during beta period

2002-08-29 Thread Tom Lane
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > Is it ok if Florian and I submit the improvements to the fulltextindex > contrib during beta? What improvements are we talking about here? FTI is sufficiently widely depended on that I think it ought to follow the same quality standard as t

Re: [HACKERS] Reporting query duration

2002-08-29 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: >> I think the log entries should be separate: print the query text when >> you start, print the duration when you're done. A little bit of >> postprocessing can reassemble the two entries. > How would someone reassemble them? You would have to have the

[HACKERS] contrib features during beta period

2002-08-29 Thread Christopher Kings-Lynne
Is it ok if Florian and I submit the improvements to the fulltextindex contrib during beta? Chris ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [HACKERS] Reporting query duration

2002-08-29 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > There is a TODO item: > > * Allow logging of query durations > > > Currently there is no easy way to get a list of query durations in the > > server log file. My idea is to add query duration to the end of the > > query string f

Re: [HACKERS] @(#)Mordred Labs advisory 0x0007: Remove DoS in PostgreSQL

2002-08-29 Thread Tom Lane
=?iso-8859-1?Q?=DE=F3rhallur_H=E1lfd=E1narson?= <[EMAIL PROTECTED]> writes: > And another (perhaps silly) thought: Currently, if the authentication > process is exploited, it would kill the postmaster, resulting in a > total crash of the whole database system. Would it be beneficial to > split th

Re: [HACKERS] [7.3devl] Using PGPASSWORDFILE with psql requires -U

2002-08-29 Thread Tom Lane
"Dann Corbit" <[EMAIL PROTECTED]> writes: >> What have you got against strdup() ? > The strdup() function is non-standard, and need not exist in a C > implementation. But it *does* exist in all Postgres implementations. This is what we carry around a port/ directory for ...

Re: [HACKERS] [7.3devl] Using PGPASSWORDFILE with psql requires -U

2002-08-29 Thread Alvaro Herrera
Dann Corbit dijo: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > ! ret=(char *)malloc(sizeof(char)*strlen(t)); > > > ! strncpy(ret, t, strlen(t)); > > > > > > ! ret=(char *)malloc(sizeof(char)*(strlen(t)+1)); > > > ! strncpy(r

Re: [HACKERS] [7.3devl] Using PGPASSWORDFILE with psql requires -U

2002-08-29 Thread Dann Corbit
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED]] > Sent: Thursday, August 29, 2002 9:07 PM > To: Alvaro Herrera > Cc: Gordon Runkle; [EMAIL PROTECTED] > Subject: Re: [HACKERS] [7.3devl] Using PGPASSWORDFILE with > psql requires -U > > > Alvaro Herrera <[EMAIL PROTECTED

Re: [HACKERS] [7.3devl] Using PGPASSWORDFILE with psql requires -U

2002-08-29 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > ! ret=(char *)malloc(sizeof(char)*strlen(t)); > ! strncpy(ret, t, strlen(t)); > > ! ret=(char *)malloc(sizeof(char)*(strlen(t)+1)); > ! strncpy(ret, t, strlen(t)+1); What have you got against strdup() ?

Re: [HACKERS] [7.3devl] Using PGPASSWORDFILE with psql requires -U

2002-08-29 Thread Alvaro Herrera
Gordon Runkle dijo: > I'm using the current CVS (as of ~1930 EDT, 29AUG02) on RedHat's latest > beta (null). I find that I need to use the -U option when trying to use > psql and the new PGPASSWORDFILE variable. Ok, in private email with Gordon I discovered that I missed by one. Please apply t

Re: [HACKERS] Reporting query duration

2002-08-29 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > There is a TODO item: > * Allow logging of query durations > Currently there is no easy way to get a list of query durations in the > server log file. My idea is to add query duration to the end of the > query string for 'debug_print_query'. My

[HACKERS] Remove wal_files

2002-08-29 Thread Bruce Momjian
We have the TODO item: * Remove wal_files postgresql.conf option because WAL files are now recycled The following patch completes this item. It also makes the WAL documentation a lot easier to understand. ;-) -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PRO

Re: [HACKERS] [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?

2002-08-29 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Rod Taylor wrote: > >> The above, or something along those lines, would show order > >> independence. > > > It is this kind of added abstraction that I definitely want to avoid. > > I agree. We want to promote the LIMIT/FOR UPDATE

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Bruce Momjian
Would you please retest this. I have attached my email showing a simpler test that is less error-prone. I can't come up with any scenario that would produce what you have reported. If I look at function call cost, MemSet loop efficiency, and memset loop efficiency, I can't come up with a combi

[HACKERS] [7.3devl] Using PGPASSWORDFILE with psql requires -U option?

2002-08-29 Thread Gordon Runkle
I'm using the current CVS (as of ~1930 EDT, 29AUG02) on RedHat's latest beta (null). I find that I need to use the -U option when trying to use psql and the new PGPASSWORDFILE variable. Here's what I have in my ~/.pgpw file (pointed to by PGPASSWORDFILE): localhost:*:az_audit:gar:test This my

[HACKERS] RULE regression test failure

2002-08-29 Thread Christopher Kings-Lynne
With the recent talk of RULE regression failures, I thought I'd bring back up that I _always_ have a rule failure on Freebsd/alpha. The files are attached... Chris regression.diffs Description: Binary data regression.out Description: Binary data ---(end of broadcas

Re: Type definition process (was Re: [HACKERS] MemoryContextAlloc: invalid request size 1934906735)

2002-08-29 Thread D'Arcy J.M. Cain
On August 29, 2002 03:37 pm, Tom Lane wrote: > "D'Arcy J.M. Cain" <[EMAIL PROTECTED]> writes: > > One thing I do see though is that there is a completion issue. > > Well, (a) the shell type can't be used for anything till you turn it > into a real type, and (b) the completion issue already exists,

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Bruce Momjian
Larry Rosenman wrote: > On Thu, 2002-08-29 at 18:53, Alvaro Herrera wrote: > > En Thu, 29 Aug 2002 19:35:13 -0400 (EDT) > > Bruce Momjian <[EMAIL PROTECTED]> escribi?: > > > > > In your results it seems to suggest that memset() gets slower for longer > > > buffer lengths, and a for loop starts to

Re: [HACKERS] Proposed GUC Variable

2002-08-29 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > That's a pretty good idea. Now, what format will the argument take: text > (NOTICE, ERROR, DEBUG, etc) or integer? The increasing severity is clear > with numbers but the correlation to NOTICE, ERROR etc is undocumented > IIRC. On the other hand, the text

Re: [PATCHES] [HACKERS] Proposed GUC Variable

2002-08-29 Thread Bruce Momjian
Gavin Sherry wrote: > On Thu, 29 Aug 2002, Tom Lane wrote: > > > Robert Treat <[EMAIL PROTECTED]> writes: > > > One of my users is generating a notice message --> NOTICE: Adding > > > missing FROM-clause entry for table "msg202" It might be helpful to > > > dump out the query on notice messages

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Bruce Momjian
Larry Rosenman wrote: > On Thu, 2002-08-29 at 18:53, Alvaro Herrera wrote: > > En Thu, 29 Aug 2002 19:35:13 -0400 (EDT) > > Bruce Momjian <[EMAIL PROTECTED]> escribi?: > > > > > In your results it seems to suggest that memset() gets slower for longer > > > buffer lengths, and a for loop starts to

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Bruce Momjian
Alvaro Herrera wrote: > En Thu, 29 Aug 2002 19:35:13 -0400 (EDT) > Bruce Momjian <[EMAIL PROTECTED]> escribi?: > > > In your results it seems to suggest that memset() gets slower for longer > > buffer lengths, and a for loop starts to win at longer sizes. Should I > > pull out my Solaris kernel

Re: [HACKERS] Proposed GUC Variable

2002-08-29 Thread Larry Rosenman
On Thu, 2002-08-29 at 19:04, Gavin Sherry wrote: > On Thu, 29 Aug 2002, Tom Lane wrote: > > > Robert Treat <[EMAIL PROTECTED]> writes: > > > One of my users is generating a notice message --> NOTICE: Adding > > > missing FROM-clause entry for table "msg202" It might be helpful to > > > dump out

Re: [HACKERS] Proposed GUC Variable

2002-08-29 Thread Gavin Sherry
On Thu, 29 Aug 2002, Tom Lane wrote: > Robert Treat <[EMAIL PROTECTED]> writes: > > One of my users is generating a notice message --> NOTICE: Adding > > missing FROM-clause entry for table "msg202" It might be helpful to > > dump out the query on notice messages like this, and it looks like a

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Larry Rosenman
On Thu, 2002-08-29 at 18:53, Alvaro Herrera wrote: > En Thu, 29 Aug 2002 19:35:13 -0400 (EDT) > Bruce Momjian <[EMAIL PROTECTED]> escribió: > > > In your results it seems to suggest that memset() gets slower for longer > > buffer lengths, and a for loop starts to win at longer sizes. Should I >

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Alvaro Herrera
En Thu, 29 Aug 2002 19:35:13 -0400 (EDT) Bruce Momjian <[EMAIL PROTECTED]> escribió: > In your results it seems to suggest that memset() gets slower for longer > buffer lengths, and a for loop starts to win at longer sizes. Should I > pull out my Solaris kernel source and see what memset() is do

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Bruce Momjian
Andrew Sullivan wrote: > On Thu, Aug 29, 2002 at 01:27:41AM -0400, Neil Conway wrote: > > > > Also, if anyone would like to contribute the results of doing the > > benchmark on their particular system, that might provide some useful > > additional data points. > > Ok, here's a run on a Sun E450,

Re: [HACKERS] @(#)Mordre Labs advisory 0x0005: Several buffer overruns

2002-08-29 Thread Bruce Momjian
Patch applied. Thanks. --- Neil Conway wrote: > Sir Mordred The Traitor <[EMAIL PROTECTED]> writes: > > Upon invoking a polygon(integer, circle) function a > > src/backend/utils/adt/geo_ops.c:circle_poly() function will g

Re: [HACKERS] [BUGS] Bug #718: request for improvement of /? to

2002-08-29 Thread Alvaro Herrera
En Fri, 30 Aug 2002 00:14:20 +0200 (CEST) Peter Eisentraut <[EMAIL PROTECTED]> escribió: > Bruce Momjian writes: > > > How do people like the idea of grouping them? I would do it in psql \? > > and in the psql manual page. > > Seems reasonable, but then we should also have something along the

Re: [HACKERS] VIRUS IN YOUR MAIL (W32/Klez.h@MM)

2002-08-29 Thread Peter Eisentraut
Tatsuo Ishii writes: > Sorry for the off-topic article, but I wonder anyone has been received > this kind of mail... I have. > Note that I do not subscribe pgsql-general list (I once subscried. But > it seems I was kicked out from the list for unknow reason). I'm subscribed to -general but I h

Re: [HACKERS] [BUGS] Bug #718: request for improvement of /? to

2002-08-29 Thread Peter Eisentraut
Bruce Momjian writes: > How do people like the idea of grouping them? I would do it in psql \? > and in the psql manual page. Seems reasonable, but then we should also have something along the lines of \? \r so I don't have to dig through the whole pile if I'm interested in a particular comma

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Andrew Sullivan
On Thu, Aug 29, 2002 at 01:27:41AM -0400, Neil Conway wrote: > > Also, if anyone would like to contribute the results of doing the > benchmark on their particular system, that might provide some useful > additional data points. Ok, here's a run on a Sun E450, Solaris 7. I presume your "total" t

[HACKERS] [PATCH] Sprintf() patch against current CVS tree.

2002-08-29 Thread Jukka Holappa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I checked all the previous string handling errors and most of them were already fixed by You. However there were a few left and this patch should fix the rest of them. I used StringInfo only in 2 places and both of them are inside debug ifdefs.

Re: [HACKERS] README.tsearch.diff for CVS

2002-08-29 Thread Bruce Momjian
Patch applied. Thanks. --- Oleg Bartunov wrote: > Bruce, > > please apply small patch for README.tsearch. > > I've documented space usage and using CLUSTER command > > Regards, > Oleg >

Re: Type definition process (was Re: [HACKERS] MemoryContextAlloc: invalid request size 1934906735)

2002-08-29 Thread Tom Lane
"D'Arcy J.M. Cain" <[EMAIL PROTECTED]> writes: > One thing I do see though is that there is a completion issue. Well, (a) the shell type can't be used for anything till you turn it into a real type, and (b) the completion issue already exists, and has for a long time; you've always been able to c

Re: [HACKERS] tweaking MemSet() performance

2002-08-29 Thread Bruce Momjian
I consider this a very good test. As you can see from the date of my last test, 1997/09/11, I think I may have had a dual Pentium Pro at that point, and hardware has certainly changed since then. I did try 128 at that time and found it to be slower, but with newer hardware, it is very possible

Re: Type definition process (was Re: [HACKERS] MemoryContextAlloc: invalid request size 1934906735)

2002-08-29 Thread D'Arcy J.M. Cain
On August 29, 2002 09:45 am, Tom Lane wrote: > "D'Arcy J.M. Cain" <[EMAIL PROTECTED]> writes: > > YES! Well, sort of. I didn't have any other operators but while I > > thought that both were the same (after all, I contributed it) someone > > must have fixed the one in CVS before adding it. The

Re: [HACKERS] [Resend] Sprintf() auditing and a patch

2002-08-29 Thread Bruce Momjian
Neil Conway wrote: > If you're interested, another common source of problems is integer > overflow when dealing with numeric input from the user. In fact, far > more security problems have been caused by insufficient integer > overflow checking than by string handling bugs. One other things that

Re: [HACKERS] C vs. C++ contributions

2002-08-29 Thread Bruce Momjian
Mario Weilguni wrote: > Yes this is completly different. Oracle decode works like this: > > decode(value, choice1, result1, choice 2, result2, .., > default_result) > > it works this way: case > when value=choice1 then result1 when value=choice2 then result2 > > else default_resu

Re: [HACKERS] Musings

2002-08-29 Thread Gavin Sherry
On Sun, 5 May 2002 [EMAIL PROTECTED] wrote: > On Sun, 05 May 2002 10:01:57 EDT, the world broke into rejoicing as > mlw <[EMAIL PROTECTED]> said: > > It is sunday morning and I have been musing about some PostgreSQL issues. As > > some of you are aware, my dot com, dot died, and I am working on

Re: [HACKERS] Proposed GUC Variable

2002-08-29 Thread D'Arcy J.M. Cain
On August 29, 2002 12:09 pm, Robert Treat wrote: > One of my users is generating a notice message --> NOTICE: Adding > missing FROM-clause entry for table "msg202" It might be helpful to > dump out the query on notice messages like this, and it looks like a > simple change as far as elog.c and g

Re: [HACKERS] Proposed GUC Variable

2002-08-29 Thread Tom Lane
Robert Treat <[EMAIL PROTECTED]> writes: > One of my users is generating a notice message --> NOTICE: Adding > missing FROM-clause entry for table "msg202" It might be helpful to > dump out the query on notice messages like this, and it looks like a > simple change as far as elog.c and guc.c are

[HACKERS] the optimizer and exists

2002-08-29 Thread Thomas F. O'Connell
i think i might've stumbled across a tiny defect in the optimizer. unfortunately, i haven't the knowledge of the code to know where to begin looking at how to address this problem. anyway, consider the following: create table foo( id int2 ); create table bar( id int2 f

Re: [HACKERS] Proposed GUC Variable

2002-08-29 Thread Robert Treat
One of my users is generating a notice message --> NOTICE: Adding missing FROM-clause entry for table "msg202" It might be helpful to dump out the query on notice messages like this, and it looks like a simple change as far as elog.c and guc.c are concerned, but would this be overkill? Robert T

Re: [HACKERS] [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?

2002-08-29 Thread Bruce Momjian
Tom Lane wrote: > BTW, I'd like to see the old COPY syntax still documented, but in the > same way --- it need not be in the synopsis, just somewhere where people > can see it without having to refer back to old manuals. Agreed. -- Bruce Momjian| http://candle.pha.pa.

Type definition process (was Re: [HACKERS] MemoryContextAlloc: invalid request size 1934906735)

2002-08-29 Thread Tom Lane
"D'Arcy J.M. Cain" <[EMAIL PROTECTED]> writes: > YES! Well, sort of. I didn't have any other operators but while I thought > that both were the same (after all, I contributed it) someone must have fixed > the one in CVS before adding it. The one I was working with had the > operators working

Re: [HACKERS] ms word 2002

2002-08-29 Thread Bruno Wolff III
On Thu, Aug 29, 2002 at 10:53:12 -0300, Paul Cowan <[EMAIL PROTECTED]> wrote: > I do not know if this is the right list for this question but I am at > the end of my rope. I have migrated a number of database into postgres > and every thing seems to be working fine as far as the data is > con

[HACKERS] ms word 2002

2002-08-29 Thread Paul Cowan
I do not know if this is the right list for this question but I am at the end of my rope. I have migrated a number of database into postgres and every thing seems to be working fine as far as the data is concerned. I am now beginnng the development work using php. The problem is when some of t

Re: [HACKERS] MemoryContextAlloc: invalid request size 1934906735

2002-08-29 Thread D'Arcy J.M. Cain
On August 28, 2002 11:07 pm, Tom Lane wrote: > "D'Arcy J.M. Cain" <[EMAIL PROTECTED]> writes: > > Hmm. I did give it a harder look and look what jumped out. Both > > chkpass_out and chkpass_rout return PG_RETURN_CSTRING but chkpass_out > > builds a standard c string while chkpass_rout builds a v

[HACKERS] README.tsearch.diff for CVS

2002-08-29 Thread Oleg Bartunov
Bruce, please apply small patch for README.tsearch. I've documented space usage and using CLUSTER command Regards, Oleg _ Oleg Bartunov, sci.researcher, hostmaster of AstroNet, Sternberg Astronomical Institute,

[HACKERS] Misc replies

2002-08-29 Thread Sir Mordred The Traitor
> And dealing with a real name would be nice, IMHO. > Otherwise we may end up with 'SMtT' as the nickname, 'SMitTy' perhaps ? :-) Never camed across with such an offensive bullshit. But we will not end up with 'SMtT' nor with 'SMitTy', i am sure of it. Also , i never camed across with the situ

Re: [HACKERS] #ifdef MULTIBYTE removed

2002-08-29 Thread Tatsuo Ishii
> I didn't follow the -hackers discussion, but shouldn't the references > to '--enable-multibyte' and the MULTIBYTE #define be removed from > src/include/pg_config.h.in ? Thanks for pointing it out. I just forgot to commit the file. -- Tatsuo Ishii ---(end of broadcast)--

Re: [HACKERS] #ifdef MULTIBYTE removed

2002-08-29 Thread Neil Conway
Tatsuo Ishii <[EMAIL PROTECTED]> writes: > I have removed bunch of #ifdef MULTIBYTE per recent pgsql-hackers > discussion. All regression tests passed. I didn't follow the -hackers discussion, but shouldn't the references to '--enable-multibyte' and the MULTIBYTE #define be removed from src/inclu

[HACKERS] #ifdef MULTIBYTE removed

2002-08-29 Thread Tatsuo Ishii
I have removed bunch of #ifdef MULTIBYTE per recent pgsql-hackers discussion. All regression tests passed. -- Tatsuo Ishii ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMA