On Sun, Oct 20, 2019 at 2:44 AM Andres Freund wrote:
>
> Hi,
>
> On 2019-10-19 21:50:03 +0200, Peter Eisentraut wrote:
> > diff --git a/contrib/bloom/blcost.c b/contrib/bloom/blcost.c
> > index f9fe57f..6224735 100644
> > --- a/contrib/bloom/blcost.c
> > +++ b/contrib/bloom/blcost.c
> > @@ -12,10
On Tue, Oct 22, 2019 at 12:56 PM Amit Kapila wrote:
> Few comments on 0001-Ordering-of-header-files-in-contrib-dir-oct21.patch
> ---
> 1.
> --- a/contrib/isn/isn.c
> +++ b/contrib/isn/isn.c
> @@
On Tue, Oct 22, 2019 at 3:42 PM Amit Kapila wrote:
> Review for 0003-Ordering-of-header-files-remaining-dir-oct21
> -
> 1.
> --- a/src/bin/pg_basebackup/pg_recvlogical.c
> +++ b/src/bin/pg_basebackup/pg_recvlog
On Tue, Oct 22, 2019 at 11:05 PM vignesh C wrote:
>
> On Tue, Oct 22, 2019 at 3:42 PM Amit Kapila wrote:
> > Review for 0003-Ordering-of-header-files-remaining-dir-oct21
> > -
> &
Hi,
One of the function apply_typmod in numeric.c file present within #if 0.
This is like this for many years.
I felt this can be removed.
Attached patch contains the changes to handle removal of apply_typmod
present in #if 0.
Thoughts?
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
ed from the checkpoint onwards up to a consistent point.
>
> My two cents!
>
> Regards,
> Jeevan Ladhe
>
> On Sat, Jul 20, 2019 at 11:22 PM vignesh C wrote:
>>
>> Hi Jeevan,
>>
>> The idea is very nice.
>> When Insert/update/delete and truncate/dro
Hi,
I have done some review of undolog patch series
and here are my comments:
0003-Add-undo-log-manager.patch
1) As undo log is being created in tablespace,
if the tablespace is dropped later, will it have any impact?
+void
+UndoLogDirectory(Oid tablespace, char *dir)
+{
+ if (tablespace == DEFA
On Thu, Jul 25, 2019 at 7:48 AM Amit Kapila wrote:
>
> On Wed, Jul 24, 2019 at 11:04 PM vignesh C wrote:
> >
> > Hi,
> >
> > I have done some review of undolog patch series
> > and here are my comments:
> > 0003-Add-undo-log-manager.patch
> >
&
Hi,
Initdb fails when following path is provided as input:
datasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafdds/datasadfasfdsafddsdata
essed in usable non-header bytes. Figure out how far we
+ * have to move insert to create space for 'size' usable bytes, stepping
+ * over any intervening headers.
+ */
+ Assert(slot->meta.unlogged.insert % BLCKSZ >= UndoLogBlockHeaderSize);
+ if (context->try_location != I
On Thu, Jul 25, 2019 at 4:52 PM Rafia Sabih wrote:
>
> On Thu, 25 Jul 2019 at 07:39, vignesh C wrote:
> >
> > Hi,
> >
> > Initdb fails when follo
On Thu, Jul 25, 2019 at 8:39 PM Rafia Sabih wrote:
>
> On Thu, 25 Jul 2019 at 16:44, Tom Lane wrote:
> >
> > Rafia Sabih writes:
> > > On Thu, 25 Jul 2019 at 13:50, vignesh C wrote:
> > >>> Initdb fail
Hi,
I have noticed in some cases the warning messages appear twice, one such
instance is given below:
postgres=# begin;
BEGIN
postgres=# prepare transaction 't1';
PREPARE TRANSACTION
postgres=# rollback;
*WARNING: there is no transaction in progressWARNING: there is no
transaction in progress*
On Fri, Jul 26, 2019 at 11:23 AM Dilip Kumar wrote:
> On Fri, Jul 26, 2019 at 11:04 AM vignesh C wrote:
> >
> > Hi,
> >
> > I have noticed in some cases the warning messages appear twice, one such
> instance is given below:
> > postgres=# begin;
> > BE
On Fri, Jul 26, 2019 at 11:21 AM Jeevan Ladhe
wrote:
> Hi Vignesh,
>
> Please find my comments inline below:
>
> 1) If relation file has changed due to truncate or vacuum.
>> During incremental backup the new files will be copied.
>> There are chances that both the old file and new file
Hi,
I could not locate the caller of ParsePrepareRecord function in twophase.c.
Any idea how it gets called?
or
Is it a dead function?
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
On Mon, Jul 29, 2019 at 8:24 PM Robert Haas wrote:
>
> On Mon, Jul 29, 2019 at 4:10 AM vignesh C wrote:
> > I could not locate the caller of ParsePrepareRecord function in twophase.c.
> > Any idea how it gets called?
> > or
> > Is it a dead function?
>
> I
On Tue, Jul 30, 2019 at 2:34 AM Alvaro Herrera wrote:
>
> On 2019-Jul-29, vignesh C wrote:
>
> > On Mon, Jul 29, 2019 at 8:24 PM Robert Haas wrote:
> > >
> > > On Mon, Jul 29, 2019 at 4:10 AM vignesh C wrote:
> > > > I could not locate
On Tue, Jul 30, 2019 at 9:19 PM Daniel Gustafsson wrote:
>
> Hi,
>
> In contrib/pgcrypto/pgp.c we have a struct member int_name in digest_info
> which
> isn’t used, and seems to have never been used (a potential copy/pasteo from
> the
> cipher_info struct?). Is there a reason for keeping this,
Hi,
I noticed that there are many header files being
included which need not be included.
I have tried this in a few files and found the
compilation and regression to be working.
I have attached the patch for the files that
I tried.
I tried this in CentOS, I did not find the header
files to be pla
On Wed, Jul 31, 2019 at 11:26 AM Michael Paquier wrote:
>
> On Wed, Jul 31, 2019 at 11:19:08AM +0530, vignesh C wrote:
> > I noticed that there are many header files being included which need
> > not be included. I have tried this in a few files and found the
> > compilat
On Wed, Jul 31, 2019 at 11:55 AM Amit Kapila wrote:
>
> On Wed, Jul 31, 2019 at 11:31 AM vignesh C wrote:
> >
> > On Wed, Jul 31, 2019 at 11:26 AM Michael Paquier
> > wrote:
> > >
> > > On Wed, Jul 31, 2019 at 11:19:08AM +0530, vignesh C wrote:
&g
On Tue, Jul 30, 2019 at 1:58 AM Robert Haas wrote:
>
> On Wed, Jul 10, 2019 at 2:17 PM Anastasia Lubennikova
> wrote:
> > In attachments, you can find a prototype of incremental pg_basebackup,
> > which consists of 2 features:
> >
> > 1) To perform incremental backup one should call pg_basebackup
Hi,
In the undo system, we use full-transaction-id for transactions. For
rollback of prepared transactions, we were planning to use
FullTransactionId by combining TransactionId and epoch, but as
suggested by multiple people in that email chain [1][2], the better
idea is to store Full-transactioni
On Thu, Aug 1, 2019 at 5:36 PM Thomas Munro wrote:
>
> Hi Vignesh,
>
> On Thu, Aug 1, 2019 at 9:32 PM vignesh C wrote:
> > In the undo system, we use full-transaction-id for transactions. For
> > rollback of prepared transactions, we were planning to use
> >
On Thu, Aug 1, 2019 at 5:06 PM Jeevan Chalke
wrote:
>
> On Tue, Jul 30, 2019 at 9:39 AM Jeevan Chalke
> wrote:
>>
>> I am almost done writing the patch for pg_combinebackup and will post soon.
>
>
> Attached patch which implements the pg_combinebackup utility used to combine
> full basebackup wi
On Wed, Jul 31, 2019 at 12:26 PM Andres Freund wrote:
>
> Hi,
>
> On 2019-07-31 11:19:08 +0530, vignesh C wrote:
> > I noticed that there are many header files being
> > included which need not be included.
> > I have tried this in a few files and found the
> &
On Wed, Jul 31, 2019 at 9:37 AM Amit Kapila wrote:
>
> On Wed, Jul 31, 2019 at 12:05 AM Robert Haas wrote:
> >
> > On Thu, Jul 18, 2019 at 9:45 AM Tom Lane wrote:
> > > I think this is going in the wrong direction. Nodes should *always*
> > > assume that a rescan is possible until ExecEndNode i
On Mon, Aug 5, 2019 at 8:31 AM Andres Freund wrote:
>
> Hi,
>
> On 2019-08-05 14:44:37 +1200, Thomas Munro wrote:
> > Yeah. I think we're agreed for now that we don't want to change
> > procarray (though we still need to figure out how to compute the 64
> > bit horizons correctly and efficiently)
On Fri, Aug 16, 2019 at 8:07 PM Ibrar Ahmed wrote:
>
> What do you mean by bigger file, a file greater than 1GB? In which case you
> get file > 1GB?
>
>
>
Few comments:
Comment:
+ buf = (char *) malloc(statbuf->st_size);
+ if (buf == NULL)
+ ereport(ERROR,
+ (errcode(ERRCODE_OUT_OF_MEMORY),
+ err
Hi,
Please find the attached patch having the fix for the typos and
inconsistencies present in code.
The patch contains the following changes:
1) attibute -> attribute
2) efficent -> efficient
3) becuase -> because
4) fallthru -> fall through
5) uncoming -> upcoming
6) ans -> and
7) requrested ->
On Tue, Oct 29, 2019 at 9:19 AM Dilip Kumar wrote:
>
> Few comments:
> 1.
> * The act of allocating pages to recycle may have invalidated the
> - * results of our previous btree reserch, so repeat it. (We could
> + * results of our previous btree search, so repeat it. (We could
> * recheck whe
On Wed, Oct 30, 2019 at 6:35 AM Michael Paquier wrote:
>
> On Tue, Oct 29, 2019 at 05:27:20PM +0530, vignesh C wrote:
> > I have attached the updated patch with the fixes.
>
> The changes in rangetypes_gist.c are not correct, the usual pattern to
> add an "s" af
On Tue, Oct 22, 2019 at 10:52 PM Tomas Vondra
wrote:
>
> I think the patch should do the simplest thing possible, i.e. what it
> does today. Otherwise we'll never get it committed.
>
I found a couple of crashes while reviewing and testing flushing of
open transaction data:
Issue 1:
#0 0x7f22c
On Tue, Oct 29, 2019 at 2:51 PM Peter Eisentraut
wrote:
>
> The cache_plan argument to ri_PlanCheck has not been used since
> e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it.
>
> That commit said "I left it alone in case there is any future need for
> it" but there hasn't been a
On Thu, Oct 24, 2019 at 7:07 PM Amit Kapila wrote:
>
> On Tue, Oct 22, 2019 at 10:30 AM Dilip Kumar wrote:
> >
> > I have merged bugs_and_review_comments_fix.patch changes to 0001 and 0002.
> >
>
> I was wondering whether we have checked the code coverage after this
> patch? Previously, the exis
On Mon, Nov 4, 2019 at 5:22 PM Amit Kapila wrote:
>
> On Wed, Oct 30, 2019 at 9:38 AM vignesh C wrote:
> >
> > On Tue, Oct 22, 2019 at 10:52 PM Tomas Vondra
> > wrote:
> > >
> > > I think the patch should do the simplest thing possible, i.e. what it
&
Hi,
I found couple of crashes in reorderbuffer while review/testing of
logical_work_mem and logical streaming of large in-progress
transactions. Stack trace of the same are given below:
Issue 1:
#0 0x7f985c7d8337 in raise () from /lib64/libc.so.6
#1 0x7f985c7d9a28 in abort () from /lib64
On Wed, Nov 6, 2019 at 5:41 PM Dilip Kumar wrote:
>
> On Wed, Nov 6, 2019 at 5:20 PM vignesh C wrote:
> >
> > Hi,
> >
> > I found couple of crashes in reorderbuffer while review/testing of
> > logical_work_mem and logical streaming of large in-progress
>
On Thu, Nov 7, 2019 at 10:01 PM Andres Freund wrote:
>
> Hi,
>
> On 2019-11-07 17:03:44 +0530, Amit Kapila wrote:
> > On Thu, Nov 7, 2019 at 4:48 PM Tomas Vondra
> > wrote:
> > >
> > > I'm a bit confused - does this happen only with the logical_work_mem
> > > patches, or with clean master too?
>
On Sat, Nov 9, 2019 at 5:07 PM Amit Kapila wrote:
>
> On Fri, Nov 8, 2019 at 10:05 AM vignesh C wrote:
> >
> > On Thu, Nov 7, 2019 at 10:01 PM Andres Freund wrote:
> > >
> > > Hi,
> > >
> > > On 2019-11-07 17:03:44 +0530, Amit Kapila wrot
On Wed, Nov 13, 2019 at 8:05 PM Pavel Stehule wrote:
>
>
>
> st 13. 11. 2019 v 7:13 odesílatel Pavel Stehule
> napsal:
>>
>>
>>
>> st 13. 11. 2019 v 7:12 odesílatel Amit Kapila
>> napsal:
>>>
>>> On Tue, Nov 12, 2019 at 11:17 AM Amit Kapila
>>> wrote:
>>> >
>>> > I am planning to commit this
On Fri, Nov 15, 2019 at 1:23 PM Pavel Stehule wrote:
>
> updated patch attached
>
Thanks Pavel for providing updated version.
Few comments:
I felt the help text seems incomplete:
@@ -159,6 +167,7 @@ help(const char *progname)
printf(_("\nOptions:\n"));
printf(_(" -e, --echo
On Tue, Nov 12, 2019 at 11:19 AM Amit Kapila wrote:
>
> On Tue, Nov 12, 2019 at 6:33 AM vignesh C wrote:
> >
> >
> > Thanks Amit for your comments. Please find the updated patch which
> > does not include the changes mentioned above.
> >
>
> Thanks for w
Hi,
I noticed that some of the source files does not include the copyright
information. Most of the files have included it, but few files have
not included it. I felt it should be included. The attached patch
contains the fix for including the copyright information in the source
files. Let me know
On Sat, Nov 16, 2019 at 1:25 PM Pavel Stehule wrote:
>> >
>> > updated patch attached
>> >
>>
>> Thanks Pavel for providing updated version.
>> Few comments:
>> I felt the help text seems incomplete:
>> @@ -159,6 +167,7 @@ help(const char *progname)
>> printf(_("\nOptions:\n"));
>> pri
Hi,
While checking initdb code, I found one segmentation fault, stack
trace for the same is:
Core was generated by `./initdb -D data6'.
Program terminated with signal 11, Segmentation fault.
#0 0x0040ea22 in main (argc=3, argv=0x7ffc82237308) at initdb.c:3340
3340printf(_("\nSucce
On Mon, Nov 18, 2019 at 6:30 PM Pavel Stehule wrote:
>>
>> I'll send this test today
>
>
> here is it
>
Thanks for adding the test.
Few comments:
This function is same as in test/recovery/t/013_crash_restart.pl, we
can add to a common file and use in both places:
+# Pump until string is matched,
On Thu, Nov 21, 2019 at 2:11 PM Amit Kapila wrote:
>
> On Sat, Nov 16, 2019 at 7:01 AM vignesh C wrote:
> >
> > On Tue, Nov 12, 2019 at 11:19 AM Amit Kapila
> > wrote:
> > >
> > > On Tue, Nov 12, 2019 at 6:33 AM vignesh C wrote:
> > > >
On Fri, Nov 22, 2019 at 12:10 AM Pavel Stehule wrote:
>
>
>
> čt 21. 11. 2019 v 6:33 odesílatel vignesh C napsal:
>>
>> On Mon, Nov 18, 2019 at 6:30 PM Pavel Stehule
>> wrote:
>> >>
>> >> I'll send this test today
>> >
>>
On Fri, Nov 22, 2019 at 2:12 AM Tom Lane wrote:
>
> Thomas Munro writes:
> > I'd like to get rid of those IDENTIFICATION lines completely (they are
> > left over from the time when the project used CVS, and that section
> > had a $Header$ "ident" tag, but in the git era, those ident tags are
> >
On Sun, Nov 24, 2019 at 7:24 AM John Naylor wrote:
>
> On Sat, Nov 23, 2019 at 11:39 PM vignesh C wrote:
>
> > * Copyright (c) 2016-2019, PostgreSQL Global Development Group
>
> While we're talking about copyrights, I noticed while researching
> something else that
On Sat, Nov 23, 2019 at 4:42 PM Amit Kapila wrote:
>
> On Fri, Nov 22, 2019 at 3:16 PM vignesh C wrote:
> >
> > Thanks for fixing the comments. The changes looks fine to me. I have
> > fixed the first comment, attached patch has the changes for the sa
On Sun, Nov 24, 2019 at 5:06 PM Pavel Stehule wrote:
>
>
>
> ne 24. 11. 2019 v 11:25 odesílatel vignesh C napsal:
>>
>> On Sat, Nov 23, 2019 at 4:42 PM Amit Kapila wrote:
>> >
>> > On Fri, Nov 22, 2019 at 3:16 PM vignesh C wrote:
>> > >
&g
On Sun, Nov 24, 2019 at 8:44 PM Tom Lane wrote:
>
> John Naylor writes:
> > On Sat, Nov 23, 2019 at 11:39 PM vignesh C wrote:
> >> * Copyright (c) 2016-2019, PostgreSQL Global Development Group
>
> > While we're talking about copyrights, I noticed while rese
On Tue, Nov 26, 2019 at 11:37 AM Amit Kapila wrote:
>
> On Mon, Nov 25, 2019 at 11:22 PM vignesh C wrote:
> >
> > On Sun, Nov 24, 2019 at 5:06 PM Pavel Stehule
> > wrote:
> > >
> > >
> > >
> > > ne 24. 11. 2019 v 11:25 odesílatel vign
On Thu, Nov 28, 2019 at 8:54 AM Amit Kapila wrote:
>
> On Wed, Nov 27, 2019 at 10:15 AM vignesh C wrote:
> >
> >
> > Attached patch has the fixes for the above comments.
> >
>
> I have pushed the refactoring patch. In the second patch, I have a
> few more
On Fri, Nov 29, 2019 at 1:36 PM Juan José Santamaría Flecha
wrote:
>
>
>
> On Fri, Nov 29, 2019 at 7:30 AM Michael Paquier wrote:
>>
>> On Thu, Nov 28, 2019 at 08:53:56AM +0530, Amit Kapila wrote:
>> > I have pushed the refactoring patch. In the second patch, I have a
>> > few more comments. I
Hi,
In few scenarios the message displayed in psql console is not consistent in
windows and linux. The execution results from few scenarios in windows and
linux is listed below:
In CentOS
*After transaction idle timeout*postgres=# SET
idle
> I found couple of crashes in reorderbuffer while review/testing of
> logical_work_mem and logical streaming of large in-progress
> transactions. Stack trace of the same are given below:
> Issue 1:
> #0 0x7f985c7d8337 in raise () from /lib64/libc.so.6
> #1 0x7f985c7d9a28 in abort () from
On Fri, Dec 6, 2019 at 5:30 PM Amit Kapila wrote:
>
> On Mon, Nov 25, 2019 at 8:25 PM Jehan-Guillaume de Rorthais
> wrote:
> >
> > On Wed, 6 Nov 2019 14:34:38 +0100
> > Peter Eisentraut wrote:
> >
> > > On 2019-11-05 17:29, Jehan-Guillaume de Rorthais wrote:
> > > > My best bet so far is that lo
EnterpriseDB: http://www.enterprisedb.com
From 2c4123d514473a9203c3617655229286a84487e6 Mon Sep 17 00:00:00 2001
From: vignesh
Date: Tue, 17 Dec 2019 17:05:35 +0530
Subject: [PATCH] Fix subscriber invalid memory access on DDL.
This patch allows building the local relmap cache for a subscribed
rel
On Mon, Dec 2, 2019 at 2:02 PM Dilip Kumar wrote:
>
> On Sun, Dec 1, 2019 at 7:58 AM Michael Paquier wrote:
> >
> > On Fri, Nov 22, 2019 at 01:18:11PM +0530, Dilip Kumar wrote:
> > > I have rebased the patch on the latest head and also fix the issue of
> > > "concurrent abort handling of the (sub
On Tue, Dec 17, 2019 at 2:32 PM Amit Kapila wrote:
>
> On Wed, Dec 11, 2019 at 11:13 AM vignesh C wrote:
> >
> >
> > It sets the final_lsn here so that it can iterate from the start_lsn
> > to final_lsn and cleanup the serialized files in
> > ReorderBufferRest
On Mon, Dec 30, 2019 at 11:17 AM Amit Kapila wrote:
>
> On Fri, Dec 27, 2019 at 8:37 PM Alvaro Herrera
> wrote:
> >
> > On 2019-Dec-27, vignesh C wrote:
> >
> > > I felt amit solution also solves the problem. Attached patch has the
> > > fix b
n the child process is
being created.
Thoughts?
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
From 5cded66879e74f6351b44856eef2d66fab172e95 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Wed, 1 Jan 2020 08:48:44 +0530
Subject: [PATCH] pg_restore crash when there is a failure before all
On Thu, Sep 26, 2019 at 7:17 PM Luis Carril wrote:
>
>
> I don't disagree with adding FOREIGN, though.
>
> Your patch is failing the pg_dump TAP tests. Please use
> configure --enable-tap-tests, fix the problems, then resubmit.
>
> Fixed, I've attached a new version.
Will it be possible to add a
On Mon, Jan 13, 2020 at 7:52 PM Tom Lane wrote:
>
> vignesh C writes:
> > On Thu, Sep 26, 2019 at 7:17 PM Luis Carril wrote:
> >>> Your patch is failing the pg_dump TAP tests. Please use
> >>> configure --enable-tap-tests, fix the problems, then resubmi
On Fri, Nov 29, 2019 at 2:10 PM Luis Carril wrote:
>
> Luis,
>
> It seems you've got enough support for this concept, so let's move
> forward with this patch. There are some comments from Tom about the
> patch; would you like to send an updated version perhaps?
>
> Thanks
>
> Hi,
>
> I've attach
On Tue, Jan 14, 2020 at 5:22 PM Luis Carril wrote:
> Can you have a look at dump with parallel option. Parallel option will
> take a lock on table while invoking lockTableForWorker. May be this is
> not required for foreign tables.
> Thoughts?
>
> I tried with -j and found no issue. I guess that
On Thu, Jan 16, 2020 at 9:17 AM Dilip Kumar wrote:
>
> One minor comment. Otherwise, the patch looks fine to me.
> + /*
> + * We set final_lsn on a transaction when we decode its commit or abort
> + * record, but we never see those records for crashed transactions. To
> + * ensure cleanup of the
On Sat, Jan 18, 2020 at 2:42 AM Alvaro Herrera wrote:
>
> On 2020-Jan-17, vignesh C wrote:
>
> > Thanks Dilip for reviewing.
> > I have fixed the comments you have suggested.
>
> I ended up rewording that comment completely; I thought the original was
> not explai
On Mon, Jan 20, 2020 at 8:34 PM Luis Carril wrote:
>
>
> Hi Vignesh,
>
>yes you are right I could reproduce it also with 'file_fdw'. The issue is
> that LOCK is not supported on foreign tables, so I guess that the safest
> solution is to make the --include-foreign-data incompatible with --jo
On Tue, Jan 21, 2020 at 3:06 PM Luis Carril wrote:
>
> Yes we can support --include-foreign-data without parallel option and
> later add support for parallel option as a different patch.
>
> Hi,
>
> I've attached a new version of the patch in which an error is emitted if
> the parallel backup
On Wed, 10 Jan 2024 at 14:08, Bharath Rupireddy
wrote:
>
> Hi,
>
> I've been observing a failure in t/038_save_logical_slots_shutdown.pl
> of late on my developer system:
>
> t/038_save_logical_slots_shutdown.pl .. 1/?
> # Failed test 'Check that the slot's confirmed_flush LSN is the same
> as t
On Wed, 10 Jan 2024 at 15:04, Amit Kapila wrote:
>
> On Wed, Jan 10, 2024 at 2:59 PM Shlok Kyal wrote:
> >
> > This patch is not applying on the HEAD. Please rebase and share the
> > updated patch.
> >
>
> IIRC, there were some regressions observed with this patch. So, one
> needs to analyze thos
On Wed, 10 Jan 2024 at 15:50, Amit Kapila wrote:
>
> On Thu, Jan 4, 2024 at 2:22 PM vignesh C wrote:
> >
> > We have documentation on how to upgrade "publisher" and "subscriber"
> > at [1], but currently we do not have any documentation on how
On Wed, 10 Jan 2024 at 18:37, vignesh C wrote:
>
> On Wed, 10 Jan 2024 at 14:08, Bharath Rupireddy
> wrote:
> >
> > Hi,
> >
> > I've been observing a failure in t/038_save_logical_slots_shutdown.pl
> > of late on my developer system:
>
On Thu, 7 Dec 2023 at 04:50, Nathan Bossart wrote:
>
> On Wed, Dec 06, 2023 at 11:30:02AM -0600, Nathan Bossart wrote:
> > On Wed, Dec 06, 2023 at 06:27:04PM +0100, Peter Eisentraut wrote:
> >> Makes sense. Can you commit that?
> >
> > Yes, I will do so shortly.
>
> Committed. Apologies for the
On Sat, 6 Jan 2024 at 01:47, Robert Haas wrote:
>
> On Thu, Mar 23, 2023 at 11:02 PM Kyotaro Horiguchi
> wrote:
> > [ new patch ]
>
> Well, I guess nobody is too excited about fixing this, because it's
> been another 10 months with no discussion. Andres doesn't even seem to
> think this is as muc
On Tue, 17 Oct 2023 at 04:18, Thomas Munro wrote:
>
> I pushed the retry-loop-in-frontend-executables patch and the
> missing-locking-in-SQL-functions patch yesterday. That leaves the
> backup ones, which I've rebased and attached, no change. It sounds
> like we need some more healthy debate abo
On Thu, 9 Feb 2023 at 12:02, Masahiko Sawada wrote:
>
> On Wed, Feb 8, 2023 at 1:13 PM Amit Kapila wrote:
> >
> > On Wed, Feb 8, 2023 at 1:19 AM Andres Freund wrote:
> > >
> > > On 2023-02-01 11:23:57 +0530, Amit Kapila wrote:
> > > > On Tue, Jan 31, 2023 at 6:08 PM Masahiko Sawada
> > > > wro
On Thu, 13 Apr 2023 at 23:34, Fujii Masao wrote:
>
>
>
> On 2023/04/13 11:00, Kyotaro Horiguchi wrote:
> > Agreed, it seems to be a leftover when we moved to parse_int_param()
> > in that area.
>
> It looks like there was an oversight in commit e7a2217978. I've attached a
> patch (0002) that upda
On Tue, 29 Aug 2023 at 06:29, Jimmy Yih wrote:
>
> Thanks for the insightful response! I have attached an updated patch
> that moves the proposed logic to the end of StartupXLOG where it seems
> more correct to do this. It also helps with backporting (if it's
> needed) since the archiver process o
On Thu, 7 Dec 2023 at 13:52, Richard Guo wrote:
>
>
> On Mon, Sep 25, 2023 at 3:11 PM Richard Guo wrote:
>>
>> If the grouping expression is a Var or PHV, we can just set its
>> nullingrels, very straightforward. For an expression that is neither a
>> Var nor a PHV, I'm not quite sure how to se
On Tue, 28 Nov 2023 at 18:23, Jingxian Li wrote:
>
> Hi hackers,
>
> I found a problem when doing the test shown below:
>
> Time
>
> Session A
>
> Session B
>
> T1
>
> postgres=# create table test(a int);
>
> CREATE TABLE
>
> postgres=# insert into test values (1);
>
> INSERT 0 1
>
>
>
> T2
>
> po
On Thu, 14 Dec 2023 at 02:13, Imseih (AWS), Sami wrote:
>
> Hi,
>
>
>
> A recent case in the field in which a database session_authorization is
>
> altered to a non-superuser, non-owner of tables via alter database .. set
> session_authorization ..
>
> caused autovacuum to skip tables.
>
>
>
> Th
+
> + Enable all the subscriptions on node1 that are
> + subscribing the changes from node2 by using
> + ALTER
> SUBSCRIPTION ... ENABLE,
> + for e.g.:
> +
> +node2=# ALTER SUBSCRIPTION sub1_node2_node1 ENABLE;
> +AL
On Fri, 5 Jan 2024 at 10:49, Peter Smith wrote:
>
> Here are some review comments for patch v1-0001.
>
> ==
> doc/src/sgml/ref/pgupgrade.sgml
>
> 1. GENERAL - blank lines
>
> Most (but not all) of your procedure steps are preceded by blank lines
> to make them more readable in the SGML. Add th
On Tue, 15 Aug 2023 at 08:09, Peter Smith wrote:
>
> A rebase was needed due to a recent push [1].
I have changed the status of the patch to "Waiting on Author" as
Amit's queries at [1] have not been verified and concluded. Please
feel free to address them and change the status back again.
[1] -
On Fri, 2 Dec 2022 at 05:05, Kohei KaiGai wrote:
>
> > > IIUC, we already can use ctid in the where clause on the latest
> > > PostgreSQL, can't we?
> >
> > Oh, sorry, I missed the TidRangeScan. My apologies for the noise.
> >
> I made the ctidscan extension when we developed CustomScan API
> towa
On Tue, 26 Sept 2023 at 04:38, Nathan Bossart wrote:
>
> On Fri, Sep 15, 2023 at 02:25:38PM -0700, Yurii Rashkovskii wrote:
> > Thank you for the feedback. I've updated the glossary and updated the
> > terminology to be consistent. Please see the new patch attached.
>
> Thanks for the new version
On Wed, 20 Sept 2023 at 17:27, Daniel Gustafsson wrote:
>
> > On 20 Sep 2023, at 11:24, Peter Eisentraut wrote:
> >
> > On 06.08.23 21:39, Ahmed Ibrahim wrote:
> >> I have addressed the pg version compatibility with the FORCE option in
> >> drop. Here is the last version of the patch
> >
> > The
On Sat, 10 Jun 2023 at 07:57, James Coleman wrote:
>
> I've previously noted in "Add last commit LSN to
> pg_last_committed_xact()" [1] that it's not possible to monitor how
> many bytes of WAL behind a logical replication slot is (computing such
> is obviously trivial for physical slots) because
On Wed, 25 Oct 2023 at 19:06, Andrei Zubkov wrote:
>
> Hi Aleksander,
>
> On Wed, 2023-10-25 at 16:17 +0300, Aleksander Alekseev wrote:
> > On top of that not sure if I see the patch on the November commitfest
> > [1]. Please make sure it's there so that cfbot will check the patch.
>
> Yes, this p
On Thu, 28 Sept 2023 at 10:23, Michael Paquier wrote:
>
> On Sat, Jun 03, 2023 at 07:42:36PM -0400, Fabrízio de Royes Mello wrote:
> > So in order to improve things a bit in this area I'm proposing to add a
> > test module for Table Access Method similar what we already have for Index
> > Access M
On Fri, 14 Jul 2023 at 20:17, Tomas Vondra
wrote:
>
> On 7/9/23 23:44, Tomas Vondra wrote:
> > ...
> >>> Yes, my previous message was mostly about backwards compatibility, and
> >>> this may seem a bit like an argument against it. But that message was
> >>> more a question "If we do this, is it ac
On Tue, 31 Oct 2023 at 23:42, Corey Huinker wrote:
>>
>>
>> I think the SQL statements should end with semicolons. Our SQL examples
>> are usually written like that.
>
>
> ok
>
>
>>
>>
>> Our general style with CTEs seems to be (according to
>> https://www.postgresql.org/docs/current/queries-with
On Fri, 10 Nov 2023 at 23:20, Nathan Bossart wrote:
>
> On Tue, Oct 03, 2023 at 03:17:57PM +0530, vignesh C wrote:
> > Few comments:
>
> Pierre, do you plan to submit a new revision of this patch set for the
> November commitfest? If not, the commitfest entry may be mark
On Mon, 15 Jan 2024 at 04:45, Tomas Vondra
wrote:
>
> On 1/14/24 12:18, vignesh C wrote:
> > On Fri, 14 Jul 2023 at 20:17, Tomas Vondra
> > wrote:
> >>
> >> On 7/9/23 23:44, Tomas Vondra wrote:
> >>> ...
> >>>>> Yes, my previous
301 - 400 of 1903 matches
Mail list logo
