RE: tab-complete for CREATE TYPE ... SUBSCRIPT

On Wednesday, June 2, 2021 6:51 PM, tanghy.f...@fujitsu.com wrote: >Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT >introduced at c7aba7c14e. Oops, comma forgot. patch Updated. Regards, Tang V2-0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patch Descripti

RE: [BUG]Update Toast data failure in logical replication

On Thu, Jun 3, 2021 7:45 PMDilip Kumar wrote: > > I have fixed all the pending issues, I see there is already a test > case for this so I have changed the output for that. Thanks for your patch. I tested it for all branches(10,11,12,13,HEAD) and all of them passed.(This bug was introduced in PG

RE: Support tab completion for upper character inputs in psql

Hi I've updated the patch to V8 since Tom, Kyotaro and Laurenz discussed the lower case issue of German/Turkish language at [1]. Differences from V7 are: * Add a function valid_input_text which checks the input text to see if it only contains alphabet letters, numbers etc. * Delete the flag se

RE: Added schema level support for publication.

Hi I applied your V7* patch and complied it. The following warnings came out, please take a look. >pg_publication.c:688:22: warning: ‘tables’ may be used uninitialized in this >function [-Wmaybe-uninitialized] > funcctx->user_fctx = (void *) tables; > ~~~^ >d

RE: Added schema level support for publication.

On Friday, June 25, 2021 2:25 AM vignesh C wrote: > > Thanks for reporting these warnings, I have fixed this in the v8 patch > attached at [1]. > [1] - https://www.postgresql.org/message- > id/CALDaNm044P_cds1OxZvFse5rE_qQfhbUg5MdtMgsa7t_bZGJdw%40mail. > gmail.com > Thanks for your patch. The wa

RE: Added schema level support for publication.

On Tuesday, June 29, 2021 11:25 AM tanghy.f...@fujitsu.com wrote: > > Thanks for your patch. The warnings are fixed. > > But I found an issue while using your V8 patch, which is similar to [1]. The > case > is as below: > Drop a schema from publication and refresh publ

RE: Added schema level support for publication.

On Wednesday, June 30, 2021 7:43 PM vignesh C mailto:vignes...@gmail.com>> wrote: > > Thanks for reporting this issue, the attached v9 patch fixes this issue. This > also fixes the other issue you reported at [1]. Thanks for your patch. I confirmed that the two issues I reported has been fi

RE: Added schema level support for publication.

On Wednesday, June 30, 2021 7:43 PM vignesh C wrote: > > Thanks for reporting this issue, the attached v9 patch fixes this issue. This > also fixes the other issue you reported at [1]. A comment on v9: src/bin/psql/describe.c + if (pset.sversion >=

RE: [HACKERS] logical decoding of two-phase transactions

On Thursday, July 1, 2021 11:48 AM Ajin Cherian > > Adding a new patch (0004) to this patch-set that handles skipping of > empty streamed transactions. patch-0003 did not > handle empty streamed transactions. To support this, added a new flag > "sent_stream_start" to PGOutputTxnData. > Also trans

RE: [HACKERS] logical decoding of two-phase transactions

On Tuesday, July 6, 2021 7:18 PM Ajin Cherian > > thanks for the test! > I hadn't updated the case where sending schema across was the first > change of the transaction as part of the decoding of the > truncate command. In this test case, the schema was sent across > without the stream start, henc

RE: [HACKERS] logical decoding of two-phase transactions

On Friday, July 9, 2021 2:56 PM Ajin Cherian wrote: > > On Fri, Jul 9, 2021 at 9:13 AM Peter Smith wrote: > > > I tried the v95-0001 patch. > > > > - The patch applied cleanly and all build / testing was OK. > > - The documentation also builds OK. > > - I checked all v95-0001 / v93-0001 differen

Memory leak fix in psql

Hi I think there is a newly introduced memory leak in your patch d2d3547. Try to fix it in the attached patch. Kindly to have a check. Regards, Tang v1-0001-fix-the-memory-leak-in-validateSQLNamePattern.patch Description: v1-0001-fix-the-memory-leak-in-validateSQLNamePattern.patch

RE: Memory leak fix in psql

On Tuesday, July 19, 2022 7:41 PM, Japin Li wrote: > After looking around, I found psql/describe.c also has some memory > leaks, > attached a patch to fix these leaks. Thanks for your check and improvement. Your fix LGTM so please allow me to merge it in the attached patch. Based on your rebased

RE: Memory leak fix in psql

On Wednesday, July 20, 2022 12:52 PM, Michael Paquier wrote: > What about the argument of upthread where we could use a goto in > functions where there are multiple pattern validation checks? Per se > v4 attached. Thanks for your kindly remind and modification. I checked v4 patch, it looks good

RE: Memory leak fix in psql

> On Wed, Jul 20, 2022 at 12:51:24PM +0800, Junwang Zhao wrote: > > Though the patch looks good, I myself think the patch should be edited > > and submitted by Tang > > It's easy to attach a fixed patch based on the comments of the thread, > > but coins should be > > given to Tang since he is the f

RE: Support tab completion for upper character inputs in psql

On Monday, January 31, 2022 3:35 AM, Tom Lane wrote: > "tanghy.f...@fujitsu.com" writes: > > Thanks for your V16 patch, I tested it. > > The results LGTM. > > Pushed, thanks for looking. I think 02b8048 forgot to free some used memory. Attached a tiny patch

RE: Added schema level support for publication.

On Wednesday, August 25, 2021 5:37 PM vignesh C wrote: > > Attached v21 patch has the changes based on the new syntax and fixes > few of the other review comments provided by reviewers. > Thanks for your new patch. I saw the following warning when building, please have a look. publicationcmds

RE: Added schema level support for publication.

On Friday, August 27, 2021 2:13 PM vignesh C wrote: > > I have implemented this in the 0003 patch, I have kept it separate to > reduce the testing effort and also it will be easier if someone > disagrees with the syntax. I will merge it to the main patch later > based on the feedback. Attached v22

RE: Added schema level support for publication.

> On Monday, August 30, 2021 11:28 PM vignesh C wrote: > > I have fixed these comments as part of v23 patch attached at [1]. > [1] - https://www.postgresql.org/message- > id/CALDaNm0xmqJeQEfV5Wnj2BawM%3DsdFdfOXz5N%2BgGG3WB6k9%3Dtdw > %40mail.gmail.com > Thanks for your new patch. Here are some c

RE: [PATCH] support tab-completion for single quote input with equal sign

On Friday, September 3, 2021 2:14 AM, Jacob Champion wrote >I applied your patch against HEAD (and did a clean build for good >measure) but couldn't get the tab-completion you described -- on my >machine, `PUBLICATION` still fails to complete. Tab completion is >working in general, for example wi

RE: Added schema level support for publication.

On Thursday, September 2, 2021 2:36 PM vignesh C wrote: > > On Wed, Sep 1, 2021 at 11:14 AM tanghy.f...@fujitsu.com > wrote: > > > > 3. When using '\dn+', I noticed that the list of publications only contains > > the > > publications for "SCHE

RE: [PATCH] Add tab-complete for backslash commands

On Sunday, September 5, 2021 1:42 AM, Tom Lane wrote: >I particularly question why we'd offer both >single- and multiple-character versions, as the single-character >version seems entirely useless from a completion standpoint. I generally agreed with your opinion. But I'm not sure if there's some

[BUG] Unexpected action when publishing partition tables

Hi I met a problem when using logical replication. Maybe it's a bug in logical replication. When publishing a partition table without replica identity, update or delete operation can be successful in some cases. For example: create table tbl1 (a int) partition by range ( a ); create table tbl1_

RE: [BUG] Unexpected action when publishing partition tables

> > > --- > > > PublicationAddTables > > > publication_add_relation > > > /* Invalidate relcache so that publication info is > > > rebuilt. */ > > > CacheInvalidateRelcache(targetrel); > > > --- > > > > > > In addition, this problem can happen in both ADD TA

RE: [PATCH] Add tab-complete for backslash commands

On Wednesday, September 8, 2021 5:05 AM, Tom Lane wrote: >Sure, but he'd still get all the commands, just not all the possible >spellings of each one. And a person who's not sure what's available >is unlikely to be helped by an entry for "\c", because it's entirely >not clear which command that's

RE: Support tab completion for upper character inputs in psql

On Tuesday, September 7, 2021 5:25 PM, Peter Eisentraut wrote: >The coding of valid_input_text() seems a bit bulky. I think you can do >the same thing using strspn() without a loop. Thanks, modified in V9 patch. >The name is also not great. It's not like other strings are not "valid". Modi

RE: Added schema level support for publication.

On Sunday, September 12, 2021 11:13 PM vignesh C wrote: > > Thanks for the changes, the suggested changes make the parsing code > simpler. I have merged the changes to the main patch. Attached v27 > patch has the changes for the same. > Thanks for your new patch. I had a look at the changes rel

Remove double check when field_name is not NULL in be-secure-openssl.c

Hi Attached a small fix to remove double check when field_name is not NULL in be-secure-openssl.c. The double check is introduced in 13cfa02f7 for "Improve error handling in backend OpenSSL implementation". Regards, Tang v1-0001-remove-double-check-when-field_name-is-not-NULL-i.patch Descript

RE: Remove double check when field_name is not NULL in be-secure-openssl.c

On Wednesday, September 15, 2021 6:54 PM, Daniel Gustafsson wrote: >The proposal removes a second == NULL check on field_name in the case where >OBJ_nid2sn() returns an ASN1_OBJECT. This is not in a hot path, and the ASM >generated is equal under optimization levels so I don't see the value in t

RE: [PATCH] support tab-completion for single quote input with equal sign

On Saturday, September 4, 2021 11:58 PM, Tom Lane wrote: >Actually ... those are just implementation details, and now that >I've thought about it a little more, I question the entire concept >of making single-quoted strings be single words in tab-complete's >view. I think it's quite intentional t

RE: Added schema level support for publication.

On Wednesday, September 22, 2021 11:22 AM Masahiko Sawada wrote: > > --- > + if (!IsA(node, String)) > + ereport(ERROR, > + errcode(ERRCODE_SYNTAX_ERROR), > +

RE: Added schema level support for publication.

On Monday, September 27, 2021 1:32 PM, vignesh C wrote: >Attached v33 patch has the preprocess_pubobj_list review comment fix >suggested by Alvaro at [1]. The >v33-0006-Alternate-grammar-for-ALL-TABLES-IN-SCHEMA.patch patch has >the grammar changes as suggested by Alvaro at [1]. If we agree this

RE: Added schema level support for publication.

On Monday, Tuesday, September 28, 2021 10:49 PM, vignesh C wrote: > > Yes this should not be supported, we should throw an error in this case. > This is handled in the v34 patch attached at [1]. > [1] - https://www.postgresql.org/message- > id/CALDaNm2Z9TfuoCf09YGKfwy7F1NwC4iCXJGTaZS%3DchH6VHtad

RE: Added schema level support for publication.

> On Friday, October 8, 2021 7:05 PM Amit Kapila > wrote: > > v37-0003-Tests-for-FOR-ALL-TABLES-IN-SCHEMA-publication > 3. > --- a/src/bin/pg_dump/t/002_pg_dump.pl > +++ b/src/bin/pg_dump/t/002_pg_dump.pl > .. > + 'ALTER PUBLICATION pub3 ADD ALL TABLES IN SCHEMA dump_test' => { > + create_order

RE: Added schema level support for publication.

On Monday, July 12, 2021 5:36 PM vignesh C wrote: > > Thanks for reporting this issue, this issue is fixed in the v10 patch > attached at [1]. > [1] - https://www.postgresql.org/message-id/CALDaNm2%2BtR%2B8R- > sD1CSyMbZcZbkintZE-avefjsp7LCkm6HMmw%40mail.gmail.com Thanks for fixing it. By apply

[PATCH] Add tab-complete for backslash commands

Hi Attached a patch to improve the tab completion for backslash commands. I think it’s common for some people(I'm one of them) to use full-name commands than abbreviation. So it's more convenient if we can add the full-name backslash commands in the tab-complete.c. When modify tab-complete.c, I

RE: Added schema level support for publication.

On Friday, July 16, 2021 6:13 PM vignesh C mailto:vignes...@gmail.com>> wrote: > > On Fri, Jul 16, 2021 at 9:25 AM Greg Nancarrow > wrote: > > > > Also, there seems to be an issue with ALTER PUBLICATION ... SET SCHEMA ... > > (PubType is getting set to 'e' instea

RE: Added schema level support for publication.

On Friday, July 16, 2021 6:10 PM vignesh C > On Wed, Jul 14, 2021 at 6:25 PM houzj.f...@fujitsu.com > wrote: > > > > Wednesday, July 14, 2021 6:17 PM vignesh C wrote: > > > On Tue, Jul 13, 2021 at 12:06 PM tanghy.f...@fujitsu.com > > > wrote: > > &g

[PATCH] support tab-completion for single quote input with equal sign

Hi I found a problem when using tab-completion as follows: CREATE SUBSCRIPTION my_subscription CONNECTION 'host=localhost port=5432 dbname=postgres' [TAB] The word 'PUBLICATION' couldn't be auto completed as expected. The reason is that the equal sign in a single quote is taken as WORD_BREAKS.

RE: Added schema level support for publication.

On Thursday, July 22, 2021 1:30 AM vignesh C wrote: > > Thanks for reporting this issue, this issue is fixed in the attached v13 > patch. > I have changed relation name pg_publication_schema to > pg_publication_sch so that the names are in similar lines with > pg_publication_rel relation and sim

RE: [PATCH] support tab-completion for single quote input with equal sign

On Thursday, July 22, 2021 1:05 PM, tanghy.f...@fujitsu.com wrote >I found a problem when using tab-completion as follows: > >CREATE SUBSCRIPTION my_subscription >CONNECTION 'host=localhost port=5432 dbname=postgres' [TAB] > >The word 'PUBLICATION' couldn&#

RE: [PATCH] Add tab-complete for backslash commands

On Thursday, July 15, 2021 6:46 PM, tanghy.f...@fujitsu.com wrote: >Attached a patch to improve the tab completion for backslash commands. >I think it's common for some people(I'm one of them) to use full-name commands >than abbreviation. >So it's more convenient

[Doc] Tiny fix for regression tests example

Hi When reading PG DOC, found some example code not correct as it said. https://www.postgresql.org/docs/devel/regress-run.html Here's a tiny fix in regress.sgml. -make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB" +make check PGOPTIONS="-c geqo=off -c work_mem=50MB" log_che

RE: Added schema level support for publication.

On Friday, July 23, 2021 8:18 PM vignesh C wrote: > > I have changed it to not report any error, this issue is fixed in the > v14 patch attached at [1]. > [1] - https://www.postgresql.org/message- > id/CALDaNm3DTj535ezfmm8QHLOtOkcHF2ZcCfSjfR%3DVbTbLZXFRsA%40mail.g > mail.com > Thanks for your n

RE: [Doc] Tiny fix for regression tests example

On Monday, July 26, 2021 1:04 PM, Michael Paquier wrote: >> -make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB" >> +make check PGOPTIONS="-c geqo=off -c work_mem=50MB" >> >> log_checkpoints couldn't be set in PGOPTIONS. >> >> Replace log_checkpoints with geqo in the example code >> >R

RE: Added schema level support for publication.

On Monday, July 26, 2021 1:25 PM vignesh C mailto:vignes...@gmail.com>> wrote: > > On Mon, Jul 26, 2021 at 7:41 AM > tanghy.f...@fujitsu.com<mailto:tanghy.f...@fujitsu.com> > mailto:tanghy.f...@fujitsu.com>> wrote: > > > > On Friday, July 23,

RE: [HACKERS] logical decoding of two-phase transactions

On Friday, July 30, 2021 12:02 PM Peter Smith wrote: > > Please find attached the latest patch set v100* > > v99-0002 --> v100-0001 > Thanks for your patch. A few comments on the test file: 1. src/test/subscription/t/022_twophase_cascade.pl 1.1 I saw your test cases for "PREPARE / COMMIT PREP

[PATCH]Comment improvement in publication.sql

Hi Hackers When review and test another patch at [1], I found some comments in existing test code of " src/test/regress/sql/publication.sql " is a little bit confused. Attached a patch to fix them, please take a check. Here is the detail: Existing code: CREATE TABLE testpub_tbl2 (id serial prim

RE: [PATCH]Comment improvement in publication.sql

On Monday, August 2, 2021 11:56 PM vignesh C wrote: > > Few minor suggestions: > 1) Should we change below to "fail - tables can't be added, dropped or > set to "FOR ALL TABLES" publications" > --- fail - can't add to for all tables publication > +-- fail - tables can't be added to or dropped fro

RE: Added schema level support for publication.

On Monday, August 2, 2021 11:40 PM vignesh C wrote: > > Thanks for the comments, attached v17 patches has the fixes for the same. Thanks for your new patch. I saw the following warning when compiling. It seems we don't need this variable any more. publicationcmds.c: In function ‘AlterPublicati

RE: [HACKERS] logical decoding of two-phase transactions

On Tuesday, August 3, 2021 6:03 PM vignesh C wrote: > > On Tue, Aug 3, 2021 at 12:32 PM Amit Kapila wrote: > > > > On Tue, Aug 3, 2021 at 6:17 AM Peter Smith wrote: > > > > > > Please find attached the latest patch set v102* > > > > > > > I have made minor modifications in the comments and docs,

RE: Added schema level support for publication.

On Tuesday, August 3, 2021 11:08 PM vignesh C wrote: > > Thanks for reporting this, this is fixed in the v18 patch attached. Thanks for fixing it. Few suggestions for V18: 1. +# Clean up the tables on both publisher and subscriber as we don't need them +$node_publisher->safe_psql('postgres',

RE: [PATCH]Comment improvement in publication.sql

Hi I saw some inaccurate comments for AlterPublicationStmt structure when reviewing patches related to publication[1]. The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE', but the comments only say 'ADD/DROP'. How about add 'SET' to the comments? typedef struct AlterPubli

[PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist

Hi Commit 6bf0bc842 replaced float.c's CHECKFLOATVAL() macro with static inline subroutines, but the fix introduced a performance regression as Tom Lane pointed out and fixed at 607f8ce74. Found obsolete CHECKFLOATVAL usage in contrib/btree_gist, and tried to fix it according to 607f8ce74. Th

RE: [PATCH] Add tab-complete for backslash commands

On Sunday, August 8, 2021 8:13 AM, Dagfinn Ilmari Mannsåker wrote: >> +"\\r", "\\rset", > >There's a typo here, that should be "\\reset". Also, I noticed that for >\connect, the situation is the opposite: it has the full form but not >the short form (\c). > >I've addressed both in th

RE: [PATCH]Comment improvement in publication.sql

On Sunday, August 8, 2021 6:34 PM, vignesh C wrote >Thanks for the updated patch, your changes look good to me. You might >want to include the commit message in the patch, that will be useful. Thanks for your kindly suggestion. Updated patch attached. Added the patch commit message with no new fi

RE: Skipping logical replication transactions on subscriber side

On Thursday, August 12, 2021 1:53 PM Masahiko Sawada wrote: > > I've attached the updated patches. FYI I've included the patch > (v8-0005) that fixes the assertion failure during shared fileset > cleanup to make cfbot tests happy. Hi Thanks for your patch. I met a problem when using it. The lo

RE: [PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist

On Friday, August 6, 2021 11:14 PM, tanghy.f...@fujitsu.com wrote: >Commit 6bf0bc842 replaced float.c's CHECKFLOATVAL() macro with static inline >subroutines, >but the fix introduced a performance regression as Tom Lane pointed out and >fixed at 607f8ce74. > >Found

RE: [PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist

On Thursday, August 19, 2021 12:28 PM, Michael Paquier wrote >On Wed, Aug 18, 2021 at 10:04:04AM +0900, Michael Paquier wrote: >> Yes, that does not seem wise on performance grounds. The case of >> !zero_is_valid is never reached, so it seems like this code was just a >> copy-paste from the floa

RE: Skipping logical replication transactions on subscriber side

> On Thursday, August 19, 2021 9:53 AM Masahiko Sawada > wrote: > > Thank you for reporting the issue! This issue must be fixed in the > latest (v9) patches I've just submitted[1]. > Thanks for your patch. I've confirmed the issue is fixed as you said. Regards Tang

RE: Skipping logical replication transactions on subscriber side

On Monday, August 23, 2021 11:09 AM Masahiko Sawada wrote: > > I've attached updated patches. Please review them. > I tested v10-0001 patch in both streaming and no-streaming more. All tests works well. I also tried two-phase commit feature, the error context was set as expected, but please

RE: Skipping logical replication transactions on subscriber side

On Wednesday, August 25, 2021 12:22 PM Masahiko Sawada wrote: > > Attached updated version patches. Please review them. > Thanks for your new patch. The v11-0001 patch LGTM. Regards Tang

<    1   2