Hi
I did the following steps on PG.
1. Building a synchronous streaming replication environment.
2. Executing the following SQL statements on primary
(1) postgres=# CREATE EXTENSION pageinspect;
(2) postgres=# begin;
(3) postgres=# select txid_current();
(4) postgres=# create table mytest
Hi
When reading the code FinishPreparedTransaction, I found that SI messages are
sent
when executing ROLLBACK PREPARED command.
But according to AtEOXact_Inval function, we send the SI messages only when
committing the transaction .
So, I think we needn't send SI messags when rollbacking the
handling added.
So, I think it is better to optimize the code.
Here is the patch.
Regards, liuhl
-Original Message-
From: Tom Lane
Sent: Thursday, July 15, 2021 1:36 AM
To: Liu, Huailing/刘 怀玲
Cc: pgsql-hack...@postgresql.org
Subject: Re: SI messages sent when excuting ROLLBACK PREPARE
Hi, all
When I used SPI_execute_plan function on PG12 which commit 41c6a5be is used,
Segment fault occurred.
PS: If commit 41c6a5be is not used, this phenomenon will not happen.
Reproduce:
In a background process, the following steps are executed.
--
StartTransactionComm
Hi, tom
> >Hmmm, yeah, I think you're right. It probably doesn't make a big difference
> >in
> the real world --- anyone who's dependent on the performance of 2PC rollbaxks
> is Doing It Wrong.
> > But we'd have already done LocalExecuteInvalidationMessage when getting
> out of the prepared tra
> On Wed, Aug 11, 2021 at 03:14:11PM +0900, Michael Paquier wrote:
> > I would just tweak the comment block at the top of what's being
> > changed, as per the attached. Please let me know if there are any
> > objections.
>
> And applied as of 710796f.
Thanks for your comment and commit.
I've chan
