RE: Perform streaming logical transactions by background workers and parallel apply

Hi Amit, > > I checked other flags that are set by signal handlers, their datatype > > seemed to > be sig_atomic_t. > > Is there any reasons that you use normal bool? It should be changed if not. > > > > It follows the logic similar to ParallelMessagePending. Do you see any > problem with it? H

RE: [PATCH] memory leak in ecpglib

Dear Zhang, # I resend the email Thank you for reporting a bug. I didn't care about this case. >> We should free p->cursor_name before p->cursor_name = >> ecpg_strdup(cursor_name, lineno). I'm wondering whether this approach is correct or not. If your patch is committed, in your example, any o

RE: Is PREPARE of ecpglib thread safe?

Dear all, I apologize for my late reply. I realized that the current implementation could not imitate the oracle's precompiler. The attached example can be accepted by both precompilers, but building the c file made by ecpg fails. For handling this source, we have to refactor some sources relat

RE: [PATCH] memory leak in ecpglib

Dear Zhang, Sorry for my late reply. I'm now planning to refactor this functionality: https://www.postgresql.org/message-id/osapr01mb20048298f882d25897c6ab23f5...@osapr01mb2004.jpnprd01.prod.outlook.com If DECLARE STATEMENT and other related statements are enabled only preprocessing process, thi

RE: [PATCH] memory leak in ecpglib

Dear Meskes, Zhang, I think this modification is not enough, and I have an another idea. >> If your patch is committed, in your example, any operation for cur1 will not >> be accepted. > Although the return value after calling ecpg_get_con_name_by_cursor_name(cur1) > is NULL, in ecpg_get_connec

RE: ECPG: proposal for new DECLARE STATEMENT

Dear Tomas, Daniel, Michael, I missed your e-mails, and I apologize the very late reply. I want you to thank keeping the thread. > I'm not an ecpg expert (in fact I've never even used it), so my review > is pretty superficial, but I only found a couple of minor whitespace > issues (adding/remov

RE: pgbench: option delaying queries till connections establishment?

Dear Fabien, Andres I think your idea is good, hence I put some comments as a reviewer. I focus on only the linux code because I'm not familiar with the Windows system. Sorry. [For patch A] Please complete fixes for the documentation. At least the following sentence should be fixed: ``` The la

<    1   2   3