Re: Transaction timeout

2023-09-07 Thread bt23nguyent
On 2023-09-06 20:32, Andrey M. Borodin wrote: Thanks for looking into this! On 6 Sep 2023, at 13:16, Fujii Masao wrote: While testing v4 patch, I noticed it doesn't handle the COMMIT AND CHAIN case correctly. When COMMIT AND CHAIN is executed, I believe the transaction timeout counter shou

Re: pg_logical_emit_message() misses a XLogFlush()

2023-09-10 Thread bt23nguyent
On 2023-09-11 14:02, Michael Paquier wrote: On Mon, Sep 11, 2023 at 12:54:11PM +0900, Fujii Masao wrote: However, in the current patch, if "transactional" is set to false and "flush" is true, the function flushes the WAL immediately without considering synchronous_commit. Is this the intended be

Tab completion for ATTACH PARTITION

2023-09-12 Thread bt23nguyent
Hi, Currently, the psql's tab completion feature does not support properly for ATTACH PARTITION. When key is typed after "ALTER TABLE ATTACH PARTITION ", all possible table names should be displayed, however, foreign table names are not displayed. So I created a patch that addresses this is

Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set

2023-09-15 Thread bt23nguyent
Hi, When archive_library is set to 'basic_archive' but basic_archive.archive_directory is not set, WAL archiving doesn't work and only the following warning message is logged. $ emacs $PGDATA/postgresql.conf archive_mode = on archive_library = 'basic_archive' $ bin/pg_ctl -D

Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set

2023-09-19 Thread bt23nguyent
On 2023-09-15 23:38, Nathan Bossart wrote: On Fri, Sep 15, 2023 at 02:48:55PM +0200, Daniel Gustafsson wrote: On 15 Sep 2023, at 12:49, Alvaro Herrera wrote: On 2023-Sep-15, Daniel Gustafsson wrote: -basic_archive_configured(ArchiveModuleState *state) +basic_archive_configured(ArchiveModule

Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set

2023-09-20 Thread bt23nguyent
On 2023-09-20 21:14, Daniel Gustafsson wrote: On 19 Sep 2023, at 11:21, bt23nguyent wrote: Please let me know if you have any further suggestions that I can improve more. +*logdetail = pstrdup("WAL archiving failed because basic_archive.archive_directory is not set")