Re: POC, WIP: OR-clause support for indexes

2023-10-15 Thread a.rybakina
Hi! Thank you for your review! On 15.10.2023 01:34, Alexander Korotkov wrote: Hi, Alena! Thank you for your work on the subject. On Wed, Oct 4, 2023 at 10:21 PM a.rybakina wrote: I fixed the kernel dump issue and all the regression tests were successful, but I discovered another problem

Re: POC, WIP: OR-clause support for indexes

2023-10-25 Thread a.rybakina
Hi! On 15.10.2023 01:34, Alexander Korotkov wrote: Hi, Alena! Thank you for your work on the subject. On Wed, Oct 4, 2023 at 10:21 PM a.rybakina wrote: I fixed the kernel dump issue and all the regression tests were successful, but I discovered another problem when I added my own

Re: Not deleted mentions of the cleared path

2023-11-01 Thread a.rybakina
Hi! Thank you for the interest to this issue. On 31.10.2023 06:25, Richard Guo wrote: On Mon, Oct 30, 2023 at 7:31 PM Alena Rybakina wrote: I have already written about the problem of InvalidPath [0] appearing. I investigated this and found an error in the add_path()

Re: POC, WIP: OR-clause support for indexes

2023-11-13 Thread a.rybakina
Hi, all! These days I was porting a patch for converting or expressions to ANY to the choose_bitmap_and function. Unfortunately, it is not possible to transfer the conversion there, since expressions are processed one by one, as far as I saw. Therefore, I tried to make the conversion earlier

Re: POC, WIP: OR-clause support for indexes

2023-11-20 Thread a.rybakina
On 20.11.2023 11:52, Andrei Lepikhov wrote: On 10/11/2023 16:20, Alena Rybakina wrote: I added log like that: ERROR: unrecognized node type: 0. I fixed this issue and added some cosmetic refactoring. The changes are presented in the or_patch_changes.diff file. Looking into the patch, I found

Re: POC, WIP: OR-clause support for indexes

2023-08-28 Thread a.rybakina
Thank you for your interest in this problem and help, and I'm sorry that I didn't respond to this email for a long time. To be honest, I wanted to investigate the problems in more detail and already answer more clearly, but unfortunately I have not found anything more significant yet. On 21.08

Re: POC, WIP: OR-clause support for indexes

2023-09-20 Thread a.rybakina
/message-id/b301dce1-09fd-72b1-834a-527ca428db5e%40yandex.ru On 20.09.2023 12:37, Peter Eisentraut wrote: On 29.08.23 05:37, a.rybakina wrote: Thank you for your interest in this problem and help, and I'm sorry that I didn't respond to this email for a long time. To be honest, I wanted

Re: POC, WIP: OR-clause support for indexes

2023-09-26 Thread a.rybakina
Sorry for the duplicates, I received a letter that my letter did not reach the addressee, I thought the design was incorrect. On 26.09.2023 12:21, a.rybakina wrote: I'm sorry I didn't write for a long time, but I really had a very difficult month, now I'm fully back to work.

Re: POC, WIP: OR-clause support for indexes

2023-09-29 Thread a.rybakina
I'm sorry I didn't write for a long time, but I really had a very difficult month, now I'm fully back to work. *I was able to implement the patches to the end and moved the transformation of "OR" expressions to ANY.* I haven't seen a big difference between them yet, one has a transformation be

Re: POC, WIP: OR-clause support for indexes

2023-10-04 Thread a.rybakina
On 29.09.2023 20:35, a.rybakina wrote: I'm sorry I didn't write for a long time, but I really had a very difficult month, now I'm fully back to work. *I was able to implement the patches to the end and moved the transformation of "OR" expressions to ANY.* I haven

Re: Removing unneeded self joins

2023-10-13 Thread a.rybakina
Also I've incorporated improvements from Alena Rybakina except one for skipping SJ removal when no SJ quals is found.  It's not yet clear for me if this check fix some cases. But at least optimization got skipped in some useful cases (as you can see in regression tests). Agree. I wouldn't say

Re: Removing unneeded self joins

2023-10-13 Thread a.rybakina
On 13.10.2023 12:03, Andrei Lepikhov wrote: On 13/10/2023 15:56, a.rybakina wrote: Also I've incorporated improvements from Alena Rybakina except one for skipping SJ removal when no SJ quals is found.  It's not yet clear for me if this check fix some cases. But at least optimi

Re: POC, WIP: OR-clause support for indexes

2023-08-17 Thread a.rybakina
Hi, all! The optimizer will itself do a limited form of "normalizing to CNF". Are you familiar with extract_restriction_or_clauses(), from orclauses.c? Comments above the function have an example of how this can work:   * Although a join clause must reference multiple relations overall,   * an O

Re: POC, WIP: OR-clause support for indexes

2023-08-17 Thread a.rybakina
Sorry, I didn't write correctly enough, about the second second place in the code where the conversion works well enough is the removal of duplicate OR expressions. I attached patch to learn it in more detail. On 17.08.2023 13:08, a.rybakina wrote: Hi, all! The optimizer will itself

RFC: Logging plan of the running query

2022-09-16 Thread a.rybakina
Hi, I liked this idea and after reviewing code I noticed some moments and I'd rather ask you some questions. Firstly, I suggest some editing in the comment of commit. I think, it is turned out the more laconic and the same clear. I wrote it below since I can't think of any other way to add

Re: RFC: Logging plan of the running query

2022-09-19 Thread a.rybakina
Hi, I'm sorry,if this message is duplicated previous this one, but the previous message is sent incorrectly. I sent it from email address lena.riback...@yandex.ru. I liked this idea and after reviewing code I noticed some moments and I'd rather ask you some questions. Firstly, I suggest so