[patch] Help information for pg_dump

2021-01-18 Thread Zhang, Jie
Hi all After executing command [pg_dump -?], some help information is as follows. pg_dump -? - -N, --exclude-schema=PATTERN do NOT dump the specified schema(s) ※ -T, --exclude-table=PATTERN do NOT dump the specified tab

[PATCH] remove repetitive characters in fdwhandler.sgml

2019-03-12 Thread Zhang, Jie
Hi all, Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml. Page: https://github.com/postgres/postgres/blob/master/doc/src/sgml/fdwhandler.sgml --- This function should store the tuple int

RE: [PATCH] remove repetitive characters in fdwhandler.sgml

2019-03-13 Thread Zhang, Jie
> This function should store the tuple into the provided slot, no? Yes, this modification is easier to understand. -Original Message- From: Michael Paquier [mailto:mich...@paquier.xyz] Sent: Wednesday, March 13, 2019 1:02 PM To: Zhang, Jie/张 杰 Cc: pgsql-hack...@postgresql.org Subj

ALTER TABLE with ADD COLUMN and ADD PRIMARY KEY USING INDEX throws spurious "column contains null values"

2019-03-25 Thread Zhang, Jie
Hi all, When I do the following: postgres=# create table t1 (a int); postgres=# insert into t1 values(1); postgres=# create unique index uniq_idx on t1(a); postgres=# alter table t1 add column b float8 not null default random(), add primary key using index uniq_idx; ERROR: column "b" contains nul

Translation updates for zh_CN.po (Chinese Simplified)

2019-04-08 Thread Zhang, Jie
Hi all zh_CN.po has not been updated for three years. The source has changed a lot. I want to do something for postgresql. I think I can update the zh_CN.po file. I plan to translate and update the following zh_CN.po postgresql/src/bin/initdb/po/zh_CN.po [Patch has been completed]

[patch] pg_test_timing does not prompt illegal option

2019-04-17 Thread Zhang, Jie
Hi all, pg_test_timing accepts the following command-line options: -d duration --duration=duration Specifies the test duration, in seconds. Longer durations give slightly better accuracy, and are more likely to discover problems with the system clock moving backwards. The default test durat

[patch] some PQExpBuffer are not destroyed in pg_dump

2020-04-06 Thread Zhang, Jie
Hi al In getDefaultACLs function, some PQExpBuffer are not destroy File: src/bin/pg_dump/pg_dump.c DefaultACLInfo * getDefaultACLs(Archive *fout, int *numDefaultACLs) { .. if (fout->remoteVersion >= 90600) { PQExpBuffer acl_subquery = createPQExpBuffer();

[PATHC] Fix minor memory leak in pg_basebackup

2020-04-15 Thread Zhang, Jie
Hi all In some cases , PGresult is not cleared. File: src\bin\pg_basebackup\streamutil.c bool RetrieveWalSegSize(PGconn *conn) { PGresult *res; .. res = PQexec(conn, "SHOW wal_segment_size"); if (PQresultStatus(res) != PGRES_TUPLES_OK) { pg_l

RE: [PATHC] Fix minor memory leak in pg_basebackup

2020-04-16 Thread Zhang, Jie
Hi Michael so much the better! -Original Message- From: Michael Paquier [mailto:mich...@paquier.xyz] Sent: Thursday, April 16, 2020 2:31 PM To: Zhang, Jie/张 杰 Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [PATHC] Fix minor memory leak in pg_basebackup On Wed, Apr 15, 2020 at 10

[PATCH] memory leak in ecpglib

2019-06-09 Thread Zhang, Jie
Hi all Memory leaks occur when the ecpg_update_declare_statement() is called the second time. FILE:postgresql\src\interfaces\ecpg\ecpglib\prepare.c void ecpg_update_declare_statement(const char *declared_name, const char *cursor_name, const int lineno) { struct declared_statement *p = N

[PATCH] Fix potential memoryleak in guc.c

2019-06-09 Thread Zhang, Jie
Hi all In src\backend\utils\misc\guc.c, I found a potential memory leak. make_absolute_path() return a malloc'd copy, we should free memory before the function return false. SelectConfigFiles(const char *userDoption, co

RE: [PATCH] memory leak in ecpglib

2019-06-10 Thread Zhang, Jie
Hi > But I wonder if it is safe that the old cursor_name is forgotten. old cursor_name is not assigned to other pointers, so it is safe that the old cursor_name is forgotten. Best Regards! -Original Message- From: Matsumura, Ryo/松村 量 Sent: Monday, June 10, 2019 5:52 PM To: Zhang,

RE: [PATCH] memory leak in ecpglib

2019-06-11 Thread Zhang, Jie
l Message- From: Kuroda, Hayato/�\田 隼人 Sent: Tuesday, June 11, 2019 2:36 PM To: Zhang, Jie/张 杰 ; Matsumura, Ryo/松村 量 ; pgsql-hackers@lists.postgresql.org Subject: RE: [PATCH] memory leak in ecpglib Dear Zhang, # I resend the email Thank you for reporting a bug. I didn't care about this